Skip to contentSkip to conversation

tty: serial: bcm63xx: use more precise Kconfig symbol

PATCH Superseded Rafał Miłecki 3 participants 3 messages Mar 10, 2022 – Mar 11, 2022

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tty: serial: bcm63xx: use more precise Kconfig symbol

From: Rafał Miłecki <[email protected]>

Patches lowering SERIAL_BCM63XX dependencies led to a discussion and documentation change regarding "depends" usage. Adjust Kconfig entry to match current guidelines. Make this symbol available for relevant architectures only.

Cc: Geert Uytterhoeven <[email protected]>
Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")

---
V2: Use precise "depends" (exact platforms)

---
 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index e952ec5c7a7c..46f3c7ca13e0 100644
@@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE
 config SERIAL_BCM63XX
 	tristate "Broadcom BCM63xx/BCM33xx UART support"
 	select SERIAL_CORE
-	depends on COMMON_CLK
+	depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
+	default y
 	help
 	  This enables the driver for the onchip UART core found on
 	  the following chipsets:
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Patches lowering SERIAL_BCM63XX dependencies led to a discussion and documentation change regarding "depends" usage. Adjust Kconfig entry to match current guidelines. Make this symbol available for relevant architectures only.

Cc: Geert Uytterhoeven <[email protected]>
Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")

Signature · 1 line
Florian
#2 lore raw
In reply to Rafał Miłecki

Hi Rafał,

Quoted 7 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Patches lowering SERIAL_BCM63XX dependencies led to a discussion and documentation change regarding "depends" usage. Adjust Kconfig entry to match current guidelines. Make this symbol available for relevant architectures only.

Quoted 6 lines

Cc: Geert Uytterhoeven <[email protected]>
Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies")
Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises")

---
V2: Use precise "depends" (exact platforms)

Thanks for the update!

drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1104

Quoted 9 lines
drivers/tty/serial/Kconfig +2 -1
@@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE
 config SERIAL_BCM63XX
        tristate "Broadcom BCM63xx/BCM33xx UART support"
        select SERIAL_CORE
-       depends on COMMON_CLK
+       depends on ARCH_BCM4908 || ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
+       default y

Merely enabling COMPILE_TEST should not enable additional drivers.

drivers/tty/serial/Kconfig config SERIAL_TIMBERDALE · line 1107

Quoted 3 lines
drivers/tty/serial/Kconfig +0 -0
        help
          This enables the driver for the onchip UART core found on
          the following chipsets:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds