accel: Unassorted cleanups around debugging
cover accel: Unassorted cleanups around debugging
Refreshing the `split-accel' preparatory work; this series follows "accel: Preparatory cleanups for split-accel" from last year:
https://lore.kernel.org/qemu-devel/[email protected]/
Nothing really noteworthy here, generic code refactoring with the objective to strengthen the various APIs, introducing few enums or headers.
Philippe Mathieu-Daudé (33):
cpu: Constify CPUState::cc (cached CPUClass pointer) target/i386: Remove duplicate tlb_flush() call in cpu_post_load() accel/tcg: Restrict tlb_protect/unprotect_code() to TCG accel/hvf: Remove left-over comment
accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
gdbstub: Add trace event for STEP packet handler
gdbstub: Only return E22 when reverse GDB is not supported accel/kvm: Always define AccelOpsClass::supports_guest_debug accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG
accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config()
gdbstub: Store @can_reverse in GDBState
gdbstub: Make default replay_mode value explicit in stubs
accel: Have get_gdbstub_config() return @can_reverse value
accel: Move supports_guest_debug() declaration to AccelClass accel/kvm: Hold have_guest_supported in KVMState accel/kvm: Hold gdbstub_sstep_flags in KVMState
cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h'
cpu: Define BreakpointFlags type
accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode
gdbstub: Reduce @type variable scope
gdbstub: Introduce GdbBreakpointType enumerator
accel: Use GdbBreakpointType enum
target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint() target/arm: Factor arm_check_watchpoint_hit() out target/xtensa: Move watchpoints handling to check_hw_watchpoints() target/ppc: Ensure TCG is used in ppc_update_daw() accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers
cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h'
cpu: Better name cpu_single_step() trace event
cpu: Introduce cpu_single_stepping() helper
cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping()
accel/kvm/kvm-cpus.h | 12 +++-- accel/tcg/system-page-protection.h | 17 +++++++ gdbstub/internals.h | 10 ++-- include/accel/accel-cpu-ops.h | 10 ++-- include/accel/accel-ops.h | 4 +- include/accel/tcg/cpu-ops.h | 12 +++-- include/exec/breakpoint.h | 26 ++++++---- include/exec/cputlb.h | 8 +-- include/exec/watchpoint.h | 20 ++++++-- include/gdbstub/enums.h | 12 +++-- include/hw/core/cpu.h | 42 ++++++++-------- include/qemu/accel.h | 10 ++-- include/system/hvf_int.h | 11 ++-- include/system/kvm.h | 9 ++-- include/system/kvm_int.h | 2 + include/system/mshv_int.h | 1 - include/system/whpx-all.h | 4 +- target/arm/internals.h | 6 ++- accel/accel-common.c | 22 ++++++-- accel/hvf/hvf-accel-ops.c | 23 ++++----- accel/hvf/hvf-all.c | 9 ++-- accel/kvm/kvm-accel-ops.c | 7 ++- accel/kvm/kvm-all.c | 55 +++++++++++--------- accel/mshv/mshv-all.c | 18 +++---- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 12 ++--- accel/tcg/cputlb.c | 15 +++--- accel/tcg/tb-maint.c | 1 + accel/tcg/tcg-accel-ops-rr.c | 2 +- accel/tcg/tcg-accel-ops.c | 31 ++++++------ accel/tcg/tcg-all.c | 16 ++++-- accel/tcg/translate-all.c | 3 +- accel/tcg/user-exec-stub.c | 11 ++-- accel/tcg/watchpoint.c | 9 ++-- accel/whpx/whpx-accel-ops.c | 7 --- accel/whpx/whpx-common.c | 1 + cpu-common.c | 8 +-- cpu-target.c | 10 ++-- gdbstub/gdbstub.c | 11 ++-- gdbstub/system.c | 39 ++++++-------- gdbstub/user.c | 20 ++------ linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- stubs/replay-mode.c | 2 +- system/cpus.c | 2 +- system/watchpoint.c | 8 +-- target/arm/hvf/hvf.c | 24 +++++---- target/arm/hyp_gdbstub.c | 9 ++-- target/arm/kvm.c | 14 +++--- target/arm/tcg/debug.c | 81 +++++++++++++++--------------- target/arm/tcg/mte_helper.c | 3 +- target/arm/whpx/whpx-all.c | 2 +- target/i386/hvf/hvf.c | 10 ++-- target/i386/kvm/kvm.c | 15 +++--- target/i386/machine.c | 1 - target/i386/mshv/mshv-cpu.c | 6 +-- target/i386/whpx/whpx-all.c | 8 +-- target/loongarch/kvm/kvm.c | 10 ++-- target/microblaze/translate.c | 2 +- target/ppc/cpu.c | 4 +- target/ppc/kvm.c | 20 +++++--- target/ppc/translate.c | 16 +++--- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 ++--- target/riscv/kvm/kvm-cpu.c | 8 +-- target/s390x/kvm/kvm.c | 11 ++-- target/s390x/tcg/debug.c | 3 +- target/xtensa/dbg_helper.c | 2 +- target/xtensa/helper.c | 36 ++++++------- trace-events | 2 +- 70 files changed, 477 insertions(+), 388 deletions(-) create mode 100644 accel/tcg/system-page-protection.h
Signature · 1 line
2.53.0
PATCH 1/33 cpu: Constify CPUState::cc (cached CPUClass pointer)
Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const.
--- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-)
include/hw/core/cpu.h +1 -1
@@ -480,7 +480,7 @@ struct CPUState {/*< private >*/ DeviceState parent_obj;/* cache to avoid expensive CPU_GET_CLASS */ -CPUClass *cc; +const CPUClass *cc;/*< public >*/ int nr_threads;
accel/tcg/cpu-exec.c +1 -1
@@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *tb_exit)* counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;const TCGCPUOps *tcg_ops = cc->tcg_ops;if (tcg_ops->synchronize_from_tb) {
accel/tcg/translate-all.c +1 -2
@@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retaddr)void cpu_io_recompile (CPUState *cpu,uintptr_t retaddr) {TranslationBlock *tb; -CPUClass *cc; +const CPUClass *cc = cpu->cc;uint32_t n; tb =tcg_tb_lookup (retaddr);
@@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)* to account for the re-execution of the branch. */ n =1 ; - cc = cpu->cc;if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch (cpu, tb)) { cpu->neg.icount_decr.u16.low++;
gdbstub/gdbstub.c +1 -1
@@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int base_reg,static const char *gdb_get_core_xml_file (CPUState *cpu) { -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;/* * The CPU class can provide the XML filename via a method,
Signature · 1 line
2.53.0
Re: [PATCH 01/33] cpu: Constify CPUState::cc (cached CPUClass pointer)
Quoted 6 lines · Philippe Mathieu-Daudé
Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 66 lines
include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-)include/hw/core/cpu.h +1
-1@@ -480,7 +480,7 @@ struct CPUState {/*< private >*/ DeviceState parent_obj;/* cache to avoid expensive CPU_GET_CLASS */ -CPUClass *cc; +const CPUClass *cc;/*< public >*/ int nr_threads;accel/tcg/cpu-exec.c +1
-1@@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *tb_exit)* counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;const TCGCPUOps *tcg_ops = cc->tcg_ops;if (tcg_ops->synchronize_from_tb) {accel/tcg/translate-all.c +1
-2@@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retaddr)void cpu_io_recompile (CPUState *cpu,uintptr_t retaddr) {TranslationBlock *tb; -CPUClass *cc; +const CPUClass *cc = cpu->cc;uint32_t n; tb =tcg_tb_lookup (retaddr);@@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)* to account for the re-execution of the branch. */ n =1 ; - cc = cpu->cc;if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch (cpu, tb)) { cpu->neg.icount_decr.u16.low++;gdbstub/gdbstub.c +1
-1@@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int base_reg,static const char *gdb_get_core_xml_file (CPUState *cpu) { -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;/* * The CPU class can provide the XML filename via a method,
Re: [PATCH 01/33] cpu: Constify CPUState::cc (cached CPUClass pointer)
In reply to Philippe Mathieu-DaudéQuoted 11 lines · Philippe Mathieu-Daudé
Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const.
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-)
r~
Re: [PATCH 01/33] cpu: Constify CPUState::cc (cached CPUClass pointer)
In reply to Philippe Mathieu-DaudéQuoted 5 lines · Philippe Mathieu-Daudé
Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Thanks,
Chao
Quoted 70 lines
--- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-)include/hw/core/cpu.h +1
-1@@ -480,7 +480,7 @@ struct CPUState {/*< private >*/ DeviceState parent_obj;/* cache to avoid expensive CPU_GET_CLASS */ -CPUClass *cc; +const CPUClass *cc;/*< public >*/ int nr_threads;accel/tcg/cpu-exec.c +1
-1@@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *tb_exit)* counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;const TCGCPUOps *tcg_ops = cc->tcg_ops;if (tcg_ops->synchronize_from_tb) {accel/tcg/translate-all.c +1
-2@@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retaddr)void cpu_io_recompile (CPUState *cpu,uintptr_t retaddr) {TranslationBlock *tb; -CPUClass *cc; +const CPUClass *cc = cpu->cc;uint32_t n; tb =tcg_tb_lookup (retaddr);@@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)* to account for the re-execution of the branch. */ n =1 ; - cc = cpu->cc;if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch (cpu, tb)) { cpu->neg.icount_decr.u16.low++;gdbstub/gdbstub.c +1
-1@@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int base_reg,static const char *gdb_get_core_xml_file (CPUState *cpu) { -CPUClass *cc = cpu->cc; +const CPUClass *cc = cpu->cc;/* * The CPU class can provide the XML filename via a method, Signature · 1 line
2.53.0
PATCH 2/33 target/i386: Remove duplicate tlb_flush() call in cpu_post_load()
In reply to Philippe Mathieu-DaudéCommon vCPU cpu_post_load() handler calls tlb_flush() since commit 9656f324d25 ("Move interrupt_request and user_mode_only to common cpu state..."), no need to call it twice.
--- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-)
target/i386/machine.c +0 -1
@@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7 ] = dr7 & ~(DR7_GLOBAL_BP_MASK |DR7_LOCAL_BP_MASK );cpu_x86_update_dr7 (env, dr7); } -tlb_flush (cs);return 0 ; }
Signature · 1 line
2.53.0
Re: [PATCH 02/33] target/i386: Remove duplicate tlb_flush() call in cpu_post_load()
Quoted 3 lines · Philippe Mathieu-Daudé
Common vCPU
cpu_post_load()handler callstlb_flush()since commit9656f324d25("Moveinterrupt_requestanduser_mode_onlyto common cpu state..."), no need to call it twice.
While that commit is where things were moved, using the modern function name would be helpful here in the commit message: cpu_common_post_load.
r~
Quoted 18 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-)target/i386/machine.c +0
-1@@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7 ] = dr7 & ~(DR7_GLOBAL_BP_MASK |DR7_LOCAL_BP_MASK );cpu_x86_update_dr7 (env, dr7); } -tlb_flush (cs);return 0 ; }
Re: [PATCH 02/33] target/i386: Remove duplicate tlb_flush() call in cpu_post_load()
In reply to Philippe Mathieu-DaudéQuoted 5 lines · Philippe Mathieu-Daudé
Common vCPU
cpu_post_load()handler callstlb_flush()since commit9656f324d25("Moveinterrupt_requestanduser_mode_onlyto common cpu state..."), no need to call it twice.Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Quoted 19 lines
--- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-)target/i386/machine.c +0
-1@@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7 ] = dr7 & ~(DR7_GLOBAL_BP_MASK |DR7_LOCAL_BP_MASK );cpu_x86_update_dr7 (env, dr7); } -tlb_flush (cs);return 0 ; }Signature · 1 line
2.53.0
PATCH 3/33 accel/tcg: Restrict tlb_protect/unprotect_code() to TCG
In reply to Philippe Mathieu-DaudéBoth tlb_protect() and tlb_unprotect_code() are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header.
--- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.h
accel/tcg/system-page-protection.h new file +17 -0
@@ -0,0 +1,17 @@ +/* +* QEMU page protection (system emulation) +* +* Copyright (c) 2003 Fabrice Bellard +* +* SPDX-License-Identifier: LGPL-2.1-or-later +*/ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code (ram_addr_t ram_addr); +void tlb_unprotect_code (ram_addr_t ram_addr); + +#endif +
include/exec/cputlb.h +2 -6
@@ -24,14 +24,10 @@#include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG ) && !defined(CONFIG_USER_ONLY ) -void tlb_protect_code (ram_addr_t ram_addr); -void tlb_unprotect_code (ram_addr_t ram_addr); -#endif #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" +void tlb_reset_dirty (CPUState *cpu,uintptr_t start,uintptr_t length);void tlb_reset_dirty_range_all (ram_addr_t start,ram_addr_t length);#endif
accel/tcg/cputlb.c +2 -1
@@ -1,5 +1,5 @@/* -* Common CPU TLB handling +* Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard *
@@ -47,6 +47,7 @@#include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif
accel/tcg/tb-maint.c +1 -0
@@ -38,6 +38,7 @@#include "user/page-protection.h" #define runstate_is_running () true#else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h"
Signature · 1 line
2.53.0
Re: [PATCH 03/33] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG
Quoted 6 lines · Philippe Mathieu-Daudé
Both
tlb_protect()andtlb_unprotect_code()are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 82 lines
accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-)create mode 100644
accel/tcg/system-page-protection.haccel/tcg/system-page-protection.h new file +17
-0@@ -0,0 +1,17 @@ +/* +* QEMU page protection (system emulation) +* +* Copyright (c) 2003 Fabrice Bellard +* +* SPDX-License-Identifier: LGPL-2.1-or-later +*/ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code (ram_addr_t ram_addr); +void tlb_unprotect_code (ram_addr_t ram_addr); + +#endif +include/exec/cputlb.h +2
-6@@ -24,14 +24,10 @@#include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG ) && !defined(CONFIG_USER_ONLY ) -void tlb_protect_code (ram_addr_t ram_addr); -void tlb_unprotect_code (ram_addr_t ram_addr); -#endif #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" +void tlb_reset_dirty (CPUState *cpu,uintptr_t start,uintptr_t length);void tlb_reset_dirty_range_all (ram_addr_t start,ram_addr_t length);#endif accel/tcg/cputlb.c +2
-1@@ -1,5 +1,5 @@/* -* Common CPU TLB handling +* Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@#include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif accel/tcg/tb-maint.c +1
-0@@ -38,6 +38,7 @@#include "user/page-protection.h" #define runstate_is_running () true#else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h"
Re: [PATCH 03/33] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG
In reply to Philippe Mathieu-DaudéQuoted 4 lines · Philippe Mathieu-Daudé
Both
tlb_protect()andtlb_unprotect_code()are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header.
Quoted 8 lines
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-)create mode 100644
accel/tcg/system-page-protection.h
r~
Re: [PATCH 03/33] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG
In reply to Philippe Mathieu-DaudéQuoted 5 lines · Philippe Mathieu-Daudé
Both
tlb_protect()andtlb_unprotect_code()are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header.Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Quoted 86 lines
--- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.haccel/tcg/system-page-protection.h new file +17
-0@@ -0,0 +1,17 @@ +/* +* QEMU page protection (system emulation) +* +* Copyright (c) 2003 Fabrice Bellard +* +* SPDX-License-Identifier: LGPL-2.1-or-later +*/ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code (ram_addr_t ram_addr); +void tlb_unprotect_code (ram_addr_t ram_addr); + +#endif +include/exec/cputlb.h +2
-6@@ -24,14 +24,10 @@#include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG ) && !defined(CONFIG_USER_ONLY ) -void tlb_protect_code (ram_addr_t ram_addr); -void tlb_unprotect_code (ram_addr_t ram_addr); -#endif #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" +void tlb_reset_dirty (CPUState *cpu,uintptr_t start,uintptr_t length);void tlb_reset_dirty_range_all (ram_addr_t start,ram_addr_t length);#endif accel/tcg/cputlb.c +2
-1@@ -1,5 +1,5 @@/* -* Common CPU TLB handling +* Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@#include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif accel/tcg/tb-maint.c +1
-0@@ -38,6 +38,7 @@#include "user/page-protection.h" #define runstate_is_running () true#else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h" Signature · 1 line
2.53.0
PATCH 4/33 accel/hvf: Remove left-over comment
In reply to Philippe Mathieu-DaudéMissed in commit 6bf331164c5 ("accel/hvf: Drop hvf_slot and hvf_find_overlap_slot").
--- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-)
accel/hvf/hvf-accel-ops.c +0 -2
@@ -62,8 +62,6 @@HVFState *hvf_state; -/* Memory slots */ -static void do_hvf_cpu_synchronize_state (CPUState *cpu,run_on_cpu_data arg) {if (!cpu->vcpu_dirty) {
Signature · 1 line
2.53.0
Re: [PATCH 04/33] accel/hvf: Remove left-over comment
Quoted 5 lines · Philippe Mathieu-Daudé
Missed in commit
6bf331164c5("accel/hvf: Drophvf_slotandhvf_find_overlap_slot").Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Trivial stuff even for non-HVF people, so:
Quoted 16 lines
accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-)accel/hvf/hvf-accel-ops.c +0
-2@@ -62,8 +62,6 @@HVFState *hvf_state; -/* Memory slots */ -static void do_hvf_cpu_synchronize_state (CPUState *cpu,run_on_cpu_data arg) {if (!cpu->vcpu_dirty) {
Re: [PATCH 04/33] accel/hvf: Remove left-over comment
In reply to Philippe Mathieu-DaudéQuoted 13 lines · Philippe Mathieu-Daudé
Missed in commit
6bf331164c5("accel/hvf: Drophvf_slotandhvf_find_overlap_slot").Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-)accel/hvf/hvf-accel-ops.c +0
-0
accel/hvf/hvf-accel-ops.c line 67
Quoted 8 lines
accel/hvf/hvf-accel-ops.c +0
-2@@ -62,8 +62,6 @@HVFState *hvf_state; -/* Memory slots */ -static void do_hvf_cpu_synchronize_state (CPUState *cpu,run_on_cpu_data arg) {if (!cpu->vcpu_dirty) {
r~
PATCH 5/33 accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
In reply to Philippe Mathieu-DaudéNo need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits 6f13a0ada01..36ab216b81d).
--- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-)
include/system/mshv_int.h +0 -1
@@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs {struct AccelCPUState {int cpufd; -bool dirty;MshvHvCallArgs hvcall_args; };
accel/mshv/mshv-all.c +9 -9
@@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) }mshv_arch_init_vcpu (cpu); - cpu->accel->dirty = true; + cpu->vcpu_dirty = true;return 0 ; }
@@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu)cpu_exec_start (cpu); do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret = mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s",
@@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =-1 ;break ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; } ret =mshv_run_vcpu (mshv_state->vm, cpu, &mshv_msg, &exit_reason);
@@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState *cpu,abort (); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void mshv_cpu_synchronize_post_init (CPUState *cpu)
@@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState *cpu)cpu_dump_state (cpu, stderr,CPU_DUMP_CODE );vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void do_mshv_cpu_synchronize_pre_loadvm (CPUState *cpu,run_on_cpu_data arg) { - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; }static void mshv_cpu_synchronize_pre_loadvm (CPUState *cpu)
@@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu)static void do_mshv_cpu_synchronize (CPUState *cpu,run_on_cpu_data arg) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {int ret =mshv_arch_load_vcpu_state (cpu);if (ret <0 ) { error_report("Failed to load registers for vcpu %d",
@@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg)vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; } }static void mshv_cpu_synchronize (CPUState *cpu) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {run_on_cpu (cpu, do_mshv_cpu_synchronize,RUN_ON_CPU_NULL ); } }
target/i386/mshv/mshv-cpu.c +3 -3
@@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *data, uintptr_t size,return ret; } -static int handle_pio_non_str (const CPUState *cpu, +static int handle_pio_non_str (CPUState *cpu,hv_x64_io_port_intercept_message *info) {size_t len = info->access_info.access_size;
@@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu,return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ; }
@@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ; }
Signature · 1 line
2.53.0
Re: [PATCH 05/33] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
Cc'ing Magnus.
Quoted 135 lines · Philippe Mathieu-Daudé
No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits
6f13a0ada01..36ab216b81d).Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-)include/system/mshv_int.h +0
-1@@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs {struct AccelCPUState {int cpufd; -bool dirty;MshvHvCallArgs hvcall_args; };accel/mshv/mshv-all.c +9
-9@@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) }mshv_arch_init_vcpu (cpu); - cpu->accel->dirty = true; + cpu->vcpu_dirty = true;return 0 ; }@@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu)cpu_exec_start (cpu); do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret = mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s",@@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =-1 ;break ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; } ret =mshv_run_vcpu (mshv_state->vm, cpu, &mshv_msg, &exit_reason);@@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState *cpu,abort (); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void mshv_cpu_synchronize_post_init (CPUState *cpu)@@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState *cpu)cpu_dump_state (cpu, stderr,CPU_DUMP_CODE );vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void do_mshv_cpu_synchronize_pre_loadvm (CPUState *cpu,run_on_cpu_data arg) { - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; }static void mshv_cpu_synchronize_pre_loadvm (CPUState *cpu)@@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu)static void do_mshv_cpu_synchronize (CPUState *cpu,run_on_cpu_data arg) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {int ret =mshv_arch_load_vcpu_state (cpu);if (ret <0 ) { error_report("Failed to load registers for vcpu %d",@@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg)vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; } }static void mshv_cpu_synchronize (CPUState *cpu) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {run_on_cpu (cpu, do_mshv_cpu_synchronize,RUN_ON_CPU_NULL ); } }target/i386/mshv/mshv-cpu.c +3
-3@@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *data, uintptr_t size,return ret; } -static int handle_pio_non_str (const CPUState *cpu, +static int handle_pio_non_str (CPUState *cpu,hv_x64_io_port_intercept_message *info) {size_t len = info->access_info.access_size;@@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu,return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ; }@@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ; }
Magnus Kulke
Tested-byRe: [PATCH 05/33] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
Quoted 112 lines · Philippe Mathieu-Daudé
Cc'ing Magnus.
Quoted 109 lines · Philippe Mathieu-Daudé
No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits
6f13a0ada01..36ab216b81d).Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-)include/system/mshv_int.h +0
-1@@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs {struct AccelCPUState {int cpufd; -bool dirty;MshvHvCallArgs hvcall_args; };accel/mshv/mshv-all.c +9
-9@@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) }mshv_arch_init_vcpu (cpu); - cpu->accel->dirty = true; + cpu->vcpu_dirty = true;return 0 ; }@@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu)cpu_exec_start (cpu); do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret = mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s",@@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =-1 ;break ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; } ret =mshv_run_vcpu (mshv_state->vm, cpu, &mshv_msg, &exit_reason);@@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState *cpu,abort (); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void mshv_cpu_synchronize_post_init (CPUState *cpu)@@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState *cpu)cpu_dump_state (cpu, stderr,CPU_DUMP_CODE );vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false; }static void do_mshv_cpu_synchronize_pre_loadvm (CPUState *cpu,run_on_cpu_data arg) { - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; }static void mshv_cpu_synchronize_pre_loadvm (CPUState *cpu)@@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu)static void do_mshv_cpu_synchronize (CPUState *cpu,run_on_cpu_data arg) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {int ret =mshv_arch_load_vcpu_state (cpu);if (ret <0 ) { error_report("Failed to load registers for vcpu %d",@@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg)vm_stop (RUN_STATE_INTERNAL_ERROR ); } - cpu->accel->dirty = true; + cpu->vcpu_dirty = true; } }static void mshv_cpu_synchronize (CPUState *cpu) { -if (!cpu->accel->dirty) { +if (!cpu->vcpu_dirty) {run_on_cpu (cpu, do_mshv_cpu_synchronize,RUN_ON_CPU_NULL ); } }target/i386/mshv/mshv-cpu.c +2
-2@@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *data, uintptr_t size,return ret; } -static int handle_pio_non_str (const CPUState *cpu, +static int handle_pio_non_str (CPUState *cpu,hv_x64_io_port_intercept_message *info) {size_t len = info->access_info.access_size;@@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu,return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ;
Quoted 8 lines
target/i386/mshv/mshv-cpu.c static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) · line 1913
Quoted 8 lines
target/i386/mshv/mshv-cpu.c +1
-1}@@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)return -1 ; } - cpu->accel->dirty = false; + cpu->vcpu_dirty = false;return 0 ; }
thanks, applied and tested.
Re: [PATCH 05/33] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field
In reply to Philippe Mathieu-DaudéQuoted 10 lines · Philippe Mathieu-Daudé
No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits
6f13a0ada01..36ab216b81d).Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-)
r~
PATCH 6/33 gdbstub: Add trace event for STEP packet handler
In reply to Philippe Mathieu-Daudé--- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)
gdbstub/gdbstub.c +1 -0
@@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ctx)gdb_set_cpu_pc (gdb_get_cmd_param (params,0 )->val_ull); } +trace_gdbstub_op_stepping (gdbserver_state.c_cpu->cpu_index);cpu_single_step (gdbserver_state.c_cpu, gdbserver_state.sstep_flags);gdb_continue (); }
Signature · 1 line
2.53.0
Re: [PATCH 06/33] gdbstub: Add trace event for STEP packet handler
Quoted 2 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 15 lines
gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)gdbstub/gdbstub.c +1
-0@@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ctx)gdb_set_cpu_pc (gdb_get_cmd_param (params,0 )->val_ull); } +trace_gdbstub_op_stepping (gdbserver_state.c_cpu->cpu_index);cpu_single_step (gdbserver_state.c_cpu, gdbserver_state.sstep_flags);gdb_continue (); }
Re: [PATCH 06/33] gdbstub: Add trace event for STEP packet handler
In reply to Philippe Mathieu-DaudéQuoted 1 line · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Quoted 16 lines
--- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)gdbstub/gdbstub.c +1
-0@@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ctx)gdb_set_cpu_pc (gdb_get_cmd_param (params,0 )->val_ull); } +trace_gdbstub_op_stepping (gdbserver_state.c_cpu->cpu_index);cpu_single_step (gdbserver_state.c_cpu, gdbserver_state.sstep_flags);gdb_continue (); }
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
PATCH 7/33 gdbstub: Only return E22 when reverse GDB is not supported
In reply to Philippe Mathieu-DaudéNo need to keep processing the arguments when we know reverse debugging is not available.
--- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)
gdbstub/gdbstub.c +1 -0
@@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *user_ctx) {if (!gdb_can_reverse ()) {gdb_put_packet ("E22" ); +return ; }if (params->len ==1 ) {switch (gdb_get_cmd_param (params,0 )->opcode) {
Signature · 1 line
2.53.0
Re: [PATCH 07/33] gdbstub: Only return E22 when reverse GDB is not supported
Quoted 5 lines · Philippe Mathieu-Daudé
No need to keep processing the arguments when we know reverse debugging is not available.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 15 lines
gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)gdbstub/gdbstub.c +1
-0@@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *user_ctx) {if (!gdb_can_reverse ()) {gdb_put_packet ("E22" ); +return ; }if (params->len ==1 ) {switch (gdb_get_cmd_param (params,0 )->opcode) {
Re: [PATCH 07/33] gdbstub: Only return E22 when reverse GDB is not supported
In reply to Philippe Mathieu-DaudéQuoted 4 lines · Philippe Mathieu-Daudé
No need to keep processing the arguments when we know reverse debugging is not available.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Quoted 16 lines
--- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+)gdbstub/gdbstub.c +1
-0@@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *user_ctx) {if (!gdb_can_reverse ()) {gdb_put_packet ("E22" ); +return ; }if (params->len ==1 ) {switch (gdb_get_cmd_param (params,0 )->opcode) {
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
PATCH 8/33 accel/kvm: Always define AccelOpsClass::supports_guest_debug
In reply to Philippe Mathieu-DaudéWhether TARGET_KVM_HAVE_GUEST_DEBUG is defined or not, kvm_supports_guest_debug() still exists and can be called.
--- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
accel/kvm/kvm-accel-ops.c +1 -1
@@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data) ops->synchronize_pre_loadvm = kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt = generic_handle_interrupt; + ops->supports_guest_debug = kvm_supports_guest_debug;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug = kvm_update_guest_debug_ops; - ops->supports_guest_debug = kvm_supports_guest_debug; ops->insert_breakpoint = kvm_insert_breakpoint; ops->remove_breakpoint = kvm_remove_breakpoint; ops->remove_all_breakpoints = kvm_remove_all_breakpoints;
Signature · 1 line
2.53.0
Re: [PATCH 08/33] accel/kvm: Always define AccelOpsClass::supports_guest_debug
Quoted 5 lines · Philippe Mathieu-Daudé
Whether
TARGET_KVM_HAVE_GUEST_DEBUGis defined or not,kvm_supports_guest_debug()still exists and can be called.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 18 lines
accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)accel/kvm/kvm-accel-ops.c +1
-1@@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data) ops->synchronize_pre_loadvm = kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt = generic_handle_interrupt; + ops->supports_guest_debug = kvm_supports_guest_debug;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug = kvm_update_guest_debug_ops; - ops->supports_guest_debug = kvm_supports_guest_debug; ops->insert_breakpoint = kvm_insert_breakpoint; ops->remove_breakpoint = kvm_remove_breakpoint; ops->remove_all_breakpoints = kvm_remove_all_breakpoints;
Re: [PATCH 08/33] accel/kvm: Always define AccelOpsClass::supports_guest_debug
In reply to Philippe Mathieu-DaudéQuoted 7 lines · Philippe Mathieu-Daudé
Whether
TARGET_KVM_HAVE_GUEST_DEBUGis defined or not,kvm_supports_guest_debug()still exists and can be called.Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
r~
PATCH 9/33 accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG
In reply to Philippe Mathieu-DaudéSimplify #ifdef'ry using TARGET_KVM_HAVE_GUEST_DEBUG in kvm_init().
--- accel/kvm/kvm-all.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
accel/kvm/kvm-all.c +3 -4
@@ -3037,24 +3037,23 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_vm_attributes_allowed = (kvm_check_extension (s,KVM_CAP_VM_ATTRIBUTES ) >0 ); + kvm_sstep_flags =0 ; +#ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 ); -#endif - kvm_sstep_flags =0 ;if (kvm_has_guest_debug) { kvm_sstep_flags =SSTEP_ENABLE ; -#if definedTARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG2 );if (guest_debug_flags &KVM_GUESTDBG_BLOCKIRQ ) { kvm_sstep_flags |=SSTEP_NOIRQ ; } -#endif } +#endif kvm_state = s;
Signature · 1 line
2.53.0
Re: [PATCH 09/33] accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG
Quoted 12 lines · Philippe Mathieu-Daudé
Simplify #ifdef'ry using
TARGET_KVM_HAVE_GUEST_DEBUGinkvm_init().Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/kvm/kvm-all.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)accel/kvm/kvm-all.c +0
-0
accel/kvm/kvm-all.c static int kvm_init(AccelState *as, MachineState *ms) · line 3041
Quoted 5 lines
accel/kvm/kvm-all.c +2
-0@@ -3037,24 +3037,23 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_vm_attributes_allowed = (kvm_check_extension (s,KVM_CAP_VM_ATTRIBUTES ) >0 ); + kvm_sstep_flags =0 ; +
You don't need this, since the global is zero-initialized by default.
Otherwise,
r~
Quoted 22 lines
accel/kvm/kvm-all.c +1
-4#ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 ); -#endif - kvm_sstep_flags =0 ;if (kvm_has_guest_debug) { kvm_sstep_flags =SSTEP_ENABLE ; -#if definedTARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG2 );if (guest_debug_flags &KVM_GUESTDBG_BLOCKIRQ ) { kvm_sstep_flags |=SSTEP_NOIRQ ; } -#endif } +#endif kvm_state = s;
PATCH 10/33 accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config()
In reply to Philippe Mathieu-DaudéIn order to have accelerator return multiple gdbstub parameters, pass @supported_sstep_flags as argument instead of returning it.
--- include/accel/accel-ops.h | 2 +- include/qemu/accel.h | 7 ++++--- accel/accel-common.c | 9 +++++---- accel/hvf/hvf-all.c | 6 +++--- accel/kvm/kvm-all.c | 12 +++++++----- accel/tcg/tcg-all.c | 8 ++++---- gdbstub/gdbstub.c | 2 +- 7 files changed, 25 insertions(+), 21 deletions(-)
include/accel/accel-ops.h +1 -1
@@ -37,7 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size);/* gdbstub related hooks */ -int (*gdbstub_supported_sstep_flags)(AccelState *as); +void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags);bool *allowed;/*
include/qemu/accel.h +4 -3
@@ -74,11 +74,12 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **errp);void accel_cpu_common_unrealize (CPUState *cpu);/** -* accel_supported_gdbstub_sstep_flags: +* accel_get_gdbstub_config: +* @supported_sstep_flags: pointer to store the single step modes in * -* Returns the supported single step modes for the configured +* Set the supported single step modes for the configured * accelerator. */ -int accel_supported_gdbstub_sstep_flags (void ); +void accel_get_gdbstub_config (int *supported_sstep_flags);#endif /* QEMU_ACCEL_H */
accel/accel-common.c +5 -4
@@ -113,14 +113,15 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } -int accel_supported_gdbstub_sstep_flags (void ) +void accel_get_gdbstub_config (int *supported_sstep_flags) {AccelState *accel =current_accel ();AccelClass *acc =ACCEL_GET_CLASS (accel); -if (acc->gdbstub_supported_sstep_flags) { -return acc->gdbstub_supported_sstep_flags (accel); +if (acc->get_gdbstub_config) { + acc->get_gdbstub_config (accel, supported_sstep_flags); + }else { + *supported_sstep_flags =0 ; } -return 0 ; }static const TypeInfo accel_types[] = {
accel/hvf/hvf-all.c +3 -3
@@ -228,9 +228,9 @@ static int hvf_accel_init(AccelState *as, MachineState *ms)return hvf_arch_init (); } -static int hvf_gdbstub_sstep_flags (AccelState *as) +static void hvf_gdbstub_config (AccelState *as,int *supported_sstep_flags) { -return SSTEP_ENABLE |SSTEP_NOIRQ ; + *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ ; } static void hvf_set_kernel_irqchip(Object *obj, Visitor *v,
@@ -278,7 +278,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const void *data) ac->name ="HVF" ; ac->init_machine = hvf_accel_init; ac->allowed = &hvf_allowed; - ac->gdbstub_supported_sstep_flags = hvf_gdbstub_sstep_flags; + ac->get_gdbstub_config = hvf_gdbstub_config; hvf_kernel_irqchip_override = false; hvf_kernel_irqchip = false; object_class_property_add(oc, "kernel-irqchip", "on|off|split",
accel/kvm/kvm-all.c +7 -5
@@ -4281,14 +4281,16 @@ static void kvm_accel_instance_init(Object *obj) }/** -* kvm_gdbstub_sstep_flags(): +* kvm_gdbstub_config(): * -* Returns: SSTEP_* flags that KVM supports for guest debug. The +* Set SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static int kvm_gdbstub_sstep_flags (AccelState *as) +static void kvm_gdbstub_config (AccelState *as,int *supported_sstep_flags) { -return kvm_sstep_flags; +KVMState *s =KVM_STATE (as); + + *supported_sstep_flags = s->gdbstub_sstep_flags; }static void kvm_accel_class_init (ObjectClass *oc,const void *data)
@@ -4299,7 +4301,7 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data) ac->rebuild_guest = kvm_reset_vmfd; ac->has_memory = kvm_accel_has_memory; ac->allowed = &kvm_allowed; - ac->gdbstub_supported_sstep_flags = kvm_gdbstub_sstep_flags; + ac->get_gdbstub_config = kvm_gdbstub_config; object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip,
accel/tcg/tcg-all.c +4 -4
@@ -242,7 +242,7 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp)qatomic_set (&one_insn_per_tb, value); } -static int tcg_gdbstub_supported_sstep_flags (AccelState *as) +static void tcg_gdbstub_config (AccelState *as,int *supported_sstep_flags) {/* * In replay mode all events will come from the log and can't be
@@ -251,9 +251,9 @@ static int tcg_gdbstub_supported_sstep_flags(AccelState *as)* them occurring every time we single step. */ if (replay_mode !=REPLAY_MODE_NONE ) { -return SSTEP_ENABLE ; + *supported_sstep_flags =SSTEP_ENABLE ; }else { -return SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; + *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; } }
@@ -266,7 +266,7 @@ static void tcg_accel_class_init(ObjectClass *oc, const void *data) ac->cpu_common_unrealize = tcg_exec_unrealizefn; ac->get_stats = tcg_get_stats; ac->allowed = &tcg_allowed; - ac->gdbstub_supported_sstep_flags = tcg_gdbstub_supported_sstep_flags; + ac->get_gdbstub_config = tcg_gdbstub_config; object_class_property_add_str(oc, "thread", tcg_get_thread,
gdbstub/gdbstub.c +1 -1
@@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void)* By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =accel_supported_gdbstub_sstep_flags (); +accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags; }
Signature · 1 line
2.53.0
Re: [PATCH 10/33] accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config()
Quoted 19 lines · Philippe Mathieu-Daudé
In order to have accelerator return multiple gdbstub parameters, pass @supported_sstep_flags as argument instead of returning it.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/accel/accel-ops.h | 2 +- include/qemu/accel.h | 7 ++++--- accel/accel-common.c | 9 +++++---- accel/hvf/hvf-all.c | 6 +++--- accel/kvm/kvm-all.c | 12 +++++++----- accel/tcg/tcg-all.c | 8 ++++---- gdbstub/gdbstub.c | 2 +- 7 files changed, 25 insertions(+), 21 deletions(-)include/accel/accel-ops.h +0
-0
include/accel/accel-ops.h struct AccelClass { · line 41
Quoted 6 lines
include/accel/accel-ops.h +1
-1@@ -37,7 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size);/* gdbstub related hooks */ -int (*gdbstub_supported_sstep_flags)(AccelState *as); +void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags);
Is there anything wrong with just returning a structure rather than each individual config being passed by reference?
--8<---------------cut here---------------start------------->8---
modified include/accel/accel-ops.h
@@ -15,6 +15,11 @@ struct AccelState {
Object parent_obj;};
+struct AccelGdbConfig {
+ int supported_sstep_flags;
+ bool can_reverse;
+};
+
struct AccelClass {
ObjectClass parent_class;@@ -38,8 +43,7 @@ struct AccelClass {
/* gdbstub related hooks */
bool (*supports_guest_debug)(AccelState *as);- void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags,
- bool *can_reverse);
+ struct AccelGdbConfig (*get_gdbstub_config)(AccelState *as);
bool *allowed;
--8<---------------cut here---------------end--------------->8---
Quoted 153 lines
include/accel/accel-ops.h +0
-0bool *allowed;/* include/qemu/accel.h +4
-3@@ -74,11 +74,12 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **errp);void accel_cpu_common_unrealize (CPUState *cpu);/** -* accel_supported_gdbstub_sstep_flags: +* accel_get_gdbstub_config: +* @supported_sstep_flags: pointer to store the single step modes in * -* Returns the supported single step modes for the configured +* Set the supported single step modes for the configured * accelerator. */ -int accel_supported_gdbstub_sstep_flags (void ); +void accel_get_gdbstub_config (int *supported_sstep_flags);#endif /* QEMU_ACCEL_H */ accel/accel-common.c +5
-4@@ -113,14 +113,15 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } -int accel_supported_gdbstub_sstep_flags (void ) +void accel_get_gdbstub_config (int *supported_sstep_flags) {AccelState *accel =current_accel ();AccelClass *acc =ACCEL_GET_CLASS (accel); -if (acc->gdbstub_supported_sstep_flags) { -return acc->gdbstub_supported_sstep_flags (accel); +if (acc->get_gdbstub_config) { + acc->get_gdbstub_config (accel, supported_sstep_flags); + }else { + *supported_sstep_flags =0 ; } -return 0 ; }static const TypeInfo accel_types[] = {accel/hvf/hvf-all.c +3
-3@@ -228,9 +228,9 @@ static int hvf_accel_init(AccelState *as, MachineState *ms)return hvf_arch_init (); } -static int hvf_gdbstub_sstep_flags (AccelState *as) +static void hvf_gdbstub_config (AccelState *as,int *supported_sstep_flags) { -return SSTEP_ENABLE |SSTEP_NOIRQ ; + *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ ; } static void hvf_set_kernel_irqchip(Object *obj, Visitor *v,@@ -278,7 +278,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const void *data) ac->name ="HVF" ; ac->init_machine = hvf_accel_init; ac->allowed = &hvf_allowed; - ac->gdbstub_supported_sstep_flags = hvf_gdbstub_sstep_flags; + ac->get_gdbstub_config = hvf_gdbstub_config; hvf_kernel_irqchip_override = false; hvf_kernel_irqchip = false; object_class_property_add(oc, "kernel-irqchip", "on|off|split",accel/kvm/kvm-all.c +7
-5@@ -4281,14 +4281,16 @@ static void kvm_accel_instance_init(Object *obj) }/** -* kvm_gdbstub_sstep_flags(): +* kvm_gdbstub_config(): * -* Returns: SSTEP_* flags that KVM supports for guest debug. The +* Set SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static int kvm_gdbstub_sstep_flags (AccelState *as) +static void kvm_gdbstub_config (AccelState *as,int *supported_sstep_flags) { -return kvm_sstep_flags; +KVMState *s =KVM_STATE (as); + + *supported_sstep_flags = s->gdbstub_sstep_flags; }static void kvm_accel_class_init (ObjectClass *oc,const void *data)@@ -4299,7 +4301,7 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data) ac->rebuild_guest = kvm_reset_vmfd; ac->has_memory = kvm_accel_has_memory; ac->allowed = &kvm_allowed; - ac->gdbstub_supported_sstep_flags = kvm_gdbstub_sstep_flags; + ac->get_gdbstub_config = kvm_gdbstub_config; object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip,accel/tcg/tcg-all.c +4
-4@@ -242,7 +242,7 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp)qatomic_set (&one_insn_per_tb, value); } -static int tcg_gdbstub_supported_sstep_flags (AccelState *as) +static void tcg_gdbstub_config (AccelState *as,int *supported_sstep_flags) {/* * In replay mode all events will come from the log and can't be @@ -251,9 +251,9 @@ static int tcg_gdbstub_supported_sstep_flags(AccelState *as)* them occurring every time we single step. */ if (replay_mode !=REPLAY_MODE_NONE ) { -return SSTEP_ENABLE ; + *supported_sstep_flags =SSTEP_ENABLE ; }else { -return SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; + *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; } }@@ -266,7 +266,7 @@ static void tcg_accel_class_init(ObjectClass *oc, const void *data) ac->cpu_common_unrealize = tcg_exec_unrealizefn; ac->get_stats = tcg_get_stats; ac->allowed = &tcg_allowed; - ac->gdbstub_supported_sstep_flags = tcg_gdbstub_supported_sstep_flags; + ac->get_gdbstub_config = tcg_gdbstub_config; object_class_property_add_str(oc, "thread", tcg_get_thread,gdbstub/gdbstub.c +1
-1@@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void)* By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =accel_supported_gdbstub_sstep_flags (); +accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags; }
Signature · 2 lines
Alex Bennée Virtualisation Tech Lead @ Linaro
Re: [PATCH 10/33] accel: Change gdbstub_supported_sstep_flags() -> get_gdbstub_config()
Quoted 23 lines · Alex Bennée
Quoted 21 lines · Philippe Mathieu-Daudé
In order to have accelerator return multiple gdbstub parameters, pass @supported_sstep_flags as argument instead of returning it.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/accel/accel-ops.h | 2 +- include/qemu/accel.h | 7 ++++--- accel/accel-common.c | 9 +++++---- accel/hvf/hvf-all.c | 6 +++--- accel/kvm/kvm-all.c | 12 +++++++----- accel/tcg/tcg-all.c | 8 ++++---- gdbstub/gdbstub.c | 2 +- 7 files changed, 25 insertions(+), 21 deletions(-)include/accel/accel-ops.h +0
-0@@ -37,7 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size);
Quoted 7 lines
include/accel/accel-ops.h struct AccelClass {
Quoted 4 lines
include/accel/accel-ops.h +1
-1/* gdbstub related hooks */ -int (*gdbstub_supported_sstep_flags)(AccelState *as); +void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags);Is there anything wrong with just returning a structure rather than each individual config being passed by reference?
Sure, will update and respin.
Quoted 30 lines
--8<---------------cut here---------------start------------->8---
modified include/accel/accel-ops.h(quoted diff) +6
-3@@ -15,6 +15,11 @@ struct AccelState { Object parent_obj; }; +struct AccelGdbConfig { + int supported_sstep_flags; + bool can_reverse; +}; + struct AccelClass { ObjectClass parent_class;@@ -38,8 +43,7 @@ struct AccelClass { /* gdbstub related hooks */ bool (*supports_guest_debug)(AccelState *as); - void (*get_gdbstub_config)(AccelState *as, int *supported_sstep_flags, - bool *can_reverse); + struct AccelGdbConfig (*get_gdbstub_config)(AccelState *as); bool *allowed; --8<---------------cut here---------------end--------------->8---Quoted 5 lines
include/accel/accel-ops.h +0
-0bool *allowed;/*
PATCH 11/33 gdbstub: Store @can_reverse in GDBState
In reply to Philippe Mathieu-DaudéCall gdb_can_reverse() once in gdb_init_gdbserver_state() and store the result in GDBState.
--- gdbstub/internals.h | 1 + gdbstub/gdbstub.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-)
gdbstub/internals.h +1 -0
@@ -85,6 +85,7 @@ typedef struct GDBState {GByteArray *mem_buf;int sstep_flags;int supported_sstep_flags; +bool can_reverse;/* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself.
gdbstub/gdbstub.c +3 -2
@@ -75,6 +75,7 @@ void gdb_init_gdbserver_state(void)accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags; + gdbserver_state.can_reverse =gdb_can_reverse (); }/* writes 2*len+1 bytes in buf */
@@ -1376,7 +1377,7 @@ static void handle_step(GArray *params, void *user_ctx)static void handle_backward (GArray *params,void *user_ctx) { -if (!gdb_can_reverse ()) { +if (!gdbserver_state.can_reverse) {gdb_put_packet ("E22" );return ; }
@@ -1684,7 +1685,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)g_string_append (gdbserver_state.str_buf,";qXfer:features:read+" ); } -if (gdb_can_reverse ()) { +if (gdbserver_state.can_reverse) {g_string_append (gdbserver_state.str_buf,";ReverseStep+;ReverseContinue+" ); }
Signature · 1 line
2.53.0
Re: [PATCH 11/33] gdbstub: Store @can_reverse in GDBState
Quoted 5 lines · Philippe Mathieu-Daudé
Call
gdb_can_reverse()once ingdb_init_gdbserver_state()and store the result in GDBState.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 46 lines
gdbstub/internals.h | 1 + gdbstub/gdbstub.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-)gdbstub/internals.h +1
-0@@ -85,6 +85,7 @@ typedef struct GDBState {GByteArray *mem_buf;int sstep_flags;int supported_sstep_flags; +bool can_reverse;/* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself. gdbstub/gdbstub.c +3
-2@@ -75,6 +75,7 @@ void gdb_init_gdbserver_state(void)accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags); gdbserver_state.sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags; + gdbserver_state.can_reverse =gdb_can_reverse (); }/* writes 2*len+1 bytes in buf */ @@ -1376,7 +1377,7 @@ static void handle_step(GArray *params, void *user_ctx)static void handle_backward (GArray *params,void *user_ctx) { -if (!gdb_can_reverse ()) { +if (!gdbserver_state.can_reverse) {gdb_put_packet ("E22" );return ; }@@ -1684,7 +1685,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)g_string_append (gdbserver_state.str_buf,";qXfer:features:read+" ); } -if (gdb_can_reverse ()) { +if (gdbserver_state.can_reverse) {g_string_append (gdbserver_state.str_buf,";ReverseStep+;ReverseContinue+" ); }
PATCH 12/33 gdbstub: Make default replay_mode value explicit in stubs
In reply to Philippe Mathieu-DaudéMake explicit @replay_mode is stubbed as REPLAY_MODE_NONE.
--- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
stubs/replay-mode.c +1 -1
@@ -1,4 +1,4 @@#include "qemu/osdep.h" #include "system/replay.h" -ReplayMode replay_mode; +ReplayMode replay_mode =REPLAY_MODE_NONE ;
Signature · 1 line
2.53.0
Re: [PATCH 12/33] gdbstub: Make default replay_mode value explicit in stubs
Quoted 12 lines · Philippe Mathieu-Daudé
Make explicit @replay_mode is stubbed as
REPLAY_MODE_NONE.Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)stubs/replay-mode.c +0
-0
stubs/replay-mode.c line 4
Quoted 5 lines
stubs/replay-mode.c +1
-1@@ -1,4 +1,4 @@#include "qemu/osdep.h" #include "system/replay.h" -ReplayMode replay_mode; +ReplayMode replay_mode =REPLAY_MODE_NONE ;
r~
PATCH 13/33 accel: Have get_gdbstub_config() return @can_reverse value
In reply to Philippe Mathieu-DaudéHave accelerators set @can_reverse in their get_gdbstub_config() handler. Remove gdb_can_reverse() as now unused.
--- gdbstub/internals.h | 1 - include/accel/accel-ops.h | 3 ++- include/qemu/accel.h | 5 +++-- accel/accel-common.c | 5 +++-- accel/hvf/hvf-all.c | 4 +++- accel/kvm/kvm-all.c | 4 +++- accel/tcg/tcg-all.c | 4 +++- gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 5 ----- gdbstub/user.c | 6 ------ 10 files changed, 19 insertions(+), 22 deletions(-)
gdbstub/internals.h +0 -1
@@ -154,7 +154,6 @@ CPUState *gdb_first_attached_cpu(void);void gdb_append_thread_id (CPUState *cpu,GString *buf);int gdb_get_cpu_index (CPUState *cpu);unsigned int gdb_get_max_cpus (void );/* both */ -bool gdb_can_reverse (void );/* system emulation, stub for user */ int gdb_target_sigtrap (void );/* user */ void gdb_create_default_process (GDBState *s);
include/accel/accel-ops.h +2 -1
@@ -37,7 +37,8 @@ struct AccelClass { hwaddr start_addr, hwaddr size);/* gdbstub related hooks */ -void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags); +void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags, +bool *can_reverse);bool *allowed;/*
include/qemu/accel.h +3 -2
@@ -76,10 +76,11 @@ void accel_cpu_common_unrealize(CPUState *cpu);/** * accel_get_gdbstub_config: * @supported_sstep_flags: pointer to store the single step modes in +* @can_reverse: pointer to store whether reverse mode is supported * -* Set the supported single step modes for the configured +* Set the supported single step and reverse modes for the configured * accelerator. */ -void accel_get_gdbstub_config (int *supported_sstep_flags); +void accel_get_gdbstub_config (int *supported_sstep_flags,bool *can_reverse);#endif /* QEMU_ACCEL_H */
accel/accel-common.c +3 -2
@@ -113,14 +113,15 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } -void accel_get_gdbstub_config (int *supported_sstep_flags) +void accel_get_gdbstub_config (int *supported_sstep_flags,bool *can_reverse) {AccelState *accel =current_accel ();AccelClass *acc =ACCEL_GET_CLASS (accel);if (acc->get_gdbstub_config) { - acc->get_gdbstub_config (accel, supported_sstep_flags); + acc->get_gdbstub_config (accel, supported_sstep_flags, can_reverse); }else { *supported_sstep_flags =0 ; + *can_reverse = false; } }
accel/hvf/hvf-all.c +3 -1
@@ -228,9 +228,11 @@ static int hvf_accel_init(AccelState *as, MachineState *ms)return hvf_arch_init (); } -static void hvf_gdbstub_config (AccelState *as,int *supported_sstep_flags) +static void hvf_gdbstub_config (AccelState *as,int *supported_sstep_flags, +bool *can_reverse) { *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ ; + *can_reverse = false; } static void hvf_set_kernel_irqchip(Object *obj, Visitor *v,
accel/kvm/kvm-all.c +3 -1
@@ -4286,11 +4286,13 @@ static void kvm_accel_instance_init(Object *obj)* Set SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static void kvm_gdbstub_config (AccelState *as,int *supported_sstep_flags) +static void kvm_gdbstub_config (AccelState *as,int *supported_sstep_flags, +bool *can_reverse) {KVMState *s =KVM_STATE (as); *supported_sstep_flags = s->gdbstub_sstep_flags; + *can_reverse = false; }static void kvm_accel_class_init (ObjectClass *oc,const void *data)
accel/tcg/tcg-all.c +3 -1
@@ -242,7 +242,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp)qatomic_set (&one_insn_per_tb, value); } -static void tcg_gdbstub_config (AccelState *as,int *supported_sstep_flags) +static void tcg_gdbstub_config (AccelState *as,int *supported_sstep_flags, +bool *can_reverse) {/* * In replay mode all events will come from the log and can't be
@@ -255,6 +256,7 @@ static void tcg_gdbstub_config(AccelState *as, int *supported_sstep_flags) }else { *supported_sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; } + *can_reverse = replay_mode ==REPLAY_MODE_PLAY ; }static void tcg_accel_class_init (ObjectClass *oc,const void *data)
gdbstub/gdbstub.c +2 -2
@@ -72,10 +72,10 @@ void gdb_init_gdbserver_state(void)* By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ -accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags); +accel_get_gdbstub_config (&gdbserver_state.supported_sstep_flags, + &gdbserver_state.can_reverse); gdbserver_state.sstep_flags =SSTEP_ENABLE |SSTEP_NOIRQ |SSTEP_NOTIMER ; gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags; - gdbserver_state.can_reverse =gdb_can_reverse (); }/* writes 2*len+1 bytes in buf */
gdbstub/system.c +0 -5
@@ -477,11 +477,6 @@ unsigned int gdb_get_max_cpus(void)return ms->smp.max_cpus; } -bool gdb_can_reverse (void ) -{ -return replay_mode ==REPLAY_MODE_PLAY ; -} -/* * Softmmu specific command helpers */
gdbstub/user.c +0 -6
@@ -786,12 +786,6 @@ unsigned int gdb_get_max_cpus(void)return max_cpus; } -/* replay not supported for user-mode */ -bool gdb_can_reverse (void ) -{ -return false; -} -/* * Break/Watch point helpers */
Signature · 1 line
2.53.0
PATCH 14/33 accel: Move supports_guest_debug() declaration to AccelClass
In reply to Philippe Mathieu-DaudéFrom: Philippe Mathieu-Daudé <[email protected]>
AccelOpsClass is for methods dealing with vCPUs. When only dealing with AccelState, AccelClass is sufficient.
In order to have AccelClass methods instrospect their state, we need to pass AccelState by argument.
Restrict kvm_supports_guest_debug() scope.
--- accel/kvm/kvm-cpus.h | 1 - gdbstub/internals.h | 1 - include/accel/accel-cpu-ops.h | 1 - include/accel/accel-ops.h | 1 + include/qemu/accel.h | 2 ++ include/system/hvf_int.h | 2 +- include/system/whpx-all.h | 4 +--- accel/accel-common.c | 12 ++++++++++++ accel/hvf/hvf-accel-ops.c | 1 - accel/hvf/hvf-all.c | 1 + accel/kvm/kvm-accel-ops.c | 1 - accel/kvm/kvm-all.c | 3 ++- accel/tcg/tcg-accel-ops.c | 6 ------ accel/tcg/tcg-all.c | 6 ++++++ accel/whpx/whpx-accel-ops.c | 7 ------- accel/whpx/whpx-common.c | 1 + gdbstub/system.c | 12 ++---------- gdbstub/user.c | 6 ------ target/arm/hvf/hvf.c | 2 +- target/arm/whpx/whpx-all.c | 2 +- target/i386/hvf/hvf.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- 22 files changed, 33 insertions(+), 43 deletions(-)
accel/kvm/kvm-cpus.h +0 -1
@@ -16,7 +16,6 @@ void kvm_destroy_vcpu(CPUState *cpu);void kvm_cpu_synchronize_post_reset (CPUState *cpu);void kvm_cpu_synchronize_post_init (CPUState *cpu);void kvm_cpu_synchronize_pre_loadvm (CPUState *cpu); -bool kvm_supports_guest_debug (void );int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len);int kvm_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len);void kvm_remove_all_breakpoints (CPUState *cpu);
gdbstub/internals.h +0 -1
@@ -217,7 +217,6 @@ void gdb_syscall_handling(const char *syscall_packet);* Break/Watch point support - there is an implementation for system * and user mode. */ -bool gdb_supports_guest_debug (void );int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len);int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len);void gdb_breakpoint_remove_all (CPUState *cs);
include/accel/accel-cpu-ops.h +0 -1
@@ -84,7 +84,6 @@ struct AccelOpsClass {int64_t (*get_elapsed_ticks)(void );/* gdbstub hooks */ -bool (*supports_guest_debug)(void );int (*update_guest_debug)(CPUState *cpu);int (*insert_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len);int (*remove_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len);
include/accel/accel-ops.h +1 -0
@@ -37,6 +37,7 @@ struct AccelClass { hwaddr start_addr, hwaddr size);/* gdbstub related hooks */ +bool (*supports_guest_debug)(AccelState *as);void (*get_gdbstub_config)(AccelState *as,int *supported_sstep_flags,bool *can_reverse);
include/qemu/accel.h +2 -0
@@ -73,6 +73,8 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **errp);*/ void accel_cpu_common_unrealize (CPUState *cpu); +bool accel_supports_guest_debug (void ); +/** * accel_get_gdbstub_config: * @supported_sstep_flags: pointer to store the single step modes in
include/system/hvf_int.h +1 -1
@@ -107,7 +107,7 @@ int hvf_update_guest_debug(CPUState *cpu);/* * Return whether the guest supports debugging. */ -bool hvf_arch_supports_guest_debug (void ); +bool hvf_arch_supports_guest_debug (AccelState *as);bool hvf_arch_cpu_realize (CPUState *cpu,Error **errp);uint32_t hvf_arch_get_default_ipa_bit_size (void );
include/system/whpx-all.h +1 -3
@@ -9,6 +9,7 @@ int whpx_vcpu_run(CPUState *cpu);void whpx_get_registers (CPUState *cpu,WHPXStateLevel level);void whpx_set_registers (CPUState *cpu,WHPXStateLevel level);int whpx_accel_init (AccelState *as,MachineState *ms); +bool whpx_arch_supports_guest_debug (AccelState *as);void whpx_cpu_instance_init (CPUState *cs);HRESULT whpx_set_exception_exit_bitmap (UINT64 exceptions); void whpx_apply_breakpoints(
@@ -22,7 +23,4 @@ void whpx_translate_cpu_breakpoints(void whpx_arch_destroy_vcpu (CPUState *cpu);void whpx_arch_accel_class_init (ObjectClass *oc); -/* called by whpx-accel-ops */ -bool whpx_arch_supports_guest_debug (void ); -#endif
accel/accel-common.c +12 -0
@@ -113,6 +113,18 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } +bool accel_supports_guest_debug (void ) +{ +AccelState *accel =current_accel (); +AccelClass *acc =ACCEL_GET_CLASS (accel); + +if (acc->supports_guest_debug) { +return acc->supports_guest_debug (accel); + } +return false; +} + +void accel_get_gdbstub_config (int *supported_sstep_flags,bool *can_reverse) {AccelState *accel =current_accel ();
accel/hvf/hvf-accel-ops.c +0 -1
@@ -369,7 +369,6 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, const void *data) ops->remove_breakpoint = hvf_remove_breakpoint; ops->remove_all_breakpoints = hvf_remove_all_breakpoints; ops->update_guest_debug = hvf_update_guest_debug; - ops->supports_guest_debug = hvf_arch_supports_guest_debug; ops->get_vcpu_stats = hvf_get_vcpu_stats; };
accel/hvf/hvf-all.c +1 -0
@@ -280,6 +280,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const void *data) ac->name ="HVF" ; ac->init_machine = hvf_accel_init; ac->allowed = &hvf_allowed; + ac->supports_guest_debug = hvf_arch_supports_guest_debug; ac->get_gdbstub_config = hvf_gdbstub_config; hvf_kernel_irqchip_override = false; hvf_kernel_irqchip = false;
accel/kvm/kvm-accel-ops.c +0 -1
@@ -105,7 +105,6 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data) ops->synchronize_pre_loadvm = kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt = generic_handle_interrupt; - ops->supports_guest_debug = kvm_supports_guest_debug;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug = kvm_update_guest_debug_ops; ops->insert_breakpoint = kvm_insert_breakpoint;
accel/kvm/kvm-all.c +2 -1
@@ -3833,7 +3833,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)return data.err; } -bool kvm_supports_guest_debug (void ) +static bool kvm_supports_guest_debug (AccelState *as) {/* probed during kvm_init() */ return kvm_has_guest_debug;
@@ -4303,6 +4303,7 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data) ac->rebuild_guest = kvm_reset_vmfd; ac->has_memory = kvm_accel_has_memory; ac->allowed = &kvm_allowed; + ac->supports_guest_debug = kvm_supports_guest_debug; ac->get_gdbstub_config = kvm_gdbstub_config; object_class_property_add(oc, "kernel-irqchip", "on|off|split",
accel/tcg/tcg-accel-ops.c +0 -6
@@ -109,11 +109,6 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } } -static bool tcg_supports_guest_debug (void ) -{ -return true; -} -/* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ static inline int xlat_gdb_type (CPUState *cpu,int gdbtype) {
@@ -221,7 +216,6 @@ static void tcg_accel_ops_init(AccelClass *ac) } ops->cpu_reset_hold = tcg_cpu_reset_hold; - ops->supports_guest_debug = tcg_supports_guest_debug; ops->insert_breakpoint = tcg_insert_breakpoint; ops->remove_breakpoint = tcg_remove_breakpoint; ops->remove_all_breakpoints = tcg_remove_all_breakpoints;
accel/tcg/tcg-all.c +6 -0
@@ -242,6 +242,11 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp)qatomic_set (&one_insn_per_tb, value); } +static bool tcg_supports_guest_debug (AccelState *as) +{ +return true; +} +static void tcg_gdbstub_config (AccelState *as,int *supported_sstep_flags,bool *can_reverse) {
@@ -268,6 +273,7 @@ static void tcg_accel_class_init(ObjectClass *oc, const void *data) ac->cpu_common_unrealize = tcg_exec_unrealizefn; ac->get_stats = tcg_get_stats; ac->allowed = &tcg_allowed; + ac->supports_guest_debug = tcg_supports_guest_debug; ac->get_gdbstub_config = tcg_gdbstub_config; object_class_property_add_str(oc, "thread",
accel/whpx/whpx-accel-ops.c +0 -7
@@ -82,12 +82,6 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu)return !whpx_irqchip_in_kernel (); } -static bool whpx_supports_guest_debug (void ) -{ -return whpx_arch_supports_guest_debug (); -} - -static void whpx_accel_ops_class_init (ObjectClass *oc,const void *data) {AccelOpsClass *ops =ACCEL_OPS_CLASS (oc);
@@ -96,7 +90,6 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data) ops->kick_vcpu_thread = whpx_kick_vcpu_thread; ops->cpu_thread_is_idle = whpx_vcpu_thread_is_idle; ops->handle_interrupt = generic_handle_interrupt; - ops->supports_guest_debug = whpx_supports_guest_debug; ops->synchronize_post_reset = whpx_cpu_synchronize_post_reset; ops->synchronize_post_init = whpx_cpu_synchronize_post_init;
accel/whpx/whpx-common.c +1 -0
@@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, const void *data) ac->init_machine = whpx_accel_init; ac->pre_resume_vm = whpx_pre_resume_vm; ac->allowed = &whpx_allowed; + ac->supports_guest_debug = whpx_arch_supports_guest_debug; object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip,
gdbstub/system.c +2 -10
@@ -13,6 +13,7 @@#include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/error-report.h" +#include "qemu/accel.h" #include "qemu/cutils.h" #include "exec/gdbstub.h" #include "gdbstub/syscalls.h"
@@ -343,7 +344,7 @@ bool gdbserver_start(const char *device, Error **errp)return false; } -if (!gdb_supports_guest_debug ()) { +if (!accel_supports_guest_debug ()) {error_setg (errp,"gdbstub: current accelerator doesn't " "support guest debugging" );return false;
@@ -622,15 +623,6 @@ int gdb_signal_to_target(int sig)* Break/Watch point helpers */ -bool gdb_supports_guest_debug (void ) -{ -const AccelOpsClass *ops =cpus_get_accel (); -if (ops->supports_guest_debug) { -return ops->supports_guest_debug (); - } -return false; -} -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) {const AccelOpsClass *ops =cpus_get_accel ();
gdbstub/user.c +0 -6
@@ -790,12 +790,6 @@ unsigned int gdb_get_max_cpus(void)* Break/Watch point helpers */ -bool gdb_supports_guest_debug (void ) -{ -/* user-mode == TCG == supported */ -return true; -} -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) {CPUState *cpu;
target/arm/hvf/hvf.c +1 -1
@@ -2901,7 +2901,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu)hvf_arch_set_traps (cpu); } -bool hvf_arch_supports_guest_debug (void ) +bool hvf_arch_supports_guest_debug (AccelState *as) {return true; }
target/arm/whpx/whpx-all.c +1 -1
@@ -295,7 +295,7 @@ void whpx_translate_cpu_breakpoints(/* Breakpoints aren’t supported on this platform */ } -bool whpx_arch_supports_guest_debug (void ) +bool whpx_arch_supports_guest_debug (AccelState *as) {return false; }
target/i386/hvf/hvf.c +1 -1
@@ -1067,7 +1067,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) { } -bool hvf_arch_supports_guest_debug (void ) +bool hvf_arch_supports_guest_debug (AccelState *as) {return false; }
target/i386/whpx/whpx-all.c +1 -1
@@ -1853,7 +1853,7 @@ void whpx_apply_breakpoints( } } -bool whpx_arch_supports_guest_debug (void ) +bool whpx_arch_supports_guest_debug (AccelState *as) {return true; }
Signature · 1 line
2.53.0
Re: [PATCH 14/33] accel: Move supports_guest_debug() declaration to AccelClass
Quoted 8 lines · Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé<[email protected]>
AccelOpsClass is for methods dealing with vCPUs. When only dealing with AccelState, AccelClass is sufficient.
In order to have AccelClass methods instrospect their state, we need to pass AccelState by argument.
Quoted 8 lines
Restrict
kvm_supports_guest_debug()scope.Signed-off-by Philippe Mathieu-Daudé<[email protected]>Reviewed-by Richard Henderson<[email protected]>Reviewed-by Xiaoyao Li<[email protected]>Reviewed-by Zhao Liu<[email protected]>Signed-off-by Philippe Mathieu-Daudé<[email protected]>---
Ideally there wouldn't be two different accel callbacks to init gdbserver state. But this is a small step in the right direction.
r~
PATCH 15/33 accel/kvm: Hold have_guest_supported in KVMState
In reply to Philippe Mathieu-DaudéPrefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
--- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)
include/system/kvm_int.h +1 -0
@@ -113,6 +113,7 @@ struct KVMStatestruct kvm_coalesced_mmio_ring *coalesced_mmio_ring;bool coalesced_flush_in_progress;int vcpu_events; +bool have_guest_supported;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif
accel/kvm/kvm-all.c +4 -4
@@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed;bool kvm_vm_attributes_allowed;bool kvm_msi_use_devid;bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug;static int kvm_sstep_flags;static bool kvm_immediate_exit;static uint64_t kvm_supported_memory_attributes;
@@ -3040,10 +3039,10 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_sstep_flags =0 ;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug = + s->have_guest_supported = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 ); -if (kvm_has_guest_debug) { +if (s->have_guest_supported) { kvm_sstep_flags =SSTEP_ENABLE ; int guest_debug_flags =
@@ -3835,8 +3834,9 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)static bool kvm_supports_guest_debug (AccelState *as) { +KVMState *s =KVM_STATE (as);/* probed during kvm_init() */ -return kvm_has_guest_debug; +return s->have_guest_supported; }int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len)
Signature · 1 line
2.53.0
Re: [PATCH 15/33] accel/kvm: Hold have_guest_supported in KVMState
Quoted 6 lines · Philippe Mathieu-Daudé
Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 52 lines
include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)include/system/kvm_int.h +1
-0@@ -113,6 +113,7 @@ struct KVMStatestruct kvm_coalesced_mmio_ring *coalesced_mmio_ring;bool coalesced_flush_in_progress;int vcpu_events; +bool have_guest_supported;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif accel/kvm/kvm-all.c +4
-4@@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed;bool kvm_vm_attributes_allowed;bool kvm_msi_use_devid;bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug;static int kvm_sstep_flags;static bool kvm_immediate_exit;static uint64_t kvm_supported_memory_attributes;@@ -3040,10 +3039,10 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_sstep_flags =0 ;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug = + s->have_guest_supported = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 ); -if (kvm_has_guest_debug) { +if (s->have_guest_supported) { kvm_sstep_flags =SSTEP_ENABLE ; int guest_debug_flags =@@ -3835,8 +3834,9 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)static bool kvm_supports_guest_debug (AccelState *as) { +KVMState *s =KVM_STATE (as);/* probed during kvm_init() */ -return kvm_has_guest_debug; +return s->have_guest_supported; }int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len)
Re: [PATCH 15/33] accel/kvm: Hold have_guest_supported in KVMState
In reply to Philippe Mathieu-DaudéQuoted 9 lines · Philippe Mathieu-Daudé
Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)
This doesn't really preclude concurrent accelerators, since there will only ever be one KVMState instance. But it's also not unreasonable.
That said,
include/system/kvm_int.h struct KVMState · line 119
Quoted 12 lines
include/system/kvm_int.h +1
-0@@ -113,6 +113,7 @@ struct KVMStatestruct kvm_coalesced_mmio_ring *coalesced_mmio_ring;bool coalesced_flush_in_progress;int vcpu_events; +bool have_guest_supported;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif
you could sort the members by size to avoid extra structure holes. There's a lot of them already due to existing poor ordering.
Anyway,
r~
PATCH 16/33 accel/kvm: Hold gdbstub_sstep_flags in KVMState
In reply to Philippe Mathieu-DaudéPrefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
--- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-)
include/system/kvm_int.h +1 -0
@@ -114,6 +114,7 @@ struct KVMStatebool coalesced_flush_in_progress;int vcpu_events;bool have_guest_supported; +int gdbstub_sstep_flags;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif
accel/kvm/kvm-all.c +3 -4
@@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed;bool kvm_vm_attributes_allowed;bool kvm_msi_use_devid;bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags;static bool kvm_immediate_exit;static uint64_t kvm_supported_memory_attributes;static bool kvm_guest_memfd_supported;
@@ -3036,20 +3035,20 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_vm_attributes_allowed = (kvm_check_extension (s,KVM_CAP_VM_ATTRIBUTES ) >0 ); - kvm_sstep_flags =0 ; + s->gdbstub_sstep_flags =0 ;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG s->have_guest_supported = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 );if (s->have_guest_supported) { - kvm_sstep_flags =SSTEP_ENABLE ; + s->gdbstub_sstep_flags =SSTEP_ENABLE ;int guest_debug_flags =kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG2 );if (guest_debug_flags &KVM_GUESTDBG_BLOCKIRQ ) { - kvm_sstep_flags |=SSTEP_NOIRQ ; + s->gdbstub_sstep_flags |=SSTEP_NOIRQ ; } }#endif
Signature · 1 line
2.53.0
Re: [PATCH 16/33] accel/kvm: Hold gdbstub_sstep_flags in KVMState
Quoted 6 lines · Philippe Mathieu-Daudé
Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 52 lines
include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-)include/system/kvm_int.h +1
-0@@ -114,6 +114,7 @@ struct KVMStatebool coalesced_flush_in_progress;int vcpu_events;bool have_guest_supported; +int gdbstub_sstep_flags;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif accel/kvm/kvm-all.c +3
-4@@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed;bool kvm_vm_attributes_allowed;bool kvm_msi_use_devid;bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags;static bool kvm_immediate_exit;static uint64_t kvm_supported_memory_attributes;static bool kvm_guest_memfd_supported;@@ -3036,20 +3035,20 @@ static int kvm_init(AccelState *as, MachineState *ms) kvm_vm_attributes_allowed = (kvm_check_extension (s,KVM_CAP_VM_ATTRIBUTES ) >0 ); - kvm_sstep_flags =0 ; + s->gdbstub_sstep_flags =0 ;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG s->have_guest_supported = (kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG ) >0 );if (s->have_guest_supported) { - kvm_sstep_flags =SSTEP_ENABLE ; + s->gdbstub_sstep_flags =SSTEP_ENABLE ;int guest_debug_flags =kvm_check_extension (s,KVM_CAP_SET_GUEST_DEBUG2 );if (guest_debug_flags &KVM_GUESTDBG_BLOCKIRQ ) { - kvm_sstep_flags |=SSTEP_NOIRQ ; + s->gdbstub_sstep_flags |=SSTEP_NOIRQ ; } }#endif
Re: [PATCH 16/33] accel/kvm: Hold gdbstub_sstep_flags in KVMState
In reply to Philippe Mathieu-DaudéQuoted 15 lines · Philippe Mathieu-Daudé
Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future.
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-)include/system/kvm_int.h +0
-0
include/system/kvm_int.h struct KVMState · line 120
Quoted 7 lines
include/system/kvm_int.h +1
-0@@ -114,6 +114,7 @@ struct KVMStatebool coalesced_flush_in_progress;int vcpu_events;bool have_guest_supported; +int gdbstub_sstep_flags;#ifdef TARGET_KVM_HAVE_GUEST_DEBUG QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;#endif
Same comments as for patch 15.
r~
PATCH 17/33 cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h'
In reply to Philippe Mathieu-Daudé--- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-)
include/exec/breakpoint.h +14 -0
@@ -12,6 +12,20 @@#include "exec/vaddr.h" #include "exec/memattrs.h" +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */
include/hw/core/cpu.h +0 -14
@@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu);*/ void cpu_single_step (CPUState *cpu,int enabled); -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags,CPUBreakpoint **breakpoint);int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags);
Signature · 1 line
2.53.0
Re: [PATCH 17/33] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h'
Quoted 2 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 54 lines
include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-)include/exec/breakpoint.h +14
-0@@ -12,6 +12,20 @@#include "exec/vaddr.h" #include "exec/memattrs.h" +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */include/hw/core/cpu.h +0
-14@@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu);*/ void cpu_single_step (CPUState *cpu,int enabled); -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags,CPUBreakpoint **breakpoint);int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags);
Re: [PATCH 17/33] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h'
In reply to Philippe Mathieu-DaudéQuoted 5 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-)
r~
PATCH 18/33 cpu: Define BreakpointFlags type
In reply to Philippe Mathieu-DaudéUse the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*).
--- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 3 ++- include/exec/watchpoint.h | 8 +++++--- include/hw/core/cpu.h | 11 ++++++----- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 11 ++++++----- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 8 ++++---- system/watchpoint.c | 8 ++++---- target/arm/tcg/debug.c | 4 ++-- target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 65 insertions(+), 54 deletions(-)
include/accel/tcg/cpu-ops.h +4 -2
@@ -298,7 +298,8 @@ struct TCGCPUOps {* specified by @flags. Exit via exception with a hit. */ void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs attrs,int flags,uintptr_t ra); +MemTxAttrs attrs,BreakpointFlags flags, +uintptr_t ra);/** * cpu_watchpoint_address_matches:
@@ -309,7 +310,8 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len,* Return the watchpoint flags that apply to [addr, addr+len). * If no watchpoint is registered for the range, the result is 0. */ -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len); +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len);/* * Common pointer_wrap implementations.
include/exec/breakpoint.h +2 -1
@@ -12,6 +12,7 @@#include "exec/vaddr.h" #include "exec/memattrs.h" +typedef int BreakpointFlags ;/* Breakpoint/watchpoint flags */ #define BP_MEM_READ 0x01#define BP_MEM_WRITE 0x02
@@ -28,7 +29,7 @@typedef struct CPUBreakpoint {vaddr pc; -int flags;/* BP_* */ +BreakpointFlags flags;QTAILQ_ENTRY (CPUBreakpoint) entry; }CPUBreakpoint ;
include/exec/watchpoint.h +5 -3
@@ -8,11 +8,13 @@#ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H +#include "exec/breakpoint.h" +int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint); +BreakpointFlags flags,CPUWatchpoint **watchpoint);int cpu_watchpoint_remove (CPUState *cpu,vaddr addr, -vaddr len,int flags); +vaddr len,BreakpointFlags flags);void cpu_watchpoint_remove_by_ref (CPUState *cpu,CPUWatchpoint *watchpoint); -void cpu_watchpoint_remove_all (CPUState *cpu,int mask); +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags);#endif /* EXEC_WATCHPOINT_H */
include/hw/core/cpu.h +6 -5
@@ -1138,20 +1138,21 @@ void qemu_init_vcpu(CPUState *cpu);*/ void cpu_single_step (CPUState *cpu,int enabled); -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags, +int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,BreakpointFlags flags,CPUBreakpoint **breakpoint); -int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags); +int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,BreakpointFlags flags);void cpu_breakpoint_remove_by_ref (CPUState *cpu,CPUBreakpoint *breakpoint); -void cpu_breakpoint_remove_all (CPUState *cpu,int mask); +void cpu_breakpoint_remove_all (CPUState *cpu,BreakpointFlags flags);/* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test (CPUState *cpu,vaddr pc,int mask) +static inline bool cpu_breakpoint_test (CPUState *cpu,vaddr pc, +BreakpointFlags flags) {CPUBreakpoint *bp;if (unlikely (!QTAILQ_EMPTY (&cpu->breakpoints))) { QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { -if (bp->pc == pc && (bp->flags & mask)) { +if (bp->pc == pc && (bp->flags & flags)) {return true; } }
accel/tcg/cputlb.c +7 -5
@@ -1033,7 +1033,8 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx,CPUTLBEntry *te, tn;hwaddr iotlb, xlat, sz, paddr_page;vaddr addr_page; -int asidx, wp_flags, prot; +int asidx, prot; +BreakpointFlags wp_flags;bool is_ram, is_romd;assert_cpu_is_self (cpu);
@@ -1499,8 +1500,8 @@ void *probe_access(CPUArchState *env, vaddr addr, int size,if (unlikely (flags & (TLB_NOTDIRTY |TLB_WATCHPOINT ))) {/* Handle watchpoints. */ if (flags &TLB_WATCHPOINT ) { -int wp_access = (access_type ==MMU_DATA_STORE - ?BP_MEM_WRITE :BP_MEM_READ ); +BreakpointFlags wp_access = (access_type ==MMU_DATA_STORE + ?BP_MEM_WRITE :BP_MEM_READ );cpu_check_watchpoint (env_cpu (env), addr, size, full->attrs, wp_access, retaddr); }
@@ -1702,7 +1703,8 @@ static void mmu_watch_or_dirty(CPUState *cpu, MMULookupPageData *data,/* On watchpoint hit, this will longjmp out. */ if (flags &TLB_WATCHPOINT ) { -int wp = access_type ==MMU_DATA_STORE ?BP_MEM_WRITE :BP_MEM_READ ; +BreakpointFlags wp = access_type ==MMU_DATA_STORE ?BP_MEM_WRITE + :BP_MEM_READ ;cpu_check_watchpoint (cpu, addr, size, full->attrs, wp, ra); flags &= ~TLB_WATCHPOINT ; }
@@ -1885,7 +1887,7 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr addr, MemOpIdx oi, }if (unlikely (tlb_addr &TLB_WATCHPOINT )) { -int wp_flags =0 ; +BreakpointFlags wp_flags =0 ;if (full->slow_flags[MMU_DATA_STORE ] &TLB_WATCHPOINT ) { wp_flags |=BP_MEM_WRITE ;
accel/tcg/tcg-accel-ops.c +5 -5
@@ -110,20 +110,20 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) }/* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type (CPUState *cpu,int gdbtype) +static inline BreakpointFlags xlat_gdb_type (CPUState *cpu,int gdbtype) { -static const int xlat[] = { +static const BreakpointFlags xlat[] = { [GDB_WATCHPOINT_WRITE ] =BP_GDB |BP_MEM_WRITE , [GDB_WATCHPOINT_READ ] =BP_GDB |BP_MEM_READ , [GDB_WATCHPOINT_ACCESS ] =BP_GDB |BP_MEM_ACCESS , }; -int cputype = xlat[gdbtype]; +BreakpointFlags cpuflags = xlat[gdbtype];if (cpu->cc->gdb_stop_before_watchpoint) { - cputype |=BP_STOP_BEFORE_ACCESS ; + cpuflags |=BP_STOP_BEFORE_ACCESS ; } -return cputype; +return cpuflags; }static int tcg_insert_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len)
accel/tcg/user-exec-stub.c +6 -5
@@ -22,13 +22,13 @@ void cpu_exec_reset_hold(CPUState *cpu) }int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint) +BreakpointFlags flags,CPUWatchpoint **watchpoint) {return -ENOSYS ; }int cpu_watchpoint_remove (CPUState *cpu,vaddr addr, -vaddr len,int flags) +vaddr len,BreakpointFlags flags) {return -ENOSYS ; }
@@ -37,17 +37,18 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *wp) { } -void cpu_watchpoint_remove_all (CPUState *cpu,int mask) +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags) { } -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len) +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len) {return 0 ; }void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs atr,int fl,uintptr_t ra) +MemTxAttrs atr,BreakpointFlags flags,uintptr_t ra) { }
accel/tcg/watchpoint.c +5 -4
@@ -52,10 +52,11 @@ static inline bool watchpoint_address_matches(CPUWatchpoint *wp, }/* Return flags for watchpoints that match addr + prot. */ -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len) +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len) {CPUWatchpoint *wp; -int ret =0 ; +BreakpointFlags ret =0 ; QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {if (watchpoint_address_matches (wp, addr, len)) {
@@ -67,7 +68,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len)/* Generate a debug exception if a watchpoint has been hit. */ void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs attrs,int flags,uintptr_t ra) +MemTxAttrs attrs,BreakpointFlags flags,uintptr_t ra) {CPUWatchpoint *wp;
@@ -91,7 +92,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len,assert ((flags & ~BP_MEM_ACCESS ) ==0 ); QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { -int hit_flags = wp->flags & flags; +BreakpointFlags hit_flags = wp->flags & flags;if (hit_flags &&watchpoint_address_matches (wp, addr, len)) {if (replay_running_debug ()) {
cpu-common.c +4 -4
@@ -389,7 +389,7 @@ void process_queued_cpu_work(CPUState *cpu) }/* Add a breakpoint. */ -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags, +int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,BreakpointFlags flags,CPUBreakpoint **breakpoint) {CPUBreakpoint *bp;
@@ -419,7 +419,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, }/* Remove a specific breakpoint. */ -int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags) +int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,BreakpointFlags flags) {CPUBreakpoint *bp;
@@ -446,12 +446,12 @@ void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *bp) }/* Remove all matching breakpoints. */ -void cpu_breakpoint_remove_all (CPUState *cpu,int mask) +void cpu_breakpoint_remove_all (CPUState *cpu,BreakpointFlags flags) {CPUBreakpoint *bp, *next; QTAILQ_FOREACH_SAFE(bp, &cpu->breakpoints, entry, next) { -if (bp->flags & mask) { +if (bp->flags & flags) {cpu_breakpoint_remove_by_ref (cpu, bp); } }
system/watchpoint.c +4 -4
@@ -26,7 +26,7 @@/* Add a watchpoint. */ int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint) +BreakpointFlags flags,CPUWatchpoint **watchpoint) {CPUWatchpoint *wp;vaddr in_page;
@@ -65,7 +65,7 @@ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len,/* Remove a specific watchpoint. */ int cpu_watchpoint_remove (CPUState *cpu,vaddr addr,vaddr len, -int flags) +BreakpointFlags flags) {CPUWatchpoint *wp;
@@ -90,12 +90,12 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *watchpoint) }/* Remove all matching watchpoints. */ -void cpu_watchpoint_remove_all (CPUState *cpu,int mask) +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags) {CPUWatchpoint *wp, *next; QTAILQ_FOREACH_SAFE(wp, &cpu->watchpoints, entry, next) { -if (wp->flags & mask) { +if (wp->flags & flags) {cpu_watchpoint_remove_by_ref (cpu, wp); } }
target/arm/tcg/debug.c +2 -2
@@ -550,7 +550,7 @@ void hw_watchpoint_update(ARMCPU *cpu, int n)vaddr wvr = env->cp15.dbgwvr[n];uint64_t wcr = env->cp15.dbgwcr[n];int mask; -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;if (env->cpu_watchpoint[n]) {cpu_watchpoint_remove_by_ref (CPU (cpu), env->cpu_watchpoint[n]);
@@ -656,7 +656,7 @@ void hw_breakpoint_update(ARMCPU *cpu, int n)uint64_t bcr = env->cp15.dbgbcr[n];vaddr addr;int bt; -int flags =BP_CPU ; +BreakpointFlags flags =BP_CPU ;if (env->cpu_breakpoint[n]) {cpu_breakpoint_remove_by_ref (CPU (cpu), env->cpu_breakpoint[n]);
target/arm/tcg/mte_helper.c +2 -1
@@ -190,7 +190,8 @@ uint8_t *allocation_tag_mem_probe(CPUARMState *env, int ptr_mmu_idx,/* Any debug exception has priority over a tag check exception. */ if (!probe &&unlikely (flags &TLB_WATCHPOINT )) { -int wp = ptr_access ==MMU_DATA_LOAD ?BP_MEM_READ :BP_MEM_WRITE ; +BreakpointFlags wp = ptr_access ==MMU_DATA_LOAD ?BP_MEM_READ + :BP_MEM_WRITE ;assert (ra !=0 );cpu_check_watchpoint (env_cpu (env), ptr, ptr_size, attrs, wp, ra); }
target/ppc/cpu.c +1 -1
@@ -145,7 +145,7 @@ void ppc_update_daw(CPUPPCState *env, int rid)bool sv =extract32 (dawrx,PPC_BIT_NR (62 ),1 );bool pr =extract32 (dawrx,PPC_BIT_NR (62 ),1 );vaddr len; -int flags; +BreakpointFlags flags;if (env->dawr_watchpoint[rid]) {cpu_watchpoint_remove_by_ref (cs, env->dawr_watchpoint[rid]);
target/ppc/kvm.c +3 -2
@@ -1429,7 +1429,7 @@ static int find_hw_breakpoint(target_ulong addr, int type)return -1 ; } -static int find_hw_watchpoint (target_ulong addr,int *flag) +static int find_hw_watchpoint (target_ulong addr,BreakpointFlags *flag) {int n;
@@ -1575,7 +1575,6 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, {int handle =DEBUG_RETURN_GUEST ;int n; -int flag =0 ;if (nb_hw_breakpoint + nb_hw_watchpoint >0 ) {if (arch_info->status &KVMPPC_DEBUG_BREAKPOINT ) {
@@ -1585,6 +1584,8 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, } }else if (arch_info->status & (KVMPPC_DEBUG_WATCH_READ |KVMPPC_DEBUG_WATCH_WRITE )) { +BreakpointFlags flag =0 ; + n =find_hw_watchpoint (arch_info->address, &flag);if (n >=0 ) { handle =DEBUG_RETURN_GDB ;
target/riscv/cpu_helper.c +1 -1
@@ -1992,7 +1992,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, }else if (probe) {return false; }else { -int wp_access =0 ; +BreakpointFlags wp_access =0 ;if (access_type ==MMU_DATA_LOAD ) { wp_access |=BP_MEM_READ ;
target/riscv/debug.c +5 -7
@@ -479,7 +479,7 @@ static void type2_breakpoint_insert(CPURISCVState *env, target_ulong index)target_ulong addr = env->tdata2[index];bool enabled =type2_breakpoint_enabled (ctrl);CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t size, def_size;if (!enabled) {
@@ -604,7 +604,7 @@ static void type6_breakpoint_insert(CPURISCVState *env, target_ulong index)target_ulong addr = env->tdata2[index];bool enabled =type6_breakpoint_enabled (ctrl);CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t size;if (!enabled) {
@@ -992,12 +992,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)CPURISCVState *env = &cpu->env;target_ulong ctrl;target_ulong addr; -int trigger_type; -int flags; -int i; -for (i =0 ; i <RV_MAX_TRIGGERS ; i++) { - trigger_type =get_trigger_type (env, i); +for (int i =0 ; i <RV_MAX_TRIGGERS ; i++) { +int trigger_type =get_trigger_type (env, i); +BreakpointFlags flags;if (!trigger_common_match (env, trigger_type, i)) {continue ;
target/s390x/tcg/debug.c +2 -1
@@ -14,7 +14,8 @@void s390_cpu_recompute_watchpoints (CPUState *cs) { -const int wp_flags =BP_CPU |BP_MEM_WRITE |BP_STOP_BEFORE_ACCESS ; +const BreakpointFlags wp_flags =BP_CPU |BP_MEM_WRITE + |BP_STOP_BEFORE_ACCESS ;CPUS390XState *env =cpu_env (cs);/* We are called when the watchpoints have changed. First
target/xtensa/dbg_helper.c +1 -1
@@ -85,7 +85,7 @@ static void set_dbreak(CPUXtensaState *env, unsigned i, uint32_t dbreaka, uint32_t dbreakc) {CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t mask = dbreakc | ~DBREAKC_MASK ;if (env->cpu_watchpoint[i]) {
Signature · 1 line
2.53.0
Re: [PATCH 18/33] cpu: Define BreakpointFlags type
Hello fine sir,
This patch fails to apply to master due to a riscv conflict down there:
Quoted 465 lines · Philippe Mathieu-Daudé
Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*).
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 3 ++- include/exec/watchpoint.h | 8 +++++--- include/hw/core/cpu.h | 11 ++++++----- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 11 ++++++----- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 8 ++++---- system/watchpoint.c | 8 ++++---- target/arm/tcg/debug.c | 4 ++-- target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 65 insertions(+), 54 deletions(-)include/accel/tcg/cpu-ops.h +4
-2@@ -298,7 +298,8 @@ struct TCGCPUOps {* specified by @flags. Exit via exception with a hit. */ void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs attrs,int flags,uintptr_t ra); +MemTxAttrs attrs,BreakpointFlags flags, +uintptr_t ra);/** * cpu_watchpoint_address_matches: @@ -309,7 +310,8 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len,* Return the watchpoint flags that apply to [addr, addr+len). * If no watchpoint is registered for the range, the result is 0. */ -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len); +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len);/* * Common pointer_wrap implementations. include/exec/breakpoint.h +2
-1@@ -12,6 +12,7 @@#include "exec/vaddr.h" #include "exec/memattrs.h" +typedef int BreakpointFlags ;/* Breakpoint/watchpoint flags */ #define BP_MEM_READ 0x01#define BP_MEM_WRITE 0x02@@ -28,7 +29,7 @@typedef struct CPUBreakpoint {vaddr pc; -int flags;/* BP_* */ +BreakpointFlags flags;QTAILQ_ENTRY (CPUBreakpoint) entry; }CPUBreakpoint ;include/exec/watchpoint.h +5
-3@@ -8,11 +8,13 @@#ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H +#include "exec/breakpoint.h" +int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint); +BreakpointFlags flags,CPUWatchpoint **watchpoint);int cpu_watchpoint_remove (CPUState *cpu,vaddr addr, -vaddr len,int flags); +vaddr len,BreakpointFlags flags);void cpu_watchpoint_remove_by_ref (CPUState *cpu,CPUWatchpoint *watchpoint); -void cpu_watchpoint_remove_all (CPUState *cpu,int mask); +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags);#endif /* EXEC_WATCHPOINT_H */ include/hw/core/cpu.h +6
-5@@ -1138,20 +1138,21 @@ void qemu_init_vcpu(CPUState *cpu);*/ void cpu_single_step (CPUState *cpu,int enabled); -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags, +int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,BreakpointFlags flags,CPUBreakpoint **breakpoint); -int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags); +int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,BreakpointFlags flags);void cpu_breakpoint_remove_by_ref (CPUState *cpu,CPUBreakpoint *breakpoint); -void cpu_breakpoint_remove_all (CPUState *cpu,int mask); +void cpu_breakpoint_remove_all (CPUState *cpu,BreakpointFlags flags);/* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test (CPUState *cpu,vaddr pc,int mask) +static inline bool cpu_breakpoint_test (CPUState *cpu,vaddr pc, +BreakpointFlags flags) {CPUBreakpoint *bp;if (unlikely (!QTAILQ_EMPTY (&cpu->breakpoints))) { QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { -if (bp->pc == pc && (bp->flags & mask)) { +if (bp->pc == pc && (bp->flags & flags)) {return true; } }accel/tcg/cputlb.c +7
-5@@ -1033,7 +1033,8 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx,CPUTLBEntry *te, tn;hwaddr iotlb, xlat, sz, paddr_page;vaddr addr_page; -int asidx, wp_flags, prot; +int asidx, prot; +BreakpointFlags wp_flags;bool is_ram, is_romd;assert_cpu_is_self (cpu);@@ -1499,8 +1500,8 @@ void *probe_access(CPUArchState *env, vaddr addr, int size,if (unlikely (flags & (TLB_NOTDIRTY |TLB_WATCHPOINT ))) {/* Handle watchpoints. */ if (flags &TLB_WATCHPOINT ) { -int wp_access = (access_type ==MMU_DATA_STORE - ?BP_MEM_WRITE :BP_MEM_READ ); +BreakpointFlags wp_access = (access_type ==MMU_DATA_STORE + ?BP_MEM_WRITE :BP_MEM_READ );cpu_check_watchpoint (env_cpu (env), addr, size, full->attrs, wp_access, retaddr); }@@ -1702,7 +1703,8 @@ static void mmu_watch_or_dirty(CPUState *cpu, MMULookupPageData *data,/* On watchpoint hit, this will longjmp out. */ if (flags &TLB_WATCHPOINT ) { -int wp = access_type ==MMU_DATA_STORE ?BP_MEM_WRITE :BP_MEM_READ ; +BreakpointFlags wp = access_type ==MMU_DATA_STORE ?BP_MEM_WRITE + :BP_MEM_READ ;cpu_check_watchpoint (cpu, addr, size, full->attrs, wp, ra); flags &= ~TLB_WATCHPOINT ; }@@ -1885,7 +1887,7 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr addr, MemOpIdx oi, }if (unlikely (tlb_addr &TLB_WATCHPOINT )) { -int wp_flags =0 ; +BreakpointFlags wp_flags =0 ;if (full->slow_flags[MMU_DATA_STORE ] &TLB_WATCHPOINT ) { wp_flags |=BP_MEM_WRITE ;accel/tcg/tcg-accel-ops.c +5
-5@@ -110,20 +110,20 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) }/* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type (CPUState *cpu,int gdbtype) +static inline BreakpointFlags xlat_gdb_type (CPUState *cpu,int gdbtype) { -static const int xlat[] = { +static const BreakpointFlags xlat[] = { [GDB_WATCHPOINT_WRITE ] =BP_GDB |BP_MEM_WRITE , [GDB_WATCHPOINT_READ ] =BP_GDB |BP_MEM_READ , [GDB_WATCHPOINT_ACCESS ] =BP_GDB |BP_MEM_ACCESS , }; -int cputype = xlat[gdbtype]; +BreakpointFlags cpuflags = xlat[gdbtype];if (cpu->cc->gdb_stop_before_watchpoint) { - cputype |=BP_STOP_BEFORE_ACCESS ; + cpuflags |=BP_STOP_BEFORE_ACCESS ; } -return cputype; +return cpuflags; }static int tcg_insert_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len)accel/tcg/user-exec-stub.c +6
-5@@ -22,13 +22,13 @@ void cpu_exec_reset_hold(CPUState *cpu) }int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint) +BreakpointFlags flags,CPUWatchpoint **watchpoint) {return -ENOSYS ; }int cpu_watchpoint_remove (CPUState *cpu,vaddr addr, -vaddr len,int flags) +vaddr len,BreakpointFlags flags) {return -ENOSYS ; }@@ -37,17 +37,18 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *wp) { } -void cpu_watchpoint_remove_all (CPUState *cpu,int mask) +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags) { } -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len) +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len) {return 0 ; }void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs atr,int fl,uintptr_t ra) +MemTxAttrs atr,BreakpointFlags flags,uintptr_t ra) { }accel/tcg/watchpoint.c +5
-4@@ -52,10 +52,11 @@ static inline bool watchpoint_address_matches(CPUWatchpoint *wp, }/* Return flags for watchpoints that match addr + prot. */ -int cpu_watchpoint_address_matches (CPUState *cpu,vaddr addr,vaddr len) +BreakpointFlags cpu_watchpoint_address_matches (CPUState *cpu, +vaddr addr,vaddr len) {CPUWatchpoint *wp; -int ret =0 ; +BreakpointFlags ret =0 ; QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {if (watchpoint_address_matches (wp, addr, len)) {@@ -67,7 +68,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len)/* Generate a debug exception if a watchpoint has been hit. */ void cpu_check_watchpoint (CPUState *cpu,vaddr addr,vaddr len, -MemTxAttrs attrs,int flags,uintptr_t ra) +MemTxAttrs attrs,BreakpointFlags flags,uintptr_t ra) {CPUWatchpoint *wp;@@ -91,7 +92,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len,assert ((flags & ~BP_MEM_ACCESS ) ==0 ); QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { -int hit_flags = wp->flags & flags; +BreakpointFlags hit_flags = wp->flags & flags;if (hit_flags &&watchpoint_address_matches (wp, addr, len)) {if (replay_running_debug ()) {cpu-common.c +4
-4@@ -389,7 +389,7 @@ void process_queued_cpu_work(CPUState *cpu) }/* Add a breakpoint. */ -int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,int flags, +int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,BreakpointFlags flags,CPUBreakpoint **breakpoint) {CPUBreakpoint *bp;@@ -419,7 +419,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, }/* Remove a specific breakpoint. */ -int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,int flags) +int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,BreakpointFlags flags) {CPUBreakpoint *bp;@@ -446,12 +446,12 @@ void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *bp) }/* Remove all matching breakpoints. */ -void cpu_breakpoint_remove_all (CPUState *cpu,int mask) +void cpu_breakpoint_remove_all (CPUState *cpu,BreakpointFlags flags) {CPUBreakpoint *bp, *next; QTAILQ_FOREACH_SAFE(bp, &cpu->breakpoints, entry, next) { -if (bp->flags & mask) { +if (bp->flags & flags) {cpu_breakpoint_remove_by_ref (cpu, bp); } }system/watchpoint.c +4
-4@@ -26,7 +26,7 @@/* Add a watchpoint. */ int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len, -int flags,CPUWatchpoint **watchpoint) +BreakpointFlags flags,CPUWatchpoint **watchpoint) {CPUWatchpoint *wp;vaddr in_page;@@ -65,7 +65,7 @@ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len,/* Remove a specific watchpoint. */ int cpu_watchpoint_remove (CPUState *cpu,vaddr addr,vaddr len, -int flags) +BreakpointFlags flags) {CPUWatchpoint *wp;@@ -90,12 +90,12 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *watchpoint) }/* Remove all matching watchpoints. */ -void cpu_watchpoint_remove_all (CPUState *cpu,int mask) +void cpu_watchpoint_remove_all (CPUState *cpu,BreakpointFlags flags) {CPUWatchpoint *wp, *next; QTAILQ_FOREACH_SAFE(wp, &cpu->watchpoints, entry, next) { -if (wp->flags & mask) { +if (wp->flags & flags) {cpu_watchpoint_remove_by_ref (cpu, wp); } }target/arm/tcg/debug.c +2
-2@@ -550,7 +550,7 @@ void hw_watchpoint_update(ARMCPU *cpu, int n)vaddr wvr = env->cp15.dbgwvr[n];uint64_t wcr = env->cp15.dbgwcr[n];int mask; -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;if (env->cpu_watchpoint[n]) {cpu_watchpoint_remove_by_ref (CPU (cpu), env->cpu_watchpoint[n]);@@ -656,7 +656,7 @@ void hw_breakpoint_update(ARMCPU *cpu, int n)uint64_t bcr = env->cp15.dbgbcr[n];vaddr addr;int bt; -int flags =BP_CPU ; +BreakpointFlags flags =BP_CPU ;if (env->cpu_breakpoint[n]) {cpu_breakpoint_remove_by_ref (CPU (cpu), env->cpu_breakpoint[n]);target/arm/tcg/mte_helper.c +2
-1@@ -190,7 +190,8 @@ uint8_t *allocation_tag_mem_probe(CPUARMState *env, int ptr_mmu_idx,/* Any debug exception has priority over a tag check exception. */ if (!probe &&unlikely (flags &TLB_WATCHPOINT )) { -int wp = ptr_access ==MMU_DATA_LOAD ?BP_MEM_READ :BP_MEM_WRITE ; +BreakpointFlags wp = ptr_access ==MMU_DATA_LOAD ?BP_MEM_READ + :BP_MEM_WRITE ;assert (ra !=0 );cpu_check_watchpoint (env_cpu (env), ptr, ptr_size, attrs, wp, ra); }target/ppc/cpu.c +1
-1@@ -145,7 +145,7 @@ void ppc_update_daw(CPUPPCState *env, int rid)bool sv =extract32 (dawrx,PPC_BIT_NR (62 ),1 );bool pr =extract32 (dawrx,PPC_BIT_NR (62 ),1 );vaddr len; -int flags; +BreakpointFlags flags;if (env->dawr_watchpoint[rid]) {cpu_watchpoint_remove_by_ref (cs, env->dawr_watchpoint[rid]);target/ppc/kvm.c +3
-2@@ -1429,7 +1429,7 @@ static int find_hw_breakpoint(target_ulong addr, int type)return -1 ; } -static int find_hw_watchpoint (target_ulong addr,int *flag) +static int find_hw_watchpoint (target_ulong addr,BreakpointFlags *flag) {int n;@@ -1575,7 +1575,6 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, {int handle =DEBUG_RETURN_GUEST ;int n; -int flag =0 ;if (nb_hw_breakpoint + nb_hw_watchpoint >0 ) {if (arch_info->status &KVMPPC_DEBUG_BREAKPOINT ) {@@ -1585,6 +1584,8 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, } }else if (arch_info->status & (KVMPPC_DEBUG_WATCH_READ |KVMPPC_DEBUG_WATCH_WRITE )) { +BreakpointFlags flag =0 ; + n =find_hw_watchpoint (arch_info->address, &flag);if (n >=0 ) { handle =DEBUG_RETURN_GDB ;target/riscv/cpu_helper.c +1
-1@@ -1992,7 +1992,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, }else if (probe) {return false; }else { -int wp_access =0 ; +BreakpointFlags wp_access =0 ;if (access_type ==MMU_DATA_LOAD ) { wp_access |=BP_MEM_READ ;target/riscv/debug.c +2
-2@@ -479,7 +479,7 @@ static void type2_breakpoint_insert(CPURISCVState *env, target_ulong index)target_ulong addr = env->tdata2[index];bool enabled =type2_breakpoint_enabled (ctrl);CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t size, def_size;if (!enabled) {@@ -604,7 +604,7 @@ static void type6_breakpoint_insert(CPURISCVState *env, target_ulong index)target_ulong addr = env->tdata2[index];bool enabled =type6_breakpoint_enabled (ctrl);CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t size;if (!enabled) {@@ -992,12 +992,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)CPURISCVState *env = &cpu->env;target_ulong ctrl;
target/riscv/debug.c bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp) · line 998
Quoted 10 lines
target/riscv/debug.c +3
-5target_ulong addr; -int trigger_type; -int flags; -int i; -for (i =0 ; i <RV_MAX_TRIGGERS ; i++) { - trigger_type =get_trigger_type (env, i); +for (int i =0 ; i <RV_MAX_TRIGGERS ; i++) { +int trigger_type =get_trigger_type (env, i); +BreakpointFlags flags;
Here ^ the reason is we're not using RV_MAX_TRIGGERS anymore but env->num_triggers.
Patch LGTM otherwise. For the RISC-V bits:
Quoted 30 lines
target/riscv/debug.c +0
-0if (!trigger_common_match (env, trigger_type, i)) {continue ;target/s390x/tcg/debug.c +2
-1@@ -14,7 +14,8 @@void s390_cpu_recompute_watchpoints (CPUState *cs) { -const int wp_flags =BP_CPU |BP_MEM_WRITE |BP_STOP_BEFORE_ACCESS ; +const BreakpointFlags wp_flags =BP_CPU |BP_MEM_WRITE + |BP_STOP_BEFORE_ACCESS ;CPUS390XState *env =cpu_env (cs);/* We are called when the watchpoints have changed. First target/xtensa/dbg_helper.c +1
-1@@ -85,7 +85,7 @@ static void set_dbreak(CPUXtensaState *env, unsigned i, uint32_t dbreaka, uint32_t dbreakc) {CPUState *cs =env_cpu (env); -int flags =BP_CPU |BP_STOP_BEFORE_ACCESS ; +BreakpointFlags flags =BP_CPU |BP_STOP_BEFORE_ACCESS ;uint32_t mask = dbreakc | ~DBREAKC_MASK ;if (env->cpu_watchpoint[i]) {
Re: [PATCH 18/33] cpu: Define BreakpointFlags type
Quoted 31 lines · Daniel Henrique Barboza
Hello fine sir,
This patch fails to apply to master due to a riscv conflict down there:
Quoted 24 lines · Philippe Mathieu-Daudé
Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*).
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
include/accel/tcg/cpu-ops.h| 6 ++++--
include/exec/breakpoint.h | 3 ++-
include/exec/watchpoint.h | 8 +++++---
include/hw/core/cpu.h | 11 ++++++-----
accel/tcg/cputlb.c | 12 +++++++-----
accel/tcg/tcg-accel-ops.c | 10 +++++-----
accel/tcg/user-exec-stub.c | 11 ++++++-----
accel/tcg/watchpoint.c | 9 +++++----
cpu-common.c | 8 ++++----
system/watchpoint.c | 8 ++++----
target/arm/tcg/debug.c | 4 ++--
target/arm/tcg/mte_helper.c| 3 ++-
target/ppc/cpu.c | 2 +-
target/ppc/kvm.c | 5 +++--
target/riscv/cpu_helper.c | 2 +-
target/riscv/debug.c | 12 +++++-------
target/s390x/tcg/debug.c | 3 ++-
target/xtensa/dbg_helper.c | 2 +-18 files changed, 65 insertions(+), 54 deletions(-)
Quoted 16 lines
target/riscv/debug.c bool riscv_cpu_debug_check_watchpoint(CPUState · line 998
Quoted 13 lines
target/riscv/debug.c +3
-5@@ -992,12 +992,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp) CPURISCVState *env = &cpu->env; target_ulong ctrl; target_ulong addr; - int trigger_type; - int flags; - int i; - for (i = 0; i < RV_MAX_TRIGGERS; i++) { - trigger_type = get_trigger_type(env, i); + for (int i = 0; i < RV_MAX_TRIGGERS; i++) { + int trigger_type = get_trigger_type(env, i); + BreakpointFlags flags;Here ^ the reason is we're not using
RV_MAX_TRIGGERSanymore but env-Quoted 1 line
num_triggers.
Yeah I am aware of this, I was waiting for the RISCV queue to be merged but the soft-freeze date is approaching so I preferred to post for review, and re-post just after, no other alternative when updating a core API used by all subsystems. -- this workflow issue has been discussed elsewhere recently --.
Quoted 6 lines
Patch LGTM otherwise. For the RISC-V bits:
Reviewed-by Daniel Henrique Barboza <[email protected]>
Thanks!
Re: [PATCH 18/33] cpu: Define BreakpointFlags type
In reply to Philippe Mathieu-DaudéQuoted 16 lines · Philippe Mathieu-Daudé
Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*).
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 3 ++- include/exec/watchpoint.h | 8 +++++--- include/hw/core/cpu.h | 11 ++++++----- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 11 ++++++----- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 8 ++++---- system/watchpoint.c | 8 ++++---- target/arm/tcg/debug.c | 4 ++--
Quoted 8 lines
target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 65 insertions(+), 54 deletions(-)
r~
PATCH 19/33 accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints
In reply to Philippe Mathieu-Daudé--- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
accel/tcg/tcg-accel-ops.c +1 -1
@@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static inline void tcg_remove_all_breakpoints (CPUState *cpu) +static void tcg_remove_all_breakpoints (CPUState *cpu) {cpu_breakpoint_remove_all (cpu,BP_GDB );cpu_watchpoint_remove_all (cpu,BP_GDB );
Signature · 1 line
2.53.0
Re: [PATCH 19/33] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints
Quoted 2 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 16 lines
accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)accel/tcg/tcg-accel-ops.c +1
-1@@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static inline void tcg_remove_all_breakpoints (CPUState *cpu) +static void tcg_remove_all_breakpoints (CPUState *cpu) {cpu_breakpoint_remove_all (cpu,BP_GDB );cpu_watchpoint_remove_all (cpu,BP_GDB );
Re: [PATCH 19/33] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints
In reply to Philippe Mathieu-DaudéQuoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)accel/tcg/tcg-accel-ops.c +0
-0
accel/tcg/tcg-accel-ops.c static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) · line 194
Quoted 8 lines
accel/tcg/tcg-accel-ops.c +1
-1@@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static inline void tcg_remove_all_breakpoints (CPUState *cpu) +static void tcg_remove_all_breakpoints (CPUState *cpu) {cpu_breakpoint_remove_all (cpu,BP_GDB );cpu_watchpoint_remove_all (cpu,BP_GDB );
r~
PATCH 20/33 gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode
In reply to Philippe Mathieu-DaudéNo need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly.
--- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
gdbstub/user.c +1 -1
@@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu)close (gdbserver_user_state.fd); gdbserver_user_state.fd =-1 ;CPU_FOREACH (cpu) { -cpu_breakpoint_remove_all (cpu,BP_GDB ); +gdb_breakpoint_remove_all (cpu);/* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step (cpu,0 ); }
Signature · 1 line
2.53.0
Re: [PATCH 20/33] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode
Quoted 6 lines · Philippe Mathieu-Daudé
No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 16 lines
gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)gdbstub/user.c +1
-1@@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu)close (gdbserver_user_state.fd); gdbserver_user_state.fd =-1 ;CPU_FOREACH (cpu) { -cpu_breakpoint_remove_all (cpu,BP_GDB ); +gdb_breakpoint_remove_all (cpu);/* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step (cpu,0 ); }
Re: [PATCH 20/33] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode
In reply to Philippe Mathieu-DaudéQuoted 14 lines · Philippe Mathieu-Daudé
No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)gdbstub/user.c +0
-0
gdbstub/user.c static void disable_gdbstub(CPUState *thread_cpu) · line 563
Quoted 8 lines
gdbstub/user.c +1
-1@@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu)close (gdbserver_user_state.fd); gdbserver_user_state.fd =-1 ;CPU_FOREACH (cpu) { -cpu_breakpoint_remove_all (cpu,BP_GDB ); +gdb_breakpoint_remove_all (cpu);/* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step (cpu,0 ); }
r~
PATCH 21/33 gdbstub: Reduce @type variable scope
In reply to Philippe Mathieu-Daudé--- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
gdbstub/system.c +2 -1
@@ -126,7 +126,6 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)CPUState *cpu = gdbserver_state.c_cpu;g_autoptr (GString) buf =g_string_new (NULL );g_autoptr (GString) tid =g_string_new (NULL ); -const char *type;int ret;if (running || gdbserver_state.state ==RS_INACTIVE ) {
@@ -152,6 +151,8 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)switch (state) {case RUN_STATE_DEBUG :if (cpu->watchpoint_hit) { +const char *type; +switch (cpu->watchpoint_hit->flags &BP_MEM_ACCESS ) {case BP_MEM_READ : type ="r" ;
Signature · 1 line
2.53.0
Re: [PATCH 21/33] gdbstub: Reduce @type variable scope
Quoted 2 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 24 lines
gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)gdbstub/system.c +2
-1@@ -126,7 +126,6 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)CPUState *cpu = gdbserver_state.c_cpu;g_autoptr (GString) buf =g_string_new (NULL );g_autoptr (GString) tid =g_string_new (NULL ); -const char *type;int ret;if (running || gdbserver_state.state ==RS_INACTIVE ) {@@ -152,6 +151,8 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)switch (state) {case RUN_STATE_DEBUG :if (cpu->watchpoint_hit) { +const char *type; +switch (cpu->watchpoint_hit->flags &BP_MEM_ACCESS ) {case BP_MEM_READ : type ="r" ;
Re: [PATCH 21/33] gdbstub: Reduce @type variable scope
In reply to Philippe Mathieu-DaudéQuoted 18 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)gdbstub/system.c +0
-1@@ -126,7 +126,6 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)CPUState *cpu = gdbserver_state.c_cpu;g_autoptr (GString) buf =g_string_new (NULL );g_autoptr (GString) tid =g_string_new (NULL ); -const char *type;int ret;if (running || gdbserver_state.state ==RS_INACTIVE ) {
gdbstub/system.c static void gdb_vm_state_change(void *opaque, bool running, RunState state) · line 158
Quoted 8 lines
gdbstub/system.c +2
-0@@ -152,6 +151,8 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state)switch (state) {case RUN_STATE_DEBUG :if (cpu->watchpoint_hit) { +const char *type; +switch (cpu->watchpoint_hit->flags &BP_MEM_ACCESS ) {case BP_MEM_READ : type ="r" ;
r~
PATCH 22/33 gdbstub: Introduce GdbBreakpointType enumerator
In reply to Philippe Mathieu-DaudéIntroduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling.
--- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-)
gdbstub/internals.h +5 -2
@@ -10,6 +10,7 @@#define GDBSTUB_INTERNALS_H #include "exec/cpu-common.h" +#include "gdbstub/enums.h" /* * Most "large" transfers (e.g. memory reads, feature XML
@@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet);* Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len); -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len); +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len); +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len);void gdb_breakpoint_remove_all (CPUState *cs);/**
include/gdbstub/enums.h +7 -5
@@ -12,10 +12,12 @@#define DEFAULT_GDBSTUB_PORT "1234"/* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { +GDB_BREAKPOINT_SW =0 , +GDB_BREAKPOINT_HW =1 , +GDB_WATCHPOINT_WRITE =2 , +GDB_WATCHPOINT_READ =3 , +GDB_WATCHPOINT_ACCESS =4 , +}GdbBreakpointType ;#endif /* GDBSTUB_ENUMS_H */
gdbstub/system.c +4 -2
@@ -624,7 +624,8 @@ int gdb_signal_to_target(int sig)* Break/Watch point helpers */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {const AccelOpsClass *ops =cpus_get_accel ();if (ops->insert_breakpoint) {
@@ -633,7 +634,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len)return -ENOSYS ; } -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {const AccelOpsClass *ops =cpus_get_accel ();if (ops->remove_breakpoint) {
gdbstub/user.c +4 -2
@@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void)* Break/Watch point helpers */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;
@@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) } } -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;
Signature · 1 line
2.53.0
Re: [PATCH 22/33] gdbstub: Introduce GdbBreakpointType enumerator
Quoted 2 lines · Philippe Mathieu-Daudé
Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling.
I've been thinking about using enums a lot more lately ... not only because it's more idiomatic but it's also a built-in guard for allowed values.
Quoted 104 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-)gdbstub/internals.h +5
-2@@ -10,6 +10,7 @@#define GDBSTUB_INTERNALS_H #include "exec/cpu-common.h" +#include "gdbstub/enums.h" /* * Most "large" transfers (e.g. memory reads, feature XML @@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet);* Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len); -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len); +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len); +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len);void gdb_breakpoint_remove_all (CPUState *cs);/** include/gdbstub/enums.h +7
-5@@ -12,10 +12,12 @@#define DEFAULT_GDBSTUB_PORT "1234"/* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { +GDB_BREAKPOINT_SW =0 , +GDB_BREAKPOINT_HW =1 , +GDB_WATCHPOINT_WRITE =2 , +GDB_WATCHPOINT_READ =3 , +GDB_WATCHPOINT_ACCESS =4 , +}GdbBreakpointType ;#endif /* GDBSTUB_ENUMS_H */ gdbstub/system.c +4
-2@@ -624,7 +624,8 @@ int gdb_signal_to_target(int sig)* Break/Watch point helpers */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {const AccelOpsClass *ops =cpus_get_accel ();if (ops->insert_breakpoint) {@@ -633,7 +634,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len)return -ENOSYS ; } -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {const AccelOpsClass *ops =cpus_get_accel ();if (ops->remove_breakpoint) {gdbstub/user.c +4
-2@@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void)* Break/Watch point helpers */ -int gdb_breakpoint_insert (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_insert (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;@@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) } } -int gdb_breakpoint_remove (CPUState *cs,int type,vaddr addr,vaddr len) +int gdb_breakpoint_remove (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;
Re: [PATCH 22/33] gdbstub: Introduce GdbBreakpointType enumerator
Quoted 9 lines · Daniel Henrique Barboza
Quoted 2 lines · Philippe Mathieu-Daudé
Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling.
I've been thinking about using enums a lot more lately ... not only because it's more idiomatic but it's also a built-in guard for allowed values.
Here or in general?
For me the direct benefit is finding all the API uses (call, implementation) with a single 'git grep GdbBreakpointType'; that would have been helpful 20 years ago (now we have clever IDEs).
Quoted 1 line
Reviewed-by Daniel Henrique Barboza <[email protected]>
Thanks :)
Quoted 9 lines
Quoted 9 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
gdbstub/internals.h | 7 +++++--
include/gdbstub/enums.h| 12 +++++++-----
gdbstub/system.c | 6 ++++--
gdbstub/user.c | 6 ++++--4 files changed, 20 insertions(+), 11 deletions(-)
Re: [PATCH 22/33] gdbstub: Introduce GdbBreakpointType enumerator
In reply to Philippe Mathieu-DaudéQuoted 10 lines · Philippe Mathieu-Daudé
Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling.
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-)
r~
PATCH 23/33 accel: Use GdbBreakpointType enum
In reply to Philippe Mathieu-DaudéInclude '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests.
--- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-)
accel/kvm/kvm-cpus.h +8 -3
@@ -10,13 +10,18 @@#ifndef KVM_CPUS_H #define KVM_CPUS_H +#include "gdbstub/enums.h" +int kvm_init_vcpu (CPUState *cpu,Error **errp);int kvm_cpu_exec (CPUState *cpu);void kvm_destroy_vcpu (CPUState *cpu);void kvm_cpu_synchronize_post_reset (CPUState *cpu);void kvm_cpu_synchronize_post_init (CPUState *cpu);void kvm_cpu_synchronize_pre_loadvm (CPUState *cpu); -int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len); -int kvm_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len); -void kvm_remove_all_breakpoints (CPUState *cpu); +int kvm_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +int kvm_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +void kvm_remove_all_gdbstub_breakpoints (CPUState *cpu); +#endif /* KVM_CPUS_H */
include/accel/accel-cpu-ops.h +6 -3
@@ -13,6 +13,7 @@#include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" #define ACCEL_OPS_SUFFIX "-ops"#define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX
@@ -85,9 +86,11 @@ struct AccelOpsClass {/* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); -int (*insert_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len); -int (*remove_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len); -void (*remove_all_breakpoints)(CPUState *cpu); +int (*insert_gdbstub_breakpoint)(CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +int (*remove_gdbstub_breakpoint)(CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); };void generic_handle_interrupt (CPUState *cpu,int mask);
include/system/hvf_int.h +6 -3
@@ -13,6 +13,7 @@#include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h"
@@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu);int hvf_arch_insert_sw_breakpoint (CPUState *cpu,struct hvf_sw_breakpoint *bp);int hvf_arch_remove_sw_breakpoint (CPUState *cpu,struct hvf_sw_breakpoint *bp); -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type); -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type); -void hvf_arch_remove_all_hw_breakpoints (void ); +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void );/* * hvf_update_guest_debug:
include/system/kvm.h +6 -3
@@ -17,6 +17,7 @@#define QEMU_KVM_H #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h"
@@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp);int kvm_arch_remove_sw_breakpoint (CPUState *cpu,struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type); -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type); -void kvm_arch_remove_all_hw_breakpoints (void ); +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void );void kvm_arch_update_guest_debug (CPUState *cpu,struct kvm_guest_debug *dbg);
target/arm/internals.h +3 -2
@@ -29,6 +29,7 @@#include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h"
@@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc);bool check_watchpoint_in_range (int i,vaddr addr);CPUWatchpoint *find_hw_watchpoint (CPUState *cpu,vaddr addr); -int insert_hw_watchpoint (vaddr addr,vaddr len,int type); -int delete_hw_watchpoint (vaddr addr,vaddr len,int type); +int insert_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type); +int delete_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type);/* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue (CPUARMState *env);
accel/hvf/hvf-accel-ops.c +11 -9
@@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu)return 0 ; } -static int hvf_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +static int hvf_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct hvf_sw_breakpoint *bp;int err;
@@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_INSERT_HEAD (&hvf_state->hvf_sw_breakpoints, bp, entry); }else { - err =hvf_arch_insert_hw_breakpoint (addr, len, type); + err =hvf_arch_insert_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }
@@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -static int hvf_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +static int hvf_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct hvf_sw_breakpoint *bp;int err;
@@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_REMOVE (&hvf_state->hvf_sw_breakpoints, bp, entry);g_free (bp); }else { - err =hvf_arch_remove_hw_breakpoint (addr, len, type); + err =hvf_arch_remove_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }
@@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -static void hvf_remove_all_breakpoints (CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints (CPUState *cpu) {struct hvf_sw_breakpoint *bp, *next;CPUState *tmpcpu;
@@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu)QTAILQ_REMOVE (&hvf_state->hvf_sw_breakpoints, bp, entry);g_free (bp); } -hvf_arch_remove_all_hw_breakpoints (); +hvf_arch_remove_all_gdbstub_hw_breakpoints ();CPU_FOREACH (cpu) {hvf_update_guest_debug (cpu);
@@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, const void *data) ops->synchronize_state = hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm = hvf_cpu_synchronize_pre_loadvm; - ops->insert_breakpoint = hvf_insert_breakpoint; - ops->remove_breakpoint = hvf_remove_breakpoint; - ops->remove_all_breakpoints = hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = hvf_remove_all_gdbstub_breakpoints; ops->update_guest_debug = hvf_update_guest_debug; ops->get_vcpu_stats = hvf_get_vcpu_stats;
accel/kvm/kvm-accel-ops.c +3 -3
@@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data)#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug = kvm_update_guest_debug_ops; - ops->insert_breakpoint = kvm_insert_breakpoint; - ops->remove_breakpoint = kvm_remove_breakpoint; - ops->remove_all_breakpoints = kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = kvm_remove_all_gdbstub_breakpoints;#endif }
accel/kvm/kvm-all.c +8 -6
@@ -3838,7 +3838,8 @@ static bool kvm_supports_guest_debug(AccelState *as)return s->have_guest_supported; } -int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +int kvm_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct kvm_sw_breakpoint *bp;int err;
@@ -3861,7 +3862,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_INSERT_HEAD (&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); }else { - err =kvm_arch_insert_hw_breakpoint (addr, len, type); + err =kvm_arch_insert_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }
@@ -3876,7 +3877,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -int kvm_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +int kvm_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct kvm_sw_breakpoint *bp;int err;
@@ -3900,7 +3902,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_REMOVE (&cpu->kvm_state->kvm_sw_breakpoints, bp, entry);g_free (bp); }else { - err =kvm_arch_remove_hw_breakpoint (addr, len, type); + err =kvm_arch_remove_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }
@@ -3915,7 +3917,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -void kvm_remove_all_breakpoints (CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints (CPUState *cpu) {struct kvm_sw_breakpoint *bp, *next;KVMState *s = cpu->kvm_state;
@@ -3933,7 +3935,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu)QTAILQ_REMOVE (&s->kvm_sw_breakpoints, bp, entry);g_free (bp); } -kvm_arch_remove_all_hw_breakpoints (); +kvm_arch_remove_all_gdbstub_hw_breakpoints ();CPU_FOREACH (cpu) {kvm_update_guest_debug (cpu,0 );
accel/tcg/tcg-accel-ops.c +10 -7
@@ -110,7 +110,8 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) }/* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline BreakpointFlags xlat_gdb_type (CPUState *cpu,int gdbtype) +static inline BreakpointFlags xlat_gdb_type (CPUState *cpu, +GdbBreakpointType gdbtype) {static const BreakpointFlags xlat[] = { [GDB_WATCHPOINT_WRITE ] =BP_GDB |BP_MEM_WRITE ,
@@ -126,7 +127,8 @@ static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype)return cpuflags; } -static int tcg_insert_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len) +static int tcg_insert_gdbstub_breakpoint (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;
@@ -157,7 +159,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static int tcg_remove_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len) +static int tcg_remove_gdbstub_breakpoint (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;
@@ -188,7 +191,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static void tcg_remove_all_breakpoints (CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints (CPUState *cpu) {cpu_breakpoint_remove_all (cpu,BP_GDB );cpu_watchpoint_remove_all (cpu,BP_GDB );
@@ -216,9 +219,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } ops->cpu_reset_hold = tcg_cpu_reset_hold; - ops->insert_breakpoint = tcg_insert_breakpoint; - ops->remove_breakpoint = tcg_remove_breakpoint; - ops->remove_all_breakpoints = tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = tcg_remove_all_gdbstub_breakpoints; }static void tcg_accel_ops_class_init (ObjectClass *oc,const void *data)
gdbstub/system.c +6 -6
@@ -628,8 +628,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, vaddr addr, vaddr len) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->insert_breakpoint) { -return ops->insert_breakpoint (cs, type, addr, len); +if (ops->insert_gdbstub_breakpoint) { +return ops->insert_gdbstub_breakpoint (cs, type, addr, len); }return -ENOSYS ; }
@@ -638,8 +638,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, vaddr addr, vaddr len) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->remove_breakpoint) { -return ops->remove_breakpoint (cs, type, addr, len); +if (ops->remove_gdbstub_breakpoint) { +return ops->remove_gdbstub_breakpoint (cs, type, addr, len); }return -ENOSYS ; }
@@ -647,8 +647,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type,void gdb_breakpoint_remove_all (CPUState *cs) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints (cs); +if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints (cs); } }
target/arm/hvf/hvf.c +7 -5
@@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp)return 0 ; } -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return insert_hw_watchpoint (addr, len, type); +return insert_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return delete_hw_watchpoint (addr, len, type); +return delete_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -void hvf_arch_remove_all_hw_breakpoints (void ) +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void ) {if (cur_hw_wps >0 ) {g_array_remove_range (hw_watchpoints,0 , cur_hw_wps);
target/arm/hyp_gdbstub.c +4 -4
@@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) }/** -* insert_hw_watchpoint() +* insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point
@@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc)* need to ensure you mask the address as required and set BAS=0xff */ -int insert_hw_watchpoint (vaddr addr,vaddr len,int type) +int insert_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type) {HWWatchpoint wp = { .wcr =R_DBGWCR_E_MASK ,/* E=1, enable */
@@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) }/** -* delete_hw_watchpoint() +* delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ -int delete_hw_watchpoint (vaddr addr,vaddr len,int type) +int delete_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type) {int i;for (i =0 ; i < cur_hw_wps; i++) {
target/arm/kvm.c +7 -5
@@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)"); } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return insert_hw_watchpoint (addr, len, type); +return insert_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return delete_hw_watchpoint (addr, len, type); +return delete_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) {if (cur_hw_wps >0 ) {g_array_remove_range (hw_watchpoints,0 , cur_hw_wps);
target/i386/hvf/hvf.c +5 -3
@@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp)return -ENOSYS ; } -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -void hvf_arch_remove_all_hw_breakpoints (void ) +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void ) { }
target/i386/kvm/kvm.c +7 -5
@@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)static struct {target_ulong addr;int len; -int type; +GdbBreakpointType type; } hw_breakpoint[4 ];static int nb_hw_breakpoint; -static int find_hw_breakpoint (target_ulong addr,int len,int type) +static int find_hw_breakpoint (target_ulong addr,int len,GdbBreakpointType type) {int n;
@@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int len, int type)return -1 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int n;
@@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoint =0 ; }
target/loongarch/kvm/kvm.c +5 -3
@@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { }
target/ppc/kvm.c +7 -5
@@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)static struct HWBreakpoint {target_ulong addr; -int type; +GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS ];static CPUWatchpoint hw_watchpoint;
@@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -static int find_hw_breakpoint (target_ulong addr,int type) +static int find_hw_breakpoint (target_ulong addr,GdbBreakpointType type) {int n;
@@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, BreakpointFlags *flag)return -1 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {const unsigned breakpoint_index = nb_hw_breakpoint + nb_hw_watchpoint;if (breakpoint_index >=ARRAY_SIZE (hw_debug_points)) {
@@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int n;
@@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoint = nb_hw_watchpoint =0 ; }
target/riscv/kvm/kvm-cpu.c +5 -3
@@ -2206,19 +2206,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {/* TODO; To be implemented later. */ return -EINVAL ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {/* TODO; To be implemented later. */ return -EINVAL ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) {/* TODO; To be implemented later. */ }
target/s390x/kvm/kvm.c +5 -3
@@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, int type)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :
@@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return insert_hw_breakpoint (addr, len, type); } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int size;struct kvm_hw_breakpoint *bp =find_hw_breakpoint (addr, len, type);
@@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoints =0 ;g_free (hw_breakpoints);
Signature · 1 line
2.53.0
Re: [PATCH 23/33] accel: Use GdbBreakpointType enum
Quoted 5 lines · Philippe Mathieu-Daudé
Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 741 lines
accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-)accel/kvm/kvm-cpus.h +8
-3@@ -10,13 +10,18 @@#ifndef KVM_CPUS_H #define KVM_CPUS_H +#include "gdbstub/enums.h" +int kvm_init_vcpu (CPUState *cpu,Error **errp);int kvm_cpu_exec (CPUState *cpu);void kvm_destroy_vcpu (CPUState *cpu);void kvm_cpu_synchronize_post_reset (CPUState *cpu);void kvm_cpu_synchronize_post_init (CPUState *cpu);void kvm_cpu_synchronize_pre_loadvm (CPUState *cpu); -int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len); -int kvm_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len); -void kvm_remove_all_breakpoints (CPUState *cpu); +int kvm_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +int kvm_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +void kvm_remove_all_gdbstub_breakpoints (CPUState *cpu); +#endif /* KVM_CPUS_H */ include/accel/accel-cpu-ops.h +6
-3@@ -13,6 +13,7 @@#include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" #define ACCEL_OPS_SUFFIX "-ops"#define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX@@ -85,9 +86,11 @@ struct AccelOpsClass {/* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); -int (*insert_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len); -int (*remove_breakpoint)(CPUState *cpu,int type,vaddr addr,vaddr len); -void (*remove_all_breakpoints)(CPUState *cpu); +int (*insert_gdbstub_breakpoint)(CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +int (*remove_gdbstub_breakpoint)(CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len); +void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); };void generic_handle_interrupt (CPUState *cpu,int mask);include/system/hvf_int.h +6
-3@@ -13,6 +13,7 @@#include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h" @@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu);int hvf_arch_insert_sw_breakpoint (CPUState *cpu,struct hvf_sw_breakpoint *bp);int hvf_arch_remove_sw_breakpoint (CPUState *cpu,struct hvf_sw_breakpoint *bp); -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type); -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type); -void hvf_arch_remove_all_hw_breakpoints (void ); +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void );/* * hvf_update_guest_debug: include/system/kvm.h +6
-3@@ -17,6 +17,7 @@#define QEMU_KVM_H #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h" @@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp);int kvm_arch_remove_sw_breakpoint (CPUState *cpu,struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type); -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type); -void kvm_arch_remove_all_hw_breakpoints (void ); +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void );void kvm_arch_update_guest_debug (CPUState *cpu,struct kvm_guest_debug *dbg);target/arm/internals.h +3
-2@@ -29,6 +29,7 @@#include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h" @@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc);bool check_watchpoint_in_range (int i,vaddr addr);CPUWatchpoint *find_hw_watchpoint (CPUState *cpu,vaddr addr); -int insert_hw_watchpoint (vaddr addr,vaddr len,int type); -int delete_hw_watchpoint (vaddr addr,vaddr len,int type); +int insert_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type); +int delete_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type);/* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue (CPUARMState *env);accel/hvf/hvf-accel-ops.c +11
-9@@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu)return 0 ; } -static int hvf_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +static int hvf_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct hvf_sw_breakpoint *bp;int err;@@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_INSERT_HEAD (&hvf_state->hvf_sw_breakpoints, bp, entry); }else { - err =hvf_arch_insert_hw_breakpoint (addr, len, type); + err =hvf_arch_insert_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }@@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -static int hvf_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +static int hvf_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct hvf_sw_breakpoint *bp;int err;@@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_REMOVE (&hvf_state->hvf_sw_breakpoints, bp, entry);g_free (bp); }else { - err =hvf_arch_remove_hw_breakpoint (addr, len, type); + err =hvf_arch_remove_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }@@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -static void hvf_remove_all_breakpoints (CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints (CPUState *cpu) {struct hvf_sw_breakpoint *bp, *next;CPUState *tmpcpu;@@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu)QTAILQ_REMOVE (&hvf_state->hvf_sw_breakpoints, bp, entry);g_free (bp); } -hvf_arch_remove_all_hw_breakpoints (); +hvf_arch_remove_all_gdbstub_hw_breakpoints ();CPU_FOREACH (cpu) {hvf_update_guest_debug (cpu);@@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, const void *data) ops->synchronize_state = hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm = hvf_cpu_synchronize_pre_loadvm; - ops->insert_breakpoint = hvf_insert_breakpoint; - ops->remove_breakpoint = hvf_remove_breakpoint; - ops->remove_all_breakpoints = hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = hvf_remove_all_gdbstub_breakpoints; ops->update_guest_debug = hvf_update_guest_debug; ops->get_vcpu_stats = hvf_get_vcpu_stats;accel/kvm/kvm-accel-ops.c +3
-3@@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data)#ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug = kvm_update_guest_debug_ops; - ops->insert_breakpoint = kvm_insert_breakpoint; - ops->remove_breakpoint = kvm_remove_breakpoint; - ops->remove_all_breakpoints = kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = kvm_remove_all_gdbstub_breakpoints;#endif }accel/kvm/kvm-all.c +8
-6@@ -3838,7 +3838,8 @@ static bool kvm_supports_guest_debug(AccelState *as)return s->have_guest_supported; } -int kvm_insert_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +int kvm_insert_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct kvm_sw_breakpoint *bp;int err;@@ -3861,7 +3862,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_INSERT_HEAD (&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); }else { - err =kvm_arch_insert_hw_breakpoint (addr, len, type); + err =kvm_arch_insert_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }@@ -3876,7 +3877,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -int kvm_remove_breakpoint (CPUState *cpu,int type,vaddr addr,vaddr len) +int kvm_remove_gdbstub_breakpoint (CPUState *cpu,GdbBreakpointType type, +vaddr addr,vaddr len) {struct kvm_sw_breakpoint *bp;int err;@@ -3900,7 +3902,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)QTAILQ_REMOVE (&cpu->kvm_state->kvm_sw_breakpoints, bp, entry);g_free (bp); }else { - err =kvm_arch_remove_hw_breakpoint (addr, len, type); + err =kvm_arch_remove_gdbstub_hw_breakpoint (addr, len, type);if (err) {return err; }@@ -3915,7 +3917,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len)return 0 ; } -void kvm_remove_all_breakpoints (CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints (CPUState *cpu) {struct kvm_sw_breakpoint *bp, *next;KVMState *s = cpu->kvm_state;@@ -3933,7 +3935,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu)QTAILQ_REMOVE (&s->kvm_sw_breakpoints, bp, entry);g_free (bp); } -kvm_arch_remove_all_hw_breakpoints (); +kvm_arch_remove_all_gdbstub_hw_breakpoints ();CPU_FOREACH (cpu) {kvm_update_guest_debug (cpu,0 );accel/tcg/tcg-accel-ops.c +10
-7@@ -110,7 +110,8 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) }/* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline BreakpointFlags xlat_gdb_type (CPUState *cpu,int gdbtype) +static inline BreakpointFlags xlat_gdb_type (CPUState *cpu, +GdbBreakpointType gdbtype) {static const BreakpointFlags xlat[] = { [GDB_WATCHPOINT_WRITE ] =BP_GDB |BP_MEM_WRITE ,@@ -126,7 +127,8 @@ static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype)return cpuflags; } -static int tcg_insert_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len) +static int tcg_insert_gdbstub_breakpoint (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;@@ -157,7 +159,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static int tcg_remove_breakpoint (CPUState *cs,int type,vaddr addr,vaddr len) +static int tcg_remove_gdbstub_breakpoint (CPUState *cs,GdbBreakpointType type, +vaddr addr,vaddr len) {CPUState *cpu;int err =0 ;@@ -188,7 +191,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr len) } } -static void tcg_remove_all_breakpoints (CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints (CPUState *cpu) {cpu_breakpoint_remove_all (cpu,BP_GDB );cpu_watchpoint_remove_all (cpu,BP_GDB );@@ -216,9 +219,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } ops->cpu_reset_hold = tcg_cpu_reset_hold; - ops->insert_breakpoint = tcg_insert_breakpoint; - ops->remove_breakpoint = tcg_remove_breakpoint; - ops->remove_all_breakpoints = tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint = tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint = tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints = tcg_remove_all_gdbstub_breakpoints; }static void tcg_accel_ops_class_init (ObjectClass *oc,const void *data)gdbstub/system.c +6
-6@@ -628,8 +628,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, vaddr addr, vaddr len) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->insert_breakpoint) { -return ops->insert_breakpoint (cs, type, addr, len); +if (ops->insert_gdbstub_breakpoint) { +return ops->insert_gdbstub_breakpoint (cs, type, addr, len); }return -ENOSYS ; }@@ -638,8 +638,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, vaddr addr, vaddr len) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->remove_breakpoint) { -return ops->remove_breakpoint (cs, type, addr, len); +if (ops->remove_gdbstub_breakpoint) { +return ops->remove_gdbstub_breakpoint (cs, type, addr, len); }return -ENOSYS ; }@@ -647,8 +647,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type,void gdb_breakpoint_remove_all (CPUState *cs) {const AccelOpsClass *ops =cpus_get_accel (); -if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints (cs); +if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints (cs); } }target/arm/hvf/hvf.c +7
-5@@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp)return 0 ; } -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return insert_hw_watchpoint (addr, len, type); +return insert_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return delete_hw_watchpoint (addr, len, type); +return delete_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -void hvf_arch_remove_all_hw_breakpoints (void ) +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void ) {if (cur_hw_wps >0 ) {g_array_remove_range (hw_watchpoints,0 , cur_hw_wps);target/arm/hyp_gdbstub.c +4
-4@@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) }/** -* insert_hw_watchpoint() +* insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point @@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc)* need to ensure you mask the address as required and set BAS=0xff */ -int insert_hw_watchpoint (vaddr addr,vaddr len,int type) +int insert_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type) {HWWatchpoint wp = { .wcr =R_DBGWCR_E_MASK ,/* E=1, enable */ @@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) }/** -* delete_hw_watchpoint() +* delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ -int delete_hw_watchpoint (vaddr addr,vaddr len,int type) +int delete_gdbstub_hw_watchpoint (vaddr addr,vaddr len,GdbBreakpointType type) {int i;for (i =0 ; i < cur_hw_wps; i++) {target/arm/kvm.c +7
-5@@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)"); } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return insert_hw_watchpoint (addr, len, type); +return insert_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)case GDB_WATCHPOINT_READ :case GDB_WATCHPOINT_WRITE :case GDB_WATCHPOINT_ACCESS : -return delete_hw_watchpoint (addr, len, type); +return delete_gdbstub_hw_watchpoint (addr, len, type);default :return -ENOSYS ; } } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) {if (cur_hw_wps >0 ) {g_array_remove_range (hw_watchpoints,0 , cur_hw_wps);target/i386/hvf/hvf.c +5
-3@@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint *bp)return -ENOSYS ; } -int hvf_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -int hvf_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int hvf_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -void hvf_arch_remove_all_hw_breakpoints (void ) +void hvf_arch_remove_all_gdbstub_hw_breakpoints (void ) { }target/i386/kvm/kvm.c +7
-5@@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)static struct {target_ulong addr;int len; -int type; +GdbBreakpointType type; } hw_breakpoint[4 ];static int nb_hw_breakpoint; -static int find_hw_breakpoint (target_ulong addr,int len,int type) +static int find_hw_breakpoint (target_ulong addr,int len,GdbBreakpointType type) {int n;@@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int len, int type)return -1 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int n;@@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoint =0 ; }target/loongarch/kvm/kvm.c +5
-3@@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {return -ENOSYS ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { }target/ppc/kvm.c +7
-5@@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)static struct HWBreakpoint {target_ulong addr; -int type; +GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS ];static CPUWatchpoint hw_watchpoint;@@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -static int find_hw_breakpoint (target_ulong addr,int type) +static int find_hw_breakpoint (target_ulong addr,GdbBreakpointType type) {int n;@@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, BreakpointFlags *flag)return -1 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {const unsigned breakpoint_index = nb_hw_breakpoint + nb_hw_watchpoint;if (breakpoint_index >=ARRAY_SIZE (hw_debug_points)) {@@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int n;@@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoint = nb_hw_watchpoint =0 ; }target/riscv/kvm/kvm-cpu.c +5
-3@@ -2206,19 +2206,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {/* TODO; To be implemented later. */ return -EINVAL ; } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {/* TODO; To be implemented later. */ return -EINVAL ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) {/* TODO; To be implemented later. */ }target/s390x/kvm/kvm.c +5
-3@@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, int type)return 0 ; } -int kvm_arch_insert_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_insert_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {switch (type) {case GDB_BREAKPOINT_HW :@@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type)return insert_hw_breakpoint (addr, len, type); } -int kvm_arch_remove_hw_breakpoint (vaddr addr,vaddr len,int type) +int kvm_arch_remove_gdbstub_hw_breakpoint (vaddr addr,vaddr len, +GdbBreakpointType type) {int size;struct kvm_hw_breakpoint *bp =find_hw_breakpoint (addr, len, type);@@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type)return 0 ; } -void kvm_arch_remove_all_hw_breakpoints (void ) +void kvm_arch_remove_all_gdbstub_hw_breakpoints (void ) { nb_hw_breakpoints =0 ;g_free (hw_breakpoints);
Re: [PATCH 23/33] accel: Use GdbBreakpointType enum
In reply to Philippe Mathieu-DaudéQuoted 17 lines · Philippe Mathieu-Daudé
Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests.
Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++----
Quoted 8 lines
target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-)
r~
PATCH 24/33 target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint()
In reply to Philippe Mathieu-Daudécheck_watchpoints() is called once, by arm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended.
--- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-)
target/arm/tcg/debug.c +17 -23
@@ -351,28 +351,6 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_wp)return true; } -static bool check_watchpoints (ARMCPU *cpu) -{ -CPUARMState *env = &cpu->env; -int n; - -/* -* If watchpoints are disabled globally or we can't take debug -* exceptions here then watchpoint firings are ignored. -*/ -if (extract32 (env->cp15.mdscr_el1,15 ,1 ) ==0 - || !arm_generate_debug_exceptions (env)) { -return false; - } - -for (n =0 ; n <ARRAY_SIZE (env->cpu_watchpoint); n++) { -if (bp_wp_matches (cpu, n, true)) { -return true; - } - } -return false; -} -bool arm_debug_check_breakpoint (CPUState *cs) {ARMCPU *cpu =ARM_CPU (cs);
@@ -426,8 +404,24 @@ bool arm_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)* is also an architectural watchpoint match. */ ARMCPU *cpu =ARM_CPU (cs); +CPUARMState *env = &cpu->env; +int n; -return check_watchpoints (cpu); +/* +* If watchpoints are disabled globally or we can't take debug +* exceptions here then watchpoint firings are ignored. +*/ +if (extract32 (env->cp15.mdscr_el1,15 ,1 ) ==0 + || !arm_generate_debug_exceptions (env)) { +return false; + } + +for (n =0 ; n <ARRAY_SIZE (env->cpu_watchpoint); n++) { +if (bp_wp_matches (cpu, n, true)) { +return true; + } + } +return false; }/*
Signature · 1 line
2.53.0
Re: [PATCH 24/33] target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint()
Quoted 8 lines · Philippe Mathieu-Daudé
check_watchpoints()is called once, byarm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended.Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-)
r~
PATCH 25/33 target/arm: Factor arm_check_watchpoint_hit() out
In reply to Philippe Mathieu-DaudéFactor arm_check_watchpoint_hit() out of arm_debug_excp_handler(). No logical change intended.
--- target/arm/tcg/debug.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-)
target/arm/tcg/debug.c +22 -15
@@ -455,28 +455,35 @@ static uint32_t arm_debug_exception_fsr(CPUARMState *env) } } +static bool arm_check_watchpoint_hit (CPUState *cs) +{ +CPUARMState *env =cpu_env (cs); +CPUWatchpoint *wp_hit = cs->watchpoint_hit; +bool wnr; + +if (!wp_hit || !(wp_hit->flags &BP_CPU )) { +return false; + } + + cs->watchpoint_hit =NULL ; + + env->exception.fsr =arm_debug_exception_fsr (env); + env->exception.vaddress = wp_hit->hitaddr; + wnr = (wp_hit->flags &BP_WATCHPOINT_HIT_WRITE ) !=0 ; +raise_exception_debug (env,EXCP_DATA_ABORT , +syn_watchpoint (0 ,0 , wnr)); +return true; +} +void arm_debug_excp_handler (CPUState *cs) {/* * Called by core code when a watchpoint or breakpoint fires; * need to check which one and raise the appropriate exception. */ -ARMCPU *cpu =ARM_CPU (cs); -CPUARMState *env = &cpu->env; -CPUWatchpoint *wp_hit = cs->watchpoint_hit; +CPUARMState *env =cpu_env (cs); -if (wp_hit) { -if (wp_hit->flags &BP_CPU ) { -bool wnr = (wp_hit->flags &BP_WATCHPOINT_HIT_WRITE ) !=0 ; - - cs->watchpoint_hit =NULL ; - - env->exception.fsr =arm_debug_exception_fsr (env); - env->exception.vaddress = wp_hit->hitaddr; -raise_exception_debug (env,EXCP_DATA_ABORT , -syn_watchpoint (0 ,0 , wnr)); - } - }else { +if (!arm_check_watchpoint_hit (cs)) {uint64_t pc =is_a64 (env) ? env->pc : env->regs[15 ];/*
Signature · 1 line
2.53.0
Re: [PATCH 25/33] target/arm: Factor arm_check_watchpoint_hit() out
Quoted 7 lines · Philippe Mathieu-Daudé
Factor
arm_check_watchpoint_hit()out ofarm_debug_excp_handler(). No logical change intended.Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/arm/tcg/debug.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-)
Note for future work: I really dislike having these separate "check breakpoint" and "check watchpoint" hooks, then having one single "do debug exception" that then has to work out what happened. And clear the "watchpoint_hit" state.
Ideally we'd reorganize this to "raise watchpoint" and "raise breakpoint" hooks, which are given the CPU{Break,Watch}point structure in progress.
r~
PATCH 26/33 target/xtensa: Move watchpoints handling to check_hw_watchpoints()
In reply to Philippe Mathieu-DaudéRewrite check_hw_watchpoints() by moving related code from xtensa_breakpoint_handler() to it. No logical change intended.
--- target/xtensa/helper.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-)
target/xtensa/helper.c +19 -17
@@ -30,6 +30,7 @@#include "cpu.h" #include "exec/cputlb.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "gdbstub/helpers.h" #include "exec/helper-proto.h" #include "accel/tcg/cpu-loop.h"
@@ -205,35 +206,36 @@ void xtensa_register_core(XtensaConfigList *node)g_free ((gpointer )type.name); } -static uint32_t check_hw_breakpoints (CPUXtensaState *env) +static bool check_hw_watchpoints (CPUState *cs) { -unsigned i; +CPUXtensaState *env =cpu_env (cs); +CPUWatchpoint *wp_hit = cs->watchpoint_hit; -for (i =0 ; i < env->config->ndbreak; ++i) { +if (!wp_hit || !(wp_hit->flags &BP_CPU )) { +return false; + } + cs->watchpoint_hit =NULL ; +for (int i =0 ; i < env->config->ndbreak; ++i) {if (env->cpu_watchpoint[i] && env->cpu_watchpoint[i]->flags &BP_WATCHPOINT_HIT ) { -return DEBUGCAUSE_DB | (i <<DEBUGCAUSE_DBNUM_SHIFT ); + +uint32_t cause =DEBUGCAUSE_DB | (i <<DEBUGCAUSE_DBNUM_SHIFT ); +if (cause) { +debug_exception_env (env, cause); +break ; + } } } -return 0 ; +cpu_loop_exit_noexc (cs); + +return true; }void xtensa_breakpoint_handler (CPUState *cs) {CPUXtensaState *env =cpu_env (cs); -if (cs->watchpoint_hit) { -if (cs->watchpoint_hit->flags &BP_CPU ) { -uint32_t cause; - - cs->watchpoint_hit =NULL ; - cause =check_hw_breakpoints (env); -if (cause) { -debug_exception_env (env, cause); - } -cpu_loop_exit_noexc (cs); - } - }else { +if (!check_hw_watchpoints (cs)) {if (cpu_breakpoint_test (cs, env->pc,BP_GDB ) || !cpu_breakpoint_test (cs, env->pc,BP_CPU )) {return ;
Signature · 1 line
2.53.0
Re: [PATCH 26/33] target/xtensa: Move watchpoints handling to check_hw_watchpoints()
Quoted 7 lines · Philippe Mathieu-Daudé
Rewrite
check_hw_watchpoints()by moving related code fromxtensa_breakpoint_handler()to it. No logical change intended.Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/xtensa/helper.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-)
Eh. I gave you an r-b plus future work for the previous, but if we're going to start adjuting all of the backends, let's do it right.
r~
PATCH 27/33 target/ppc: Ensure TCG is used in ppc_update_daw()
In reply to Philippe Mathieu-DaudéPer commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented:
ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG.
^^^^^^^^^^^^^^^^^^^^^
--- target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+)
target/ppc/cpu.c +2 -0
@@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid)vaddr len;BreakpointFlags flags; +assert (tcg_enabled ()); +if (env->dawr_watchpoint[rid]) {cpu_watchpoint_remove_by_ref (cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =NULL ;
Signature · 1 line
2.53.0
Re: [PATCH 27/33] target/ppc: Ensure TCG is used in ppc_update_daw()
Quoted 9 lines · Philippe Mathieu-Daudé
Per commit
d5ee641cfc5("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented:ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG.
^^^^^^^^^^^^^^^^^^^^^Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
I remember this one, so I feel comfortable giving an ack.
Quoted 16 lines
target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+)target/ppc/cpu.c +2
-0@@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid)vaddr len;BreakpointFlags flags; +assert (tcg_enabled ()); +if (env->dawr_watchpoint[rid]) {cpu_watchpoint_remove_by_ref (cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =NULL ;
PATCH 28/33 accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers
In reply to Philippe Mathieu-DaudéCommit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S") also implemented TCGCPUOps::debug_check_watchpoint for
PPC: make the comment generic.
--- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
include/accel/tcg/cpu-ops.h +2 -3
@@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr);/** -* @adjust_watchpoint_address: hack for cpu_check_watchpoint used by ARM +* @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu,vaddr addr,int len);/** * @debug_check_watchpoint: return true if the architectural -* watchpoint whose address has matched should really fire, used by ARM -* and RISC-V +* watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu,CPUWatchpoint *wp);
Signature · 1 line
2.53.0
Re: [PATCH 28/33] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers
Quoted 6 lines · Philippe Mathieu-Daudé
Commit
d5ee641cfc5("target/ppc: Implement watchpoint debug facility for v2.07S") also implementedTCGCPUOps::debug_check_watchpointfor
PPC: make the comment generic.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 24 lines
include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)include/accel/tcg/cpu-ops.h +2
-3@@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr);/** -* @adjust_watchpoint_address: hack for cpu_check_watchpoint used by ARM +* @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu,vaddr addr,int len);/** * @debug_check_watchpoint: return true if the architectural -* watchpoint whose address has matched should really fire, used by ARM -* and RISC-V +* watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu,CPUWatchpoint *wp);
Re: [PATCH 28/33] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers
In reply to Philippe Mathieu-DaudéQuoted 20 lines · Philippe Mathieu-Daudé
Commit
d5ee641cfc5("target/ppc: Implement watchpoint debug facility for v2.07S") also implementedTCGCPUOps::debug_check_watchpointfor
PPC: make the comment generic.Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)include/accel/tcg/cpu-ops.h +1
-1@@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr);/** -* @adjust_watchpoint_address: hack for cpu_check_watchpoint used by ARM +* @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by ARM) */
include/accel/tcg/cpu-ops.h struct TCGCPUOps { · line 262
Quoted 10 lines
include/accel/tcg/cpu-ops.h +1
-2vaddr (*adjust_watchpoint_address)(CPUState *cpu,vaddr addr,int len);/** * @debug_check_watchpoint: return true if the architectural -* watchpoint whose address has matched should really fire, used by ARM -* and RISC-V +* watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu,CPUWatchpoint *wp);
r~
PATCH 29/33 cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h'
In reply to Philippe Mathieu-DaudéDefine CPUWatchpoint in "exec/watchpoint.h", including this header where appropriate.
--- include/accel/tcg/cpu-ops.h | 1 + include/exec/breakpoint.h | 9 --------- include/exec/watchpoint.h | 12 ++++++++++++ target/arm/internals.h | 1 + gdbstub/system.c | 1 + target/arm/hyp_gdbstub.c | 1 + target/i386/kvm/kvm.c | 1 + target/ppc/kvm.c | 1 + target/s390x/kvm/kvm.c | 1 + 9 files changed, 19 insertions(+), 9 deletions(-)
include/accel/tcg/cpu-ops.h +1 -0
@@ -20,6 +20,7 @@#include "exec/memop.h" #include "exec/mmu-access-type.h" #include "exec/vaddr.h" +#include "exec/watchpoint.h" #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-mo.h"
include/exec/breakpoint.h +0 -9
@@ -33,13 +33,4 @@ typedef struct CPUBreakpoint { QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; -typedef struct CPUWatchpoint { -vaddr vaddr; -vaddr len; -vaddr hitaddr; -MemTxAttrs hitattrs; -int flags;/* BP_* */ -QTAILQ_ENTRY (CPUWatchpoint) entry; -}CPUWatchpoint ; -#endif
include/exec/watchpoint.h +12 -0
@@ -8,7 +8,19 @@#ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H +#include "qemu/queue.h" #include "exec/breakpoint.h" +#include "exec/memattrs.h" +#include "exec/vaddr.h" + +typedef struct CPUWatchpoint { +vaddr vaddr; +vaddr len; +vaddr hitaddr; +MemTxAttrs hitattrs; +BreakpointFlags flags; +QTAILQ_ENTRY (CPUWatchpoint) entry; +}CPUWatchpoint ;int cpu_watchpoint_insert (CPUState *cpu,vaddr addr,vaddr len,BreakpointFlags flags,CPUWatchpoint **watchpoint);
target/arm/internals.h +1 -0
@@ -29,6 +29,7 @@#include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "exec/watchpoint.h" #include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h"
gdbstub/system.c +1 -0
@@ -19,6 +19,7 @@#include "gdbstub/syscalls.h" #include "gdbstub/commands.h" #include "exec/hwaddr.h" +#include "exec/watchpoint.h" #include "accel/accel-ops.h" #include "accel/accel-cpu-ops.h" #include "system/address-spaces.h"
target/arm/hyp_gdbstub.c +1 -0
@@ -10,6 +10,7 @@*/ #include "qemu/osdep.h" +#include "exec/watchpoint.h" #include "cpu.h" #include "internals.h" #include "gdbstub/enums.h"
target/i386/kvm/kvm.c +1 -0
@@ -70,6 +70,7 @@#include "migration/blocker.h" #include "exec/memattrs.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "trace.h" #include CONFIG_DEVICES
target/ppc/kvm.c +1 -0
@@ -41,6 +41,7 @@#include "trace.h" #include "gdbstub/enums.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "system/ramblock.h" #include "system/hostmem.h" #include "qemu/cutils.h"
target/s390x/kvm/kvm.c +1 -0
@@ -49,6 +49,7 @@#include "hw/s390x/ipl.h" #include "hw/s390x/ebcdic.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "hw/s390x/s390-virtio-ccw.h" #include "hw/s390x/s390-hypercall.h" #include "target/s390x/kvm/pv.h"
Signature · 1 line
2.53.0
Re: [PATCH 29/33] cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h'
Quoted 4 lines · Philippe Mathieu-Daudé
Define CPUWatchpoint in "
exec/watchpoint.h", including this header where appropriate.Signed-off-by Philippe Mathieu-Daudé<[email protected]>
Quoted 11 lines
--- include/accel/tcg/cpu-ops.h | 1 + include/exec/breakpoint.h | 9 --------- include/exec/watchpoint.h | 12 ++++++++++++ target/arm/internals.h | 1 + gdbstub/system.c | 1 + target/arm/hyp_gdbstub.c | 1 + target/i386/kvm/kvm.c | 1 + target/ppc/kvm.c | 1 + target/s390x/kvm/kvm.c | 1 + 9 files changed, 19 insertions(+), 9 deletions(-)
r~
PATCH 30/33 cpu: Better name cpu_single_step() trace event
In reply to Philippe Mathieu-Daudécpu_single_step() is not related to breakpoints. Rename the trace event.
--- cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
cpu-target.c +2 -2
@@ -31,6 +31,8 @@void cpu_single_step (CPUState *cpu,int enabled) {if (cpu->singlestep_enabled != enabled) { +trace_cpu_change_singlestep_flags (cpu->cpu_index, + cpu->singlestep_enabled, enabled); cpu->singlestep_enabled = enabled;#if !defined(CONFIG_USER_ONLY )
@@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); }#endif - -trace_breakpoint_singlestep (cpu->cpu_index, enabled); } }
trace-events +1 -1
@@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64 " flags=0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64 " flags=0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=%d enable=%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "cpu=%d flags=0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=%d" cpu_exec_end(int cpu_index) "cpu=%d"
Signature · 1 line
2.53.0
Re: [PATCH 30/33] cpu: Better name cpu_single_step() trace event
Quoted 5 lines · Philippe Mathieu-Daudé
cpu_single_step()is not related to breakpoints. Rename the trace event.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 39 lines
cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)cpu-target.c +2
-2@@ -31,6 +31,8 @@void cpu_single_step (CPUState *cpu,int enabled) {if (cpu->singlestep_enabled != enabled) { +trace_cpu_change_singlestep_flags (cpu->cpu_index, + cpu->singlestep_enabled, enabled); cpu->singlestep_enabled = enabled;#if !defined(CONFIG_USER_ONLY )@@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); }#endif - -trace_breakpoint_singlestep (cpu->cpu_index, enabled); } }trace-events +1
-1@@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64 " flags=0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64 " flags=0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=%d enable=%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "cpu=%d flags=0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=%d" cpu_exec_end(int cpu_index) "cpu=%d"
PATCH 31/33 cpu: Introduce cpu_single_stepping() helper
In reply to Philippe Mathieu-DaudéAccess CPUState::@singlestep_enabled field with a helper.
--- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++---- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-)
include/hw/core/cpu.h +11 -0
@@ -1138,6 +1138,17 @@ void qemu_init_vcpu(CPUState *cpu);*/ void cpu_single_step (CPUState *cpu,int enabled); +/** +* cpu_single_stepping: +* @cpu: The vCPU to check +* +* Returns whether the vCPU has single-stepping enabled. +*/ +static inline bool cpu_single_stepping (const CPUState *cpu) +{ +return cpu->singlestep_enabled; +} +int cpu_breakpoint_insert (CPUState *cpu,vaddr pc,BreakpointFlags flags,CPUBreakpoint **breakpoint);int cpu_breakpoint_remove (CPUState *cpu,vaddr pc,BreakpointFlags flags);
accel/kvm/kvm-all.c +1 -1
@@ -3817,7 +3817,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap) data.dbg.control = reinject_trap; -if (cpu->singlestep_enabled) { +if (cpu_single_stepping (cpu)) { data.dbg.control |=KVM_GUESTDBG_ENABLE |KVM_GUESTDBG_SINGLESTEP ;if (cpu->singlestep_enabled &SSTEP_NOIRQ ) {
accel/tcg/cpu-exec-common.c +1 -1
@@ -47,7 +47,7 @@ uint32_t curr_cflags(CPUState *cpu)* For singlestep and -d nochain, suppress goto_tb so that * we can log -d cpu,exec after every TB. */ -if (unlikely (cpu->singlestep_enabled)) { +if (unlikely (cpu_single_stepping (cpu))) { cflags |=CF_NO_GOTO_TB |CF_NO_GOTO_PTR |CF_SINGLE_STEP |1 ; }else if (qatomic_read (&one_insn_per_tb)) { cflags |=CF_NO_GOTO_TB |1 ;
accel/tcg/cpu-exec.c +4 -4
@@ -308,7 +308,7 @@ static bool check_for_breakpoints_slow(CPUState *cpu, vaddr pc,* so that one could (gdb) singlestep into the guest kernel's * architectural breakpoint handler. */ -if (cpu->singlestep_enabled) { +if (cpu_single_stepping (cpu)) {return false; }
@@ -485,7 +485,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *tb_exit)* raise a debug exception. Single-step with another exception * is handled in cpu_handle_exception. */ -if (unlikely (cpu->singlestep_enabled) && cpu->exception_index ==-1 ) { +if (unlikely (cpu_single_stepping (cpu)) && cpu->exception_index ==-1 ) { cpu->exception_index =EXCP_DEBUG ;cpu_loop_exit (cpu); }
@@ -732,7 +732,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, int *ret)bql_unlock (); cpu->exception_index =-1 ; -if (unlikely (cpu->singlestep_enabled)) { +if (unlikely (cpu_single_stepping (cpu))) {/* * After processing the exception, ensure an EXCP_DEBUG is * raised when single-stepping so that GDB doesn't miss the
@@ -849,7 +849,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,* raised when single-stepping so that GDB doesn't miss the * next instruction. */ -if (unlikely (cpu->singlestep_enabled)) { +if (unlikely (cpu_single_stepping (cpu))) { cpu->exception_index =EXCP_DEBUG ;bql_unlock ();return true;
linux-user/riscv/cpu_loop.c +1 -1
@@ -68,7 +68,7 @@ void cpu_loop(CPURISCVState *env) }else if (ret != -QEMU_ESIGRETURN && ret != -QEMU_ESETPC ) { env->gpr[xA0] = ret; } -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) { goto gdbstep; }break ;
linux-user/s390x/cpu_loop.c +1 -1
@@ -87,7 +87,7 @@ void cpu_loop(CPUS390XState *env) env->regs[2 ] = ret; } -if (unlikely (cs->singlestep_enabled)) { +if (unlikely (cpu_single_stepping (cs))) {/* * cpu_tb_exec() did not raise EXCP_DEBUG, because it has seen * that EXCP_SVC was already pending.
system/cpus.c +1 -1
@@ -343,7 +343,7 @@ bool cpu_can_run(CPUState *cpu)void cpu_handle_guest_debug (CPUState *cpu) {if (replay_running_debug ()) { -if (!cpu->singlestep_enabled) { +if (!cpu_single_stepping (cpu)) {/* * Report about the breakpoint and * make a single step to skip it
target/arm/hvf/hvf.c +4 -4
@@ -2340,7 +2340,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)case EC_SOFTWARESTEP : { ret =EXCP_DEBUG ; -if (!cpu->singlestep_enabled) { +if (!cpu_single_stepping (cpu)) {error_report ("EC_SOFTWARESTEP but single-stepping not enabled" ); }break ;
@@ -2549,7 +2549,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)assert_hvf_ok (r);/* Handle single-stepping over instructions which trigger a VM exit */ -if (cpu->singlestep_enabled) { +if (cpu_single_stepping (cpu)) { ret =EXCP_DEBUG ; } }
@@ -2868,7 +2868,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu)CPUARMState *env = &arm_cpu->env;/* Check whether guest debugging is enabled */ - cpu->accel->guest_debug_enabled = cpu->singlestep_enabled || + cpu->accel->guest_debug_enabled =cpu_single_stepping (cpu) ||hvf_sw_breakpoints_active (cpu) ||hvf_arm_hw_debug_active (cpu);
@@ -2882,7 +2882,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu)cpu_synchronize_state (cpu);/* Enable/disable single-stepping */ -if (cpu->singlestep_enabled) { +if (cpu_single_stepping (cpu)) { env->cp15.mdscr_el1 =deposit64 (env->cp15.mdscr_el1,MDSCR_EL1_SS_SHIFT ,1 ,1 );pstate_write (env,pstate_read (env) |PSTATE_SS );
target/arm/kvm.c +1 -1
@@ -1492,7 +1492,7 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu,switch (hsr_ec) {case EC_SOFTWARESTEP : -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) {return true; }else {/*
target/i386/kvm/kvm.c +1 -1
@@ -6251,7 +6251,7 @@ static int kvm_handle_debug(X86CPU *cpu,if (arch_info->exception ==EXCP01_DB ) {if (arch_info->dr6 &DR6_BS ) { -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) { ret =EXCP_DEBUG ; } }else {
target/i386/whpx/whpx-all.c +3 -3
@@ -2271,7 +2271,7 @@ int whpx_vcpu_run(CPUState *cpu) } } -if (exclusive_step_mode !=WHPX_STEP_NONE || cpu->singlestep_enabled) { +if (exclusive_step_mode !=WHPX_STEP_NONE ||cpu_single_stepping (cpu)) {whpx_vcpu_configure_single_stepping (cpu, true,NULL ); }
@@ -2288,7 +2288,7 @@ int whpx_vcpu_run(CPUState *cpu)break ; } -if (exclusive_step_mode !=WHPX_STEP_NONE || cpu->singlestep_enabled) { +if (exclusive_step_mode !=WHPX_STEP_NONE ||cpu_single_stepping (cpu)) {whpx_vcpu_configure_single_stepping (cpu, false, &vcpu->exit_ctx.VpContext.Rflags);
@@ -2653,7 +2653,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu->exception_index =EXCP_DEBUG ; }else if ((vcpu->exit_ctx.VpException.ExceptionType == WHvX64ExceptionTypeDebugTrapOrFault) && - !cpu->singlestep_enabled) { + !cpu_single_stepping (cpu)) {/* * Just finished stepping over a breakpoint, but the * gdb does not expect us to do single-stepping.
target/loongarch/kvm/kvm.c +1 -1
@@ -1440,7 +1440,7 @@ static bool kvm_loongarch_handle_debug(CPUState *cs, struct kvm_run *run)CPULoongArchState *env = &cpu->env;kvm_cpu_synchronize_state (cs); -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) {return true; }
target/microblaze/translate.c +1 -1
@@ -1772,7 +1772,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUState *cs) }/* Finish DISAS_EXIT_* */ -if (unlikely (cs->singlestep_enabled)) { +if (unlikely (cpu_single_stepping (cs))) {gen_raise_exception (dc,EXCP_DEBUG ); }else {tcg_gen_exit_tb (NULL ,0 );
target/ppc/kvm.c +1 -1
@@ -1617,7 +1617,7 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct kvm_run *run)CPUPPCState *env = &cpu->env;struct kvm_debug_exit_arch *arch_info = &run->debug.arch; -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) {return kvm_handle_singlestep (); }
target/s390x/kvm/kvm.c +1 -1
@@ -1875,7 +1875,7 @@ static int kvm_arch_handle_debug_exit(S390CPU *cpu) }break ;case KVM_SINGLESTEP : -if (cs->singlestep_enabled) { +if (cpu_single_stepping (cs)) { ret =EXCP_DEBUG ; }break ;
Signature · 1 line
2.53.0
Re: [PATCH 31/33] cpu: Introduce cpu_single_stepping() helper
Quoted 12 lines · Philippe Mathieu-Daudé
Access CPUState::@singlestep_enabled field with a helper.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++----
Quoted 8 lines
target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-)
r~
PATCH 32/33 cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
In reply to Philippe Mathieu-DaudéCPUState::singlestep_enabled contains multiple flags since commit 60897d369f1 ("Debugger single step without interrupts"). Rename to avoid mistakes.
--- include/hw/core/cpu.h | 8 ++++---- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 20 insertions(+), 20 deletions(-)
include/hw/core/cpu.h +4 -4
@@ -440,7 +440,7 @@ struct qemu_work_item;* @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU -* @singlestep_enabled: Flags for single-stepping. +* @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has)
@@ -505,7 +505,7 @@ struct CPUState {int exclusive_context_count;uint32_t cflags_next_tb;uint32_t interrupt_request; -int singlestep_enabled; +int singlestep_flags;int64_t icount_budget;int64_t icount_extra;uint64_t random_seed;
@@ -1136,7 +1136,7 @@ void qemu_init_vcpu(CPUState *cpu);* * Enables or disables single-stepping for @cpu. */ -void cpu_single_step (CPUState *cpu,int enabled); +void cpu_single_step (CPUState *cpu,int flags);/** * cpu_single_stepping:
@@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int enabled);*/ static inline bool cpu_single_stepping (const CPUState *cpu) { -return cpu->singlestep_enabled; +return cpu->singlestep_flags; } int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags,
accel/kvm/kvm-all.c +1 -1
@@ -3820,7 +3820,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)if (cpu_single_stepping (cpu)) { data.dbg.control |=KVM_GUESTDBG_ENABLE |KVM_GUESTDBG_SINGLESTEP ; -if (cpu->singlestep_enabled &SSTEP_NOIRQ ) { +if (cpu->singlestep_flags &SSTEP_NOIRQ ) { data.dbg.control |=KVM_GUESTDBG_BLOCKIRQ ; } }
accel/tcg/cpu-exec.c +1 -1
@@ -828,7 +828,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,return true; } -if (unlikely (cpu->singlestep_enabled &SSTEP_NOIRQ )) { +if (unlikely (cpu->singlestep_flags &SSTEP_NOIRQ )) {/* Mask out external interrupts for this step. */ interrupt_request &= ~CPU_INTERRUPT_SSTEP_MASK ; }
accel/tcg/tcg-accel-ops-rr.c +1 -1
@@ -274,7 +274,7 @@ static void *rr_cpu_thread_fn(void *arg) current_cpu = cpu;qemu_clock_enable (QEMU_CLOCK_VIRTUAL , - (cpu->singlestep_enabled &SSTEP_NOTIMER ) ==0 ); + (cpu->singlestep_flags &SSTEP_NOTIMER ) ==0 );if (cpu_can_run (cpu)) {int r;
cpu-target.c +4 -4
@@ -28,12 +28,12 @@/* enable or disable single step mode. EXCP_DEBUG is returned by the CPU loop after each instruction */ -void cpu_single_step (CPUState *cpu,int enabled) +void cpu_single_step (CPUState *cpu,int flags) { -if (cpu->singlestep_enabled != enabled) { +if (cpu->singlestep_flags != flags) {trace_cpu_change_singlestep_flags (cpu->cpu_index, - cpu->singlestep_enabled, enabled); - cpu->singlestep_enabled = enabled; + cpu->singlestep_flags, flags); + cpu->singlestep_flags = flags;#if !defined(CONFIG_USER_ONLY )const AccelOpsClass *ops =cpus_get_accel ();
target/arm/hvf/hvf.c +1 -1
@@ -2603,7 +2603,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu)flush_cpu_state (cpu); do { - if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) && + if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { return EXCP_INTERRUPT; }
target/ppc/translate.c +8 -8
@@ -198,7 +198,7 @@ struct DisasContext {bool pmu_insn_cnt;bool bhrb_enable;ppc_spr_t *spr_cb;/* Needed to check rights for mfspr/mtspr */ -int singlestep_enabled; +int singlestep_flags;uint32_t flags;uint64_t insns_flags;uint64_t insns_flags2;
@@ -367,7 +367,7 @@ static void gen_debug_exception(DisasContext *ctx, bool rfi_type)#if !defined(CONFIG_USER_ONLY )if (ctx->flags &POWERPC_FLAG_DE ) {target_ulong dbsr =0 ; -if (ctx->singlestep_enabled &CPU_SINGLE_STEP ) { +if (ctx->singlestep_flags &CPU_SINGLE_STEP ) { dbsr =DBCR0_ICMP ; }else {/* Must have been branch */
@@ -3645,7 +3645,7 @@ static void pmu_count_insns(DisasContext *ctx)static inline bool use_goto_tb (DisasContext *ctx,target_ulong dest) { -if (unlikely (ctx->singlestep_enabled)) { +if (unlikely (ctx->singlestep_flags)) {return false; }return translator_use_goto_tb (&ctx->base, dest);
@@ -3653,7 +3653,7 @@ static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest)static void gen_lookup_and_goto_ptr (DisasContext *ctx) { -if (unlikely (ctx->singlestep_enabled)) { +if (unlikely (ctx->singlestep_flags)) {gen_debug_exception (ctx, false); }else {/*
@@ -6559,13 +6559,13 @@ static void ppc_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) ctx->pmu_insn_cnt = (hflags >>HFLAGS_INSN_CNT ) &1 ; ctx->bhrb_enable = (hflags >>HFLAGS_BHRB_ENABLE ) &1 ; - ctx->singlestep_enabled =0 ; + ctx->singlestep_flags =0 ;if ((hflags >>HFLAGS_SE ) &1 ) { - ctx->singlestep_enabled |=CPU_SINGLE_STEP ; + ctx->singlestep_flags |=CPU_SINGLE_STEP ; ctx->base.max_insns =1 ; }if ((hflags >>HFLAGS_BE ) &1 ) { - ctx->singlestep_enabled |=CPU_BRANCH_STEP ; + ctx->singlestep_flags |=CPU_BRANCH_STEP ; } }
@@ -6641,7 +6641,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) }/* Honor single stepping. */ -if (unlikely (ctx->singlestep_enabled &CPU_SINGLE_STEP )) { +if (unlikely (ctx->singlestep_flags &CPU_SINGLE_STEP )) {bool rfi_type = false;switch (is_jmp) {
Signature · 1 line
2.53.0
Re: [PATCH 32/33] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
Quoted 5 lines · Philippe Mathieu-Daudé
CPUState::singlestep_enabledcontains multiple flags since commit60897d369f1("Debugger single step without interrupts"). Rename to avoid mistakes.Signed-off-by Philippe Mathieu-Daudé<[email protected]>
Quoted 9 lines
--- include/hw/core/cpu.h | 8 ++++---- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 20 insertions(+), 20 deletions(-)
r~
Re: [PATCH 32/33] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
In reply to Philippe Mathieu-DaudéQuoted 29 lines · Philippe Mathieu-Daudé
CPUState::singlestep_enabledcontains multiple flags since commit60897d369f1("Debugger single step without interrupts"). Rename to avoid mistakes.Signed-off-by Philippe Mathieu-Daudé<[email protected]>--- include/hw/core/cpu.h | 8 ++++---- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 20 insertions(+), 20 deletions(-)include/hw/core/cpu.h +1
-1@@ -440,7 +440,7 @@ struct qemu_work_item;* @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU -* @singlestep_enabled: Flags for single-stepping. +* @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has)
include/hw/core/cpu.h struct CPUState { · line 508
Quoted 5 lines
include/hw/core/cpu.h +1
-1@@ -505,7 +505,7 @@ struct CPUState {int exclusive_context_count;uint32_t cflags_next_tb;uint32_t interrupt_request; -int singlestep_enabled; +int singlestep_flags;
can we also change the type to uint32_t?
Re: [PATCH 32/33] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags
Quoted 17 lines · Xiaoyao Li
Quoted 14 lines · Philippe Mathieu-Daudé
CPUState::singlestep_enabledcontains multiple flags since commit60897d369f1("Debugger single step without interrupts"). Rename to avoid mistakes.Signed-off-by Philippe Mathieu-Daudé<[email protected]>---
include/hw/core/cpu.h | 8 ++++---- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +-accel/tcg/tcg-accel-ops-rr.c| 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++--------7 files changed, 20 insertions(+), 20 deletions(-)
Quoted 8 lines
include/hw/core/cpu.h struct CPUState { · line 508
Quoted 6 lines
include/hw/core/cpu.h +1
-1@@ -505,7 +505,7 @@ struct CPUState { int exclusive_context_count; uint32_t cflags_next_tb; uint32_t interrupt_request; - int singlestep_enabled; + int singlestep_flags;can we also change the type to
uint32_t?
Good suggestion, sure.
PATCH 33/33 cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping()
In reply to Philippe Mathieu-DaudéOnly the SSTEP_ENABLE bitmask means single-step is enabled.
--- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/hw/core/cpu.h +1 -1
@@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int flags);*/ static inline bool cpu_single_stepping (const CPUState *cpu) { -return cpu->singlestep_flags; +return cpu->singlestep_flags &SSTEP_ENABLE ; } int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags,
Signature · 1 line
2.53.0
Re: [PATCH 33/33] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping()
Quoted 5 lines · Philippe Mathieu-Daudé
Only the
SSTEP_ENABLEbitmask means single-step is enabled.Fixes 60897d369f1 ("Debugger single step without interrupts")Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 16 lines
include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/hw/core/cpu.h +1
-1@@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int flags);*/ static inline bool cpu_single_stepping (const CPUState *cpu) { -return cpu->singlestep_flags; +return cpu->singlestep_flags &SSTEP_ENABLE ; } int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags,
Re: [PATCH 33/33] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping()
In reply to Philippe Mathieu-DaudéQuoted 13 lines · Philippe Mathieu-Daudé
Only the
SSTEP_ENABLEbitmask means single-step is enabled.Fixes 60897d369f1 ("Debugger single step without interrupts")Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/hw/core/cpu.h +0
-0
include/hw/core/cpu.h void cpu_single_step(CPUState *cpu, int flags); · line 1152
Quoted 8 lines
include/hw/core/cpu.h +1
-1@@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int flags);*/ static inline bool cpu_single_stepping (const CPUState *cpu) { -return cpu->singlestep_flags; +return cpu->singlestep_flags &SSTEP_ENABLE ; } int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags,
r~