Skip to contentSkip to conversation

f2fs: add error checking in do_write_page()

PATCH Superseded mason.zhang 2 participants 2 messages Jul 24, 2025 – Jul 25, 2025 F2FS file system

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: add error checking in do_write_page()

Otherwise, the filesystem may unaware of potential file corruption.

---
 fs/f2fs/segment.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
fs/f2fs/segment.c +5 -2
index ae1223ef648f..ce80ba226aed 100644
@@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
 	int seg_type = log_type_to_seg_type(type);
 	bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
 				seg_type == CURSEG_COLD_DATA);
+	int err;
 
 	if (keep_order)
 		f2fs_down_read(&fio->sbi->io_order_lock);
 
-	if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
-			&fio->new_blkaddr, sum, type, fio)) {
+	err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
+			&fio->new_blkaddr, sum, type, fio);
+	if (unlikely(err)) {
+		f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);
 		if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
 			fscrypt_finalize_bounce_page(&fio->encrypted_page);
 		folio_end_writeback(folio);
Signature · 1 line
2.50.0
maintainer
#1 lore raw
Quoted 16 lines · mason.zhang

Otherwise, the filesystem may unaware of potential file corruption.

---
  fs/f2fs/segment.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)
fs/f2fs/segment.c +1 -0
index ae1223ef648f..ce80ba226aed 100644
@@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
  	int seg_type = log_type_to_seg_type(type);
  	bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
  				seg_type == CURSEG_COLD_DATA);
+	int err;

fs/f2fs/segment.c static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio) · line 3947

Quoted 10 lines
fs/f2fs/segment.c +4 -2
 
  	if (keep_order)
  		f2fs_down_read(&fio->sbi->io_order_lock);
 
-	if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
-			&fio->new_blkaddr, sum, type, fio)) {
+	err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
+			&fio->new_blkaddr, sum, type, fio);
+	if (unlikely(err)) {
+		f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);

How about using f2fs_err_ratelimited() to avoid too many logs?

Can you please dump more informations about inode, page, blkaddr...?

Thanks,

Quoted 3 lines
fs/f2fs/segment.c +0 -0
  		if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
  			fscrypt_finalize_bounce_page(&fio->encrypted_page);
  		folio_end_writeback(folio);