Skip to contentSkip to conversation

llvm: Remove -fcommon

PATCH In review Adrian Bunk 2 participants 3 messages May 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 llvm: Remove -fcommon

I cannot reproduce the problem.

---
 meta/recipes-devtools/llvm/llvm_git.bb | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-devtools/llvm/llvm_git.bb +0 -2
index a8607f5008..d24ed761bf 100644
@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\
                   -DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
                  "
 
-CFLAGS += "-fcommon"
-
 do_configure_prepend() {
 # Fix paths in llvm-config
 	sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Adrian Bunk

I cannot reproduce the problem.

have you built the target recipe with gcc10 with -fno-common default ?

Quoted 22 lines
---
  meta/recipes-devtools/llvm/llvm_git.bb | 2 --
  1 file changed, 2 deletions(-)
meta/recipes-devtools/llvm/llvm_git.bb +0 -2
index a8607f5008..d24ed761bf 100644
@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\
                    -DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
                   "
 
-CFLAGS += "-fcommon"
-
  do_configure_prepend() {
  # Fix paths in llvm-config
  	sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp
#2 lore raw
Quoted 4 lines · Khem Raj
Quoted 1 line · Adrian Bunk

I cannot reproduce the problem.

have you built the target recipe with gcc10 with -fno-common default ?

Yes.

For menu-cache and matchbox-wm I got failures without the patches, but not for llvm.

cu
Adrian