Skip to contentSkip to conversation

staging: media: omap4iss: Align line break to the open parenthesis in file iss.c

PATCH In review Aline Santana Cordeiro 2 participants 4 messages Apr 9, 2021 – Apr 13, 2021 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/2 staging: media: omap4iss: Align line break to the open parenthesis in file iss.c

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/omap4iss/iss.c +1 -1
index dae9073..c89f268a 100644
@@ -960,7 +960,7 @@ iss_register_subdev_group(struct iss_device *iss,
 		}
 
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);
 		if (!subdev) {
 			dev_err(iss->dev, "Unable to register subdev %s\n",
 				board_info->board_info->type);
Signature · 1 line
2.7.4
#2 lore raw
Quoted 4 lines · Aline Santana Cordeiro

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

Obsolete, a similar patch from Beatriz Martins de Carvalho <[email protected]> has already been applied in the media subsystem tree.

Regards,

Hans

Quoted 18 lines
---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/omap4iss/iss.c +1 -1
index dae9073..c89f268a 100644
@@ -960,7 +960,7 @@ iss_register_subdev_group(struct iss_device *iss,
 		}
 
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);
 		if (!subdev) {
 			dev_err(iss->dev, "Unable to register subdev %s\n",
 				board_info->board_info->type);
author
#3 lore raw

Em ter, 2021-04-13 às 16:32 +0200, Hans Verkuil escreveu:

Quoted 7 lines · Aline Santana Cordeiro
Quoted 5 lines

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <
[email protected]>

Quoted 8 lines

Obsolete, a similar patch from Beatriz Martins de Carvalho < [email protected]>
has already been applied in the media subsystem tree.

Regards,

        Hans

Okay, thank you for letting me know.

Aline

Quoted 24 lines
Quoted 23 lines

---
 drivers/staging/media/omap4iss/iss.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/omap4iss/iss.c +0 -0
index dae9073..c89f268a 100644
@@ -960,7 +960,7 @@ iss_register_subdev_group(struct iss_device
 *iss,
                 }


                subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-                               board_info->board_info, NULL); +                                                  board_info-

Quoted 1 line

board_info, NULL);

                if (!subdev) {
                        dev_err(iss->dev, "Unable to register subdev %s\n",
                                board_info->board_info->type);

#4 lore raw

PATCH 2/2 staging: media: omap4iss: Align line break to the open parenthesis in file iss_video.c

In reply to a message not in the archive

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/omap4iss/iss_video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/omap4iss/iss_video.c +2 -2
index 66975a3..a2cef7c 100644
@@ -399,7 +399,7 @@ static void iss_video_buf_queue(struct vb2_buffer *vb)
 
 		if (start)
 			omap4iss_pipeline_set_stream(pipe,
-						ISS_PIPELINE_STREAM_SINGLESHOT);
+						     ISS_PIPELINE_STREAM_SINGLESHOT);
 	}
 }
 
@@ -957,7 +957,7 @@ iss_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
 		unsigned long flags;
 
 		ret = omap4iss_pipeline_set_stream(pipe,
-					      ISS_PIPELINE_STREAM_CONTINUOUS);
+						   ISS_PIPELINE_STREAM_CONTINUOUS);
 		if (ret < 0)
 			goto err_omap4iss_set_stream;
 		spin_lock_irqsave(&video->qlock, flags);
Signature · 1 line
2.7.4