Skip to contentSkip to conversation

mm: avoid possible multiple call to swap_node()

PATCH linmiaohe 1 participant 1 message Sep 17, 2020 Memory management

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 5 lines · Matthew Wilcox
Quoted 2 lines · Miaohe Lin

Cache the swap_node() in a local variable to avoid possible multiple call to swap_node(), though compiler may do this for us.

Why don't you find out? Compare the assembly before and after, see what the compiler did.

In fact, I don't care if the compiler can really do this for us. I think it's better to do this explicity. I think this can improve the readability. Thanks.