Skip to contentSkip to conversation

ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

PATCH In review Rado Vrbovsky 3 participants 6 messages Feb 21, 2013 – Mar 4, 2013 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

From: Andrew Brownfield <[email protected]>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c this trivial patch adds a description to prefer_ms_hyperv.

[[email protected]: MODULE_PARM_DESC() string formatting modified]

---
 drivers/ata/ata_piix.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/ata/ata_piix.c +4 -0
index 174eca6..b9bf99a 100644
@@ -1530,6 +1530,10 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 
 static int prefer_ms_hyperv = 1;
 module_param(prefer_ms_hyperv, int, 0);
+MODULE_PARM_DESC(prefer_ms_hyperv,
+       "Prefer Hyper-V paravirtualization drivers instead of ATA, "
+       "0 - Use ATA drivers, "
+       "1 (Default) - Use the paravirtualization drivers.");
 
 static void piix_ignore_devices_quirk(struct ata_host *host)
 {
Signature · 1 line
1.7.11.7
#2 lore raw

Hello.

Quoted 2 lines · Rado Vrbovsky

From: Andrew Brownfield<[email protected]>

Hm, I don't see his signoff...

Quoted 2 lines

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c

Please also specify that commit's summary in parens (or however you
like).

Quoted 6 lines

this trivial patch adds a description to prefer_ms_hyperv.

[[email protected]: MODULE_PARM_DESC() string formatting modified]

MBR, Sergei

#3 lore raw

From: Andrew Brownfield <[email protected]>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv.

[[email protected]: MODULE_PARM_DESC() string formatting modified]

---
 drivers/ata/ata_piix.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/ata/ata_piix.c +4 -0
index 174eca6..b9bf99a 100644
@@ -1530,6 +1530,10 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 
 static int prefer_ms_hyperv = 1;
 module_param(prefer_ms_hyperv, int, 0); 
+MODULE_PARM_DESC(prefer_ms_hyperv,
+       "Prefer Hyper-V paravirtualization drivers instead of ATA, "
+       "0 - Use ATA drivers, "
+       "1 (Default) - Use the paravirtualization drivers.");
 
 static void piix_ignore_devices_quirk(struct ata_host *host)
 {
Signature · 1 line
1.7.11.7
#4 lore raw

Hello.

Quoted 9 lines · Rado Vrbovsky

From: Andrew Brownfield <[email protected]>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv.

[[email protected]: MODULE_PARM_DESC() string formatting modified]

Note that you can't jus mechanically add Andrew's signoff to the patch,
you have to ask him to sign it off... I hope you did.

Quoted 1 line

MBR, Sergei

#5 lore raw
Quoted 1 line

Hello.

Hi Sergei,

Quoted 8 lines · Rado Vrbovsky
Quoted 6 lines

From: Andrew Brownfield <[email protected]>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv.

Quoted 8 lines
Quoted 4 lines

[[email protected]: MODULE_PARM_DESC() string formatting modified]

Note that you can't jus mechanically add Andrew's signoff to the patch,
you have to ask him to sign it off... I hope you did.

It was in the original patch and I erased by mistake.

Quoted 4 lines
Quoted 1 line

MBR, Sergei

Brg,

Rado

#6 lore raw
In reply to Rado Vrbovsky
Quoted 6 lines · Rado Vrbovsky

From: Andrew Brownfield <[email protected]>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv.

Quoted 8 lines

[[email protected]: MODULE_PARM_DESC() string formatting modified]

---
  drivers/ata/ata_piix.c | 4 ++++
  1 file changed, 4 insertions(+)

applied [manually]