Skip to contentSkip to conversation

fixup! Bluetooth: btusb: Use pm_ptr instead of #ifdef CONFIG_PM

PATCH NAK Luiz Augusto von Dentz 3 participants 3 messages Jan 20 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 fixup! Bluetooth: btusb: Use pm_ptr instead of #ifdef CONFIG_PM

From: Luiz Augusto von Dentz <[email protected]>

---
 drivers/bluetooth/btusb.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bluetooth/btusb.c +3 -2
index 759def260ed0..f9fba78f0a4a 100644
@@ -4468,7 +4468,8 @@ static void btusb_disconnect(struct usb_interface *intf)
 	kfree(data);
 }
 
-static int btusb_suspend(struct usb_interface *intf, pm_message_t message)
+static int __maybe_unused btusb_suspend(struct usb_interface *intf,
+					pm_message_t message)
 {
 	struct btusb_data *data = usb_get_intfdata(intf);
 
@@ -4557,7 +4558,7 @@ static void play_deferred(struct btusb_data *data)
 	}
 }
 
-static int btusb_resume(struct usb_interface *intf)
+static int __maybe_unused btusb_resume(struct usb_interface *intf)
 {
 	struct btusb_data *data = usb_get_intfdata(intf);
 	struct hci_dev *hdev = data->hdev;
Signature · 1 line
2.52.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1044807

---Test result---

Test Summary:

CheckPatch                    PENDING   0.39 seconds
GitLint                       PENDING   0.27 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      25.81 seconds
CheckAllWarning               PASS      28.04 seconds
CheckSparse                   PASS      31.14 seconds
BuildKernel32                 PASS      25.34 seconds
TestRunnerSetup               PASS      550.69 seconds
TestRunner_l2cap-tester       PASS      27.64 seconds
TestRunner_iso-tester         PASS      85.89 seconds
TestRunner_bnep-tester        PASS      6.34 seconds
TestRunner_mgmt-tester        FAIL      128.94 seconds
TestRunner_rfcomm-tester      PASS      9.32 seconds
TestRunner_sco-tester         FAIL      14.51 seconds
TestRunner_ioctl-tester       PASS      10.17 seconds
TestRunner_mesh-tester        FAIL      11.48 seconds
TestRunner_smp-tester         PASS      8.55 seconds
TestRunner_userchan-tester    PASS      6.63 seconds
IncrementalBuild              PENDING   0.76 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 487 (98.6%), Failed: 3, Not Run: 4

Failed Test Cases

Read Exp Feature - Success                           Failed       0.104 seconds
LL Privacy - Set Flags 1 (Add to RL)                 Failed       0.155 seconds
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.139 seconds

##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected

BUG: sleeping function called from invalid context at net/core/sock.c:3782

Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases

Mesh - Send cancel - 1                               Timed out    1.866 seconds
Mesh - Send cancel - 2                               Timed out    1.996 seconds

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz

NAK, see explanation at:
https://patchwork.kernel.org/project/bluetooth/patch/[email protected]/#26748187

Quoted 32 lines · Luiz Augusto von Dentz

From: Luiz Augusto von Dentz <[email protected]>

---
 drivers/bluetooth/btusb.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bluetooth/btusb.c +0 -0
index 759def260ed0..f9fba78f0a4a 100644
@@ -4468,7 +4468,8 @@ static void btusb_disconnect(struct
 usb_interface *intf)
  	kfree(data);
  }


-static int btusb_suspend(struct usb_interface *intf, pm_message_t message)

drivers/bluetooth/btusb.c +2 -0
+static int __maybe_unused btusb_suspend(struct usb_interface *intf,
+					pm_message_t message)

 {
  struct btusb_data *data = usb_get_intfdata(intf);

drivers/bluetooth/btusb.c +0 -0
@@ -4557,7 +4558,7 @@ static void play_deferred(struct btusb_data
 *data)
  	}
  }

drivers/bluetooth/btusb.c +1 -1
-static int btusb_resume(struct usb_interface *intf)
+static int __maybe_unused btusb_resume(struct usb_interface *intf)

 {
  struct btusb_data *data = usb_get_intfdata(intf); struct hci_dev *hdev = data->hdev;