Skip to contentSkip to conversation

clk: g12a-aoclk: re-export CLKID_AO_SAR_ADC_SEL clock id

PATCH Applied Neil Armstrong 2 participants 3 messages Mar 4, 2019 – Mar 19, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: g12a-aoclk: re-export CLKID_AO_SAR_ADC_SEL clock id

When submitted v2 of the G12A AO-CLK IDs, the SAR_ADC_SEL ID was moved to the internal non-exported bindings, but this clock is necessary and mandatory for the SAR ADC bindings.

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/g12a-aoclk.h +0 -1
index 04b0d5506641..666b4493822c 100644
@@ -16,7 +16,6 @@
  * to expose, such as the internal muxes and dividers of composite clocks,
  * will remain defined here.
  */
-#define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_DIV	17
 #define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K_PRE	20
include/dt-bindings/clock/g12a-aoclkc.h +1 -0
index 8db01ffbeb06..5ac66a2eee0f 100644
@@ -26,6 +26,7 @@
 #define CLKID_AO_M4_FCLK	13
 #define CLKID_AO_M4_HCLK	14
 #define CLKID_AO_CLK81		15
+#define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_CLK	18
 #define CLKID_AO_32K		23
 #define CLKID_AO_CEC		27
Signature · 1 line
2.20.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Neil Armstrong

When submitted v2 of the G12A AO-CLK IDs, the SAR_ADC_SEL ID was moved to the internal non-exported bindings, but this clock is necessary and mandatory for the SAR ADC bindings.

Quoted 8 lines

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
author Applied
#2 lore raw
In reply to Neil Armstrong
Quoted 31 lines · Neil Armstrong

When submitted v2 of the G12A AO-CLK IDs, the SAR_ADC_SEL ID was moved to the internal non-exported bindings, but this clock is necessary and mandatory for the SAR ADC bindings.

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/g12a-aoclk.h +0 -1
index 04b0d5506641..666b4493822c 100644
@@ -16,7 +16,6 @@
  * to expose, such as the internal muxes and dividers of composite clocks,
  * will remain defined here.
  */
-#define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_DIV	17
 #define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K_PRE	20
include/dt-bindings/clock/g12a-aoclkc.h +0 -0
index 8db01ffbeb06..5ac66a2eee0f 100644

include/dt-bindings/clock/g12a-aoclkc.h line 32

Quoted 7 lines
include/dt-bindings/clock/g12a-aoclkc.h +1 -0
@@ -26,6 +26,7 @@
 #define CLKID_AO_M4_FCLK	13
 #define CLKID_AO_M4_HCLK	14
 #define CLKID_AO_CLK81		15
+#define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_CLK	18
 #define CLKID_AO_32K		23
 #define CLKID_AO_CEC		27

Applied to next/headers