Skip to contentSkip to conversation

shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Jan 26 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH v2 1/1 shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

From: Luiz Augusto von Dentz <[email protected]>

This fix the following error cause by not converting the role value to little endian:

TMAP/SR/SGGIT/CHA/BV-01-C [Characteristic GGIT - TMAP Role] - run
**
ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0) Bail out! ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)

---
 src/shared/tmap.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
src/shared/tmap.c +4 -6
index 27e08d74a0d4..696c610aab86 100644
@@ -239,13 +239,11 @@ static void tmas_role_read(struct gatt_db_attribute *attrib,
 					void *user_data)
 {
 	struct bt_tmas_db *db = user_data;
-	struct iovec iov = {
-		.iov_base = &db->role_value,
-		.iov_len = sizeof(db->role_value)
-	};
+	uint8_t role[2];
 
-	gatt_db_attribute_read_result(attrib, id, 0, iov.iov_base,
-							iov.iov_len);
+	put_le16(db->role_value, role);
+
+	gatt_db_attribute_read_result(attrib, id, 0, role, sizeof(role));
 }
 
 static bool match_db(const void *data, const void *match_data)
Signature · 1 line
2.52.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1047202

---Test result---

Test Summary:

CheckPatch                    PENDING   0.34 seconds
GitLint                       PENDING   0.41 seconds
BuildEll                      PASS      19.96 seconds
BluezMake                     PASS      640.73 seconds
MakeCheck                     PASS      18.57 seconds
MakeDistcheck                 PASS      240.61 seconds
CheckValgrind                 PASS      292.11 seconds
CheckSmatch                   PASS      348.09 seconds
bluezmakeextell               PASS      181.60 seconds
IncrementalBuild              PENDING   0.28 seconds
ScanBuild                     PASS      1017.07 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 11 lines · On Mon, 26 Jan 2026 11:57:54 -0500 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

This fix the following error cause by not converting the role value to little endian:

TMAP/SR/SGGIT/CHA/BV-01-C [Characteristic GGIT - TMAP Role] - run
**
ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0) Bail out! ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)

[...]

Here is the summary with links:
- [BlueZ,v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=521088388bab

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html