Skip to contentSkip to conversation

watchdog: bcm6345: convert to use live dt

PATCH New Álvaro Fernández Rojas 3 participants 3 messages Mar 17, 2018 – Mar 19, 2018 Watchdog device drivers

lore
Share & tools
lore

Álvaro Fernández Rojas

author
#0 lore raw

PATCH 1/1 watchdog: bcm6345: convert to use live dt

Signed-off-by Álvaro Fernández Rojas <[email protected]>
---
 drivers/watchdog/bcm6345_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/bcm6345_wdt.c +2 -3
index 3ef7d438a6..90b33aadf1 100644
@@ -87,13 +87,12 @@ static int bcm6345_wdt_probe(struct udevice *dev)
 {
 	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
 	fdt_addr_t addr;
-	fdt_size_t size;
 
-	addr = devfdt_get_addr_size_index(dev, 0, &size);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
-	priv->regs = ioremap(addr, size);
+	priv->regs = ioremap(addr, 0);
 
 	bcm6345_wdt_stop(dev);
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 watchdog: bcm6345: convert to use live dt

Quoted 12 lines · Álvaro Fernández Rojas
Signed-off-by Álvaro Fernández Rojas <[email protected]>
---
 drivers/watchdog/bcm6345_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/bcm6345_wdt.c +0 -0
index 3ef7d438a6..90b33aadf1 100644
@@ -87,13 +87,12 @@ static int bcm6345_wdt_probe(struct udevice *dev)
 {
 	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);

drivers/watchdog/bcm6345_wdt.c static int bcm6345_wdt_probe(struct udevice *dev) · line 95

Quoted 10 lines
drivers/watchdog/bcm6345_wdt.c +2 -3
 	fdt_addr_t addr;
-	fdt_size_t size;
 
-	addr = devfdt_get_addr_size_index(dev, 0, &size);
+	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
-	priv->regs = ioremap(addr, size);
+	priv->regs = ioremap(addr, 0);

as this pattern is repeated in each driver which have to do such remapping on archs like MIPS, I suggest to add generic wrapper functions for this like:

void *dev_read_addr_and_remap_index(struct udevice *dev, int index)

void *dev_read_addr_and_remap(struct udevice *dev)

Quoted 4 lines
drivers/watchdog/bcm6345_wdt.c +0 -0
 	bcm6345_wdt_stop(dev);
Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180317/86c0777d/attachment.sig>
#2 lore raw

PATCH 1/1 watchdog: bcm6345: convert to use live dt

Hi.

Quoted 30 lines · Daniel Schwierzeck
Quoted 12 lines · Álvaro Fernández Rojas
Signed-off-by Álvaro Fernández Rojas <[email protected]>
---
 drivers/watchdog/bcm6345_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/bcm6345_wdt.c +0 -0
index 3ef7d438a6..90b33aadf1 100644
@@ -87,13 +87,12 @@ static int bcm6345_wdt_probe(struct udevice *dev)
 {
      struct bcm6345_wdt_priv *priv = dev_get_priv(dev);

drivers/watchdog/bcm6345_wdt.c static int bcm6345_wdt_probe(struct udevice *dev) · line 95

Quoted 10 lines
drivers/watchdog/bcm6345_wdt.c +2 -3
      fdt_addr_t addr;
-     fdt_size_t size;
 
-     addr = devfdt_get_addr_size_index(dev, 0, &size);
+     addr = dev_read_addr(dev);
      if (addr == FDT_ADDR_T_NONE)
              return -EINVAL;
 
-     priv->regs = ioremap(addr, size);
+     priv->regs = ioremap(addr, 0);

as this pattern is repeated in each driver which have to do such remapping on archs like MIPS, I suggest to add generic wrapper functions for this like:

Quoted 3 lines

void *dev_read_addr_and_remap_index(struct udevice *dev, int index)

void *dev_read_addr_and_remap(struct udevice *dev)

Sounds like a good idea to me.

Regards,
Simon