Bluetooth: L2CAP: Fix result of L2CAP_ECRED_CONN_RSP when MTU is too short
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH v2 1/1 Bluetooth: L2CAP: Fix result of L2CAP_ECRED_CONN_RSP when MTU is too short
From: Luiz Augusto von Dentz <[email protected]>
Test L2CAP/ECFC/BV-26-C expect the response to L2CAP_ECRED_CONN_REQ with and MTU value < L2CAP_ECRED_MIN_MTU (64) to be L2CAP_CR_LE_INVALID_PARAMS rather than L2CAP_CR_LE_UNACCEPT_PARAMS.
Also fix not including the correct number of CIDs in the response since the spec requires all CIDs being rejected to be included in the response.
--- include/net/bluetooth/l2cap.h | 6 +++--- net/bluetooth/l2cap_core.c | 11 +++++++---- 2 files changed, 10 insertions(+), 7 deletions(-)
include/net/bluetooth/l2cap.h +3 -3
@@ -284,9 +284,9 @@ struct l2cap_conn_rsp {#define L2CAP_CR_LE_BAD_KEY_SIZE 0x0007#define L2CAP_CR_LE_ENCRYPTION 0x0008#define L2CAP_CR_LE_INVALID_SCID 0x0009 -#define L2CAP_CR_LE_SCID_IN_USE 0X000A -#define L2CAP_CR_LE_UNACCEPT_PARAMS 0X000B -#define L2CAP_CR_LE_INVALID_PARAMS 0X000C +#define L2CAP_CR_LE_SCID_IN_USE 0x000A +#define L2CAP_CR_LE_UNACCEPT_PARAMS 0x000B +#define L2CAP_CR_LE_INVALID_PARAMS 0x000C/* connect/create channel status */ #define L2CAP_CS_NO_INFO 0x0000
net/bluetooth/l2cap_core.c +7 -4
@@ -5051,13 +5051,15 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,struct l2cap_chan *chan, *pchan;u16 mtu, mps;__le16 psm; -u8 result, len =0 ; +u8 result, rsp_len =0 ;int i, num_scid;bool defer = false;if (!enable_ecred)return -EINVAL ; +memset (pdu,0 ,sizeof (*pdu)); +if (cmd_len <sizeof (*req) || (cmd_len -sizeof (*req)) %sizeof (u16)) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;
@@ -5066,6 +5068,9 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, cmd_len -=sizeof (*req); num_scid = cmd_len /sizeof (u16); +/* Always respond with the same number of scids as in the request */ + rsp_len = cmd_len; +if (num_scid >L2CAP_ECRED_MAX_CID ) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;
@@ -5075,7 +5080,7 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, mps =__le16_to_cpu (req->mps);if (mtu <L2CAP_ECRED_MIN_MTU || mps <L2CAP_ECRED_MIN_MPS ) { - result =L2CAP_CR_LE_UNACCEPT_PARAMS ; + result =L2CAP_CR_LE_INVALID_PARAMS ; goto response; }
@@ -5095,8 +5100,6 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,BT_DBG ("psm 0x%2.2x mtu %u mps %u" ,__le16_to_cpu (psm), mtu, mps); -memset (pdu,0 ,sizeof (*pdu)); -/* Check if we have socket listening on psm */ pchan =l2cap_global_chan_by_psm (BT_LISTEN , psm, &conn->hcon->src, &conn->hcon->dst,LE_LINK );
Signature · 1 line
2.52.0
Dear Luiz,
Thank you for your patch.
Am 06.02.26 um 21:21 schrieb Luiz Augusto von Dentz:
Quoted 4 lines
From: Luiz Augusto von Dentz <[email protected]>
Test L2CAP/ECFC/BV-26-C expect the response to
L2CAP_ECRED_CONN_REQwith and MTU value <L2CAP_ECRED_MIN_MTU(64) to beL2CAP_CR_LE_INVALID_PARAMS
s/and/an/
Quoted 5 lines
rather than
L2CAP_CR_LE_UNACCEPT_PARAMS.Also fix not including the correct number of CIDs in the response since the spec requires all CIDs being rejected to be included in the response.
Could be a separate patch to make the commits smaller.
Quoted 13 lines
Fixes 15f02b910562 ("Bluetooth: L2CAP: Add initial code for Enhanced Credit Based Mode")Signed-off-by Luiz Augusto von Dentz <[email protected]>--- include/net/bluetooth/l2cap.h | 6 +++--- net/bluetooth/l2cap_core.c | 11 +++++++---- 2 files changed, 10 insertions(+), 7 deletions(-)include/net/bluetooth/l2cap.h +0
-0
include/net/bluetooth/l2cap.h struct l2cap_conn_rsp { · line 289
Quoted 9 lines
include/net/bluetooth/l2cap.h +3
-3@@ -284,9 +284,9 @@ struct l2cap_conn_rsp {#define L2CAP_CR_LE_BAD_KEY_SIZE 0x0007#define L2CAP_CR_LE_ENCRYPTION 0x0008#define L2CAP_CR_LE_INVALID_SCID 0x0009 -#define L2CAP_CR_LE_SCID_IN_USE 0X000A -#define L2CAP_CR_LE_UNACCEPT_PARAMS 0X000B -#define L2CAP_CR_LE_INVALID_PARAMS 0X000C +#define L2CAP_CR_LE_SCID_IN_USE 0x000A +#define L2CAP_CR_LE_UNACCEPT_PARAMS 0x000B +#define L2CAP_CR_LE_INVALID_PARAMS 0x000C
What changed here?
Quoted 44 lines
include/net/bluetooth/l2cap.h +0
-0/* connect/create channel status */ #define L2CAP_CS_NO_INFO 0x0000net/bluetooth/l2cap_core.c +7
-2@@ -5051,13 +5051,15 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,struct l2cap_chan *chan, *pchan;u16 mtu, mps;__le16 psm; -u8 result, len =0 ; +u8 result, rsp_len =0 ;int i, num_scid;bool defer = false;if (!enable_ecred)return -EINVAL ; +memset (pdu,0 ,sizeof (*pdu)); +if (cmd_len <sizeof (*req) || (cmd_len -sizeof (*req)) %sizeof (u16)) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;@@ -5066,6 +5068,9 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, cmd_len -=sizeof (*req); num_scid = cmd_len /sizeof (u16); +/* Always respond with the same number of scids as in the request */ + rsp_len = cmd_len; +if (num_scid >L2CAP_ECRED_MAX_CID ) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;@@ -5075,7 +5080,7 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, mps =__le16_to_cpu (req->mps);if (mtu <L2CAP_ECRED_MIN_MTU || mps <L2CAP_ECRED_MIN_MPS ) { - result =L2CAP_CR_LE_UNACCEPT_PARAMS ; + result =L2CAP_CR_LE_INVALID_PARAMS ; goto response; }
net/bluetooth/l2cap_core.c static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, · line 5105
Quoted 8 lines
net/bluetooth/l2cap_core.c +0
-2@@ -5095,8 +5100,6 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,BT_DBG ("psm 0x%2.2x mtu %u mps %u" ,__le16_to_cpu (psm), mtu, mps); -memset (pdu,0 ,sizeof (*pdu)); -/* Check if we have socket listening on psm */ pchan =l2cap_global_chan_by_psm (BT_LISTEN , psm, &conn->hcon->src, &conn->hcon->dst,LE_LINK );
Diff looks fine otherwise.
Kind regards,
Paul
Luiz Augusto von Dentz
maintainerHi Paul,
Quoted 14 lines · Paul Menzel
Dear Luiz,
Thank you for your patch.
Am 06.02.26 um 21:21 schrieb Luiz Augusto von Dentz:
Quoted 4 lines
From: Luiz Augusto von Dentz <[email protected]>
Test L2CAP/ECFC/BV-26-C expect the response to
L2CAP_ECRED_CONN_REQwith and MTU value <L2CAP_ECRED_MIN_MTU(64) to beL2CAP_CR_LE_INVALID_PARAMSs/and/an/
Quoted 7 lines
Quoted 5 lines
rather than
L2CAP_CR_LE_UNACCEPT_PARAMS.Also fix not including the correct number of CIDs in the response since the spec requires all CIDs being rejected to be included in the response.
Could be a separate patch to make the commits smaller.
Nope, would mean 2 patches would be needed to be backported to get one qualification test fixed, so I prefer to have it all fixed with one change when covering qualification tests.
Quoted 8 lines
Quoted 8 lines
Fixes 15f02b910562 ("Bluetooth: L2CAP: Add initial code for Enhanced Credit Based Mode")Signed-off-by Luiz Augusto von Dentz <[email protected]>--- include/net/bluetooth/l2cap.h | 6 +++--- net/bluetooth/l2cap_core.c | 11 +++++++---- 2 files changed, 10 insertions(+), 7 deletions(-)
Quoted 16 lines
Quoted 5 lines
include/net/bluetooth/l2cap.h +0
-0include/net/bluetooth/l2cap.h struct l2cap_conn_rsp { · line 289
Quoted 9 lines
include/net/bluetooth/l2cap.h +3
-3@@ -284,9 +284,9 @@ struct l2cap_conn_rsp {#define L2CAP_CR_LE_BAD_KEY_SIZE 0x0007#define L2CAP_CR_LE_ENCRYPTION 0x0008#define L2CAP_CR_LE_INVALID_SCID 0x0009 -#define L2CAP_CR_LE_SCID_IN_USE 0X000A -#define L2CAP_CR_LE_UNACCEPT_PARAMS 0X000B -#define L2CAP_CR_LE_INVALID_PARAMS 0X000C +#define L2CAP_CR_LE_SCID_IN_USE 0x000A +#define L2CAP_CR_LE_UNACCEPT_PARAMS 0x000B +#define L2CAP_CR_LE_INVALID_PARAMS 0x000CWhat changed here?
Typo, 0'X' vs 0x
Quoted 59 lines
Quoted 44 lines
include/net/bluetooth/l2cap.h +0
-0/* connect/create channel status */ #define L2CAP_CS_NO_INFO 0x0000net/bluetooth/l2cap_core.c +7
-2@@ -5051,13 +5051,15 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,struct l2cap_chan *chan, *pchan;u16 mtu, mps;__le16 psm; -u8 result, len =0 ; +u8 result, rsp_len =0 ;int i, num_scid;bool defer = false;if (!enable_ecred)return -EINVAL ; +memset (pdu,0 ,sizeof (*pdu)); +if (cmd_len <sizeof (*req) || (cmd_len -sizeof (*req)) %sizeof (u16)) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;@@ -5066,6 +5068,9 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, cmd_len -=sizeof (*req); num_scid = cmd_len /sizeof (u16); +/* Always respond with the same number of scids as in the request */ + rsp_len = cmd_len; +if (num_scid >L2CAP_ECRED_MAX_CID ) { result =L2CAP_CR_LE_INVALID_PARAMS ; goto response;@@ -5075,7 +5080,7 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, mps =__le16_to_cpu (req->mps);if (mtu <L2CAP_ECRED_MIN_MTU || mps <L2CAP_ECRED_MIN_MPS ) { - result =L2CAP_CR_LE_UNACCEPT_PARAMS ; + result =L2CAP_CR_LE_INVALID_PARAMS ; goto response; }net/bluetooth/l2cap_core.c static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn, · line 5105
Quoted 8 lines
net/bluetooth/l2cap_core.c +0
-2@@ -5095,8 +5100,6 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,BT_DBG ("psm 0x%2.2x mtu %u mps %u" ,__le16_to_cpu (psm), mtu, mps); -memset (pdu,0 ,sizeof (*pdu)); -/* Check if we have socket listening on psm */ pchan =l2cap_global_chan_by_psm (BT_LISTEN , psm, &conn->hcon->src, &conn->hcon->dst,LE_LINK );Diff looks fine otherwise.
Kind regards,
Paul
Signature · 1 line
Luiz Augusto von Dentz
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1051736
---Test result---
Test Summary:
CheckPatch PENDING 0.45 seconds GitLint PENDING 0.29 seconds SubjectPrefix PASS 0.07 seconds BuildKernel FAIL 20.00 seconds CheckAllWarning FAIL 22.20 seconds CheckSparse FAIL 24.61 seconds BuildKernel32 FAIL 19.37 seconds TestRunnerSetup FAIL 481.30 seconds TestRunner_l2cap-tester FAIL 0.09 seconds TestRunner_iso-tester FAIL 0.09 seconds TestRunner_bnep-tester FAIL 0.09 seconds TestRunner_mgmt-tester FAIL 0.09 seconds TestRunner_rfcomm-tester FAIL 0.09 seconds TestRunner_sco-tester FAIL 0.09 seconds TestRunner_ioctl-tester FAIL 0.09 seconds TestRunner_mesh-tester FAIL 0.09 seconds TestRunner_smp-tester FAIL 0.09 seconds TestRunner_userchan-tester FAIL 0.10 seconds IncrementalBuild PENDING 0.91 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: BuildKernel - FAIL
Desc: Build Kernel for Bluetooth
Output:
net/bluetooth/l2cap_core.c: In function ‘l2cap_ecred_conn_req’:net/bluetooth/l2cap_core.c:5127:3: error: ‘len’ undeclared (first use in this function)
5127 | len += sizeof(*pdu->dcid);
| ^~~net/bluetooth/l2cap_core.c:5127:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:287: net/bluetooth/l2cap_core.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:544: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:544: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2054: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: CheckAllWarning - FAIL
Desc: Run linux kernel with all warning enabled
Output:
net/bluetooth/l2cap_core.c: In function ‘l2cap_ecred_conn_req’:net/bluetooth/l2cap_core.c:5127:3: error: ‘len’ undeclared (first use in this function)
5127 | len += sizeof(*pdu->dcid);
| ^~~
net/bluetooth/l2cap_core.c:5127:3: note: each undeclared identifier is reported only once for each function it appears in
net/bluetooth/l2cap_core.c:5054:13: warning: variable ‘rsp_len’ set but not used [-Wunused-but-set-variable]
5054 | u8 result, rsp_len = 0;
| ^~~~~~~make[4]: *** [scripts/Makefile.build:287: net/bluetooth/l2cap_core.o] Error 1 make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:544: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:544: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2054: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: CheckSparse - FAIL
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/hci_vhci.c:717:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:718:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:720:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:721:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:722:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:723:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:723:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:724:1: error: bad constant expressiondrivers/bluetooth/hci_vhci.c:725:1: error: bad constant expressionnet/bluetooth/bnep/core.c:759:1: error: bad constant expressionnet/bluetooth/bnep/core.c:760:1: error: bad constant expressionnet/bluetooth/bnep/core.c:762:1: error: bad constant expressionnet/bluetooth/bnep/core.c:763:1: error: bad constant expressionnet/bluetooth/bnep/core.c:765:1: error: bad constant expressionnet/bluetooth/bnep/core.c:766:1: error: bad constant expressionnet/bluetooth/bnep/core.c:767:1: error: bad constant expressionnet/bluetooth/bnep/core.c:768:1: error: bad constant expressionnet/bluetooth/bnep/core.c:768:1: error: bad constant expressionnet/bluetooth/bnep/core.c:769:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1474:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1475:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1476:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1477:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1478:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1478:1: error: bad constant expressionnet/bluetooth/hidp/core.c:1479:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2273:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2274:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2276:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2277:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2279:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2280:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2282:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2283:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2284:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2285:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2285:1: error: bad constant expressionnet/bluetooth/rfcomm/core.c:2286:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:932:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:933:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:934:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:935:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:935:1: error: bad constant expressiondrivers/bluetooth/hci_ldisc.c:936:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:972:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:973:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:974:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:975:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:975:1: error: bad constant expressionnet/bluetooth/af_bluetooth.c:976:1: error: bad constant expressiondrivers/bluetooth/hci_bcsp.c:783:1: error: bad constant expressiondrivers/bluetooth/hci_bcsp.c:784:1: error: bad constant expressiondrivers/bluetooth/hci_bcsp.c:786:1: error: bad constant expressiondrivers/bluetooth/hci_bcsp.c:787:1: error: bad constant expressionnet/bluetooth/hci_core.c:85:9: warning: context imbalance in '__hci_dev_get' - different lock contexts for basic blocknet/bluetooth/hci_core.c: note: in included file (through include/linux/notifier.h, include/linux/memory_hotplug.h, include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, include/linux/radix-tree.h, ...):./include/linux/srcu.h:463:9: warning: context imbalance in 'hci_dev_put_srcu' - unexpected unlockdrivers/bluetooth/hci_bcm.c:167:1: error: bad constant expressiondrivers/bluetooth/hci_bcm.c:168:1: error: bad constant expressionnet/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):./include/net/bluetooth/hci.h:2922:47: warning: array of flexible structures./include/net/bluetooth/hci.h:3008:43: warning: array of flexible structuresdrivers/bluetooth/hci_ag6xx.c:257:24: warning: restricted __le32 degrades to integernet/bluetooth/l2cap_core.c: In function ‘l2cap_ecred_conn_req’:net/bluetooth/l2cap_core.c:5127:3: error: ‘len’ undeclared (first use in this function)
5127 | len += sizeof(*pdu->dcid);
| ^~~net/bluetooth/l2cap_core.c:5127:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:287: net/bluetooth/l2cap_core.o] Error 1
make[4]: *** Waiting for unfinished jobs....drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integer drivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer drivers/bluetooth/bcm203x.c:261:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:262:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:263:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:264:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:264:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:265:1: error: bad constant expressiondrivers/bluetooth/bcm203x.c:266:1: error: bad constant expression
make[3]: *** [scripts/Makefile.build:544: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:544: net] Error 2
make[2]: *** Waiting for unfinished jobs....drivers/bluetooth/bpa10x.c:444:1: error: bad constant expressiondrivers/bluetooth/bpa10x.c:445:1: error: bad constant expressiondrivers/bluetooth/bpa10x.c:446:1: error: bad constant expressiondrivers/bluetooth/bpa10x.c:447:1: error: bad constant expressiondrivers/bluetooth/bpa10x.c:447:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:720:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:721:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:722:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:723:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:723:1: error: bad constant expressiondrivers/bluetooth/bfusb.c:724:1: error: bad constant expressiondrivers/bluetooth/btsdio.c:372:1: error: bad constant expressiondrivers/bluetooth/btsdio.c:373:1: error: bad constant expressiondrivers/bluetooth/btsdio.c:374:1: error: bad constant expressiondrivers/bluetooth/btsdio.c:375:1: error: bad constant expressiondrivers/bluetooth/btsdio.c:375:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:533:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:534:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:535:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:536:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:536:1: error: bad constant expressiondrivers/bluetooth/ath3k.c:537:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4659:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4660:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4662:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4663:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4665:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4666:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4668:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4669:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4671:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4672:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4673:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4674:1: error: bad constant expressiondrivers/bluetooth/btusb.c:4674:1: error: bad constant expressiondrivers/bluetooth/btintel.c:3792:1: error: bad constant expression drivers/bluetooth/btintel.c:3793:1: error: bad constant expression drivers/bluetooth/btintel.c:3794:1: error: bad constant expression drivers/bluetooth/btintel.c:3795:1: error: bad constant expression drivers/bluetooth/btintel.c:3795:1: error: bad constant expression drivers/bluetooth/btintel.c:3796:1: error: bad constant expression drivers/bluetooth/btintel.c:3797:1: error: bad constant expression drivers/bluetooth/btintel.c:3798:1: error: bad constant expression drivers/bluetooth/btintel.c:3799:1: error: bad constant expression drivers/bluetooth/btmrvl_main.c:782:1: error: bad constant expression drivers/bluetooth/btmrvl_main.c:783:1: error: bad constant expression drivers/bluetooth/btmrvl_main.c:784:1: error: bad constant expression drivers/bluetooth/btmrvl_main.c:785:1: error: bad constant expression drivers/bluetooth/btmrvl_main.c:785:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1769:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1770:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1771:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1772:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1772:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1773:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1774:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1775:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1776:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1777:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1778:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1779:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1780:1: error: bad constant expression drivers/bluetooth/btmrvl_sdio.c:1781:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1556:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1557:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1559:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1560:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1561:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1562:1: error: bad constant expression drivers/bluetooth/btmtksdio.c:1562:1: error: bad constant expressiondrivers/bluetooth/btbcm.c:780:1: error: bad constant expressiondrivers/bluetooth/btbcm.c:781:1: error: bad constant expressiondrivers/bluetooth/btbcm.c:782:1: error: bad constant expressiondrivers/bluetooth/btbcm.c:783:1: error: bad constant expressiondrivers/bluetooth/btbcm.c:783:1: error: bad constant expressiondrivers/bluetooth/btmtkuart.c:994:1: error: bad constant expression drivers/bluetooth/btmtkuart.c:995:1: error: bad constant expression drivers/bluetooth/btmtkuart.c:996:1: error: bad constant expression drivers/bluetooth/btmtkuart.c:997:1: error: bad constant expression drivers/bluetooth/btmtkuart.c:997:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1514:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1515:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1516:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1517:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1517:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1518:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1519:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1520:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1521:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1522:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1523:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1524:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1525:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1526:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1527:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1528:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1529:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1530:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1531:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1532:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1533:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1534:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1535:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1536:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1537:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1538:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1539:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1540:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1541:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1542:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1543:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1544:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1545:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1546:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1547:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1548:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1549:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1550:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1551:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1552:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1553:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1554:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1555:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1556:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1557:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1558:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1559:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1560:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1561:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1562:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1563:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1564:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1565:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1566:1: error: bad constant expressiondrivers/bluetooth/btrtl.c:1567:1: error: bad constant expressiondrivers/bluetooth/btqca.c:1042:1: error: bad constant expressiondrivers/bluetooth/btqca.c:1043:1: error: bad constant expressiondrivers/bluetooth/btqca.c:1044:1: error: bad constant expressiondrivers/bluetooth/btqca.c:1044:1: error: bad constant expressiondrivers/bluetooth/hci_nokia.c:803:1: error: bad constant expression drivers/bluetooth/hci_nokia.c:804:1: error: bad constant expression drivers/bluetooth/hci_nokia.c:805:1: error: bad constant expression drivers/bluetooth/hci_nokia.c:806:1: error: bad constant expression drivers/bluetooth/hci_nokia.c:806:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1489:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1490:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1491:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1492:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1493:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1493:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1494:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1495:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1496:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1497:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1498:1: error: bad constant expressiondrivers/bluetooth/btmtk.c:1499:1: error: bad constant expression
make[1]: *** [/github/workspace/src/src/Makefile:2054: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: BuildKernel32 - FAIL
Desc: Build 32bit Kernel for Bluetooth
Output:
net/bluetooth/l2cap_core.c: In function ‘l2cap_ecred_conn_req’:net/bluetooth/l2cap_core.c:5127:3: error: ‘len’ undeclared (first use in this function)
5127 | len += sizeof(*pdu->dcid);
| ^~~net/bluetooth/l2cap_core.c:5127:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:287: net/bluetooth/l2cap_core.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:544: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:544: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2054: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: TestRunnerSetup - FAIL
Desc: Setup kernel and bluez for test-runner
Output:
Kernel:net/bluetooth/l2cap_core.c: In function ‘l2cap_ecred_conn_req’:net/bluetooth/l2cap_core.c:5127:3: error: ‘len’ undeclared (first use in this function)
5127 | len += sizeof(*pdu->dcid);
| ^~~net/bluetooth/l2cap_core.c:5127:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:287: net/bluetooth/l2cap_core.o] Error 1
make[3]: *** [scripts/Makefile.build:544: net/bluetooth] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:544: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:2054: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_bnep-tester - FAIL
Desc: Run bnep-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_rfcomm-tester - FAIL
Desc: Run rfcomm-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_ioctl-tester - FAIL
Desc: Run ioctl-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_smp-tester - FAIL
Desc: Run smp-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_userchan-tester - FAIL
Desc: Run userchan-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth