kernel/exit.c : Fix missing read_unlock
EP-F6AA0618C49C4AEDA73BFF1B39950BAB
Hi Oleg,
Quoted 26 lines
Quoted 8 lines
Hi,
From: Maninder Singh <[email protected]>
Subject: [PATCH 1/1]
kernel/exit.c: Fix missingtask_unlockThis patch adds missing
read_unlockifdo_wait_threadorptrace_do_waitreturns non zero.Confused...
wait_consider_task()should droptasklist_lockif it returns non-zero?Quoted 12 lines
kernel/exit.c +3
-1@@ -1486,12 +1486,16 @@ repeat: tsk = current; do { retval = do_wait_thread(wo, tsk); - if (retval) + if (retval) { + read_unlock(&tasklist_lock); goto end; + }
Quoted 9 lines
kernel/exit.c repeat: · line 1498
Quoted 6 lines
kernel/exit.c +3
-1retval =ptrace_do_wait (wo, tsk); -if (retval) +if (retval) { +read_unlock (&tasklist_lock); goto end; + }Well, the patch is obviously wrong. Because, again,
tasklist_lockwas already unlocked if (say)wait_task_zombie()reaps a child.
Yes, agree, My wrong
Quoted 2 lines
If you think there is a case which forgets to unlock, please tell us more.
I have checked It is getting unlocked in wait_task_zombie Sorry for unnecessary disturbance.
Quoted 1 line
Oleg.
Thanks
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºÊ‡Ú™ë,j¢f£¢·hš�ï�êÿ‘êçz_è®(階ŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨èÚ&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿÃÿ¶ìÿ¢¸?–I¥