Skip to contentSkip to conversation

2.6.25.2 - Jiffies/Time jumping back and forth (Regereesion from 2.6.24)

DISCUSSION Martin Knoblauch 1 participant 1 message May 9, 2008

lore
Share & tools
lore
#0 lore raw

----- Original Message ----

Quoted 74 lines

From: Mike Galbraith <[email protected]>
To: Thomas Gleixner <[email protected]>
Cc: Martin Knoblauch <[email protected]>; Gabriel C <[email protected]>; Bart Van Assche <[email protected]>; [email protected]; [email protected]
Sent: Thursday, May 8, 2008 7:31:28 PM
Subject: Re: 2.6.25.2 - Jiffies/Time jumping back and forth (Regereesion from 2.6.24)

Quoted 6 lines · Thomas Gleixner
Quoted 5 lines · Martin Knoblauch

on two different systems running 2.6.25.2:

ibm x3650(2xDualCore)
-------------------------------------
[root@lpsdm60 ~]# cat

/sys/devices/system/clocksource/clocksource0/available_clocksource

Quoted 2 lines
Quoted 2 lines

tsc hpet acpi_pm jiffies
[root@lpsdm60 ~]# cat

/sys/devices/system/clocksource/clocksource0/current_clocksource

Quoted 5 lines
Quoted 5 lines

tsc

HP Proliant DL-380G4 (2xSingleCore)
------------------------------------------------------------
[root@lpsdm52 ~]# cat

/sys/devices/system/clocksource/clocksource0/available_clocksource

Quoted 2 lines
Quoted 2 lines

tsc hpet acpi_pm jiffies
[root@lpsdm52 ~]# cat

/sys/devices/system/clocksource/clocksource0/current_clocksource

Quoted 5 lines
Quoted 5 lines

tsc

and on the DL380G4 running 2.6.24:
---------------------------------------------------------
[root@lpsdm52 ~]# cat

/sys/devices/system/clocksource/clocksource0/available_clocksource

Quoted 2 lines
Quoted 2 lines

hpet acpi_pm jiffies tsc
[root@lpsdm52 ~]# cat

/sys/devices/system/clocksource/clocksource0/current_clocksource

Quoted 4 lines
Quoted 1 line

hpet

So on 2.6.24 the TSC is declared unstable at some point and 2.6.25 thinks it works fine. Is this the same kernel config (aside of the 24/25 fuzz)

?

I had a problem with my P4's tsc being declared unstable after S2R. I carry this patchlet (it's in mainline) in my 2.6.24 kernels to keep the TSC operational. (browsing, dunno if it's the same problem, but it might be..)

arch/x86/kernel/tsc_sync.c +1 -8
index 9125efe..05d8f25 100644
@@ -129,24 +129,24 @@ void __cpuinit check_tsc_sync_source(int cpu)
    while (atomic_read(&stop_count) != cpus-1)
        cpu_relax();
 
-    /*
-     * Reset it - just in case we boot another CPU later:
-     */
-    atomic_set(&start_count, 0);
-
    if (nr_warps) {
        printk("\n");
        printk(KERN_WARNING "Measured %Ld cycles TSC warp between CPUs,"
                    " turning off TSC clock.\n", max_warp);
        mark_tsc_unstable("check_tsc_sync_source failed");
-        nr_warps = 0;
-        max_warp = 0;
-        last_tsc = 0;
    } else {
        printk(" passed.\n");
    }
 
    /*
+     * Reset it - just in case we boot another CPU later:

arch/x86/kernel/tsc_sync.c void __cpuinit check_tsc_sync_source(int cpu) · line 152

Quoted 10 lines
arch/x86/kernel/tsc_sync.c +7 -0
+     */
+    atomic_set(&start_count, 0);
+    nr_warps = 0;
+    max_warp = 0;
+    last_tsc = 0;
+
+    /*
     * Let the target continue with the bootup:
     */
    atomic_inc(&stop_count);

Not sure, as I never had this problem in 2.6.24 - started with 2.6.25.2. But trying does not cost ...

...

Nope. That patch is indeed already in 2.6.25.2.

Cheers
Martin