usb: gadget: rockchip: Add missing dependency
PATCH 1/2 usb: gadget: rockchip: Add missing dependency
The rockchip usb gadget driver cannot build without platform specific headers being available. Express that requirement in Kconfig as well.
---
Cc: Kever Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
--- drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/usb/gadget/Kconfig +1 -0
@@ -202,6 +202,7 @@ config USB_FUNCTION_MASS_STORAGE config USB_FUNCTION_ROCKUSB bool "Enable USB rockusb gadget" + depends on ARCH_ROCKCHIP help Rockusb protocol is widely used by Rockchip SoC based devices. It can read/write info, image to/from devices. This enables the USB part of
Signature · 1 line
2.43.0
PATCH 2/2 usb: gadget: rockchip: Fix spacing around the Kconfig option
This Kconfig option used spaces and not tabs for indentation. Switch to tabs.
---
Cc: Kever Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
--- drivers/usb/gadget/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/usb/gadget/Kconfig +6 -6
@@ -201,13 +201,13 @@ config USB_FUNCTION_MASS_STORAGE the eMMC/SD card content to HOST PC so it can be mounted. config USB_FUNCTION_ROCKUSB - bool "Enable USB rockusb gadget" + bool "Enable USB rockusb gadget" depends on ARCH_ROCKCHIP - help - Rockusb protocol is widely used by Rockchip SoC based devices. It can - read/write info, image to/from devices. This enables the USB part of - the rockusb gadget.for more detail about Rockusb protocol, please see - doc/README.rockusb + help + Rockusb protocol is widely used by Rockchip SoC based devices. It can + read/write info, image to/from devices. This enables the USB part of + the rockusb gadget.for more detail about Rockusb protocol, please see + doc/README.rockusb config USB_FUNCTION_SDP bool "Enable USB SDP (Serial Download Protocol)"
Signature · 1 line
2.43.0
Re: [PATCH 2/2] usb: gadget: rockchip: Fix spacing around the Kconfig option
Hi Tom,
Quoted 4 lines · Tom Rini
This
Kconfigoption used spaces and not tabs for indentation. Switch to tabs.Signed-off-by Tom Rini <[email protected]>
Thanks!
Quentin
Re: [PATCH 2/2] usb: gadget: rockchip: Fix spacing around the Kconfig option
In reply to Tom RiniQuoted 7 lines · Tom Rini
This
Kconfigoption used spaces and not tabs for indentation. Switch to tabs.Signed-off-by Tom Rini <[email protected]>---
Cc: Kever Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Thanks,
- Kever
Quoted 28 lines
--- drivers/usb/gadget/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/usb/gadget/Kconfig +6
-6@@ -201,13 +201,13 @@ config USB_FUNCTION_MASS_STORAGE the eMMC/SD card content to HOST PC so it can be mounted. config USB_FUNCTION_ROCKUSB - bool "Enable USB rockusb gadget" + bool "Enable USB rockusb gadget" depends on ARCH_ROCKCHIP - help - Rockusb protocol is widely used by Rockchip SoC based devices. It can - read/write info, image to/from devices. This enables the USB part of - the rockusb gadget.for more detail about Rockusb protocol, please see - doc/README.rockusb + help + Rockusb protocol is widely used by Rockchip SoC based devices. It can + read/write info, image to/from devices. This enables the USB part of + the rockusb gadget.for more detail about Rockusb protocol, please see + doc/README.rockusb config USB_FUNCTION_SDP bool "Enable USB SDP (Serial Download Protocol)"
Signature · 7 lines
Thanks & Best regards, Kever Yang ************************************************************************************************** 杨凯 市场部 Kever Yang Marketing Department 瑞芯微电子股份有限公司 Rockchip Electronics Co.,Ltd。 地址:福建省福州市铜盘路软件大道89号软件园A区18号楼 (350003) Addr : No.18 Building,A District,No.89,Fuzhou Software Boulevard,Fuzhou,Fujian,PRC
Hi Tom,
Quoted 4 lines · Tom Rini
The rockchip usb gadget driver cannot build without platform specific headers being available. Express that requirement in
Kconfigas well.Signed-off-by Tom Rini <[email protected]>
Thanks!
Quentin
Quoted 7 lines · Tom Rini
The rockchip usb gadget driver cannot build without platform specific headers being available. Express that requirement in
Kconfigas well.Signed-off-by Tom Rini <[email protected]>---
Cc: Kever Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Thanks,
- Kever
Quoted 16 lines
--- drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/usb/gadget/Kconfig +1
-0@@ -202,6 +202,7 @@ config USB_FUNCTION_MASS_STORAGE config USB_FUNCTION_ROCKUSB bool "Enable USB rockusb gadget" + depends on ARCH_ROCKCHIP help Rockusb protocol is widely used by Rockchip SoC based devices. It can read/write info, image to/from devices. This enables the USB part of
Signature · 7 lines
Thanks & Best regards, Kever Yang ************************************************************************************************** 杨凯 市场部 Kever Yang Marketing Department 瑞芯微电子股份有限公司 Rockchip Electronics Co.,Ltd。 地址:福建省福州市铜盘路软件大道89号软件园A区18号楼 (350003) Addr : No.18 Building,A District,No.89,Fuzhou Software Boulevard,Fuzhou,Fujian,PRC