Bluetooth: btintel_pcie: Use struct_size to improve hci_drv_read_info
PATCH 1/1 Bluetooth: btintel_pcie: Use struct_size to improve hci_drv_read_info
Use struct_size(), which provides additional compile-time checks for structures with flexible array members (e.g., __must_be_array()), to determine the allocation size for a new 'struct hci_drv_rp_read_info'.
--- drivers/bluetooth/btintel_pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bluetooth/btintel_pcie.c +2 -1
@@ -9,6 +9,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/firmware.h> +#include <linux/overflow.h> #include <linux/pci.h> #include <linux/string.h> #include <linux/wait.h>
@@ -2373,7 +2374,7 @@ static int btintel_pcie_hci_drv_read_info(struct hci_dev *hdev, void *data,u16 opcode, num_supported_commands =ARRAY_SIZE (btintel_pcie_hci_drv_supported_commands); - rp_size =sizeof (*rp) + num_supported_commands *2 ; + rp_size =struct_size (rp, supported_commands, num_supported_commands); rp =kmalloc (rp_size,GFP_KERNEL );if (!rp)
Signature · 2 lines
Thorsten Blum <[email protected]> GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1056905
---Test result---
Test Summary:
CheckPatch PENDING 0.31 seconds GitLint PENDING 0.28 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 25.71 seconds CheckAllWarning PASS 28.26 seconds CheckSparse PASS 31.34 seconds BuildKernel32 PASS 24.94 seconds TestRunnerSetup PASS 555.80 seconds TestRunner_l2cap-tester PASS 28.49 seconds TestRunner_iso-tester PASS 108.08 seconds TestRunner_bnep-tester PASS 6.34 seconds TestRunner_mgmt-tester FAIL 117.06 seconds TestRunner_rfcomm-tester PASS 10.04 seconds TestRunner_sco-tester FAIL 14.47 seconds TestRunner_ioctl-tester PASS 10.26 seconds TestRunner_mesh-tester FAIL 11.53 seconds TestRunner_smp-tester PASS 8.66 seconds TestRunner_userchan-tester PASS 6.78 seconds IncrementalBuild PENDING 0.76 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.105 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.822 seconds Mesh - Send cancel - 2 Timed out 1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Tue, 24 Feb 2026 00:33:42 +0100 you wrote:
Use
struct_size(), which provides additional compile-time checks for structures with flexible array members (e.g.,__must_be_array()), to determine the allocation size for a new 'structhci_drv_rp_read_info'.Signed-off-by Thorsten Blum <[email protected]>--- drivers/bluetooth/btintel_pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- Bluetooth: btintel_pcie: Use struct_size to improve hci_drv_read_info
https://git.kernel.org/bluetooth/bluetooth-next/c/932fa6b5adb7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html