Skip to contentSkip to conversation

Revert "drm/amdgpu: Set no-retry as default."

PATCH In review Alex Deucher 3 participants 3 messages Jan 6, 2020 – Jan 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "drm/amdgpu: Set no-retry as default."

This reverts commit 51bfac71cade386966791a8db87a5912781d249f.

This causes stability issues on some raven boards. Revert for now until a proper fix is completed.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -2
index 0ffc9447b573..3036ec883fb4 100644
@@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
 int amdgpu_mcbp = 0;
 int amdgpu_discovery = -1;
 int amdgpu_mes = 0;
-int amdgpu_noretry = 1;
+int amdgpu_noretry;
 int amdgpu_force_asic_type = -1;
 
 struct amdgpu_mgpu_info mgpu_info = {
@@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
 module_param_named(mes, amdgpu_mes, int, 0444);
 
 MODULE_PARM_DESC(noretry,
-	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
+	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
 module_param_named(noretry, amdgpu_noretry, int, 0644);
 
 /**
Signature · 6 lines
2.24.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Alex Deucher

This reverts commit 51bfac71cade386966791a8db87a5912781d249f.

This causes stability issues on some raven boards. Revert for now until a proper fix is completed.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
index 0ffc9447b573..3036ec883fb4 100644
@@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
  int amdgpu_mcbp = 0;
  int amdgpu_discovery = -1;
  int amdgpu_mes = 0;
-int amdgpu_noretry = 1;
+int amdgpu_noretry;
  int amdgpu_force_asic_type = -1;
 
  struct amdgpu_mgpu_info mgpu_info = {

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c MODULE_PARM_DESC(mes, · line 594

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
@@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
  module_param_named(mes, amdgpu_mes, int, 0444);
 
  MODULE_PARM_DESC(noretry,
-	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
+	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
  module_param_named(noretry, amdgpu_noretry, int, 0644);
 
  /**

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Alex Deucher

Am 06.01.20 um 21:45 schrieb Alex Deucher:

Quoted 8 lines

This reverts commit 51bfac71cade386966791a8db87a5912781d249f.

This causes stability issues on some raven boards. Revert for now until a proper fix is completed.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
index 0ffc9447b573..3036ec883fb4 100644
@@ -142,7 +142,7 @@ int amdgpu_async_gfx_ring = 1;
  int amdgpu_mcbp = 0;
  int amdgpu_discovery = -1;
  int amdgpu_mes = 0;
-int amdgpu_noretry = 1;
+int amdgpu_noretry;
  int amdgpu_force_asic_type = -1;
 
  struct amdgpu_mgpu_info mgpu_info = {

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c MODULE_PARM_DESC(mes, · line 594

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
@@ -588,7 +588,7 @@ MODULE_PARM_DESC(mes,
  module_param_named(mes, amdgpu_mes, int, 0444);
 
  MODULE_PARM_DESC(noretry,
-	"Disable retry faults (0 = retry enabled, 1 = retry disabled (default))");
+	"Disable retry faults (0 = retry enabled (default), 1 = retry disabled)");
  module_param_named(noretry, amdgpu_noretry, int, 0644);
 
  /**

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx