Skip to contentSkip to conversation

x86: work around build issue with GNU ld 2.37

PATCH In review Jan Beulich 2 participants 6 messages Jul 22, 2021 – Aug 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: work around build issue with GNU ld 2.37

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

xen/arch/x86/xen.lds.S +1 -1
@@ -18,7 +18,7 @@ ENTRY(efi_start)
 #else /* !EFI */
 
 #define FORMAT "elf64-x86-64"
-#define DECL_SECTION(x) x : AT(ADDR(x) - __XEN_VIRT_START)
+#define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START)
 
 ENTRY(start_pa)
 
#1 lore raw
Quoted 5 lines · Jan Beulich

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Are binutils going to fix their testing to reduce the number of serious regressions they're releasing?

Quoted 5 lines

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

I guess we've got no choice.  Acked-by: Andrew Cooper <[email protected]>

Quoted 13 lines
xen/arch/x86/xen.lds.S +1 -1
@@ -18,7 +18,7 @@ ENTRY(efi_start)
 #else /* !EFI */
 
 #define FORMAT "elf64-x86-64"
-#define DECL_SECTION(x) x : AT(ADDR(x) - __XEN_VIRT_START)
+#define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START)
 
 ENTRY(start_pa)
 
#2 lore raw
Quoted 9 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Are binutils going to fix their testing to reduce the number of serious regressions they're releasing?

To be honest - I simply don't know.

Quoted 7 lines
Quoted 4 lines

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

I guess we've got no choice.  Acked-by: Andrew Cooper <[email protected]>

Thanks. I see you've committed this already.

Jan

#3 lore raw
Quoted 11 lines · Jan Beulich
Quoted 8 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Are binutils going to fix their testing to reduce the number of serious regressions they're releasing?

To be honest - I simply don't know.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

I guess we've got no choice.  Acked-by: Andrew Cooper <[email protected]>

Thanks. I see you've committed this already.

Actually, it unilaterally breaks FreeBSD builds:
https://cirrus-ci.com/task/5417332467040256

I'm not sure why my build tests didn't notice, but obviously this patch isn't a workable option.

~Andrew

#4 lore raw
Quoted 18 lines · Andrew Cooper
Quoted 17 lines · Jan Beulich
Quoted 8 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Are binutils going to fix their testing to reduce the number of serious regressions they're releasing?

To be honest - I simply don't know.

Quoted 6 lines
Quoted 4 lines

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

I guess we've got no choice.  Acked-by: Andrew Cooper <[email protected]>

Quoted 7 lines
Quoted 1 line

Thanks. I see you've committed this already.

Actually, it unilaterally breaks FreeBSD builds:
https://cirrus-ci.com/task/5417332467040256

I'm not sure why my build tests didn't notice, but obviously this patch isn't a workable option.

I'm confused: Is the tool called "ld" there something that's not only not GNU ld, but not even compatible with GNU ld? (Iirc clang's linker is named differently. Or maybe that's just on Linux? In any event I've just checked with clang5 [on Linux], and the build worked fine there. But this looks to be using GNU ld irrespective of the compiler choice, and I also don't seem to have anything named "llvm-ld" on that system, despite there being a lot of other "llvm-*".)

Jan

#5 lore raw
Quoted 27 lines · Jan Beulich
Quoted 18 lines · Andrew Cooper
Quoted 17 lines · Jan Beulich
Quoted 8 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich

I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer accepting section names with a dash in them inside ADDR() (and perhaps other script directives expecting just a section name, not an expression): .note.gnu.build-id is such a section.

Are binutils going to fix their testing to reduce the number of serious regressions they're releasing?

To be honest - I simply don't know.

Quoted 6 lines
Quoted 4 lines

Quoting all section names passed to ADDR() via DECL_SECTION() works around the regression.

I guess we've got no choice.  Acked-by: Andrew Cooper <[email protected]>

Quoted 7 lines
Quoted 1 line

Thanks. I see you've committed this already.

Actually, it unilaterally breaks FreeBSD builds:
https://cirrus-ci.com/task/5417332467040256

I'm not sure why my build tests didn't notice, but obviously this patch isn't a workable option.

Quoted 7 lines

I'm confused: Is the tool called "ld" there something that's not only not GNU ld, but not even compatible with GNU ld? (Iirc clang's linker is named differently. Or maybe that's just on Linux? In any event I've just checked with clang5 [on Linux], and the build worked fine there. But this looks to be using GNU ld irrespective of the compiler choice, and I also don't seem to have anything named "llvm-ld" on that system, despite there being a lot of other "llvm-*".)

So I've looked at their man pages. From version 11 to version 12 the linker changed from GNU ld to LLVM's. Interestingly the respective man page says

ld.lld is a drop-in replacement for the GNU BFD and gold linkers. It ac-
cepts most of the same command line arguments and linker scripts as GNU
linkers.

To me "most of the same" isn't quite enough to claim "drop-in replacement", but I guess that's just me ... Anyway - short of Roger being around to ask, I'll try to locate a means to tell the two apart from a linker script.

Jan