Bluetooth: SCO: Fix use-after-free in sco_recv_frame() due to missing sock_hold
Subsystems (2)
PATCH 1/1 Bluetooth: SCO: Fix use-after-free in sco_recv_frame() due to missing sock_hold
sco_recv_frame() reads conn->sk under sco_conn_lock() but immediately releases the lock without holding a reference to the socket. A concurrent close() can free the socket between the lock release and the subsequent sk->sk_state access, resulting in a use-after-free.
Other functions in the same file (sco_sock_timeout(), sco_conn_del()) correctly use sco_sock_hold() to safely hold a reference under the lock.
Fix by using sco_sock_hold() to take a reference before releasing the lock, and adding sock_put() on all exit paths.
--- net/bluetooth/sco.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
net/bluetooth/sco.c +7 -3
@@ -401,7 +401,7 @@ static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb)struct sock *sk;sco_conn_lock (conn); - sk = conn->sk; + sk =sco_sock_hold (conn);sco_conn_unlock (conn);if (!sk)
@@ -410,11 +410,15 @@ static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb)BT_DBG ("sk %p len %u" , sk, skb->len);if (sk->sk_state !=BT_CONNECTED ) - goto drop; + goto drop_put; -if (!sock_queue_rcv_skb (sk, skb)) +if (!sock_queue_rcv_skb (sk, skb)) { +sock_put (sk);return ; + } +drop_put: +sock_put (sk); drop:kfree_skb (skb); }
Signature · 1 line
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1065910
---Test result---
Test Summary:
CheckPatch PENDING 0.45 seconds GitLint PENDING 0.41 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 26.58 seconds CheckAllWarning PASS 29.11 seconds CheckSparse WARNING 32.70 seconds BuildKernel32 PASS 25.66 seconds TestRunnerSetup PASS 577.00 seconds TestRunner_l2cap-tester PASS 28.96 seconds TestRunner_iso-tester PASS 66.37 seconds TestRunner_bnep-tester PASS 6.33 seconds TestRunner_mgmt-tester FAIL 127.44 seconds TestRunner_rfcomm-tester PASS 9.75 seconds TestRunner_sco-tester FAIL 15.23 seconds TestRunner_ioctl-tester PASS 10.57 seconds TestRunner_mesh-tester FAIL 12.47 seconds TestRunner_smp-tester PASS 9.00 seconds TestRunner_userchan-tester PASS 6.95 seconds IncrementalBuild PENDING 0.68 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:net/bluetooth/sco.c: note: in included file:./include/net/bluetooth/hci_core.h:153:35: warning: array of flexible structuresnet/bluetooth/sco.c:1607:1: error: bad constant expressionnet/bluetooth/sco.c:1608:1: error: bad constant expression
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.111 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.590 seconds Mesh - Send cancel - 2 Timed out 1.994 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Fri, 13 Mar 2026 05:26:16 +0900 you wrote:
sco_recv_frame()readsconn->skundersco_conn_lock()but immediately releases the lock without holding a reference to the socket. A concurrentclose()can free the socket between the lock release and the subsequentsk->sk_stateaccess, resulting in a use-after-free.Other functions in the same file (
sco_sock_timeout(),sco_conn_del()) correctly usesco_sock_hold()to safely hold a reference under the lock.[...]
Here is the summary with links:
- Bluetooth: SCO: Fix use-after-free in sco_recv_frame() due to missing sock_hold
https://git.kernel.org/bluetooth/bluetooth-next/c/506c02824131
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html