Skip to contentSkip to conversation

X.org: needs dynamic library support

PATCH New Thomas De Schampheleire 2 participants 2 messages Dec 6, 2013 – Dec 7, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 X.org: needs dynamic library support

xlib_libX11, one of the main libraries of X.org, uses dlfcn.h and dlopen. To avoid having to add a dependency on !BR2_PREFER_STATIC_LIB on tons of packages, we promote this dependency to X.org itself (similar to how thread support is handled in X.org).

Fixes
http://autobuild.buildroot.net/results/a47/a47c5d96f880af04b85bb6773e87d04f9d7c2864/

---
 package/x11r7/Config.in |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
package/x11r7/Config.in +3 -2
@@ -2,6 +2,7 @@ menuconfig BR2_PACKAGE_XORG7
 	bool "X.org X Window System"
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB # dlopen in xlib_libX11
 	help
 	  Support for X11R7 libraries, servers, drivers, and/or
 	  applications in the target.
@@ -262,5 +263,5 @@ if BR2_PACKAGE_XORG7
 	endmenu
 endif
 
-comment "X.org needs a toolchain w/ wchar, threads"
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+comment "X.org needs a toolchain w/ wchar, threads, dynamic library"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
#1 lore raw

PATCH 1/1 X.org: needs dynamic library support

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

xlib_libX11, one of the main libraries of X.org, uses dlfcn.h and dlopen. To avoid having to add a dependency on !BR2_PREFER_STATIC_LIB on tons of packages, we promote this dependency to X.org itself (similar to how thread support is handled in X.org).

Fixes
http://autobuild.buildroot.net/results/a47/a47c5d96f880af04b85bb6773e87d04f9d7c2864/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard