Skip to contentSkip to conversation

espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

PATCH New Heinrich Schuchardt 5 participants 7 messages Sep 5, 2020 – Oct 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used for espresso7420_defconfig.

---
 include/configs/espresso7420.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/espresso7420.h +0 -3
index 5aeb009f03..2495db93f8 100644
@@ -18,9 +18,6 @@
 #define CONFIG_SPL_STACK		CONFIG_IRAM_END
 #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_IRAM_END
 
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
-
 /* DRAM Memory Banks */
 #define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
 

--
2.28.0

#1 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Hello Thomas,

I tried to send an U-Boot patch to Thomas Abraham <[email protected]>. But the email address thomas.ab at samsung.com does not exist anymore.

I assume that you are the same person.

What shall happen with board/samsung/espresso7420/MAINTAINERS?

Best regards

Heinrich

-------- Forwarded Message --------
Subject: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
Date: Sat, 5 Sep 2020 12:02:10 +0200
From: Heinrich Schuchardt <[email protected]>
To: Thomas Abraham <[email protected]>
CC: u-boot at lists.denx.de, Heinrich Schuchardt <[email protected]>

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used for espresso7420_defconfig.

---
 include/configs/espresso7420.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/espresso7420.h +0 -3
index 5aeb009f03..2495db93f8 100644
@@ -18,9 +18,6 @@
 #define CONFIG_SPL_STACK		CONFIG_IRAM_END
 #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_IRAM_END
 
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
-
 /* DRAM Memory Banks */
 #define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
 

--
2.28.0

#2 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Sorry, Heinrich. Unfortunately, we are not the same person.

Best regards,

Tom Abraham

Quoted 45 lines · Heinrich Schuchardt

Hello Thomas,

I tried to send an U-Boot patch to Thomas Abraham <[email protected]>. But the email address thomas.ab at samsung.com does not exist anymore.

I assume that you are the same person.

What shall happen with board/samsung/espresso7420/MAINTAINERS?

Best regards

Heinrich

-------- Forwarded Message --------
Subject: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
Date: Sat, 5 Sep 2020 12:02:10 +0200
From: Heinrich Schuchardt <[email protected]>
To: Thomas Abraham <[email protected]>
CC: u-boot at lists.denx.de, Heinrich Schuchardt <[email protected]>

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used for espresso7420_defconfig.

---
 include/configs/espresso7420.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/espresso7420.h +0 -4
index 5aeb009f03..2495db93f8 100644
@@ -18,9 +18,6 @@
 #define CONFIG_SPL_STACK		CONFIG_IRAM_END
 #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_IRAM_END
 
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
-
 /* DRAM Memory Banks */
 #define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
 
--
Quoted 2 lines

2.28.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 1753 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200906/8cc0d435/attachment.key>

#3 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

In reply to Heinrich Schuchardt
Quoted 4 lines · Heinrich Schuchardt

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used for espresso7420_defconfig.

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict there're quite some boards with it set but unused:
include/configs/arndale.h
include/configs/peach-pi.h
include/configs/peach-pit.h
include/configs/smdk5250.h
include/configs/smdkv310.h
include/configs/snow.h
include/configs/spring.h

This one even defines it twice (looks like a rebase gone wrong), still unused:
include/configs/smdk5420.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"

Last but not least:
include/configs/origen.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
"console=ttySAC2,115200n8\0"

Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.

Regards,
Andre

Quoted 21 lines
---
  include/configs/espresso7420.h | 3 ---
  1 file changed, 3 deletions(-)
include/configs/espresso7420.h +0 -4
index 5aeb009f03..2495db93f8 100644
@@ -18,9 +18,6 @@
  #define CONFIG_SPL_STACK		CONFIG_IRAM_END
  #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_IRAM_END
 
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
-
  /* DRAM Memory Banks */
  #define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
 
--

2.28.0

#4 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Quoted 9 lines · Andre Heider
Quoted 5 lines · Heinrich Schuchardt

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict there're quite some boards with it set but unused:

Thanks for reviewing. As the boards have different maintainers we should treat them in separate patches.

Best regards

Heinrich

Quoted 47 lines

include/configs/arndale.h
include/configs/peach-pi.h
include/configs/peach-pit.h
include/configs/smdk5250.h
include/configs/smdkv310.h
include/configs/snow.h
include/configs/spring.h

This one even defines it twice (looks like a rebase gone wrong), still unused:
include/configs/smdk5420.h
#define CONFIG_DEFAULT_CONSOLE??? "console=ttySAC1,115200n8\0" #define CONFIG_DEFAULT_CONSOLE??????? "console=ttySAC1,115200n8\0"

Last but not least:
include/configs/origen.h
#define CONFIG_DEFAULT_CONSOLE??????? "console=ttySAC1,115200n8\0" "console=ttySAC2,115200n8\0"

Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.

Regards,
Andre

Quoted 22 lines

---
? include/configs/espresso7420.h | 3 ---
? 1 file changed, 3 deletions(-)

include/configs/espresso7420.h +0 -0
index 5aeb009f03..2495db93f8 100644
@@ -18,9 +18,6 @@

? #define CONFIG_SPL_STACK??????? CONFIG_IRAM_END ? #define CONFIG_SYS_INIT_SP_ADDR??????? CONFIG_IRAM_END

include/configs/espresso7420.h +0 -3
-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE??? "console=ttySAC1,115200n8\0"
-

? /* DRAM Memory Banks */
? #define SDRAM_BANK_SIZE??????? (256UL << 20UL)??? /* 256 MB */

--
2.28.0

#5 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Dear Heinrich Schuchardt,

Quoted 6 lines · Heinrich Schuchardt
Quoted 5 lines · Andre Heider
Quoted 4 lines · Heinrich Schuchardt

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict there're quite some boards with it set but unused:

Thanks for reviewing. As the boards have different maintainers we should treat them in separate patches.

Because those are all Samsung boards, I can approve them.
If you want please send changes to patch-set or single patch with adding maintainers as a CC.

thomas.ab seems to exited from company.
I will find new maintainer soon.

Thanks,
Minkyu Kang.

#6 lore raw

PATCH 1/1 espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Dear Heinrich Schuchardt,

Quoted 22 lines · Minkyu Kang

Dear Heinrich Schuchardt,

Quoted 6 lines · Heinrich Schuchardt
Quoted 5 lines · Andre Heider
Quoted 4 lines · Heinrich Schuchardt

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict there're quite some boards with it set but unused:

Thanks for reviewing. As the boards have different maintainers we should treat them in separate patches.

Because those are all Samsung boards, I can approve them.
If you want please send changes to patch-set or single patch with adding maintainers as a CC.

Quoted 7 lines

thomas.ab seems to exited from company.
I will find new maintainer soon.

Thanks,
Minkyu Kang.

Your patch was replaced by Heider's patch.
I added your signed-off at that patch.