Skip to contentSkip to conversation

arm64: dts: hisilicon: hi3798cv200: Drop unused clock-names and reset-names

PATCH Applied Krzysztof Kozlowski 2 participants 2 messages Jun 25 – Jul 7

Subsystems (2)
Device tree bindings Arm/HiSilicon SoC support
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/1 arm64: dts: hisilicon: hi3798cv200: Drop unused clock-names and reset-names

Neither Linux drivers nor DT bindings ever described or used clock-names and reset-names for this SoC. The binding allows clock-names only for atmel,at91sam9g45-ehci and atmel,at91rm9200-ohci, but not for HiSilicon. reset-names were never allowed.

Drop them from DTS to fix dtbs_check warnings:

hi3798cv200-poplar.dtb: usb@9880000 (generic-ohci): False schema does not allow ['bus', 'clk12', 'clk48'] hi3798cv200-poplar.dtb: usb@9880000 (generic-ohci): Unevaluated properties are not allowed ('reset-names' was unexpected)

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi +0 -4
index 2f4ad5da5e33..e5010c9d4c39 100644
@@ -633,9 +633,7 @@ ohci: usb@9880000 {
 			clocks = <&crg HISTB_USB2_BUS_CLK>,
 				 <&crg HISTB_USB2_12M_CLK>,
 				 <&crg HISTB_USB2_48M_CLK>;
-			clock-names = "bus", "clk12", "clk48";
 			resets = <&crg 0xb8 12>;
-			reset-names = "bus";
 			phys = <&usb2_phy1_port0>;
 			phy-names = "usb";
 			status = "disabled";

@@ -648,11 +646,9 @@ ehci: usb@9890000 {
 			clocks = <&crg HISTB_USB2_BUS_CLK>,
 				 <&crg HISTB_USB2_PHY_CLK>,
 				 <&crg HISTB_USB2_UTMI_CLK>;
-			clock-names = "bus", "phy", "utmi";
 			resets = <&crg 0xb8 12>,
 				 <&crg 0xb8 16>,
 				 <&crg 0xb8 13>;
-			reset-names = "bus", "phy", "utmi";
 			phys = <&usb2_phy1_port0>;
 			phy-names = "usb";
 			status = "disabled";
Signature · 1 line
2.53.0
maintainer Applied
#1 lore raw

Hi Krzysztof,

Quoted 32 lines · Krzysztof Kozlowski

Neither Linux drivers nor DT bindings ever described or used clock-names and reset-names for this SoC. The binding allows clock-names only for atmel,at91sam9g45-ehci and atmel,at91rm9200-ohci, but not for HiSilicon. reset-names were never allowed.

Drop them from DTS to fix dtbs_check warnings:

hi3798cv200-poplar.dtb: usb@9880000 (generic-ohci): False schema does not allow ['bus', 'clk12', 'clk48'] hi3798cv200-poplar.dtb: usb@9880000 (generic-ohci): Unevaluated properties are not allowed ('reset-names' was unexpected)

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi +0 -2
index 2f4ad5da5e33..e5010c9d4c39 100644
@@ -633,9 +633,7 @@ ohci: usb@9880000 {
 			clocks = <&crg HISTB_USB2_BUS_CLK>,
 				 <&crg HISTB_USB2_12M_CLK>,
 				 <&crg HISTB_USB2_48M_CLK>;
-			clock-names = "bus", "clk12", "clk48";
 			resets = <&crg 0xb8 12>;
-			reset-names = "bus";
 			phys = <&usb2_phy1_port0>;
 			phy-names = "usb";
 			status = "disabled";

@@ -648,11 +646,9 @@ ehci: usb@9890000 {
 			clocks = <&crg HISTB_USB2_BUS_CLK>,

arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi ehci: usb@9890000 { · line 654

Quoted 10 lines
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi +0 -2
 				 <&crg HISTB_USB2_PHY_CLK>,
 				 <&crg HISTB_USB2_UTMI_CLK>;
-			clock-names = "bus", "phy", "utmi";
 			resets = <&crg 0xb8 12>,
 				 <&crg 0xb8 16>,
 				 <&crg 0xb8 13>;
-			reset-names = "bus", "phy", "utmi";
 			phys = <&usb2_phy1_port0>;
 			phy-names = "usb";
 			status = "disabled";

Applied to the HiSilicon arm64 dt tree.
Thanks!

Best Regards,
Wei