Bluetooth: MGMT: Fix backward compatibility with userspace
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH 1/1 Bluetooth: MGMT: Fix backward compatibility with userspace
From: Luiz Augusto von Dentz <[email protected]>
bluetoothd has a bug with makes it send extra bytes as part of MGMT_OP_ADD_EXT_ADV_DATA which are now being checked to be the exact the expected length, relax this so only when the expected length is greater than the data length to cause an error since that would result in accessing invalid memory, otherwise just ignore the extra bytes.
--- net/bluetooth/mgmt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/bluetooth/mgmt.c +3 -2
@@ -9114,8 +9114,9 @@ static int add_ext_adv_data(struct sock *sk, struct hci_dev *hdev, void *data,BT_DBG ("%s" , hdev->name); - expected_len =struct_size (cp, data, cp->adv_data_len + cp->scan_rsp_len); -if (expected_len != data_len) + expected_len =struct_size (cp, data, cp->adv_data_len + + cp->scan_rsp_len); +if (expected_len > data_len)return mgmt_cmd_status (sk, hdev->id,MGMT_OP_ADD_EXT_ADV_DATA ,MGMT_STATUS_INVALID_PARAMS );
Signature · 1 line
2.54.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1104852
---Test result---
Test Summary:
CheckPatch PASS 0.74 seconds VerifyFixes PASS 0.14 seconds VerifySignedoff PASS 0.14 seconds GitLint PASS 0.33 seconds SubjectPrefix PASS 0.13 seconds BuildKernel PASS 27.61 seconds CheckAllWarning PASS 29.95 seconds CheckSparse PASS 28.55 seconds BuildKernel32 PASS 26.59 seconds TestRunnerSetup PASS 590.34 seconds TestRunner_mgmt-tester FAIL 223.41 seconds TestRunner_mesh-tester FAIL 27.00 seconds IncrementalBuild PASS 26.37 seconds
Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.253 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.645 seconds Mesh - Send cancel - 2 Timed out 1.988 seconds
https://github.com/bluez/bluetooth-next/pull/277
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 10 lines · On Tue, 2 Jun 2026 16:56:59 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
bluetoothd has a bug with makes it send extra bytes as part of
MGMT_OP_ADD_EXT_ADV_DATAwhich are now being checked to be the exact the expected length, relax this so only when the expected length is greater than the data length to cause an error since that would result in accessing invalid memory, otherwise just ignore the extra bytes.[...]
Here is the summary with links:
- [v1] Bluetooth: MGMT: Fix backward compatibility with userspace
https://git.kernel.org/bluetooth/bluetooth-next/c/149324fc762c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html