Skip to contentSkip to conversation

Add GT oriented dmesg output

PATCH Superseded [email protected] 6 participants 22 messages Nov 4, 2022 – Nov 15, 2022

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover Add GT oriented dmesg output

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

This patch also updates the gt/uc files to use the new helpers as a first step. The intention would be to convert all output messages that have access to a GT structure.

John Harrison (2):
drm/i915/gt: Add GT oriented dmesg output drm/i915/uc: Update the gt/uc code to use GT_ERR and friends

 drivers/gpu/drm/i915/gt/intel_gt.h            | 15 +++
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        | 25 +++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  9 +-
 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 50 ++++------
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  9 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 17 ++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 49 +++++-----
 drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c     |  3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |  6 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++------
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        | 20 ++--
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 84 ++++++++---------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 91 +++++++++----------
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     | 36 ++++----
 .../drm/i915/gt/uc/selftest_guc_hangcheck.c   | 22 ++---
 .../drm/i915/gt/uc/selftest_guc_multi_lrc.c   | 10 +-
 16 files changed, 243 insertions(+), 259 deletions(-)
Signature · 1 line
2.37.3
#1 lore raw

PATCH 1/2 drm/i915/gt: Add GT oriented dmesg output

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

---
 drivers/gpu/drm/i915/gt/intel_gt.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.h +15 -0
index e0365d5562484..1e016fb0117a4 100644
@@ -13,6 +13,21 @@
 struct drm_i915_private;
 struct drm_printer;
 
+#define GT_ERR(_gt, _fmt, ...) \
+	drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_WARN(_gt, _fmt, ...) \
+	drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_NOTICE(_gt, _fmt, ...) \
+	drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_INFO(_gt, _fmt, ...) \
+	drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_DBG(_gt, _fmt, ...) \
+	drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
 #define GT_TRACE(gt, fmt, ...) do {					\
 	const struct intel_gt *gt__ __maybe_unused = (gt);		\
 	GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev),		\
Signature · 1 line
2.37.3
Reviewed-by on v1 1/2
#2 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 9 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Daniele

Quoted 30 lines
---
  drivers/gpu/drm/i915/gt/intel_gt.h | 15 +++++++++++++++
  1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.h +15 -0
index e0365d5562484..1e016fb0117a4 100644
@@ -13,6 +13,21 @@
  struct drm_i915_private;
  struct drm_printer;
 
+#define GT_ERR(_gt, _fmt, ...) \
+	drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_WARN(_gt, _fmt, ...) \
+	drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_NOTICE(_gt, _fmt, ...) \
+	drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_INFO(_gt, _fmt, ...) \
+	drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
+#define GT_DBG(_gt, _fmt, ...) \
+	drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
+
  #define GT_TRACE(gt, fmt, ...) do {					\
  	const struct intel_gt *gt__ __maybe_unused = (gt);		\
  	GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev),		\
#3 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 11 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c:                                gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c:                     drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

What I'd would like to see tried is to converting all of i915/gt within one kernel release so we don't have a mish-mash of log formats.

Regards,

Tvrtko

Quoted 35 lines
Quoted 34 lines

---
  drivers/gpu/drm/i915/gt/intel_gt.h | 15 +++++++++++++++

  1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.h +14 -0
index e0365d5562484..1e016fb0117a4 100644
@@ -13,6 +13,21 @@
   struct drm_i915_private;
   struct drm_printer;
+#define GT_ERR(_gt, _fmt, ...) \
+    drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_WARN(_gt, _fmt, ...) \
+    drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_NOTICE(_gt, _fmt, ...) \
+    drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_INFO(_gt, _fmt, ...) \
+    drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_DBG(_gt, _fmt, ...) \
+    drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 

##__VA_ARGS__)
+
  #define GT_TRACE(gt, fmt, ...) do {                    \
      const struct intel_gt *gt__ __maybe_unused = (gt);        \
      GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev),        \

#4 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 37 lines · Tvrtko Ursulin
Quoted 11 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c:                                gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c:                     drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Whether or not to put the gt as parameter to the helper macro or outside wasn't really decided upon. Anyway the macro would be adding the magic "gt%u: " prefix, drm device and all.

Also the name GT_LOG (or case) is just for illustration, that part wasn't really discussed.

If agreeable this pattern could then be used to consolidate some other macros that we have. Although apart from CT_DEBUG/ERROR I don't know if we have any others.

I hope I have transferred the idea correctly. Please shout if I have not.

Regards,

Tvrtko

Quoted 41 lines

What I'd would like to see tried is to converting all of i915/gt within one kernel release so we don't have a mish-mash of log formats.

Regards,

Tvrtko

Quoted 35 lines
Quoted 34 lines

---
  drivers/gpu/drm/i915/gt/intel_gt.h | 15 +++++++++++++++

  1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.h +14 -0
index e0365d5562484..1e016fb0117a4 100644
@@ -13,6 +13,21 @@
   struct drm_i915_private;
   struct drm_printer;
+#define GT_ERR(_gt, _fmt, ...) \
+    drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_WARN(_gt, _fmt, ...) \
+    drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_NOTICE(_gt, _fmt, ...) \
+    drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_INFO(_gt, _fmt, ...) \
+    drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_DBG(_gt, _fmt, ...) \
+    drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 

##__VA_ARGS__)
+
  #define GT_TRACE(gt, fmt, ...) do {                    \
      const struct intel_gt *gt__ __maybe_unused = (gt);        \
      GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev),        \

#5 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c:                           pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 4 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

Quoted 6 lines

Whether or not to put the gt as parameter to the helper macro or outside wasn't really decided upon. Anyway the macro would be adding the magic "gt%u: " prefix, drm device and all.

Also the name GT_LOG (or case) is just for illustration, that part wasn't really discussed.

If agreeable this pattern could then be used to consolidate some other macros that we have. Although apart from CT_DEBUG/ERROR I don't know if we have any others.

By consolidating as what? I hope you aren't meaning something like 'drm_err(CT_DEBUG(GT_LOG("msg")))?'

John.

Quoted 9 lines

I hope I have transferred the idea correctly. Please shout if I have not.

Regards,

Tvrtko

Quoted 1 line

What I'd would like to see tried is to converting all of i915/gt within one kernel release so we don't have a mish-mash of log formats.

If each subsystem's team would like to convert their own section...

John.

Quoted 40 lines
Quoted 40 lines

Regards,

Tvrtko

Quoted 35 lines
Quoted 34 lines

---
  drivers/gpu/drm/i915/gt/intel_gt.h | 15 +++++++++++++++

  1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt.h +14 -0
index e0365d5562484..1e016fb0117a4 100644
@@ -13,6 +13,21 @@
   struct drm_i915_private;
   struct drm_printer;
+#define GT_ERR(_gt, _fmt, ...) \
+    drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_WARN(_gt, _fmt, ...) \
+    drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_NOTICE(_gt, _fmt, ...) \
+    drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_INFO(_gt, _fmt, ...) \
+    drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 
 ##__VA_ARGS__)
+
+#define GT_DBG(_gt, _fmt, ...) \
+    drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, 

##__VA_ARGS__)
+
  #define GT_TRACE(gt, fmt, ...) do {                    \
      const struct intel_gt *gt__ __maybe_unused = (gt);        \
      GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev),        \

#6 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                             "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 34 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c:                           pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 7 lines
Quoted 4 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Quoted 6 lines
Quoted 5 lines

Whether or not to put the gt as parameter to the helper macro or outside wasn't really decided upon. Anyway the macro would be adding the magic "gt%u: " prefix, drm device and all.

Also the name GT_LOG (or case) is just for illustration, that part wasn't really discussed.

If agreeable this pattern could then be used to consolidate some other macros that we have. Although apart from CT_DEBUG/ERROR I don't know if we have any others.

By consolidating as what? I hope you aren't meaning something like 'drm_err(CT_DEBUG(GT_LOG("msg")))?'

No, consolidate as in use the same pattern of directly calling drm logging helpers with our own formatting macro which changes per subsystem/component/directory/whatever.

Regards,

Tvrtko

#7 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 78 lines · Tvrtko Ursulin
Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 36 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 2 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 6 lines

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

John.

Quoted 13 lines
Quoted 7 lines
Quoted 6 lines

Whether or not to put the gt as parameter to the helper macro or outside wasn't really decided upon. Anyway the macro would be adding the magic "gt%u: " prefix, drm device and all.

Also the name GT_LOG (or case) is just for illustration, that part wasn't really discussed.

If agreeable this pattern could then be used to consolidate some other macros that we have. Although apart from CT_DEBUG/ERROR I don't know if we have any others.

By consolidating as what? I hope you aren't meaning something like 'drm_err(CT_DEBUG(GT_LOG("msg")))?'

No, consolidate as in use the same pattern of directly calling drm logging helpers with our own formatting macro which changes per subsystem/component/directory/whatever.

Regards,

Tvrtko

#8 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 92 lines · John Harrison
Quoted 78 lines · Tvrtko Ursulin
Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c:              snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 36 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 2 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 1 line
Quoted 6 lines
Quoted 5 lines

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

Where I have objected?

I was a) asking to convert all gt/ within one kernel release, b) transferring the maintainer discussion from IRC to this email chain to outlay one alternative, for which I said I could see the pros and cons of both, and c) raised the naming question early since that can usually become a churn point later on when we have large scale code transformations.

As said, FWIW you have my ack for GT_XXX naming and approach, but please do convert the whole of gt/ so we don't ship with a mish-mash of log messages.

Regards,

Tvrtko

#9 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 93 lines · Tvrtko Ursulin
Quoted 92 lines · John Harrison
Quoted 78 lines · Tvrtko Ursulin
Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c: snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 36 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 2 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

Where I have objected?

Only in everything you have written. Or are you saying that actually I could have just taken the r-b from Daniele and merged it while completely ignoring everything you have said because you didn't say 'NACK' at the top of your email?

Quoted 5 lines

I was a) asking to convert all gt/ within one kernel release, b) transferring the maintainer discussion from IRC to this email chain to outlay one alternative, for which I said I could see the pros and cons of both, and c) raised the naming question early since that can usually become a churn point later on when we have large scale code transformations.

As said, FWIW you have my ack for GT_XXX naming and approach, but please do convert the whole of gt/ so we don't ship with a mish-mash of log messages.

That sounds like a quite a lot of objections to me - don't do it that way, do it this way; fine do it that way but expect lots of complaints when you do; oh all right, do it that way but re-write the entire driver all at once.

I really don't get the 'we must not ship with a mish-mash of log messages' argument. It's hardly like the current total mish-mash of DRM_DEBUG, DRM_DEBUG_DRIVER, pr_dbg, drm_dbg, ... is even remotely consistent. It's also not like the patch is massively changing the format of the output messages. So some prints get a useful extra three characters in advance of others. Does anyone care? Would anyone except us even notice?

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

John.

Quoted 3 lines

Regards,

Tvrtko

#10 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 228 lines · John Harrison
Quoted 191 lines · Tvrtko Ursulin
Quoted 190 lines · John Harrison
Quoted 169 lines · Tvrtko Ursulin
Quoted 57 lines · John Harrison
Quoted 47 lines · Tvrtko Ursulin
Quoted 46 lines · Tvrtko Ursulin
Quoted 19 lines · Daniele
Quoted 11 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be
difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If
used instead of the drm_ equivalents, you get the same output but with
a GT# prefix on it.

Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

Quoted 6 lines

Reviewed-by: Daniele Ceraolo Spurio
<[email protected]>

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize
gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to
create gt%u RC6 sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs
files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to
create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to
create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle
sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u
Quoted 8 lines
Quoted 8 lines

media_perf_power_attrs sysfs (%pe)\n", i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d:
intel_pcode_init failed %d\n", id, ret); i915/i915_hwmon.c: snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);

Quoted 3 lines

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 96 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n", i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to
idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to
idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n",
i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n"); i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n"); i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 5 lines
Quoted 4 lines

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 7 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 6 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Quoted 8 lines

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

Quoted 5 lines

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 6 lines

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

Where I have objected?

Only in everything you have written. Or are you saying that actually I could have just taken the r-b from Daniele and merged it while completely ignoring everything you have said because you didn't say 'NACK' at the top of your email?

Quoted 8 lines

I was a) asking to convert all gt/ within one kernel release, b) transferring the maintainer discussion from IRC to this email chain to outlay one alternative, for which I said I could see the pros and cons of both, and c) raised the naming question early since that can usually become a churn point later on when we have large scale code transformations.

Quoted 4 lines

As said, FWIW you have my ack for GT_XXX naming and approach, but please do convert the whole of gt/ so we don't ship with a mish-mash of log messages.

That sounds like a quite a lot of objections to me - don't do it that way, do it this way; fine do it that way but expect lots of complaints when you do; oh all right, do it that way but re-write the entire driver all at once.

I really don't get the 'we must not ship with a mish-mash of log messages' argument. It's hardly like the current total mish-mash of DRM_DEBUG, DRM_DEBUG_DRIVER, pr_dbg, drm_dbg, ... is even remotely consistent. It's also not like the patch is massively changing the format of the output messages. So some prints get a useful extra three characters in advance of others. Does anyone care? Would anyone except us even notice?

Quoted 5 lines

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
- use wrappers per component
- use lower case names
- don't add colon

#define i915_xxx(_i915, _fmt, ...) \
	drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)
#define gt_xxx(_gt, _fmt, ...) \
	i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..
#define guc_xxx(_guc, _fmt, ...) \
	gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..
#define ct_xxx(_ct, _fmt, ...) \
	guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where

	xxx = { err, warn, notice, info, dbg }

and then for calls like:

	i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err));
	  gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err));
	 guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err));
	  ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));

the output would look like:

[ ] i915 0000:00:02.0: [drm] *ERROR* Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC CTB Foo failed (-EIO)

Would that work for all of you?

Michal

Quoted 8 lines

John.

Quoted 3 lines

Regards,

Tvrtko

#11 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

On 09/11/2022 19:57, Michal Wajdeczko wrote:

[snip]

Quoted 8 lines
Quoted 5 lines

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Yes, agreed.

Quoted 5 lines

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
- use wrappers per component

This is passable to me but Jani has raised a concern on IRC that it leads to a lot of macro duplication. Which is I think a valid point, but which does not have a completely nice solution. Best I heard so far was a suggestion from Joonas to add just a single component formatter macro and use the existing drm_xxx helpers.

Quoted 1 line

- use lower case names

I prefer this as well. Even though usual argument is for macros to be upper case, I find the improved readability of lower case trumps that.

Quoted 1 line

- don't add colon

Not sure, when I look at it below it looks a bit not structured enough without the colon, but maybe it is just me.

Quoted 13 lines
#define i915_xxx(_i915, _fmt, ...) \
	drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)
#define gt_xxx(_gt, _fmt, ...) \
	i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..
#define guc_xxx(_guc, _fmt, ...) \
	gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..
#define ct_xxx(_ct, _fmt, ...) \
	guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where

Quoted 8 lines
	xxx = { err, warn, notice, info, dbg }

and then for calls like:

	i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err));
	  gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err));
	 guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err));
	  ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));

So the macro idea would be like this:

  drm_err(I915_LOG("Foo failed (%pe)\n", i915), ERR_PTR(err));
  drm_err(GT_LOG("Foo failed (%pe)\n", gt), ERR_PTR(err));
  drm_err(GUC_LOG("Foo failed (%pe)\n", guc), ERR_PTR(err));
  drm_err(CT_LOG("Foo failed (%pe)\n", ct), ERR_PTR(err));

Each component would just need to define a single macro and not have to duplicate all the err, info, warn, notice, ratelimited, once, whatever versions. Which is a benefit but it's a quite a bit uglier to read in the code.

Perhaps macro could be called something other than XX_LOG to make it more readable, don't know.

Regards,

Tvrtko

#12 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 67 lines · Tvrtko Ursulin

On 09/11/2022 19:57, Michal Wajdeczko wrote:

[snip]

Quoted 8 lines
Quoted 5 lines

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Yes, agreed.

Quoted 5 lines

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
  - use wrappers per component

This is passable to me but Jani has raised a concern on IRC that it leads to a lot of macro duplication. Which is I think a valid point, but which does not have a completely nice solution. Best I heard so far was a suggestion from Joonas to add just a single component formatter macro and use the existing drm_xxx helpers.

Quoted 1 line

  - use lower case names

I prefer this as well. Even though usual argument is for macros to be upper case, I find the improved readability of lower case trumps that.

Quoted 1 line

  - don't add colon

Not sure, when I look at it below it looks a bit not structured enough without the colon, but maybe it is just me.

Quoted 15 lines

#define i915_xxx(_i915, _fmt, ...) \
    drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)

#define gt_xxx(_gt, _fmt, ...) \
    i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..

#define guc_xxx(_guc, _fmt, ...) \
    gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..

#define ct_xxx(_ct, _fmt, ...) \
    guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where
    xxx = { err, warn, notice, info, dbg }

Quoted 6 lines

and then for calls like:

    i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err)); gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err)); guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err)); ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));

So the macro idea would be like this:

  drm_err(I915_LOG("Foo failed (%pe)\n", i915), ERR_PTR(err)); drm_err(GT_LOG("Foo failed (%pe)\n", gt), ERR_PTR(err)); drm_err(GUC_LOG("Foo failed (%pe)\n", guc), ERR_PTR(err)); drm_err(CT_LOG("Foo failed (%pe)\n", ct), ERR_PTR(err));

Quoted 4 lines

Each component would just need to define a single macro and not have to duplicate all the err, info, warn, notice, ratelimited, once, whatever versions. Which is a benefit but it's a quite a bit uglier to read in the code.

If there is a choice between having ugly code all over the place and few more lines with helpers then without any doubts I would pick the latter.

And this seems to be option already used elsewhere, see:

#define dev_err(dev, fmt, ...) \
dev_printk_index_wrap ...

#define pci_err(pdev, fmt, arg...) \
	dev_err(&(pdev)->dev, fmt, ##arg)
#define drm_err(drm, fmt, ...) \
	__drm_printk((drm), err,, "*ERROR* " fmt, ##__VA_ARGS__)

#define drbd_err(obj, fmt, args...) \
drbd_printk(KERN_ERR, obj, fmt, ## args)

#define ch7006_err(client, format, ...) \
	dev_err(&client->dev, format, __VA_ARGS__)
#define mthca_err(mdev, format, arg...) \
	dev_err(&mdev->pdev->dev, format, ## arg)
#define ctx_err(ctx, fmt, arg...) \
	cal_err((ctx)->cal, "ctx%u: " fmt, (ctx)->dma_ctx, ##arg)
#define mlx4_err(mdev, format, ...) \
	dev_err(&(mdev)->persist->pdev->dev, format, ##__VA_ARGS__)

...

Michal

[1]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/linux/dev_printk.h#L143

[2]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/linux/pci.h#L2485

[3]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/drm/drm_print.h#L468

[4]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/block/drbd/drbd_int.h#L113

[5]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/gpu/drm/i2c/ch7006_priv.h#L139

[6]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/infiniband/hw/mthca/mthca_dev.h#L377

[7]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/media/platform/ti/cal/cal.h#L279

[8]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/ethernet/mellanox/mlx4/mlx4.h#L225

Quoted 7 lines

Perhaps macro could be called something other than XX_LOG to make it more readable, don't know.

Regards,

Tvrtko

#13 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 54 lines · Michal Wajdeczko
Quoted 53 lines · Tvrtko Ursulin

On 09/11/2022 19:57, Michal Wajdeczko wrote:

[snip]

Quoted 8 lines
Quoted 5 lines

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Yes, agreed.

Quoted 5 lines

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
  - use wrappers per component

This is passable to me but Jani has raised a concern on IRC that it leads to a lot of macro duplication. Which is I think a valid point, but which does not have a completely nice solution. Best I heard so far was a suggestion from Joonas to add just a single component formatter macro and use the existing drm_xxx helpers.

Quoted 1 line

  - use lower case names

I prefer this as well. Even though usual argument is for macros to be upper case, I find the improved readability of lower case trumps that.

Quoted 1 line

  - don't add colon

Not sure, when I look at it below it looks a bit not structured enough without the colon, but maybe it is just me.

Quoted 15 lines

#define i915_xxx(_i915, _fmt, ...) \
    drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)

#define gt_xxx(_gt, _fmt, ...) \
    i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..

#define guc_xxx(_guc, _fmt, ...) \
    gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..

#define ct_xxx(_ct, _fmt, ...) \
    guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where
    xxx = { err, warn, notice, info, dbg }

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

and then for calls like:

    i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err)); gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err)); guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err)); ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));

Okay lets go with this then since we have allowed some time for comments and no strict objections have been raised. Probably limit to to GT/GuC/CT space for not, ie. not adding i915_ loggers.

My preference is just to have a colon in the GT identifier, lowercase or uppercase I don't mind.

Regards,

Tvrtko

Quoted 78 lines
Quoted 8 lines

So the macro idea would be like this:

  drm_err(I915_LOG("Foo failed (%pe)\n", i915), ERR_PTR(err)); drm_err(GT_LOG("Foo failed (%pe)\n", gt), ERR_PTR(err)); drm_err(GUC_LOG("Foo failed (%pe)\n", guc), ERR_PTR(err)); drm_err(CT_LOG("Foo failed (%pe)\n", ct), ERR_PTR(err));

Quoted 4 lines

Each component would just need to define a single macro and not have to duplicate all the err, info, warn, notice, ratelimited, once, whatever versions. Which is a benefit but it's a quite a bit uglier to read in the code.

If there is a choice between having ugly code all over the place and few more lines with helpers then without any doubts I would pick the latter.

And this seems to be option already used elsewhere, see:

#define dev_err(dev, fmt, ...) \
dev_printk_index_wrap ...

#define pci_err(pdev, fmt, arg...) \
	dev_err(&(pdev)->dev, fmt, ##arg)
#define drm_err(drm, fmt, ...) \
	__drm_printk((drm), err,, "*ERROR* " fmt, ##__VA_ARGS__)

#define drbd_err(obj, fmt, args...) \
drbd_printk(KERN_ERR, obj, fmt, ## args)

#define ch7006_err(client, format, ...) \
	dev_err(&client->dev, format, __VA_ARGS__)
#define mthca_err(mdev, format, arg...) \
	dev_err(&mdev->pdev->dev, format, ## arg)
#define ctx_err(ctx, fmt, arg...) \
	cal_err((ctx)->cal, "ctx%u: " fmt, (ctx)->dma_ctx, ##arg)
#define mlx4_err(mdev, format, ...) \
	dev_err(&(mdev)->persist->pdev->dev, format, ##__VA_ARGS__)

...

Michal

[1]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/linux/dev_printk.h#L143

[2]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/linux/pci.h#L2485

[3]
https://elixir.bootlin.com/linux/v6.1-rc4/source/include/drm/drm_print.h#L468

[4]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/block/drbd/drbd_int.h#L113

[5]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/gpu/drm/i2c/ch7006_priv.h#L139

[6]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/infiniband/hw/mthca/mthca_dev.h#L377

[7]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/media/platform/ti/cal/cal.h#L279

[8]
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/ethernet/mellanox/mlx4/mlx4.h#L225

Quoted 7 lines

Perhaps macro could be called something other than XX_LOG to make it more readable, don't know.

Regards,

Tvrtko

maintainer
#14 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

In reply to Michal Wajdeczko
Quoted 33 lines · Michal Wajdeczko

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
- use wrappers per component
- use lower case names
- don't add colon

#define i915_xxx(_i915, _fmt, ...) \
	drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)
#define gt_xxx(_gt, _fmt, ...) \
	i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..
#define guc_xxx(_guc, _fmt, ...) \
	gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..
#define ct_xxx(_ct, _fmt, ...) \
	guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where

	xxx = { err, warn, notice, info, dbg }

and then for calls like:

	i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err));
	  gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err));
	 guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err));
	  ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));
Quoted 8 lines

the output would look like:

[ ] i915 0000:00:02.0: [drm] *ERROR* Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC CTB Foo failed (-EIO)

Would that work for all of you?

I think we borderline have too many wrappers already. I've basically blocked the i915_* variants early on in favour of just using the drm_* calls directly - which, themselves, are also wrappers on dev_*.

In general, there's aversion in the kernel to adding wrappers that hide what's actually going on. WYSIWYG.

So I wasn't thrilled to see the GT_* wrappers either.

And indeed part of it is that anything you do sets an example for the next developer coming along. You add wrappers for this, and sure enough someone's going to cargo cult and add wrappers for some other component. We didn't even have to merge this to see that idea pop up.

The thing with logging is that it's not just one wrapper. It's info, notice, warn, err, multiplied by the "once" variants, with some duplicated by the "ratelimited" variants. (And yeah, C sucks at this.)

Arguably the display code could use logging wrappers for connectors, encoders and crtcs, too. Not just i915, but across drm. See:

git grep "\[\(CONNECTOR\|ENCODER\|CRTC\)"

But we've opted not to.

This is just my educated guess, but what I think is more likely to happen is adding a "debug name" member to the relevant structs that you could use like:

	drm_dbg_kms(connector->dev, "%s foo\n", connector->dbg_id);

---

I'm not going to block this patchset, but I also really *really* don't want to see a cargo culted copy of this for other components. Which kind of makes me anxious.

So what if you looked again what you could do to make using the drm_* logging variants easier?

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#15 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 41 lines · Jani Nikula
Quoted 40 lines · Michal Wajdeczko

Instead of merging this patch now, oriented on GT only, I would rather wait until we discuss and plan solution for the all sub-components.

Once that's done (with agreement on naming and output) we can start converting exiting messages.

My proposal would be:
- use wrappers per component
- use lower case names
- don't add colon

#define i915_xxx(_i915, _fmt, ...) \
	drm_xxx(&(_i915)->drm, _fmt, ##__VA_ARGS__)
#define gt_xxx(_gt, _fmt, ...) \
	i915_xxx((_gt)->i915, "GT%u " _fmt, (_gt)->info.id, ..
#define guc_xxx(_guc, _fmt, ...) \
	gt_xxx(guc_to_gt(_guc), "GuC " _fmt, ..
#define ct_xxx(_ct, _fmt, ...) \
	guc_xxx(ct_to_guc(_ct), "CTB " _fmt, ..

where

	xxx = { err, warn, notice, info, dbg }

and then for calls like:

	i915_err(i915, "Foo failed (%pe)\n", ERR_PTR(err));
	  gt_err(gt,   "Foo failed (%pe)\n", ERR_PTR(err));
	 guc_err(guc,  "Foo failed (%pe)\n", ERR_PTR(err));
	  ct_err(ct,   "Foo failed (%pe)\n", ERR_PTR(err));

the output would look like:

[ ] i915 0000:00:02.0: [drm] *ERROR* Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC Foo failed (-EIO) [ ] i915 0000:00:02.0: [drm] *ERROR* GT0 GuC CTB Foo failed (-EIO)

Quoted 7 lines
Quoted 1 line

Would that work for all of you?

I think we borderline have too many wrappers already. I've basically blocked the i915_* variants early on in favour of just using the drm_* calls directly - which, themselves, are also wrappers on dev_*.

In general, there's aversion in the kernel to adding wrappers that hide what's actually going on. WYSIWYG.

That is blatantly not the case. There is a very strong push in kernel code reviews to abstract common code into helper functions. How is this any different? If you removed all helper functions with the desire to have truly WYSIWYG code then each line of code would be a paragraph long.

Quoted 17 lines

So I wasn't thrilled to see the GT_* wrappers either.

And indeed part of it is that anything you do sets an example for the next developer coming along. You add wrappers for this, and sure enough someone's going to cargo cult and add wrappers for some other component. We didn't even have to merge this to see that idea pop up.

The thing with logging is that it's not just one wrapper. It's info, notice, warn, err, multiplied by the "once" variants, with some duplicated by the "ratelimited" variants. (And yeah, C sucks at this.)

Arguably the display code could use logging wrappers for connectors, encoders and crtcs, too. Not just i915, but across drm. See:

git grep "\[\(CONNECTOR\|ENCODER\|CRTC\)"

Quoted 7 lines

But we've opted not to.

This is just my educated guess, but what I think is more likely to happen is adding a "debug name" member to the relevant structs that you could use like:

	drm_dbg_kms(connector->dev, "%s foo\n", connector->dbg_id);

Huh? You want the wrapper to be called drm_dbg_gt instead of gt_dbg but otherwise it is identical to what is currently in the patch? Other than being a longer name, how is that any different? It is still very much a wrapper of exactly the type that you don't seem to like? And as noted already, in that case shouldn't we be pushing a patch to rename drm_dbg to dev_dbg_drm first? In which case the above should be dev_dbg_drm_kms?

Quoted 6 lines

---

I'm not going to block this patchset, but I also really *really* don't want to see a cargo culted copy of this for other components. Which kind of makes me anxious.

I really don't understand the problem with adding such wrappers. Sure, there are a bunch of varients - dbg, err, warn, etc. But the variant list is contained and unlikely to grow at any point. It is trivially easy to look up gt_dbg to find out what it is doing. It makes the code much easier to read. I mean, who cares that gt_dbg is implemented via drm_dbg which is implemented via dev_dbg? Only someone that is actively wanting to further change the implementation. Anyone who is using it just wants to know that they are calling the correct debug printer for their module and are giving it the correct parameters. Having a nice simple name makes that totally clear.

Quoted 3 lines

So what if you looked again what you could do to make using the drm_* logging variants easier?

Not a lot. All other proposals so far have been adding complicated and unwieldy constructs to every single print.

Fundamentally, the drm_dbg wrappers as they stand do not allow for further customisation. So your choice is to replace, rewrite or wrap. Replacing it with an entirely parallel implementation is fundamentally the wrong direction. Re-writing the DRM layer to take a pointer to a custom printer object instead of a 'struct drm_device' (where each sub-module defines it's own private printer that adds it's preferred string and chains on to the next printer) seems like a huge change to the entire DRM code base for very little benefit. The option of wrapping the just arguments makes for messy code. The option of wrapping the function call itself means wrapping five functions. Pick your poison.

John.

Quoted 7 lines

BR,
Jani.

#16 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

In reply to John Harrison
Quoted 96 lines · John Harrison
Quoted 95 lines · Tvrtko Ursulin
Quoted 94 lines · John Harrison
Quoted 78 lines · Tvrtko Ursulin
Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c:                     "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c: snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 36 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c:             drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c:                   pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function - 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or two more of those as necessary is not making the code harder to read.

Quoted 2 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 3 lines

Because of that I was passing on to you the compromise option.

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

Where I have objected?

Only in everything you have written. Or are you saying that actually I

???

Quoted 1 line

could have just taken the r-b from Daniele and merged it while completely ignoring everything you have said because you didn't say 'NACK' at the top of your email?

No, but because we don't do that while there is an ongoing discussion.

Quoted 5 lines
Quoted 4 lines

I was a) asking to convert all gt/ within one kernel release, b) transferring the maintainer discussion from IRC to this email chain to outlay one alternative, for which I said I could see the pros and cons of both, and c) raised the naming question early since that can usually become a churn point later on when we have large scale code transformations.

As said, FWIW you have my ack for GT_XXX naming and approach, but please do convert the whole of gt/ so we don't ship with a mish-mash of log messages.

That sounds like a quite a lot of objections to me - don't do it that way, do it this way; fine do it that way but expect lots of complaints when you do; oh all right, do it that way but re-write the entire driver all at once.

No, I'll repeat what I said one last time.

I said it's good idea, raised the topic of naming, since it is good to get consensus before starting a wide renaming exercise. I also chatted with other maintainers and passed on here one alternative proposed, with its pros and cons. Finally I said your initial approach has my ack at least, even though not everyone liked it. And I asked to convert all gt/, since I think it is a good idea, and frankly it's not a very big ask. It is just how it works.

Quoted 3 lines

I really don't get the 'we must not ship with a mish-mash of log messages' argument. It's hardly like the current total mish-mash of DRM_DEBUG, DRM_DEBUG_DRIVER, pr_dbg, drm_dbg, ... is even remotely consistent. It's also not like the patch is massively changing the format of the output messages. So some prints get a useful extra three characters in advance of others. Does anyone care? Would anyone except us even notice?

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting

It can be a problem. You opened up a topic which leads to an overall improvement and if we merge churn before we decide on the final direction, then we just get more churn later.

Quoted 1 line

completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Completely conflicting?

Yours:

 drivers/gpu/drm/i915/gt/uc/intel_guc.c        | 25 +++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  9 +-
 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 50 ++++------
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  9 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 17 ++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 49 +++++-----
 drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c     |  3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |  6 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++------
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        | 20 ++--
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 84 ++++++++---------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 91 +++++++++----------
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     | 36 ++++----
 .../drm/i915/gt/uc/selftest_guc_hangcheck.c   | 22 ++---
 .../drm/i915/gt/uc/selftest_guc_multi_lrc.c   | 10 +-
 15 files changed, 228 insertions(+), 259 deletions(-)

Mine:

 drivers/gpu/drm/i915/gem/i915_gem_context.c   |  2 +-
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 23 ++++++----
 .../drm/i915/gt/intel_execlists_submission.c  | 13 +++---
 drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c  |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt_irq.c        |  8 ++--
 drivers/gpu/drm/i915/gt/intel_rps.c           |  6 ++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 43 +++++++++++--------
 .../gpu/drm/i915/gt/intel_workarounds_types.h |  4 ++
 .../gpu/drm/i915/gt/selftest_workarounds.c    |  4 +-
 drivers/gpu/drm/i915/i915_debugfs.c           |  4 +-
 drivers/gpu/drm/i915/i915_gem.c               |  2 +-
 drivers/gpu/drm/i915/i915_getparam.c          |  2 +-
 drivers/gpu/drm/i915/i915_irq.c               | 12 +++---
 drivers/gpu/drm/i915/i915_perf.c              | 14 +++---
 drivers/gpu/drm/i915/i915_query.c             | 12 +++---
 drivers/gpu/drm/i915/i915_sysfs.c             |  3 +-
 drivers/gpu/drm/i915/i915_vma.c               | 16 ++++---
 drivers/gpu/drm/i915/intel_uncore.c           | 21 +++++----
 19 files changed, 116 insertions(+), 81 deletions(-)

I deliberately did not touch gt/uc so they don't touch a single same file!

Unless you are referring to the fact gt logging will need to touch some of the same lines my patch touches. Well yes, some, not all, and I reckoned it will be much quicker since there aren't really any contentious points with DRM_XXX -> drm_xxx. Plus I added struct intel_gt or whatever or it wasn't before so it would make your patch easier/smaller.

Regards,

Tvrtko

#17 lore raw

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

Quoted 104 lines · Tvrtko Ursulin
Quoted 103 lines · John Harrison
Quoted 102 lines · Tvrtko Ursulin
Quoted 100 lines · John Harrison
Quoted 80 lines · Tvrtko Ursulin
Quoted 37 lines · John Harrison
Quoted 21 lines · Tvrtko Ursulin
Quoted 20 lines · Tvrtko Ursulin
Quoted 9 lines · Daniele
Quoted 8 lines · On 11/4/2022 10:25 AM, [email protected] wrote:

From: John Harrison <[email protected]>

When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it.

Quoted 7 lines
Quoted 1 line

The only downside to this is that we'll print "GT0: " even on single-GT devices. We could introduce a gt->info.name and print that, so we could have it different per-platform, but IMO it's not worth the effort.

I think it might be worth getting an ack from one of the maintainers to make sure we're all aligned on transitioning to these new logging macro for gt code.

Idea is I think a very good one. First I would suggest standardising to lowercase GT in logs because:

Quoted 14 lines
Quoted 5 lines
$ grep "GT%" i915/ -r
$ grep "gt%" i915/ -r
i915/gt/intel_gt_sysfs.c: gt->i915->sysfs_gt, "gt%d", gt->info.id))
i915/gt/intel_gt_sysfs.c:                "failed to initialize gt%d sysfs root\n", gt->info.id);
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6 sysfs files (%pe)\n",
Quoted 9 lines
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RC6p sysfs files (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u RPS sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u punit_req_freq_mhz sysfs (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u throttle sysfs files (%pe)",
i915/gt/intel_gt_sysfs_pm.c: "failed to create gt%u media_perf_power_attrs sysfs (%pe)\n",
i915/gt/intel_gt_sysfs_pm.c: "failed to add gt%u rps defaults (%pe)\n",
i915/i915_driver.c: drm_err(&gt->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
i915/i915_hwmon.c: snprintf(ddat_gt->name, sizeof(ddat_gt->name), "i915_gt%u", i);
Quoted 1 line

Just because there are 11 existing instances of one form doesn't mean that the 275 instances that are waiting to be converted should be done incorrectly. GT is an acronym and should be capitalised.

Okay just make it consistent then.

Quoted 38 lines

Besides:
grep -r "GT " i915 | grep '"'
i915/vlv_suspend.c: drm_err(&i915->drm, "timeout disabling GT waking\n");
i915/vlv_suspend.c:                     "timeout waiting for GT wells to go %s\n",
i915/vlv_suspend.c:     drm_dbg(&i915->drm, "GT register access while GT waking disabled\n");
i915/i915_gpu_error.c:  err_printf(m, "GT awake: %s\n", str_yes_no(gt->awake));
i915/i915_debugfs.c:    seq_printf(m, "GT awake? %s [%d], %llums\n",
i915/selftests/i915_gem_evict.c: pr_err("Failed to idle GT (on %s)", engine->name);
i915/intel_uncore.c:                  "GT thread status wait timed out\n");
i915/gt/uc/selftest_guc_multi_lrc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/uc/selftest_guc.c: drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
i915/gt/intel_gt_mcr.c: * Some GT registers are designed as "multicast" or "replicated" registers:
i915/gt/selftest_rps.c:                 pr_info("%s: rps counted %d C0 cycles [%lldns] in %lldns [%d cycles], using GT clock frequency of %uKHz\n", i915/gt/selftest_hangcheck.c: pr_err("[%s] GT is wedged!\n", engine->name);
i915/gt/selftest_hangcheck.c:           pr_err("GT is wedged!\n");
i915/gt/intel_gt_clock_utils.c:                 "GT clock frequency changed, was %uHz, now %uHz!\n", i915/gt/selftest_engine_pm.c:           pr_err("Unable to flush GT pm before test\n");
i915/gt/selftest_engine_pm.c: pr_err("GT failed to idle\n");
i915/i915_sysfs.c:                       "failed to register GT sysfs directory\n");
i915/intel_uncore.h:     * of the basic non-engine GT registers (referred to as "GSI" on
i915/intel_uncore.h:     * newer platforms, or "GT block" on older platforms)?  If so, we'll

Quoted 2 lines
Quoted 1 line

Then there is a question of naming. Are we okay with GT_XXX or, do we want intel_gt_, or something completely different. I don't have a strong opinion at the moment so I'll add some more folks to Cc.

You mean GT_ERR("msg") vs intel_gt_err("msg")? Personally, I would prefer just gt_err("msg") to keep it as close to the official drm_* versions as possible. Print lines tend to be excessively long already. Taking a 'gt' parameter instead of a '&gt->i915->drm' parameter does help with that but it seems like calling the wrapper intel_gt_* is shooting ourselves in the foot on that one. And GT_ERR vs gt_err just comes down to the fact that it is a macro wrapper and therefore is required to be in upper case.

Quoted 3 lines

There was a maintainer level mini-discussion on this topic which I will try to summarise.

Main contention point was the maintenance cost and generally an undesirable pattern of needing to add many subsystem/component/directory specific macros. Which then typically need extra flavours and so on. But over verbosity of the

How many versions are you expecting to add? Beyond the tile instance, what further addressing requirements are there? The card instance is already printed as part of the PCI address. The only other reason to add per component wrappers would be to wrap the mechanism for getting from some random per component object back to the intel_gt structure. But that is hardware a new issue being added by this wrapper. It is also not a requirement. Much of the code has a gt pointer already. For the parts that don't, some of it would be a trivial engine->gt type dereference, some of it is a more complex container_of type construction. But for those, the given file will already have multiple instances of that already (usually as the first or second line of the function
- 'intel_gt *gt = fancy_access_method(my_obj)' so adding one or
two more of those as necessary is not making the code harder to read.

Quoted 2 lines

code is obviously also bad, so one compromise idea was to add a macro which builds the GT string and use drm logging helpers directly. This would be something like:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

 drm_err(GT_LOG("something went wrong ret=%d\n", gt), ret); drm_info(GT_LOG(...same...));

Seriously? As above, some of these lines are already way too long, this version makes them even longer with no obvious benefit. Worse, it makes it harder to read what is going on. It is much less intuitive to read than just replacing the drm_err itself. And having two sets of parenthesis with some parameters inside the first and some only inside the second is really horrid! Also, putting the 'gt' parameter in the middle just confuses it with the rest of the printf arguments even though there is no %d in the string for it. So now a quick glances tells you that your code is wrong because you have three format specifiers but four parameters.

Whereas, just replacing drm_err with gt_err (or GT_ERR or intel_gt_err) keeps everything else consistent. The first parameter changes from 'drm' to 'gt' but is still the master object parameter and it matches the function/macro prefix so inherently looks correct. Then you have your message plus parameters. No confusing orders, no confusing parenthesis, no excessive macro levels, no confusion at all. Just nice simple, easy to read, easy to maintain code.

I am personally okay with gt_err/GT_ERR some other folks might object though. And I can also understand the argument why it is better to not have to define gt_err, gt_warn, gt_info, gt_notice, gt_debug, gt_err_ratelimited, gt_warn_once.. and instead have only one macro.

A small set of trivial macro definitions vs a complicated and unreadable construct on every single print? Erm, isn't that the very definition of abstracting to helpers as generally required by every code review ever?

And what 'other folks might object'? People already CC'd? People outside of i915?

Quoted 6 lines

Because of that I was passing on to you the compromise option.

It maybe still has net space savings since we wouldn't have to be repeating the gt->i915->drm whatever and gt->info.id on every line.

You are free to try the most compact one and see how hard those objections will be.

Um. I already did. This patch. And you are the only person to have objected in any manner at all.

Quoted 8 lines
Quoted 2 lines
Quoted 1 line

Where I have objected?

Only in everything you have written. Or are you saying that actually I

???

Quoted 1 line

could have just taken the r-b from Daniele and merged it while completely ignoring everything you have said because you didn't say 'NACK' at the top of your email?

No, but because we don't do that while there is an ongoing discussion.

Which is exactly my point. If it is not an ack or r-b then by definition it is an objection.

Quoted 61 lines
Quoted 6 lines
Quoted 5 lines

I was a) asking to convert all gt/ within one kernel release, b) transferring the maintainer discussion from IRC to this email chain to outlay one alternative, for which I said I could see the pros and cons of both, and c) raised the naming question early since that can usually become a churn point later on when we have large scale code transformations.

As said, FWIW you have my ack for GT_XXX naming and approach, but please do convert the whole of gt/ so we don't ship with a mish-mash of log messages.

That sounds like a quite a lot of objections to me - don't do it that way, do it this way; fine do it that way but expect lots of complaints when you do; oh all right, do it that way but re-write the entire driver all at once.

No, I'll repeat what I said one last time.

I said it's good idea, raised the topic of naming, since it is good to get consensus before starting a wide renaming exercise. I also chatted with other maintainers and passed on here one alternative proposed, with its pros and cons. Finally I said your initial approach has my ack at least, even though not everyone liked it. And I asked to convert all gt/, since I think it is a good idea, and frankly it's not a very big ask. It is just how it works.

Quoted 3 lines

I really don't get the 'we must not ship with a mish-mash of log messages' argument. It's hardly like the current total mish-mash of DRM_DEBUG, DRM_DEBUG_DRIVER, pr_dbg, drm_dbg, ... is even remotely consistent. It's also not like the patch is massively changing the format of the output messages. So some prints get a useful extra three characters in advance of others. Does anyone care? Would anyone except us even notice?

Is it really a problem to merge this patch now to get the process started? And other sub-components get updated as and when people get the time to do them? You could maybe even help rather than posting

It can be a problem. You opened up a topic which leads to an overall improvement and if we merge churn before we decide on the final direction, then we just get more churn later.

Quoted 1 line

completely conflicting patch sets that basically duplicate all the effort for no actual benefit.

Completely conflicting?

Yours:

 drivers/gpu/drm/i915/gt/uc/intel_guc.c        | 25 +++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  9 +- .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 50 ++++------ drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  9 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 17 ++-- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 49 +++++----- drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c     |  3 +- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |  6 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++------ drivers/gpu/drm/i915/gt/uc/intel_huc.c        | 20 ++-- drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 84 ++++++++--------- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 91 +++++++++---------- drivers/gpu/drm/i915/gt/uc/selftest_guc.c     | 36 ++++---- .../drm/i915/gt/uc/selftest_guc_hangcheck.c   | 22 ++--- .../drm/i915/gt/uc/selftest_guc_multi_lrc.c   | 10 +-

 15 files changed, 228 insertions(+), 259 deletions(-)

Mine:

 drivers/gpu/drm/i915/gem/i915_gem_context.c   |  2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 23 ++++++---- .../drm/i915/gt/intel_execlists_submission.c  | 13 +++--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c  |  4 +- drivers/gpu/drm/i915/gt/intel_gt.c            |  4 +- drivers/gpu/drm/i915/gt/intel_gt_irq.c        |  8 ++-- drivers/gpu/drm/i915/gt/intel_rps.c           |  6 ++- drivers/gpu/drm/i915/gt/intel_workarounds.c   | 43 +++++++++++-------- .../gpu/drm/i915/gt/intel_workarounds_types.h |  4 ++ .../gpu/drm/i915/gt/selftest_workarounds.c    |  4 +- drivers/gpu/drm/i915/i915_debugfs.c           |  4 +- drivers/gpu/drm/i915/i915_gem.c               |  2 +- drivers/gpu/drm/i915/i915_getparam.c          |  2 +- drivers/gpu/drm/i915/i915_irq.c               | 12 +++--- drivers/gpu/drm/i915/i915_perf.c              | 14 +++--- drivers/gpu/drm/i915/i915_query.c             | 12 +++--- drivers/gpu/drm/i915/i915_sysfs.c             |  3 +- drivers/gpu/drm/i915/i915_vma.c               | 16 ++++--- drivers/gpu/drm/i915/intel_uncore.c           | 21 +++++----

Quoted 5 lines
 19 files changed, 116 insertions(+), 81 deletions(-)

I deliberately did not touch gt/uc so they don't touch a single same file!

Unless you are referring to the fact gt logging will need to touch some of the same lines my patch touches. Well yes, some, not all, and I reckoned it will be much quicker since there aren't really any contentious points with DRM_XXX -> drm_xxx. Plus I added struct intel_gt or whatever or it wasn't before so it would make your patch easier/smaller.

Except that it is quite clearly a change that is 'still under discussion' and is quite clearly changing exactly the same lines of code in a number of places. Therefore, by your definition, your patch set cannot be merged because it is causing 'churn'. Alternatively, your set can be merged because we don't actually care that a few lines will get changed one way and then quickly changed another way in a follow up patch and the overall benefit is worth the 'churn'. In which case exactly the same rule should apply to this patch set. Merge something that adds immediate benefit and if necessary update it to a better version later.

Of course, there is also the view that you have just taken the task over by posting a more encompassing change that cleans up debug prints in the whole of i915. Therefore it is now up to you to update all sub-components to use appropriate prints - GT, KMS, GuC, Gem, etc.. because "frankly it's not a very big ask. It is just how it works".

John.

Quoted 4 lines

Regards,

Tvrtko

#18 lore raw

PATCH 2/2 drm/i915/uc: Update the gt/uc code to use GT_ERR and friends

In reply to [email protected]

From: John Harrison <[email protected]>

Use the new GT oriented output message helpers where possible.

---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        | 25 +++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  9 +-
 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 50 ++++------
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  9 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 17 ++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 49 +++++-----
 drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c     |  3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |  6 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++------
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        | 20 ++--
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 84 ++++++++---------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 91 +++++++++----------
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     | 36 ++++----
 .../drm/i915/gt/uc/selftest_guc_hangcheck.c   | 22 ++---
 .../drm/i915/gt/uc/selftest_guc_multi_lrc.c   | 10 +-
 15 files changed, 228 insertions(+), 259 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.c +11 -14
index 27b09ba1d295f..36983a2cc20e8 100644
@@ -330,7 +330,7 @@ static void guc_init_params(struct intel_guc *guc)
 	params[GUC_CTL_DEVID] = guc_ctl_devid(guc);
 
 	for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
-		DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
+		GT_DBG(guc_to_gt(guc), "param[%2d] = %#x\n", i, params[i]);
 }
 
 /*
@@ -475,8 +475,8 @@ void intel_guc_fini(struct intel_guc *guc)
 int intel_guc_send_mmio(struct intel_guc *guc, const u32 *request, u32 len,
 			u32 *response_buf, u32 response_buf_size)
 {
-	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
-	struct intel_uncore *uncore = guc_to_gt(guc)->uncore;
+	struct intel_gt *gt = guc_to_gt(guc);
+	struct intel_uncore *uncore = gt->uncore;
 	u32 header;
 	int i;
 	int ret;
@@ -510,8 +510,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *request, u32 len,
 					   10, 10, &header);
 	if (unlikely(ret)) {
 timeout:
-		drm_err(&i915->drm, "mmio request %#x: no reply %x\n",
-			request[0], header);
+		GT_ERR(gt, "mmio request %#x: no reply %x\n", request[0], header);
 		goto out;
 	}
 
@@ -532,8 +531,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *request, u32 len,
 	if (FIELD_GET(GUC_HXG_MSG_0_TYPE, header) == GUC_HXG_TYPE_NO_RESPONSE_RETRY) {
 		u32 reason = FIELD_GET(GUC_HXG_RETRY_MSG_0_REASON, header);
 
-		drm_dbg(&i915->drm, "mmio request %#x: retrying, reason %u\n",
-			request[0], reason);
+		GT_DBG(gt, "mmio request %#x: retrying, reason %u\n", request[0], reason);
 		goto retry;
 	}
 
@@ -541,16 +539,14 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *request, u32 len,
 		u32 hint = FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, header);
 		u32 error = FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, header);
 
-		drm_err(&i915->drm, "mmio request %#x: failure %x/%u\n",
-			request[0], error, hint);
+		GT_ERR(gt, "mmio request %#x: failure %x/%u\n", request[0], error, hint);
 		ret = -ENXIO;
 		goto out;
 	}
 
 	if (FIELD_GET(GUC_HXG_MSG_0_TYPE, header) != GUC_HXG_TYPE_RESPONSE_SUCCESS) {
 proto:
-		drm_err(&i915->drm, "mmio request %#x: unexpected reply %#x\n",
-			request[0], header);
+		GT_ERR(gt, "mmio request %#x: unexpected reply %#x\n", request[0], header);
 		ret = -EPROTO;
 		goto out;
 	}
@@ -592,9 +588,9 @@ int intel_guc_to_host_process_recv_msg(struct intel_guc *guc,
 	msg = payload[0] & guc->msg_enabled_mask;
 
 	if (msg & INTEL_GUC_RECV_MSG_CRASH_DUMP_POSTED)
-		drm_err(&guc_to_gt(guc)->i915->drm, "Received early GuC crash dump notification!\n");
+		GT_ERR(guc_to_gt(guc), "Received early GuC crash dump notification!\n");
 	if (msg & INTEL_GUC_RECV_MSG_EXCEPTION)
-		drm_err(&guc_to_gt(guc)->i915->drm, "Received early GuC exception notification!\n");
+		GT_ERR(guc_to_gt(guc), "Received early GuC exception notification!\n");
 
 	return 0;
 }
@@ -648,7 +644,8 @@ int intel_guc_suspend(struct intel_guc *guc)
 		 */
 		ret = intel_guc_send_mmio(guc, action, ARRAY_SIZE(action), NULL, 0);
 		if (ret)
-			DRM_ERROR("GuC suspend: RESET_CLIENT action failed with error %d!\n", ret);
+			GT_ERR(guc_to_gt(guc),
+			       "GuC suspend: RESET_CLIENT action failed with error %d!\n", ret);
 	}
 
 	/* Signal that the GuC isn't running. */
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c +4 -5
index a419d60166c87..6d07628e0eaf0 100644
@@ -427,8 +427,8 @@ static long guc_mmio_reg_state_create(struct intel_guc *guc)
 
 	guc->ads_regset = temp_set.storage;
 
-	drm_dbg(&guc_to_gt(guc)->i915->drm, "Used %zu KB for temporary ADS regset\n",
-		(temp_set.storage_max * sizeof(struct guc_mmio_reg)) >> 10);
+	GT_DBG(gt, "Used %zu KB for temporary ADS regset\n",
+	       (temp_set.storage_max * sizeof(struct guc_mmio_reg)) >> 10);
 
 	return total * sizeof(struct guc_mmio_reg);
 
@@ -647,7 +647,6 @@ static int
 guc_capture_prep_lists(struct intel_guc *guc)
 {
 	struct intel_gt *gt = guc_to_gt(guc);
-	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
 	u32 ads_ggtt, capture_offset, null_ggtt, total_size = 0;
 	struct guc_gt_system_info local_info;
 	struct iosys_map info_map;
@@ -752,8 +751,8 @@ guc_capture_prep_lists(struct intel_guc *guc)
 	}
 
 	if (guc->ads_capture_size && guc->ads_capture_size != PAGE_ALIGN(total_size))
-		drm_warn(&i915->drm, "GuC->ADS->Capture alloc size changed from %d to %d\n",
-			 guc->ads_capture_size, PAGE_ALIGN(total_size));
+		GT_WARN(gt, "GuC->ADS->Capture alloc size changed from %d to %d\n",
+			guc->ads_capture_size, PAGE_ALIGN(total_size));
 
 	return PAGE_ALIGN(total_size);
 }
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c +20 -30

188 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +2 -7
index 2b22065e87bf9..699290b10a3c3 100644
@@ -28,16 +28,11 @@ static inline struct drm_i915_private *ct_to_i915(struct intel_guc_ct *ct)
 	return ct_to_gt(ct)->i915;
 }
 
-static inline struct drm_device *ct_to_drm(struct intel_guc_ct *ct)
-{
-	return &ct_to_i915(ct)->drm;
-}
-
 #define CT_ERROR(_ct, _fmt, ...) \
-	drm_err(ct_to_drm(_ct), "CT: " _fmt, ##__VA_ARGS__)
+	GT_ERR(ct_to_gt(_ct), _fmt, ##__VA_ARGS__)
 #ifdef CONFIG_DRM_I915_DEBUG_GUC
 #define CT_DEBUG(_ct, _fmt, ...) \
-	drm_dbg(ct_to_drm(_ct), "CT: " _fmt, ##__VA_ARGS__)
+	GT_DBG(ct_to_gt(_ct), _fmt, ##__VA_ARGS__)
 #else
 #define CT_DEBUG(...)	do { } while (0)
 #endif
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c +8 -9
index 5b86b2e286e07..83cb4868ae3b9 100644
@@ -103,8 +103,9 @@ static inline bool guc_ready(struct intel_uncore *uncore, u32 *status)
 	return uk_val == INTEL_GUC_LOAD_STATUS_READY;
 }
 
-static int guc_wait_ucode(struct intel_uncore *uncore)
+static int guc_wait_ucode(struct intel_gt *gt)
 {
+	struct intel_uncore *uncore = gt->uncore;
 	u32 status;
 	int ret;
 
@@ -127,10 +128,8 @@ static int guc_wait_ucode(struct intel_uncore *uncore)
 	 */
 	ret = wait_for(guc_ready(uncore, &status), 200);
 	if (ret) {
-		struct drm_device *drm = &uncore->i915->drm;
-
-		drm_info(drm, "GuC load failed: status = 0x%08X\n", status);
-		drm_info(drm, "GuC load failed: status: Reset = %d, "
+		GT_INFO(gt, "GuC load failed: status = 0x%08X\n", status);
+		GT_INFO(gt, "GuC load failed: status: Reset = %d, "
 			"BootROM = 0x%02X, UKernel = 0x%02X, "
 			"MIA = 0x%02X, Auth = 0x%02X\n",
 			REG_FIELD_GET(GS_MIA_IN_RESET, status),
@@ -140,13 +139,13 @@ static int guc_wait_ucode(struct intel_uncore *uncore)
 			REG_FIELD_GET(GS_AUTH_STATUS_MASK, status));
 
 		if ((status & GS_BOOTROM_MASK) == GS_BOOTROM_RSA_FAILED) {
-			drm_info(drm, "GuC firmware signature verification failed\n");
+			GT_INFO(gt, "GuC firmware signature verification failed\n");
 			ret = -ENOEXEC;
 		}
 
 		if (REG_FIELD_GET(GS_UKERNEL_MASK, status) == INTEL_GUC_LOAD_STATUS_EXCEPTION) {
-			drm_info(drm, "GuC firmware exception. EIP: %#x\n",
-				 intel_uncore_read(uncore, SOFT_SCRATCH(13)));
+			GT_INFO(gt, "GuC firmware exception. EIP: %#x\n",
+				intel_uncore_read(uncore, SOFT_SCRATCH(13)));
 			ret = -ENXIO;
 		}
 	}
@@ -194,7 +193,7 @@ int intel_guc_fw_upload(struct intel_guc *guc)
 	if (ret)
 		goto out;
 
-	ret = guc_wait_ucode(uncore);
+	ret = guc_wait_ucode(gt);
 	if (ret)
 		goto out;
 
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c +25 -24

123 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c +1 -2
index 8f8dd05835c5a..6a507c2409ecf 100644
@@ -64,8 +64,7 @@ static int __guc_rc_control(struct intel_guc *guc, bool enable)
 		return ret;
 	}
 
-	drm_info(&gt->i915->drm, "GuC RC: %s\n",
-		 str_enabled_disabled(enable));
+	GT_INFO(gt, "GuC RC: %s\n", str_enabled_disabled(enable));
 
 	return 0;
 }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +3 -3
index 63464933cbceb..6f1a56c85a651 100644
@@ -236,9 +236,9 @@ static int slpc_force_min_freq(struct intel_guc_slpc *slpc, u32 freq)
 					SLPC_PARAM_GLOBAL_MIN_GT_UNSLICE_FREQ_MHZ,
 					freq);
 		if (ret)
-			drm_notice(&i915->drm,
-				   "Failed to send set_param for min freq(%d): (%d)\n",
-				   freq, ret);
+			GT_NOTICE(guc_to_gt(guc),
+				  "Failed to send set_param for min freq(%d): (%d)\n",
+				  freq, ret);
 	}
 
 	return ret;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +26 -30

162 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/intel_huc.c +9 -11
index fbc8bae14f76a..c31ef49ad7fd0 100644
@@ -255,29 +255,27 @@ static int check_huc_loading_mode(struct intel_huc *huc)
 			      GSC_LOADS_HUC;
 
 	if (fw_needs_gsc != hw_uses_gsc) {
-		drm_err(&gt->i915->drm,
-			"mismatch between HuC FW (%s) and HW (%s) load modes\n",
-			HUC_LOAD_MODE_STRING(fw_needs_gsc),
-			HUC_LOAD_MODE_STRING(hw_uses_gsc));
+		GT_ERR(gt, "mismatch between HuC FW (%s) and HW (%s) load modes\n",
+		       HUC_LOAD_MODE_STRING(fw_needs_gsc),
+		       HUC_LOAD_MODE_STRING(hw_uses_gsc));
 		return -ENOEXEC;
 	}
 
 	/* make sure we can access the GSC via the mei driver if we need it */
 	if (!(IS_ENABLED(CONFIG_INTEL_MEI_PXP) && IS_ENABLED(CONFIG_INTEL_MEI_GSC)) &&
 	    fw_needs_gsc) {
-		drm_info(&gt->i915->drm,
-			 "Can't load HuC due to missing MEI modules\n");
+		GT_INFO(gt, "Can't load HuC due to missing MEI modules\n");
 		return -EIO;
 	}
 
-	drm_dbg(&gt->i915->drm, "GSC loads huc=%s\n", str_yes_no(fw_needs_gsc));
+	GT_DBG(gt, "GSC loads huc=%s\n", str_yes_no(fw_needs_gsc));
 
 	return 0;
 }
 
 int intel_huc_init(struct intel_huc *huc)
 {
-	struct drm_i915_private *i915 = huc_to_gt(huc)->i915;
+	struct intel_gt *gt = huc_to_gt(huc);
 	int err;
 
 	err = check_huc_loading_mode(huc);
@@ -294,7 +292,7 @@ int intel_huc_init(struct intel_huc *huc)
 
 out:
 	intel_uc_fw_change_status(&huc->fw, INTEL_UC_FIRMWARE_INIT_FAIL);
-	drm_info(&i915->drm, "HuC init failed with %d\n", err);
+	GT_INFO(gt, "HuC init failed with %d\n", err);
 	return err;
 }
 
@@ -337,13 +335,13 @@ int intel_huc_wait_for_auth_complete(struct intel_huc *huc)
 	delayed_huc_load_complete(huc);
 
 	if (ret) {
-		drm_err(&gt->i915->drm, "HuC: Firmware not verified %d\n", ret);
+		GT_ERR(gt, "HuC: Firmware not verified %d\n", ret);
 		intel_uc_fw_change_status(&huc->fw, INTEL_UC_FIRMWARE_LOAD_FAIL);
 		return ret;
 	}
 
 	intel_uc_fw_change_status(&huc->fw, INTEL_UC_FIRMWARE_RUNNING);
-	drm_info(&gt->i915->drm, "HuC authenticated\n");
+	GT_INFO(gt, "HuC authenticated\n");
 	return 0;
 }
 
drivers/gpu/drm/i915/gt/uc/intel_uc.c +40 -44

184 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +45 -46

186 lines not on this page · raw message

drivers/gpu/drm/i915/gt/uc/selftest_guc.c +18 -18
index e28518fe8b908..dfaf8ce7d60cf 100644
@@ -65,7 +65,7 @@ static int intel_guc_scrub_ctbs(void *arg)
 		ce = intel_context_create(engine);
 		if (IS_ERR(ce)) {
 			ret = PTR_ERR(ce);
-			drm_err(&gt->i915->drm, "Failed to create context, %d: %d\n", i, ret);
+			GT_ERR(gt, "Failed to create context, %d: %d\n", i, ret);
 			goto err;
 		}
 
@@ -86,7 +86,7 @@ static int intel_guc_scrub_ctbs(void *arg)
 
 		if (IS_ERR(rq)) {
 			ret = PTR_ERR(rq);
-			drm_err(&gt->i915->drm, "Failed to create request, %d: %d\n", i, ret);
+			GT_ERR(gt, "Failed to create request, %d: %d\n", i, ret);
 			goto err;
 		}
 
@@ -96,7 +96,7 @@ static int intel_guc_scrub_ctbs(void *arg)
 	for (i = 0; i < 3; ++i) {
 		ret = i915_request_wait(last[i], 0, HZ);
 		if (ret < 0) {
-			drm_err(&gt->i915->drm, "Last request failed to complete: %d\n", ret);
+			GT_ERR(gt, "Last request failed to complete: %d\n", ret);
 			goto err;
 		}
 		i915_request_put(last[i]);
@@ -113,7 +113,7 @@ static int intel_guc_scrub_ctbs(void *arg)
 	/* GT will not idle if G2H are lost */
 	ret = intel_gt_wait_for_idle(gt, HZ);
 	if (ret < 0) {
-		drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
+		GT_ERR(gt, "GT failed to idle: %d\n", ret);
 		goto err;
 	}
 
@@ -153,7 +153,7 @@ static int intel_guc_steal_guc_ids(void *arg)
 
 	ce = kcalloc(GUC_MAX_CONTEXT_ID, sizeof(*ce), GFP_KERNEL);
 	if (!ce) {
-		drm_err(&gt->i915->drm, "Context array allocation failed\n");
+		GT_ERR(gt, "Context array allocation failed\n");
 		return -ENOMEM;
 	}
 
@@ -167,24 +167,24 @@ static int intel_guc_steal_guc_ids(void *arg)
 	if (IS_ERR(ce[context_index])) {
 		ret = PTR_ERR(ce[context_index]);
 		ce[context_index] = NULL;
-		drm_err(&gt->i915->drm, "Failed to create context: %d\n", ret);
+		GT_ERR(gt, "Failed to create context: %d\n", ret);
 		goto err_wakeref;
 	}
 	ret = igt_spinner_init(&spin, engine->gt);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Failed to create spinner: %d\n", ret);
+		GT_ERR(gt, "Failed to create spinner: %d\n", ret);
 		goto err_contexts;
 	}
 	spin_rq = igt_spinner_create_request(&spin, ce[context_index],
 					     MI_ARB_CHECK);
 	if (IS_ERR(spin_rq)) {
 		ret = PTR_ERR(spin_rq);
-		drm_err(&gt->i915->drm, "Failed to create spinner request: %d\n", ret);
+		GT_ERR(gt, "Failed to create spinner request: %d\n", ret);
 		goto err_contexts;
 	}
 	ret = request_add_spin(spin_rq, &spin);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Failed to add Spinner request: %d\n", ret);
+		GT_ERR(gt, "Failed to add Spinner request: %d\n", ret);
 		goto err_spin_rq;
 	}
 
@@ -194,7 +194,7 @@ static int intel_guc_steal_guc_ids(void *arg)
 		if (IS_ERR(ce[context_index])) {
 			ret = PTR_ERR(ce[context_index--]);
 			ce[context_index] = NULL;
-			drm_err(&gt->i915->drm, "Failed to create context: %d\n", ret);
+			GT_ERR(gt, "Failed to create context: %d\n", ret);
 			goto err_spin_rq;
 		}
 
@@ -203,8 +203,8 @@ static int intel_guc_steal_guc_ids(void *arg)
 			ret = PTR_ERR(rq);
 			rq = NULL;
 			if (ret != -EAGAIN) {
-				drm_err(&gt->i915->drm, "Failed to create request, %d: %d\n",
-					context_index, ret);
+				GT_ERR(gt, "Failed to create request, %d: %d\n",
+				       context_index, ret);
 				goto err_spin_rq;
 			}
 		} else {
@@ -218,7 +218,7 @@ static int intel_guc_steal_guc_ids(void *arg)
 	igt_spinner_end(&spin);
 	ret = intel_selftest_wait_for_rq(spin_rq);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Spin request failed to complete: %d\n", ret);
+		GT_ERR(gt, "Spin request failed to complete: %d\n", ret);
 		i915_request_put(last);
 		goto err_spin_rq;
 	}
@@ -230,7 +230,7 @@ static int intel_guc_steal_guc_ids(void *arg)
 	ret = i915_request_wait(last, 0, HZ * 30);
 	i915_request_put(last);
 	if (ret < 0) {
-		drm_err(&gt->i915->drm, "Last request failed to complete: %d\n", ret);
+		GT_ERR(gt, "Last request failed to complete: %d\n", ret);
 		goto err_spin_rq;
 	}
 
@@ -238,7 +238,7 @@ static int intel_guc_steal_guc_ids(void *arg)
 	rq = nop_user_request(ce[context_index], NULL);
 	if (IS_ERR(rq)) {
 		ret = PTR_ERR(rq);
-		drm_err(&gt->i915->drm, "Failed to steal guc_id, %d: %d\n", context_index, ret);
+		GT_ERR(gt, "Failed to steal guc_id, %d: %d\n", context_index, ret);
 		goto err_spin_rq;
 	}
 
@@ -246,20 +246,20 @@ static int intel_guc_steal_guc_ids(void *arg)
 	ret = i915_request_wait(rq, 0, HZ);
 	i915_request_put(rq);
 	if (ret < 0) {
-		drm_err(&gt->i915->drm, "Request with stolen guc_id failed to complete: %d\n", ret);
+		GT_ERR(gt, "Request with stolen guc_id failed to complete: %d\n", ret);
 		goto err_spin_rq;
 	}
 
 	/* Wait for idle */
 	ret = intel_gt_wait_for_idle(gt, HZ * 30);
 	if (ret < 0) {
-		drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
+		GT_ERR(gt, "GT failed to idle: %d\n", ret);
 		goto err_spin_rq;
 	}
 
 	/* Verify a guc_id was stolen */
 	if (guc->number_guc_id_stolen == number_guc_id_stolen) {
-		drm_err(&gt->i915->drm, "No guc_id was stolen");
+		GT_ERR(gt, "No guc_id was stolen");
 		ret = -EINVAL;
 	} else {
 		ret = 0;
drivers/gpu/drm/i915/gt/uc/selftest_guc_hangcheck.c +11 -11
index 01f8cd3c31340..a3699c14f6148 100644
@@ -42,7 +42,7 @@ static int intel_hang_guc(void *arg)
 
 	ctx = kernel_context(gt->i915, NULL);
 	if (IS_ERR(ctx)) {
-		drm_err(&gt->i915->drm, "Failed get kernel context: %ld\n", PTR_ERR(ctx));
+		GT_ERR(gt, "Failed get kernel context: %ld\n", PTR_ERR(ctx));
 		return PTR_ERR(ctx);
 	}
 
@@ -51,7 +51,7 @@ static int intel_hang_guc(void *arg)
 	ce = intel_context_create(gt->engine[BCS0]);
 	if (IS_ERR(ce)) {
 		ret = PTR_ERR(ce);
-		drm_err(&gt->i915->drm, "Failed to create spinner request: %d\n", ret);
+		GT_ERR(gt, "Failed to create spinner request: %d\n", ret);
 		goto err;
 	}
 
@@ -61,13 +61,13 @@ static int intel_hang_guc(void *arg)
 	old_beat = engine->props.heartbeat_interval_ms;
 	ret = intel_engine_set_heartbeat(engine, BEAT_INTERVAL);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Failed to boost heatbeat interval: %d\n", ret);
+		GT_ERR(gt, "Failed to boost heatbeat interval: %d\n", ret);
 		goto err;
 	}
 
 	ret = igt_spinner_init(&spin, engine->gt);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Failed to create spinner: %d\n", ret);
+		GT_ERR(gt, "Failed to create spinner: %d\n", ret);
 		goto err;
 	}
 
@@ -75,28 +75,28 @@ static int intel_hang_guc(void *arg)
 	intel_context_put(ce);
 	if (IS_ERR(rq)) {
 		ret = PTR_ERR(rq);
-		drm_err(&gt->i915->drm, "Failed to create spinner request: %d\n", ret);
+		GT_ERR(gt, "Failed to create spinner request: %d\n", ret);
 		goto err_spin;
 	}
 
 	ret = request_add_spin(rq, &spin);
 	if (ret) {
 		i915_request_put(rq);
-		drm_err(&gt->i915->drm, "Failed to add Spinner request: %d\n", ret);
+		GT_ERR(gt, "Failed to add Spinner request: %d\n", ret);
 		goto err_spin;
 	}
 
 	ret = intel_reset_guc(gt);
 	if (ret) {
 		i915_request_put(rq);
-		drm_err(&gt->i915->drm, "Failed to reset GuC, ret = %d\n", ret);
+		GT_ERR(gt, "Failed to reset GuC, ret = %d\n", ret);
 		goto err_spin;
 	}
 
 	guc_status = intel_uncore_read(gt->uncore, GUC_STATUS);
 	if (!(guc_status & GS_MIA_IN_RESET)) {
 		i915_request_put(rq);
-		drm_err(&gt->i915->drm, "GuC failed to reset: status = 0x%08X\n", guc_status);
+		GT_ERR(gt, "GuC failed to reset: status = 0x%08X\n", guc_status);
 		ret = -EIO;
 		goto err_spin;
 	}
@@ -105,12 +105,12 @@ static int intel_hang_guc(void *arg)
 	ret = intel_selftest_wait_for_rq(rq);
 	i915_request_put(rq);
 	if (ret) {
-		drm_err(&gt->i915->drm, "Request failed to complete: %d\n", ret);
+		GT_ERR(gt, "Request failed to complete: %d\n", ret);
 		goto err_spin;
 	}
 
 	if (i915_reset_count(global) == reset_count) {
-		drm_err(&gt->i915->drm, "Failed to record a GPU reset\n");
+		GT_ERR(gt, "Failed to record a GPU reset\n");
 		ret = -EINVAL;
 		goto err_spin;
 	}
@@ -130,7 +130,7 @@ static int intel_hang_guc(void *arg)
 		ret = intel_selftest_wait_for_rq(rq);
 		i915_request_put(rq);
 		if (ret) {
-			drm_err(&gt->i915->drm, "No-op failed to complete: %d\n", ret);
+			GT_ERR(gt, "No-op failed to complete: %d\n", ret);
 			goto err;
 		}
 	}
drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c +5 -5
index d17982c36d256..d045984488fa8 100644
@@ -115,30 +115,30 @@ static int __intel_guc_multi_lrc_basic(struct intel_gt *gt, unsigned int class)
 
 	parent = multi_lrc_create_parent(gt, class, 0);
 	if (IS_ERR(parent)) {
-		drm_err(&gt->i915->drm, "Failed creating contexts: %ld", PTR_ERR(parent));
+		GT_ERR(gt, "Failed creating contexts: %ld", PTR_ERR(parent));
 		return PTR_ERR(parent);
 	} else if (!parent) {
-		drm_dbg(&gt->i915->drm, "Not enough engines in class: %d", class);
+		GT_DBG(gt, "Not enough engines in class: %d", class);
 		return 0;
 	}
 
 	rq = multi_lrc_nop_request(parent);
 	if (IS_ERR(rq)) {
 		ret = PTR_ERR(rq);
-		drm_err(&gt->i915->drm, "Failed creating requests: %d", ret);
+		GT_ERR(gt, "Failed creating requests: %d", ret);
 		goto out;
 	}
 
 	ret = intel_selftest_wait_for_rq(rq);
 	if (ret)
-		drm_err(&gt->i915->drm, "Failed waiting on request: %d", ret);
+		GT_ERR(gt, "Failed waiting on request: %d", ret);
 
 	i915_request_put(rq);
 
 	if (ret >= 0) {
 		ret = intel_gt_wait_for_idle(gt, HZ * 5);
 		if (ret < 0)
-			drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
+			GT_ERR(gt, "GT failed to idle: %d\n", ret);
 	}
 
 out:
Signature · 1 line
2.37.3
#19 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GT oriented dmesg output

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add GT oriented dmesg output
URL : https://patchwork.freedesktop.org/series/110550/
State : warning

== Summary ==

Error: dim checkpatch failed
3c6bc62f46e5 drm/i915/gt: Add GT oriented dmesg output
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible side-effects? #22: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:16:
+#define GT_ERR(_gt, _fmt, ...) \
+ drm_err(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)

-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:19:
+#define GT_WARN(_gt, _fmt, ...) \
+ drm_warn(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)

-:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible side-effects? #28: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:22:
+#define GT_NOTICE(_gt, _fmt, ...) \
+ drm_notice(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)

-:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:25:
+#define GT_INFO(_gt, _fmt, ...) \
+ drm_info(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)

-:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_gt' - possible side-effects? #34: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:28:
+#define GT_DBG(_gt, _fmt, ...) \
+ drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)

total: 0 errors, 0 warnings, 5 checks, 21 lines checked bfd7d8c0cc66 drm/i915/uc: Update the gt/uc code to use GT_ERR and friends

#20 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Add GT oriented dmesg output

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add GT oriented dmesg output
URL : https://patchwork.freedesktop.org/series/110550/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12344 -> Patchwork_110550v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/index.html

Participating hosts (41 -> 30)
------------------------------

Additional (1): fi-cml-u2
Missing (12): fi-bdw-samus bat-dg2-8 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_110550v1:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@debugfs_test@basic-hwmon}:
- fi-cml-u2: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_110550v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-cml-u2: NOTRUN -> [SKIP][2] ([i915#1208]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- fi-cml-u2: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][5] -> [INCOMPLETE][6] ([i915#4817])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-rkl-11600/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-rkl-11600/igt@[email protected]

* igt@kms_chamelium@vga-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][7] ([fdo#109284] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-cml-u2: NOTRUN -> [SKIP][8] ([i915#4213])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-edp-1:
- fi-cml-u2: NOTRUN -> [INCOMPLETE][10] ([i915#7379])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-cml-u2: NOTRUN -> [SKIP][11] ([i915#3555])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-cml-u2: NOTRUN -> [SKIP][12] ([fdo#109295] / [i915#3301])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-cml-u2/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][13] ([i915#5334]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7379]: https://gitlab.freedesktop.org/drm/intel/issues/7379

Build changes
-------------

* Linux: CI_DRM_12344 -> Patchwork_110550v1

CI-20190529: 20190529
CI_DRM_12344: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110550v1: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

9c09a1c08518 drm/i915/uc: Update the gt/uc code to use GT_ERR and friends 8675c19de14c drm/i915/gt: Add GT oriented dmesg output

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/index.html

#21 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add GT oriented dmesg output

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: Add GT oriented dmesg output
URL : https://patchwork.freedesktop.org/series/110550/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12344_full -> Patchwork_110550v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_110550v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_110550v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (11 -> 9)
------------------------------

Missing (2): shard-rkl shard-dg1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_110550v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [PASS][1] -> [CRASH][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-snb6/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl9/igt@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-a-dp-1:
- shard-apl: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/igt@kms_plane_scaling@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@kms_plane_scaling@[email protected]

Known issues
------------

Here are the changes found in Patchwork_110550v1_full that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- shard-apl: ([PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31]) -> ([PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [FAIL][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56]) ([i915#4386])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl2/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][57] ([i915#4991])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][58] -> [FAIL][59] ([i915#4409])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-snb6/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-snb7/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][60] -> [SKIP][61] ([i915#4525])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb1/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][62] ([i915#2846])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#4613]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/igt@[email protected]

* igt@gem_tiled_wb:
- shard-skl: NOTRUN -> [TIMEOUT][65] ([i915#6990])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl6/igt@gem_tiled_wb.html

* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-skl: NOTRUN -> [FAIL][66] ([i915#7036]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: NOTRUN -> [FAIL][67] ([i915#2521])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@kms_async_flips@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3886]) +7 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3886]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +6 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +7 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl7/igt@[email protected]

* igt@kms_color@ctm-red-to-blue:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#3546])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-skl: NOTRUN -> [FAIL][73] ([i915#2346]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [PASS][74] -> [FAIL][75] ([i915#2122]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl7/igt@kms_flip@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#2587] / [i915#2672]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#3555])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#2672]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271]) +174 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#2672] / [i915#3555])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271]) +116 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@[email protected]

* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-b-edp-1:
- shard-skl: NOTRUN -> [FAIL][82] ([i915#4573]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl3/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#5776]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@kms_plane_scaling@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][86] -> [SKIP][87] ([fdo#109441])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl4/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2437])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@[email protected]

* igt@perf@blocking:
- shard-skl: [PASS][90] -> [FAIL][91] ([i915#1542])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl10/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl9/igt@[email protected]

* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl6/igt@[email protected]

* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2994]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][94] ([i915#4525]) -> [PASS][95] +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb8/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][96] ([i915#2842]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb1/igt@gem_exec_fair@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][98] ([i915#2842]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@gem_exec_fair@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][100] ([i915#2842]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk7/igt@gem_exec_fair@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][102] ([i915#2190]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-tglb5/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [DMESG-WARN][104] ([i915#180]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl3/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][106] ([i915#5566] / [i915#716]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl7/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1:
- shard-glk: [FAIL][108] ([i915#2521]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk9/igt@kms_async_flips@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-glk8/igt@kms_async_flips@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][110] ([i915#180] / [i915#1982]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][112] ([i915#79]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk1/igt@kms_flip@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][114] ([i915#2122]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk3/igt@kms_flip@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [FAIL][116] ([i915#2122]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-skl7/igt@kms_flip@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

#### Warnings ####

* igt@gem_pread@exhaustion:
- shard-apl: [INCOMPLETE][120] ([i915#7248]) -> [WARN][121] ([i915#2658])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][122] ([i915#7248]) -> [WARN][123] ([i915#2658])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-tglb6/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-tglb8/igt@[email protected]
- shard-glk: [INCOMPLETE][124] ([i915#7248]) -> [WARN][125] ([i915#2658])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-glk3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-glk6/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][126] ([i915#658]) -> [SKIP][127] ([i915#2920])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb8/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][128] ([i915#2920]) -> [SKIP][129] ([i915#658])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb2/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][130] ([fdo#111068] / [i915#658]) -> [SKIP][131] ([i915#2920])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-iclb7/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-iclb2/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][137], [FAIL][138]) ([i915#3002] / [i915#4312])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl8/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12344/shard-apl6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl6/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/shard-apl1/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5776]: https://gitlab.freedesktop.org/drm/intel/issues/5776
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6990]: https://gitlab.freedesktop.org/drm/intel/issues/6990
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12344 -> Patchwork_110550v1

CI-20190529: 20190529
CI_DRM_12344: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110550v1: 36c4da734877fd1d69f0b9601dd7c3fa118d18f6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110550v1/index.html