media: ipu3: fix line ending with '(' in atomic_inc_return call

PATCH In review Shivesh 2 participants 2 messages Jul 25 – Jul 28

Subsystems (3)

Media (V4L/DVB) Staging Intel IPU3 CSI-2 imgu driver

lore

Share & tools

lore

Shivesh

author

2026-07-25 13:20 UTC #0 lore raw

PATCH 1/1 media: ipu3: fix line ending with '(' in atomic_inc_return call

From c753198ad726500786ba04d66d531db4c11e2b03 Mon Sep 17 00:00:00 2001
From: Shivesh <[email protected]>
Date: Sat, 25 Jul 2026 13:18:59 +0000
Subject: [PATCH] media: ipu3: fix line ending with '(' in atomic_inc_return
call

Move the atomic_inc_return() argument to the same line as the function call to fix checkpatch 'Lines should not end with a (' warning.

Signed-off-by Shivesh <[email protected]>

---
 drivers/staging/media/ipu3/ipu3.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/staging/media/ipu3/ipu3.c +1 -2

index 84c4d0bf027d..14e30cf913b8 100644
@@ -556,8 +556,7 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
 			buf->vid_buf.vbb.vb2_buf.timestamp = ns;
 			buf->vid_buf.vbb.field = V4L2_FIELD_NONE;
 			buf->vid_buf.vbb.sequence =
-				atomic_inc_return(
-				&imgu_pipe->nodes[node].sequence);
+				atomic_inc_return(&imgu_pipe->nodes[node].sequence);
 			dev_dbg(&imgu->pci_dev->dev, "vb2 buffer sequence %d",
 				buf->vid_buf.vbb.sequence);
 		}

Signature · 1 line

2.53.0

Move the atomic_inc_return() argument to the same line as the function call to fix checkpatch 'Lines should not end with a (' warning.

Signed-off-by Shivesh <[email protected]>

---
 drivers/staging/media/ipu3/ipu3.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/staging/media/ipu3/ipu3.c +1 -2

index 84c4d0bf027d..14e30cf913b8 100644
@@ -556,8 +556,7 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
 			buf->vid_buf.vbb.vb2_buf.timestamp = ns;
 			buf->vid_buf.vbb.field = V4L2_FIELD_NONE;
 			buf->vid_buf.vbb.sequence =
-				atomic_inc_return(
-				&imgu_pipe->nodes[node].sequence);
+				atomic_inc_return(&imgu_pipe->nodes[node].sequence);
 			dev_dbg(&imgu->pci_dev->dev, "vb2 buffer sequence %d",
 				buf->vid_buf.vbb.sequence);
 		}

Signature · 1 line

2.53.0

Sakari Ailus

maintainer

2026-07-28 08:28 UTC #1 lore raw

Hi Shivesh,

Please fix your patch submission process (no attachments). The easy way is to use git send-email.

Quoted 6 lines · Shivesh

From c753198ad726500786ba04d66d531db4c11e2b03 Mon Sep 17 00:00:00 2001
From: Shivesh <[email protected]>
Date: Sat, 25 Jul 2026 13:18:59 +0000
Subject: [PATCH] media: ipu3: fix line ending with '(' in atomic_inc_return
call

Quoted 6 lines

Move the atomic_inc_return() argument to the same line as the function call to fix checkpatch 'Lines should not end with a (' warning.
Signed-off-by Shivesh <[email protected]>
Signed-off-by Shivesh <[email protected]>

Why two e-mail addresses? The latter isn't valid either.

The change itself seems fine.

Quoted 18 lines

---
 drivers/staging/media/ipu3/ipu3.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/staging/media/ipu3/ipu3.c +1 -2

index 84c4d0bf027d..14e30cf913b8 100644
@@ -556,8 +556,7 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
 			buf->vid_buf.vbb.vb2_buf.timestamp = ns;
 			buf->vid_buf.vbb.field = V4L2_FIELD_NONE;
 			buf->vid_buf.vbb.sequence =
-				atomic_inc_return(
-				&imgu_pipe->nodes[node].sequence);
+				atomic_inc_return(&imgu_pipe->nodes[node].sequence);
 			dev_dbg(&imgu->pci_dev->dev, "vb2 buffer sequence %d",
 				buf->vid_buf.vbb.sequence);
 		}

Signature · 3 lines

Regards,

Sakari Ailus