Btrfs: remove no longer used 'sync' member from transaction handle
PATCH 1/1 Btrfs: remove no longer used 'sync' member from transaction handle
From: Filipe Manana <[email protected]>
Commit db2462a6ad3d ("btrfs: don't run delayed refs in the end transaction logic") removed its last use, so now it does absolutely nothing, therefore remove it.
Signed-off-by Filipe Manana <[email protected]>
--- fs/btrfs/extent-tree.c | 6 ------ fs/btrfs/file.c | 1 - fs/btrfs/transaction.h | 1 - 3 files changed, 8 deletions(-)
fs/btrfs/extent-tree.c +0 -6
@@ -2910,12 +2910,6 @@ static void delayed_ref_async_start(struct btrfs_work *work) goto done; } -/* -* trans->sync means that when we call end_transaction, we won't -* wait on delayed refs -*/ - trans->sync = true; -/* Don't bother flushing if we got into a different transaction */ if (trans->transid > async->transid) goto end;
fs/btrfs/file.c +0 -1
@@ -2165,7 +2165,6 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)inode_unlock (inode); goto out; } - trans->sync = true; ret =btrfs_log_dentry_safe (trans, dentry, start, end, &ctx);if (ret <0 ) {
fs/btrfs/transaction.h +0 -1
@@ -120,7 +120,6 @@ struct btrfs_trans_handle {bool allocating_chunk;bool can_flush_pending_bgs;bool reloc_reserved; -bool sync;bool dirty;struct btrfs_root *root;struct btrfs_fs_info *fs_info;
Signature · 1 line
2.11.0
Quoted 7 lines · On 11.03.19 г. 15:10 ч., [email protected] wrote:
From: Filipe Manana <[email protected]>
Commit
db2462a6ad3d("btrfs: don't run delayed refs in the end transaction logic") removed its last use, so now it does absolutely nothing, therefore remove it.Signed-off-by Filipe Manana <[email protected]>
Reviewed-by Nikolay Borisov <[email protected]>
Quoted 48 lines
--- fs/btrfs/extent-tree.c | 6 ------ fs/btrfs/file.c | 1 - fs/btrfs/transaction.h | 1 - 3 files changed, 8 deletions(-)fs/btrfs/extent-tree.c +0
-6@@ -2910,12 +2910,6 @@ static void delayed_ref_async_start(struct btrfs_work *work) goto done; } -/* -* trans->sync means that when we call end_transaction, we won't -* wait on delayed refs -*/ - trans->sync = true; -/* Don't bother flushing if we got into a different transaction */ if (trans->transid > async->transid) goto end;fs/btrfs/file.c +0
-1@@ -2165,7 +2165,6 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)inode_unlock (inode); goto out; } - trans->sync = true; ret =btrfs_log_dentry_safe (trans, dentry, start, end, &ctx);if (ret <0 ) {fs/btrfs/transaction.h +0
-1@@ -120,7 +120,6 @@ struct btrfs_trans_handle {bool allocating_chunk;bool can_flush_pending_bgs;bool reloc_reserved; -bool sync;bool dirty;struct btrfs_root *root;struct btrfs_fs_info *fs_info;
Quoted 7 lines · On Mon, Mar 11, 2019 at 01:10:56PM +0000, [email protected] wrote:
From: Filipe Manana <[email protected]>
Commit
db2462a6ad3d("btrfs: don't run delayed refs in the end transaction logic") removed its last use, so now it does absolutely nothing, therefore remove it.Signed-off-by Filipe Manana <[email protected]>
Added to misc-5.2, thanks.