irqchip: Add missing of_ndoe_get() in its_of_probe()
Subsystems (2)
PATCH 1/1 irqchip: Add missing of_ndoe_get() in its_of_probe()
We need to add missing of_node_get() for of_find_matching_node() to keep refcount balance.
Note: of_find_matching_node() will decrease the refcount of its first arg.
--- drivers/irqchip/irq-gic-v3-its.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/irqchip/irq-gic-v3-its.c +2 -0
@@ -5309,6 +5309,7 @@ static int __init its_of_probe(struct device_node *node)* reset, don't even try to go any further, as this could * result in something even worse. */ +of_node_get (node);for (np =of_find_matching_node (node, its_device_id); np; np =of_find_matching_node (np, its_device_id)) {int err;
@@ -5323,6 +5324,7 @@ static int __init its_of_probe(struct device_node *node)return err; } +of_node_get (node);for (np =of_find_matching_node (node, its_device_id); np; np =of_find_matching_node (np, its_device_id)) {if (!of_device_is_available (np))
Signature · 1 line
2.25.1
Marc Zyngier
maintainer+ Miaoqian Lin
Quoted 8 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Note:
of_find_matching_node()will decrease the refcount of its first arg.Signed-off-by Liang He <[email protected]>
[...]
Please send these refcount fixes as a series for all the irqchip drivers, not one every other day.
And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 11 lines · Marc Zyngier
+ Miaoqian Lin
Quoted 7 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Note:
of_find_matching_node()will decrease the refcount of its first arg.
Quoted 7 lines
Quoted 1 line
Signed-off-by Liang He <[email protected]>[...]
Please send these refcount fixes as a series for all the irqchip drivers, not one every other day.
Sorry, I will group similar bugs in future.
Quoted 6 lines
And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs.
Thanks,
M.
Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.
By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.
Quoted 3 lines
Signature · 2 lines
-- Without deviation from the norm, progress is not possible.
Marc Zyngier
maintainerQuoted 29 lines · Liang He
Quoted 11 lines · Marc Zyngier
+ Miaoqian Lin
Quoted 7 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Note:
of_find_matching_node()will decrease the refcount of its first arg.Quoted 7 lines
Quoted 1 line
Signed-off-by Liang He <[email protected]>[...]
Please send these refcount fixes as a series for all the irqchip drivers, not one every other day.
Sorry, I will group similar bugs in future.
Quoted 3 lines
And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs.
Quoted 6 lines
Quoted 3 lines
Thanks,
M.Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.
This is not what I meant. I am asking you to actively coordinate with Miaoqian, working with them as a team instead of you both sending competing series. I would like to see one series with patches from you both.
Quoted 2 lines
By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.
Well, yet another reason for you both to work together, as you are complementing each other.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 35 lines · Marc Zyngier
Quoted 33 lines · Liang He
Quoted 11 lines · Marc Zyngier
+ Miaoqian Lin
Quoted 7 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Note:
of_find_matching_node()will decrease the refcount of its first arg.Quoted 7 lines
Quoted 1 line
Signed-off-by Liang He <[email protected]>[...]
Please send these refcount fixes as a series for all the irqchip drivers, not one every other day.
Sorry, I will group similar bugs in future.
Quoted 6 lines
And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs.
Thanks,
M.
Quoted 7 lines
Quoted 2 lines
Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.
This is not what I meant. I am asking you to actively coordinate with Miaoqian, working with them as a team instead of you both sending competing series. I would like to see one series with patches from you both.
OK, I get it. This depends on Miaoqian.
Quoted 13 lines
Quoted 3 lines
By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.
Well, yet another reason for you both to work together, as you are complementing each other.
Thanks,
M.Signature · 1 line
Without deviation from the norm, progress is not possible.
Hi,
Quoted 32 lines · Liang He
Quoted 29 lines · Marc Zyngier
Quoted 27 lines · Liang He
Quoted 7 lines · Marc Zyngier
+ Miaoqian Lin
Quoted 3 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Quoted 9 lines
Quoted 4 lines
Note:
of_find_matching_node()will decrease the refcount of its first arg.Signed-off-by Liang He <[email protected]>[...]
Please send these refcount fixes as a series for all the irqchip drivers, not one every other day.
Sorry, I will group similar bugs in future.
Quoted 5 lines
And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs.
Thanks,
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
M.Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.
This is not what I meant. I am asking you to actively coordinate with Miaoqian, working with them as a team instead of you both sending competing series. I would like to see one series with patches from you both.
OK, I get it. This depends on Miaoqian.
Sure, I would like to work with Liang to fix these bugs.
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.
It's a nice catch and I haven't noticed before.
Quoted 9 lines
Quoted 9 lines
Well, yet another reason for you both to work together, as you are complementing each other.
Thanks,
M.Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 10 lines · Liang He
We need to add missing
of_node_get()forof_find_matching_node()to keep refcount balance.Note:
of_find_matching_node()will decrease the refcount of its first arg.Signed-off-by Liang He <[email protected]>--- drivers/irqchip/irq-gic-v3-its.c | 2 ++ 1 file changed, 2 insertions(+)
Before applying the patch please check it carefully. Previous evidence [1][2] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/[email protected]/
[2]
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof