Skip to contentSkip to conversation

Bluetooth: hci_conn: Fix default RX PHY initialization

PATCH In review Jackie Liu 2 participants 2 messages Oct 14

Subsystems (2)
lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH 1/1 Bluetooth: hci_conn: Fix default RX PHY initialization

From: Jackie Liu <[email protected]>

Initialize the connection's default RX PHYs from hdev->le_rx_def_phys instead of the TX defaults, which may differ from the RX configuration.

Fixes 129d1ef3c5e6 ("Bluetooth: hci_conn: Fix using conn->le_{tx,rx}_phy as supported PHYs")
---
 net/bluetooth/hci_conn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_conn.c +1 -1
index 96195d2fd10f..c8fd3e2c79bd 100644
@@ -1102,7 +1102,7 @@ static struct hci_conn *__hci_conn_add(struct hci_dev *hdev, int type,
 		 * remote features are resolved.
 		 */
 		conn->le_tx_def_phys = hdev->le_tx_def_phys;
-		conn->le_rx_def_phys = hdev->le_tx_def_phys;
+		conn->le_rx_def_phys = hdev->le_rx_def_phys;
 		break;
 	case CIS_LINK:
 		/* conn->src should reflect the local identity address */
Signature · 1 line
2.55.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1185171/

---Test result---

Test Summary:

CheckPatch                    FAIL      0.75 seconds
VerifyFixes                   PASS      0.12 seconds
VerifySignedoff               PASS      0.12 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      29.85 seconds
CheckAllWarning               PASS      35.17 seconds
CheckSparse                   PASS      37.19 seconds
BuildKernel32                 PASS      30.54 seconds
CheckKernelLLVM               PASS      37.42 seconds
TestRunnerSetup               PASS      723.66 seconds
TestRunner_l2cap-tester       PASS      12.66 seconds
TestRunner_iso-tester         PASS      11.00 seconds
TestRunner_bnep-tester        PASS      3.14 seconds
TestRunner_mgmt-tester        PASS      87.60 seconds
TestRunner_rfcomm-tester      PASS      4.50 seconds
TestRunner_sco-tester         PASS      5.64 seconds
TestRunner_ioctl-tester       PASS      4.60 seconds
TestRunner_mesh-tester        PASS      5.53 seconds
TestRunner_smp-tester         PASS      4.35 seconds
TestRunner_userchan-tester    PASS      8.12 seconds
TestRunner_6lowpan-tester     PASS      4.56 seconds
IncrementalBuild              PASS      28.22 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: hci_conn: Fix default RX PHY initialization
WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report #69:

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/home/runner/work/bluetooth-next/bluetooth-next/src/patch/14887278.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

https://github.com/bluez/bluetooth-next/pull/926

---
Regards,
Linux Bluetooth