monitor: Fix legacy SCAN_RSP PDU type names
PATCH RESEND 1/1 monitor: Fix legacy SCAN_RSP PDU type names
The names of the two legacy scan response event types are swapped. A scan response keeps the properties of the advertisement it answers, so 0x1b, which has the connectable bit set, is the response to ADV_IND and 0x1a is the response to ADV_SCAN_IND, as listed in Core Specification Vol 4, Part E, 7.7.65.13, Table 7.1.
--- monitor/packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
monitor/packet.c +2 -2
@@ -13076,10 +13076,10 @@ static void print_legacy_adv_report_pdu(uint16_t flags) str ="ADV_DIRECT_IND" ;break ;case 0x1a : - str ="SCAN_RSP to an ADV_IND" ; + str ="SCAN_RSP to an ADV_SCAN_IND" ;break ;case 0x1b : - str ="SCAN_RSP to an ADV_SCAN_IND" ; + str ="SCAN_RSP to an ADV_IND" ;break ;default : str ="Reserved" ;
base-commit: fa6ba55020dee3c3183041c854c347b4582448be
Signature · 1 line
2.54.0 (Apple Git-157)
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1188585/
---Test result---
Test Summary:
CheckPatch PASS 0.38 seconds GitLint PASS 0.27 seconds BuildEll PASS 14.72 seconds BluezMake PASS 215.23 seconds MakeCheck PASS 0.68 seconds MakeDistcheck PASS 109.94 seconds CheckValgrind PASS 111.54 seconds CheckSmatch WARNING 190.23 seconds bluezmakeextell PASS 70.84 seconds TestFunctional PASS 904.89 seconds IncrementalBuild PASS 215.94 seconds ScanBuild PASS 747.23 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:monitor/packet.c:2289:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3925:52: warning: array of flexible structuresmonitor/bt.h:3913:40: warning: array of flexible structures
https://github.com/bluez/bluez/pull/2692
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 10 lines · On Sun, 18 Oct 2026 21:10:09 -0700 you wrote:
The names of the two legacy scan response event types are swapped. A scan response keeps the properties of the advertisement it answers, so
0x1b, which has the connectable bit set, is the response toADV_INDand0x1ais the response toADV_SCAN_IND, as listed in Core Specification Vol 4, Part E, 7.7.65.13, Table 7.1.Fixes e29ef3b85116 ("monitor: Add LE Extended Scan commands decoding")Assisted-by Claude:claude-opus-5.5[...]
Here is the summary with links:
- [BlueZ,RESEND] monitor: Fix legacy SCAN_RSP PDU type names
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5e348529cf4d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html