Skip to contentSkip to conversation

mpris-proxy: Stop and start together with dbus.service

PATCH In review Mitar 2 participants 2 messages Nov 3 Bluetooth drivers

lore
Share & tools
lore

Mitar

author
#0 lore raw

PATCH 1/1 mpris-proxy: Stop and start together with dbus.service

GNOME stops dbus.service when a session ends, with gnome-session-restart-dbus.service, and the bus is started again through dbus.socket once a client connects to it. mpris-proxy is not stopped with the bus: libdbus ends it with exit status 1 when the bus closes its connection, so the unit fails, and nothing starts it again as long as the user's service manager keeps running, for example when the user logs in again within logind's UserStopDelaySec=. The media players of the next session are then not registered with BlueZ.

Make the unit part of dbus.service, so that stopping the bus stops mpris-proxy first, and have dbus.service want it, so that it is started again together with the bus.

---
 tools/mpris-proxy.service.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/mpris-proxy.service.in +2 -1
index 6ae56c6..2b8a4d5 100644
@@ -4,6 +4,7 @@ Documentation=man:mpris-proxy(1)
 
 Wants=dbus.socket
 After=dbus.socket dbus.service
+PartOf=dbus.service
 ConditionUser=!@system
 
 [Service]
@@ -11,4 +12,4 @@ Type=simple
 ExecStart=@PKGBINDIR@/mpris-proxy
 
 [Install]
-WantedBy=default.target
+WantedBy=default.target dbus.service
Signature · 1 line
2.53.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1200507/

---Test result---

Test Summary:

CheckPatch                    PASS      0.31 seconds
GitLint                       PASS      0.26 seconds
BuildEll                      PASS      14.06 seconds
BluezMake                     PASS      181.99 seconds
CheckSmatch                   PASS      179.86 seconds
bluezmakeextell               PASS      66.63 seconds
TestFunctional                PASS      930.63 seconds
IncrementalBuild              PASS      177.63 seconds
ScanBuild                     PASS      604.51 seconds

https://github.com/bluez/bluez/pull/2753

---
Regards,
Linux Bluetooth