Skip to contentSkip to conversation

s390x/mvpg-sie: Remove unused variable

PATCH In review Thomas Huth 3 participants 3 messages Oct 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x/mvpg-sie: Remove unused variable

The guest_instr variable is not used, which was likely a copy-n-paste issue from the s390x/sie.c test.

---
 s390x/mvpg-sie.c | 3 ---
 1 file changed, 3 deletions(-)
s390x/mvpg-sie.c +0 -3
index ccc273b..5adcec1 100644
@@ -21,7 +21,6 @@
 #include <sie.h>
 
 static u8 *guest;
-static u8 *guest_instr;
 static struct vm vm;
 
 static uint8_t *src;
@@ -94,8 +93,6 @@ static void setup_guest(void)
 
 	/* Allocate 1MB as guest memory */
 	guest = alloc_pages(8);
-	/* The first two pages are the lowcore */
-	guest_instr = guest + PAGE_SIZE * 2;
 
 	sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
 
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Thu, 7 Oct 2021 09:21:36 +0200 Thomas Huth <[email protected]> wrote:

The guest_instr variable is not used, which was likely a copy-n-paste issue from the s390x/sie.c test.

Quoted 25 lines
---
 s390x/mvpg-sie.c | 3 ---
 1 file changed, 3 deletions(-)
s390x/mvpg-sie.c +0 -3
index ccc273b..5adcec1 100644
@@ -21,7 +21,6 @@
 #include <sie.h>
 
 static u8 *guest;
-static u8 *guest_instr;
 static struct vm vm;
 
 static uint8_t *src;
@@ -94,8 +93,6 @@ static void setup_guest(void)
 
 	/* Allocate 1MB as guest memory */
 	guest = alloc_pages(8);
-	/* The first two pages are the lowcore */
-	guest_instr = guest + PAGE_SIZE * 2;
 
 	sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
 
Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 4 lines · Thomas Huth

The guest_instr variable is not used, which was likely a copy-n-paste issue from the s390x/sie.c test.

Thanks, picked.

Weird that the compiler didn't complain with a set but not used message...

Quoted 26 lines
---
  s390x/mvpg-sie.c | 3 ---
  1 file changed, 3 deletions(-)
s390x/mvpg-sie.c +0 -3
index ccc273b..5adcec1 100644
@@ -21,7 +21,6 @@
  #include <sie.h>
 
  static u8 *guest;
-static u8 *guest_instr;
  static struct vm vm;
 
  static uint8_t *src;
@@ -94,8 +93,6 @@ static void setup_guest(void)
 
  	/* Allocate 1MB as guest memory */
  	guest = alloc_pages(8);
-	/* The first two pages are the lowcore */
-	guest_instr = guest + PAGE_SIZE * 2;
 
  	sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);