team: reject ARPHRD_CAN devices in team_port_add
Subsystems (3)
PATCH 1/1 team: reject ARPHRD_CAN devices in team_port_add
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in can_rx_unregister() inside net/can/af_can.c.
During team_port_add(), the code only checks IFF_LOOPBACK but does not reject ARPHRD_CAN devices. After passing this gate, team_dev_type_check_change() calls team_setup_by_port() which sets dev->type = port_dev->type, adopting the CAN type for the team device. However, CAN devices operate on a fundamentally different Layer 2 architecture, relying on the CAN mid-layer private data structure (can_ml_priv) instead of standard Ethernet structures. Since the team driver never initializes can_ml_priv, subsequent CAN subsystem operations -- such as closing an ISOTP socket bound to the team interface via isotp_release() -- reach can_rx_unregister() which dereferences the NULL can_ml_priv, causing a kernel crash.
The bonding driver already rejects CAN devices since commit 8ba68464e478 ("bonding: refuse to enslave CAN devices"). Team, as a sibling aggregation path, needs the same protection.
Fix this by adding an explicit ARPHRD_CAN check in team_port_add(), directly after the IFF_LOOPBACK guard, consistent with the approach taken in bond_enslave().
--- drivers/net/team/team_core.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/team/team_core.c +7 -0
@@ -1224,6 +1224,13 @@ static int team_port_add(struct team *team, struct net_device *port_dev,return -EINVAL ; } +if (port_dev->type ==ARPHRD_CAN ) { +NL_SET_ERR_MSG (extack,"CAN device can't be added as a team port" ); +netdev_err (dev,"Device %s is CAN device. CAN devices can't be added as a team port\n" , + portname); +return -EINVAL ; + } +if (netif_is_team_port (port_dev)) {NL_SET_ERR_MSG (extack,"Device is already a port of a team device" ); netdev_err(dev, "Device %s is already a port "
Signature · 1 line
2.34.1
Jakub Kicinski
maintainerQuoted 3 lines · On Thu, 23 Jul 2026 12:00:32 +0800 Jiale Yao wrote:
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in
can_rx_unregister()insidenet/can/af_can.c.
Gemini review says that similar issue is possible with ARPHRD_IEEE802154 devices, could you double check that, see if there are any others, and all these in a single patch?
Signature · 1 line
pw-bot: cr
Hi
Sure, I will check, and send v2 patch if there are any others.
Jiale Yao
Quoted 11 lines · Jakub Kicinski
Quoted 3 lines · On Thu, 23 Jul 2026 12:00:32 +0800 Jiale Yao wrote:
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in
can_rx_unregister()insidenet/can/af_can.c.Gemini review says that similar issue is possible with
ARPHRD_IEEE802154devices, could you double check that, see if there are any others, and all these in a single patch?Signature · 1 line
pw-bot: cr
Hi,
Quoted 3 lines · jiale yao
Hi
Sure, I will check, and send v2 patch if there are any others.
I've seen no follow-ups on this.
Did you check on other similarities between team and bonding drivers according to reject ARPHRD_IEEE802154, ARPHRD_CAN and others?
Best regards,
Oliver
Quoted 15 lines
Jiale Yao
Quoted 11 lines · Jakub Kicinski
Quoted 3 lines · On Thu, 23 Jul 2026 12:00:32 +0800 Jiale Yao wrote:
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in
can_rx_unregister()insidenet/can/af_can.c.Gemini review says that similar issue is possible with
ARPHRD_IEEE802154devices, could you double check that, see if there are any others, and all these in a single patch?Signature · 1 line
pw-bot: cr
Hi,
Sorry for I change the subject name, the new patch is
https://lore.kernel.org/all/[email protected]/
Quoted 30 lines · Oliver Hartkopp
Hi,
Quoted 3 lines · jiale yao
Hi
Sure, I will check, and send v2 patch if there are any others.
I've seen no follow-ups on this.
Did you check on other similarities between team and bonding drivers according to reject
ARPHRD_IEEE802154,ARPHRD_CANand others?Best regards,
OliverQuoted 15 lines
Jiale Yao
Quoted 11 lines · Jakub Kicinski
Quoted 3 lines · On Thu, 23 Jul 2026 12:00:32 +0800 Jiale Yao wrote:
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in
can_rx_unregister()insidenet/can/af_can.c.Gemini review says that similar issue is possible with
ARPHRD_IEEE802154devices, could you double check that, see if there are any others, and all these in a single patch?Signature · 1 line
pw-bot: cr
Quoted 21 lines · Jiale Yao
Enslaving a CAN device (e.g. vxcan) to a team master triggers a NULL pointer dereference in
can_rx_unregister()insidenet/can/af_can.c.During
team_port_add(), the code only checksIFF_LOOPBACKbut does not rejectARPHRD_CANdevices. After passing this gate,team_dev_type_check_change()callsteam_setup_by_port()which setsdev->type=port_dev->type, adopting the CAN type for the team device. However, CAN devices operate on a fundamentally different Layer 2 architecture, relying on the CAN mid-layer private data structure (can_ml_priv) instead of standard Ethernet structures. Since the team driver never initializescan_ml_priv, subsequent CAN subsystem operations -- such as closing an ISOTP socket bound to the team interface viaisotp_release()-- reachcan_rx_unregister()which dereferences the NULLcan_ml_priv, causing a kernel crash.The bonding driver already rejects CAN devices since commit
8ba68464e478("bonding: refuse to enslave CAN devices"). Team, as a sibling aggregation path, needs the same protection.
Quoted 7 lines
Fix this by adding an explicit
ARPHRD_CANcheck inteam_port_add(), directly after theIFF_LOOPBACKguard, consistent with the approach taken inbond_enslave().Fixes 1d76efe1577b ("team: add support for non-ethernet devices")Assisted-by Claude:deepseek-v4-proSigned-off-by Jiale Yao <[email protected]>
I did not know that the team driver had the same approach. Thanks for catching this!
Best regards,
Oliver
Quoted 22 lines
--- drivers/net/team/team_core.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/net/team/team_core.c +7
-0@@ -1224,6 +1224,13 @@ static int team_port_add(struct team *team, struct net_device *port_dev,return -EINVAL ; } +if (port_dev->type ==ARPHRD_CAN ) { +NL_SET_ERR_MSG (extack,"CAN device can't be added as a team port" ); +netdev_err (dev,"Device %s is CAN device. CAN devices can't be added as a team port\n" , + portname); +return -EINVAL ; + } +if (netif_is_team_port (port_dev)) {NL_SET_ERR_MSG (extack,"Device is already a port of a team device" ); netdev_err(dev, "Device %s is already a port "