x86/resctrl: Slightly clean-up mbm_config_show()
Subsystems (3)
PATCH 1/1 x86/resctrl: Slightly clean-up mbm_config_show()
'mon_info' is already zeroed in the list_for_each_entry() loop below. There is no need to explicitly initialize it here. It just wastes some space and cycles.
Remove this un-needed code.
On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
74967 5103 1880 81950 1401e arch/x86/kernel/cpu/resctrl/rdtgroup.o
After:
=====
text data bss dec hex filename
74903 5103 1880 81886 13fde arch/x86/kernel/cpu/resctrl/rdtgroup.o
--- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/rdtgroup.c +1 -1
@@ -1596,7 +1596,7 @@ static void mondata_config_read(struct rdt_mon_domain *d, struct mon_config_infostatic int mbm_config_show (struct seq_file *s,struct rdt_resource *r,u32 evtid) { -struct mon_config_info mon_info = {0 }; +struct mon_config_info mon_info;struct rdt_mon_domain *dom;bool sep = false;
Signature · 1 line
2.45.2
Hi Christophe,
Quoted 12 lines · Christophe JAILLET
'
mon_info' is already zeroed in thelist_for_each_entry()loop below. There is no need to explicitly initialize it here. It just wastes some space and cycles.Remove this un-needed code.
On a
x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
74967 5103 1880 81950 1401earch/x86/kernel/cpu/resctrl/rdtgroup.o
Quoted 7 lines
After:
=====
text data bss dec hex filename
74903 5103 1880 81886 13fdearch/x86/kernel/cpu/resctrl/rdtgroup.oSigned-off-by Christophe JAILLET <[email protected]>---
Thank you.
Reinette