PCI/AER: Remove/unexport error reporting enable/disable
Subsystems (2)
cover PCI/AER: Remove/unexport error reporting enable/disable
From: Bjorn Helgaas <[email protected]>
pci_disable_pcie_error_reporting() is unused; remove it. pci_enable_pcie_error_reporting() is used only inside aer.c; make it static.
Bjorn Helgaas (2):
PCI/AER: Drop unused pci_disable_pcie_error_reporting() PCI/AER: Unexport pci_enable_pcie_error_reporting()
drivers/pci/pcie/aer.c | 15 +-------------- include/linux/aer.h | 11 ----------- 2 files changed, 1 insertion(+), 25 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/2 PCI/AER: Drop unused pci_disable_pcie_error_reporting()
From: Bjorn Helgaas <[email protected]>
pci_disable_pcie_error_reporting() has no callers. Remove it.
--- drivers/pci/pcie/aer.c | 12 ------------ include/linux/aer.h | 5 ----- 2 files changed, 17 deletions(-)
drivers/pci/pcie/aer.c +0 -12
@@ -242,18 +242,6 @@ int pci_enable_pcie_error_reporting(struct pci_dev *dev) }EXPORT_SYMBOL_GPL (pci_enable_pcie_error_reporting); -int pci_disable_pcie_error_reporting (struct pci_dev *dev) -{ -int rc; - -if (!pcie_aer_is_native (dev)) -return -EIO ; - - rc =pcie_capability_clear_word (dev,PCI_EXP_DEVCTL ,PCI_EXP_AER_FLAGS ); -return pcibios_err_to_errno (rc); -} -EXPORT_SYMBOL_GPL (pci_disable_pcie_error_reporting); -int pci_aer_clear_nonfatal_status (struct pci_dev *dev) {int aer = dev->aer_cap;
include/linux/aer.h +0 -5
@@ -43,17 +43,12 @@ struct aer_capability_regs {#if defined(CONFIG_PCIEAER )/* PCIe port driver needs this function to enable AER */ int pci_enable_pcie_error_reporting (struct pci_dev *dev); -int pci_disable_pcie_error_reporting (struct pci_dev *dev);int pci_aer_clear_nonfatal_status (struct pci_dev *dev);#else static inline int pci_enable_pcie_error_reporting (struct pci_dev *dev) {return -EINVAL ; } -static inline int pci_disable_pcie_error_reporting (struct pci_dev *dev) -{ -return -EINVAL ; -}static inline int pci_aer_clear_nonfatal_status (struct pci_dev *dev) {return -EINVAL ;
Signature · 1 line
2.34.1
Re: [PATCH 1/2] PCI/AER: Drop unused pci_disable_pcie_error_reporting()
Looks good:
PATCH 2/2 PCI/AER: Unexport pci_enable_pcie_error_reporting()
In reply to Bjorn HelgaasFrom: Bjorn Helgaas <[email protected]>
pci_enable_pcie_error_reporting() is used only inside aer.c. Stop exposing it outside the file.
--- drivers/pci/pcie/aer.c | 3 +-- include/linux/aer.h | 6 ------ 2 files changed, 1 insertion(+), 8 deletions(-)
drivers/pci/pcie/aer.c +1 -2
@@ -230,7 +230,7 @@ int pcie_aer_is_native(struct pci_dev *dev)return pcie_ports_native || host->native_aer; } -int pci_enable_pcie_error_reporting (struct pci_dev *dev) +static int pci_enable_pcie_error_reporting (struct pci_dev *dev) {int rc;
@@ -240,7 +240,6 @@ int pci_enable_pcie_error_reporting(struct pci_dev *dev) rc =pcie_capability_set_word (dev,PCI_EXP_DEVCTL ,PCI_EXP_AER_FLAGS );return pcibios_err_to_errno (rc); } -EXPORT_SYMBOL_GPL (pci_enable_pcie_error_reporting);int pci_aer_clear_nonfatal_status (struct pci_dev *dev) {
include/linux/aer.h +0 -6
@@ -41,14 +41,8 @@ struct aer_capability_regs { };#if defined(CONFIG_PCIEAER ) -/* PCIe port driver needs this function to enable AER */ -int pci_enable_pcie_error_reporting (struct pci_dev *dev);int pci_aer_clear_nonfatal_status (struct pci_dev *dev);#else -static inline int pci_enable_pcie_error_reporting (struct pci_dev *dev) -{ -return -EINVAL ; -}static inline int pci_aer_clear_nonfatal_status (struct pci_dev *dev) {return -EINVAL ;
Signature · 1 line
2.34.1
Re: [PATCH 2/2] PCI/AER: Unexport pci_enable_pcie_error_reporting()
Looks good:
Quoted 5 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
pci_disable_pcie_error_reporting()is unused; remove it.pci_enable_pcie_error_reporting()is used only insideaer.c; make it static.
Looks fine to me.
Quoted 9 lines
Bjorn Helgaas (2):
PCI/AER: Drop unusedpci_disable_pcie_error_reporting()PCI/AER: Unexportpci_enable_pcie_error_reporting()drivers/pci/pcie/aer.c | 15 +-------------- include/linux/aer.h | 11 ----------- 2 files changed, 1 insertion(+), 25 deletions(-)
Signature · 2 lines
Sathyanarayanan Kuppuswamy Linux Kernel Developer
Bjorn Helgaas
AppliedQuoted 6 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
pci_disable_pcie_error_reporting()is unused; remove it.pci_enable_pcie_error_reporting()is used only insideaer.c; make it static.
Quoted 7 lines
Bjorn Helgaas (2):
PCI/AER: Drop unusedpci_disable_pcie_error_reporting()PCI/AER: Unexportpci_enable_pcie_error_reporting()drivers/pci/pcie/aer.c | 15 +-------------- include/linux/aer.h | 11 ----------- 2 files changed, 1 insertion(+), 25 deletions(-)
Applied to pci/aer for v6.6, thanks Christoph and Sathy!