Skip to contentSkip to conversation

MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section

PATCH In review Lukas Bulwahn 2 participants 2 messages Jan 8, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section

Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization") adds new documentation and a corresponding MAINTAINERS section. It however uses spaces instead of a single tab for all the entries in that MAINTAINERS section.

Although, the get_maintainer.pl script handles spaces instead of tabs silently, the MAINTAINERS will quickly get into a messy state with different indentations throughout the file. So, the checkpatch.pl script complains when spaces instead of a single tab are used.

Fix this recently added section using tabs instead of spaces.

Fixes 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
---
 MAINTAINERS | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
MAINTAINERS +4 -4
index fa67e2624723..c76884e40434 100644
@@ -5296,10 +5296,10 @@ W:	http://accessrunner.sourceforge.net/
 F:	drivers/usb/atm/cxacru.c
 
 CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
-M:    Elena Reshetova <[email protected]>
-M:    Carlos Bilbao <[email protected]>
-S:    Maintained
-F:    Documentation/security/snp-tdx-threat-model.rst
+M:	Elena Reshetova <[email protected]>
+M:	Carlos Bilbao <[email protected]>
+S:	Maintained
+F:	Documentation/security/snp-tdx-threat-model.rst
 
 CONFIGFS
 M:	Joel Becker <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw

Hello,

Quoted 10 lines · Lukas Bulwahn

Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization") adds new documentation and a corresponding MAINTAINERS section. It however uses spaces instead of a single tab for all the entries in that MAINTAINERS section.

Although, the get_maintainer.pl script handles spaces instead of tabs silently, the MAINTAINERS will quickly get into a messy state with different indentations throughout the file. So, the checkpatch.pl script complains when spaces instead of a single tab are used.

Quoted 4 lines

Fix this recently added section using tabs instead of spaces.

Fixes 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")

Jakub has already addressed this issue with the patch "[PATCH docs]
MAINTAINERS: use tabs for indent of CONFIDENTIAL COMPUTING THREAT MODEL" from 1/3/24. Also, I recommend refraining from using the 'Fixes' tag for things of this nature. NACK.

Quoted 13 lines
---
  MAINTAINERS | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
MAINTAINERS +0 -1
index fa67e2624723..c76884e40434 100644
@@ -5296,10 +5296,10 @@ W:	http://accessrunner.sourceforge.net/
  F:	drivers/usb/atm/cxacru.c
 
  CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
-M:    Elena Reshetova <[email protected]>

MAINTAINERS W: http://accessrunner.sourceforge.net/ · line 5305

Quoted 10 lines
MAINTAINERS +4 -3
-M:    Carlos Bilbao <[email protected]>
-S:    Maintained
-F:    Documentation/security/snp-tdx-threat-model.rst
+M:	Elena Reshetova <[email protected]>
+M:	Carlos Bilbao <[email protected]>
+S:	Maintained
+F:	Documentation/security/snp-tdx-threat-model.rst
 
  CONFIGFS
  M:	Joel Becker <[email protected]>

Thanks,
Carlos