Skip to contentSkip to conversation

net: wireless: ralink: rt2x00: "foo* bar" should be "foo *bar"

PATCH In review [email protected] 3 participants 6 messages Jul 21, 2023 – Aug 10, 2023 1 message not in the archive Ralink RT2X00 wireless LAN driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 net: wireless: ralink: rt2x00: "foo* bar" should be "foo *bar"

Fix checkpatch warnings:

./drivers/net/wireless/ralink/rt2x00/rt2x00.h:386: ERROR: "foo* bar" should be "foo *bar" ./drivers/net/wireless/ralink/rt2x00/rt2x00.h:513: ERROR: "foo* bar" should be "foo *bar"

---
 drivers/net/wireless/ralink/rt2x00/rt2x00.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ralink/rt2x00/rt2x00.h +2 -2
index 07a6a5a..c883d7f 100644
@@ -383,7 +383,7 @@ struct rt2x00_intf {
     atomic_t seqno;
 };
 
-static inline struct rt2x00_intf* vif_to_intf(struct ieee80211_vif *vif)
+static inline struct rt2x00_intf *vif_to_intf(struct ieee80211_vif *vif)
 {
     return (struct rt2x00_intf *)vif->drv_priv;
 }
@@ -510,7 +510,7 @@ struct rt2x00_sta {
     int wcid;
 };
 
-static inline struct rt2x00_sta* sta_to_rt2x00_sta(struct ieee80211_sta *sta)
+static inline struct rt2x00_sta *sta_to_rt2x00_sta(struct ieee80211_sta *sta)
 {
     return (struct rt2x00_sta *)sta->drv_priv;
 }
#2 lore raw
Quoted 8 lines · On Fri, 2023-07-21 at 14:34 +0800, [email protected] wrote:

Fix checkpatch warnings:

./drivers/net/wireless/ralink/rt2x00/rt2x00.h:386: ERROR: "foo* bar" should be "foo *bar" ./drivers/net/wireless/ralink/rt2x00/rt2x00.h:513: ERROR: "foo* bar" should be "foo *bar"

This patch is broken. I'll just point you to what I wrote before:

https://lore.kernel.org/all/[email protected]/

What _are_ you trying to achieve?!

Currently all you're achieving is annoying everyone with broken (and pointless submissions).

johannes

#3 lore raw
Quoted 10 lines · Johannes Berg
Quoted 8 lines · On Fri, 2023-07-21 at 14:34 +0800, [email protected] wrote:

Fix checkpatch warnings:

./drivers/net/wireless/ralink/rt2x00/rt2x00.h:386: ERROR: "foo* bar" should be "foo *bar" ./drivers/net/wireless/ralink/rt2x00/rt2x00.h:513: ERROR: "foo* bar" should be "foo *bar"

Quoted 9 lines

This patch is broken. I'll just point you to what I wrote before:

https://lore.kernel.org/all/[email protected]/

What _are_ you trying to achieve?!

Currently all you're achieving is annoying everyone with broken (and pointless submissions).

And the email address doesn't even work, only about two weeks after you sent this patch?

[email protected]

    host mx1.qiye.aliyun.com [47.246.146.58]
    SMTP error from remote mail server after RCPT TO:<[email protected]>:
    554 RCPT ([email protected]) dosn't exist

johannes

#4 lore raw
Quoted 21 lines · Johannes Berg
Quoted 10 lines · Johannes Berg
Quoted 8 lines · On Fri, 2023-07-21 at 14:34 +0800, [email protected] wrote:

Fix checkpatch warnings:

./drivers/net/wireless/ralink/rt2x00/rt2x00.h:386: ERROR: "foo* bar" should be "foo *bar" ./drivers/net/wireless/ralink/rt2x00/rt2x00.h:513: ERROR: "foo* bar" should be "foo *bar"

Quoted 9 lines

This patch is broken. I'll just point you to what I wrote before:

https://lore.kernel.org/all/[email protected]/

What _are_ you trying to achieve?!

Currently all you're achieving is annoying everyone with broken (and pointless submissions).

Quoted 8 lines

And the email address doesn't even work, only about two weeks after you sent this patch?

[email protected]

    host mx1.qiye.aliyun.com [47.246.146.58]
    SMTP error from remote mail server after RCPT TO:<[email protected]>:
    554 RCPT ([email protected]) dosn't exist

No wonder why @208suo.com people ignore reviews from mailing list - their addresses are send-only without real mailboxes...

BTW, how can you get above error message? I'm curious.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#5 lore raw
Quoted 9 lines · Bagas Sanjaya
Quoted 8 lines

And the email address doesn't even work, only about two weeks after you sent this patch?

[email protected]

    host mx1.qiye.aliyun.com [47.246.146.58]
    SMTP error from remote mail server after RCPT TO:<[email protected]>:
    554 RCPT ([email protected]) dosn't exist
Quoted 4 lines

No wonder why @208suo.com people ignore reviews from mailing list - their addresses are send-only without real mailboxes...

BTW, how can you get above error message? I'm curious.

That was just the error message I got back from my mail server, presumably now that you actually tried emailing them, you also got one.

I'm beginning to think we should just block that whole domain until someone there is actually willing to _interact_, not just throw (garbage!) patches over the fence.

johannes

#6 lore raw
Quoted 10 lines · Johannes Berg
Quoted 9 lines · Bagas Sanjaya
Quoted 8 lines

And the email address doesn't even work, only about two weeks after you sent this patch?

[email protected]

    host mx1.qiye.aliyun.com [47.246.146.58]
    SMTP error from remote mail server after RCPT TO:<[email protected]>:
    554 RCPT ([email protected]) dosn't exist
Quoted 8 lines
Quoted 4 lines

No wonder why @208suo.com people ignore reviews from mailing list - their addresses are send-only without real mailboxes...

BTW, how can you get above error message? I'm curious.

That was just the error message I got back from my mail server, presumably now that you actually tried emailing them, you also got one.

Ack, I also got above delivery failure notification, hence removing Yu Han from address list.

Quoted 4 lines

I'm beginning to think we should just block that whole domain until someone there is actually willing to _interact_, not just throw (garbage!) patches over the fence.

Ack too! I'm leaning towards blocking for sanity of myself and mailing lists. IMO, we should have done the same against @cdjrlc.com addresses when they sent spelling fixes that are 50-50 correct but they also ignored change-requested reviews.

Thanks!

Signature · 1 line
An old man doll... just what I always wanted! - Clara