drm/i915/bdw: Add WaHdcDisableFetchWhenMasked
Subsystems (2)
PATCH 1/1 drm/i915/bdw: Add WaHdcDisableFetchWhenMasked
We already have it for chv, but was missing for bdw.
--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +2 -0
@@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)* workaround for for a possible hang in the unlikely event a TLB * invalidation occurs during a PSD flush. */ +/* WaHdcDisableFetchWhenMasked:bdw */ /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ WA_SET_BIT_MASKED (HDC_CHICKEN0 ,HDC_FORCE_NON_COHERENT | +HDC_DONOT_FETCH_MEM_WHEN_MASKED | (IS_BDW_GT3 (dev) ?HDC_FENCE_DEST_SLM_DISABLE :0 ));/* Wa4x4STCOptimizationDisable:bdw */
Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_ringbuffer.c +0
-0
drivers/gpu/drm/i915/intel_ringbuffer.c static int bdw_init_workarounds(struct intel_engine_cs *ring) · line 764
Quoted 9 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +2
-0@@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)* workaround for for a possible hang in the unlikely event a TLB * invalidation occurs during a PSD flush. */ +/* WaHdcDisableFetchWhenMasked:bdw */ /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ WA_SET_BIT_MASKED (HDC_CHICKEN0 ,HDC_FORCE_NON_COHERENT | +HDC_DONOT_FETCH_MEM_WHEN_MASKED | (IS_BDW_GT3 (dev) ?HDC_FENCE_DEST_SLM_DISABLE :0 ));
We also seem to miss the w/a name for the "force non-coherent" thing. Can you add that as well?
Quoted 9 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0
-0/* Wa4x4STCOptimizationDisable:bdw */ Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 24 lines · Ville Syrjälä
Quoted 12 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_ringbuffer.c +0
-0drivers/gpu/drm/i915/intel_ringbuffer.c static int bdw_init_workarounds(struct intel_engine_cs *ring) · line 764
Quoted 9 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +2
-0@@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)* workaround for for a possible hang in the unlikely event a TLB * invalidation occurs during a PSD flush. */ +/* WaHdcDisableFetchWhenMasked:bdw */ /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ WA_SET_BIT_MASKED (HDC_CHICKEN0 ,HDC_FORCE_NON_COHERENT | +HDC_DONOT_FETCH_MEM_WHEN_MASKED | (IS_BDW_GT3 (dev) ?HDC_FENCE_DEST_SLM_DISABLE :0 ));Reviewed-by Ville Syrjälä <[email protected]>
Quoted 2 lines
We also seem to miss the w/a name for the "force non-coherent" thing. Can you add that as well?
Sure, I'll add the missing _WaForceEnableNonCoherent:bdw_ label
Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0
-0/* Wa4x4STCOptimizationDisable:bdw */ Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 8 lines · Ville Syrjälä
Quoted 7 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 16 lines
Quoted 5 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0
-0drivers/gpu/drm/i915/intel_ringbuffer.c static int bdw_init_workarounds(struct intel_engine_cs *ring) · line 764
Quoted 9 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +2
-0@@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)* workaround for for a possible hang in the unlikely event a TLB * invalidation occurs during a PSD flush. */ +/* WaHdcDisableFetchWhenMasked:bdw */ /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ WA_SET_BIT_MASKED (HDC_CHICKEN0 ,HDC_FORCE_NON_COHERENT | +HDC_DONOT_FETCH_MEM_WHEN_MASKED | (IS_BDW_GT3 (dev) ?HDC_FENCE_DEST_SLM_DISABLE :0 ));Reviewed-by Ville Syrjälä <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Ville Syrjälä
Quoted 2 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)Reviewed-by Ville Syrjälä <[email protected]>Queued for -next, thanks for the patch.
-Daniel
Hi Daniel,
Thanks for merging the patch, but you picked v1.
I sent an updated version adding the missing wa name in that same register, as Ville suggested ([email protected]).
-Michel
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · Michel Thierry
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Ville Syrjälä
Quoted 2 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)Reviewed-by Ville Syrjälä <[email protected]>Queued for -next, thanks for the patch.
-Daniel
Quoted 6 lines
Hi Daniel,
Thanks for merging the patch, but you picked v1.
I sent an updated version adding the missing wa name in that same register, as Ville suggested ([email protected]).
Oops sorry. Unfortunately that is already in the frozen part of dinq history, so can't exchange. Can you please resubmit a new patch with just the missing bits (and Ville's r-b included)?
Thanks, Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Daniel Vetter
Quoted 11 lines · Michel Thierry
Quoted 10 lines · Daniel Vetter
Quoted 9 lines · Ville Syrjälä
Quoted 7 lines · Michel Thierry
We already have it for chv, but was missing for bdw.
Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 1 file changed, 2 insertions(+)Reviewed-by Ville Syrjälä <[email protected]>Quoted 8 lines
Quoted 2 lines
Queued for -next, thanks for the patch.
-DanielHi Daniel,
Thanks for merging the patch, but you picked v1.
I sent an updated version adding the missing wa name in that same register, as Ville suggested ([email protected]).
Quoted 5 lines
Oops sorry. Unfortunately that is already in the frozen part of dinq history, so can't exchange. Can you please resubmit a new patch with just the missing bits (and Ville's r-b included)?
Thanks, Daniel
Sure, I just sent it.
Thanks,
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915/bdw: Add WaHdcDisableFetchWhenMasked
In reply to Michel ThierryWe already have it for chv, but was missing for bdw.
v2: Label WaForceEnableNonCoherent (Ville)
--- drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +3 -0
@@ -756,9 +756,12 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)* workaround for for a possible hang in the unlikely event a TLB * invalidation occurs during a PSD flush. */ +/* WaForceEnableNonCoherent:bdw */ +/* WaHdcDisableFetchWhenMasked:bdw */ /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */ WA_SET_BIT_MASKED (HDC_CHICKEN0 ,HDC_FORCE_NON_COHERENT | +HDC_DONOT_FETCH_MEM_WHEN_MASKED | (IS_BDW_GT3 (dev) ?HDC_FENCE_DEST_SLM_DISABLE :0 ));/* Wa4x4STCOptimizationDisable:bdw */
Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 364/364 364/364 ILK 366/366 366/366 SNB 450/450 450/450 IVB +17 481/498 498/498 BYT 289/289 289/289 HSW 564/564 564/564 BDW 417/417 417/417 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied IVB igt_kms_3d DMESG_WARN(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-128x128-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-128x128-random NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-128x128-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-256x256-offscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-256x256-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-256x256-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-64x64-offscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-64x64-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-64x64-random NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-64x64-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_cursor_crc_cursor-size-change NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_fence_pin_leak NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_rotation_crc_primary-rotation NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4) IVB igt_kms_rotation_crc_sprite-rotation NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M4)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 364/364 364/364 ILK 366/366 366/366 SNB 450/450 450/450 IVB +17 481/498 498/498 BYT 289/289 289/289 HSW 564/564 564/564 BDW 417/417 417/417 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied IVB igt_kms_3d DMESG_WARN(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-128x128-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-128x128-random NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-128x128-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-256x256-offscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-256x256-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-256x256-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-64x64-offscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-64x64-onscreen NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-64x64-random NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-64x64-sliding NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_cursor_crc_cursor-size-change NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_fence_pin_leak NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_rotation_crc_primary-rotation NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34) IVB igt_kms_rotation_crc_sprite-rotation NSPT(1, M34)PASS(8, M4M34M21) PASS(1, M34)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx