Skip to contentSkip to conversation

common/fail_make_request: fix error message

PATCH In review Mark Harmstone 3 participants 3 messages Jul 31, 2024 – Oct 11, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/fail_make_request: fix error message

fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.

---
 common/fail_make_request | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/fail_make_request +1 -1
index b5370ba6..56402021 100644
@@ -7,7 +7,7 @@ _require_fail_make_request()
 {
     [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
 	|| _notrun "$DEBUGFS_MNT/fail_make_request \
- not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
+ not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
 }
 
 _allow_fail_make_request()
Signature · 1 line
2.44.2
#1 lore raw

Would someone mind accepting this patch please? This incorrect error message keeps tripping me up whenever I'm trying to configure a kernel to work with fstests.

Thanks

Quoted 21 lines · Mark Harmstone

fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.

---
  common/fail_make_request | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
common/fail_make_request +1 -1
index b5370ba6..56402021 100644
@@ -7,7 +7,7 @@ _require_fail_make_request()
  {
      [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
  	|| _notrun "$DEBUGFS_MNT/fail_make_request \
- not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
+ not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
  }
 
  _allow_fail_make_request()
Reviewed-by on v1 1/1
#2 lore raw
In reply to Mark Harmstone
Quoted 5 lines · Mark Harmstone

fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST to function, not CONFIG_FAULT_INJECTION_DEBUG_FS.

---

Make sense to me. Maybe it want to write CONFIG_FAULT_INJECTION, anyway,

Quoted 20 lines
 common/fail_make_request | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/fail_make_request +1 -1
index b5370ba6..56402021 100644
@@ -7,7 +7,7 @@ _require_fail_make_request()
 {
     [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
 	|| _notrun "$DEBUGFS_MNT/fail_make_request \
- not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
+ not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
 }
 
 _allow_fail_make_request()
Signature · 1 line
2.44.2