lirc-tools: new package

PATCH Superseded github at wilberforce.co.nz 2 participants 2 messages Mar 24, 2015

Share & tools

github at wilberforce.co.nz

author

2015-03-24 09:36 UTC #0 lore raw

PATCH v3 1/1 lirc-tools: new package

1. What I was trying to say, that there is no point in using this package unless the lirc kernel package has been selected.

Should this be added as a dependency, rather than just on BR2_LINUX_KERNEL?

2. Noted re the personal notes.

3. I'll look at added the license details

Quoted 1 line

Please remove this part

Is this the part you mean?

Quoted 2 lines

. > +# lcdproc
+#

Thanks
Rhys

----------------------------------------
From: "Baruch Siach" <[email protected]>
Sent: Tuesday, March 24, 2015 7:17 PM
To: "Rhys Williams" <[email protected]>
Subject: Re: [Buildroot] [PATCH v3] lirc-tools: new package

Hi Rhys,

Quoted 2 lines · Rhys Williams

This package adds the userspace tools LIRC - Linux remote control. The Kernel package will need to be selected.

In this case the package should depend on BR2_LINUX_KERNEL. But are you sure
of this? The text at http://www.lirc.org/html/install.html#compiling says:

As of 0.9.1+, lirc uses the kernel modules from the official kernel. Some

of these are formerly lirc modules which are now part of the kernel. Thus,

building lirc does not involve building kernel modules (as it used to
be).

Quoted 1 line

Thanks to Baruch for help so far.

This line should not be part of the commit log that is kept forever in the

Buildroot git history. You may add "personal" comments below the --- separator...

Quoted 2 lines

Signed-off-by Rhys Williams
---

... here.

Quoted 3 lines

 package/Config.in                  |  1 +
 package/lirc-tools/Config.in       | 15 +++++++++++++++
 package/lirc-tools/S25lircd        | 38

++++++++++++++++++++++++++++++++++++++

Quoted 7 lines

 package/lirc-tools/lirc-tools.hash |  2 ++
 package/lirc-tools/lirc-tools.mk   | 20 ++++++++++++++++++++
 5 files changed, 76 insertions(+)
 create mode 100644 package/lirc-tools/Config.in
 create mode 100755 package/lirc-tools/S25lircd
 create mode 100644 package/lirc-tools/lirc-tools.hash
 create mode 100644 package/lirc-tools/lirc-tools.mk

[...]

package/lirc-tools/lirc-tools.mk

Quoted 8 lines

package/lirc-tools/lirc-tools.mk new file +0 -0
new file mode 100644
index 0000000..791ed8d
@@ -0,0 +1,20 @@

+###########################################################################
#####

package/lirc-tools/lirc-tools.mk line 3

Quoted 4 lines

package/lirc-tools/lirc-tools.mk new file +3 -0
+#
+# lirc-tools
+#

+###########################################################################
#####

package/lirc-tools/lirc-tools.mk line 7

Quoted 4 lines

package/lirc-tools/lirc-tools.mk new file +4 -0

+
+LIRC_TOOLS_VERSION = 0.9.2
+LIRC_TOOLS_SOURCE = lirc-$(LIRC_TOOLS_VERSION).tar.bz2
+LIRC_TOOLS_SITE =

http://downloads.sourceforge.net/project/lirc/LIRC/$(LIRC_TOOLS_VERSION)/

I forgot to mention that earlier, but please add license information here. See
the description of _LICENSE and _LICENSE_FILES in the manual at
http://nightly.buildroot.org/manual.html#_infrastructure_for_packages_with_s
pecific_build_systems.

package/lirc-tools/lirc-tools.mk line 9

Quoted 2 lines

package/lirc-tools/lirc-tools.mk new file +2 -0
+
+LIRC_TOOLS_CONF_OPTS = --without-x --enable-sandboxed 

--with-driver=userspace

package/lirc-tools/lirc-tools.mk line 12

Quoted 3 lines

package/lirc-tools/lirc-tools.mk new file +3 -0
+
+define LIRC_TOOLS_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/lirc-tools/S25lircd 

$(TARGET_DIR)/etc/init.d/

package/lirc-tools/lirc-tools.mk line 18

Quoted 6 lines

package/lirc-tools/lirc-tools.mk new file +6 -0
+endef
+
+$(eval $(autotools-package))
+#
+# lcdproc
+#

Please remove this part.

baruch

Signature · 6 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open 
Systems
=}------------------------------------------------ooO--U--Ooo------------{=


   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Baruch Siach

2015-03-24 11:52 UTC #1 lore raw

PATCH v3 1/1 lirc-tools: new package

Hi Rhys,

Quoted 2 lines · github at wilberforce.co.nz

1. What I was trying to say, that there is no point in using this package unless the lirc kernel package has been selected.

So please add this note in the Config.in help section.

Quoted 1 line

Should this be added as a dependency, rather than just on BR2_LINUX_KERNEL?

No need to add a dependency on BR2_LINUX_KERNEL, since the lirc package does not build kernel modules itself.

Quoted 10 lines

2. Noted re the personal notes.
3. I'll look at added the license details
4.
Quoted 1 line
Please remove this part
Is this the part you mean?
Quoted 2 lines
. > +# lcdproc
+#

Yes.

baruch

Quoted 94 lines

----------------------------------------
From: "Baruch Siach" <[email protected]>
Sent: Tuesday, March 24, 2015 7:17 PM
To: "Rhys Williams" <[email protected]>
Subject: Re: [Buildroot] [PATCH v3] lirc-tools: new package
Hi Rhys,
Quoted 2 lines · Rhys Williams
This package adds the userspace tools LIRC - Linux remote control. The Kernel package will need to be selected.
In this case the package should depend on BR2_LINUX_KERNEL. But are you sure
of this? The text at http://www.lirc.org/html/install.html#compiling says:
As of 0.9.1+, lirc uses the kernel modules from the official kernel. Some
of these are formerly lirc modules which are now part of the kernel. Thus,
building lirc does not involve building kernel modules (as it used to
be).
Quoted 1 line
Thanks to Baruch for help so far.
This line should not be part of the commit log that is kept forever in the
Buildroot git history. You may add "personal" comments below the --- separator...
Quoted 2 lines
Signed-off-by Rhys Williams
---
... here.
Quoted 3 lines
 package/Config.in                  |  1 +
 package/lirc-tools/Config.in       | 15 +++++++++++++++
 package/lirc-tools/S25lircd        | 38 
++++++++++++++++++++++++++++++++++++++
Quoted 7 lines
 package/lirc-tools/lirc-tools.hash |  2 ++
 package/lirc-tools/lirc-tools.mk   | 20 ++++++++++++++++++++
 5 files changed, 76 insertions(+)
 create mode 100644 package/lirc-tools/Config.in
 create mode 100755 package/lirc-tools/S25lircd
 create mode 100644 package/lirc-tools/lirc-tools.hash
 create mode 100644 package/lirc-tools/lirc-tools.mk
[...]
package/lirc-tools/lirc-tools.mk
Quoted 8 lines
package/lirc-tools/lirc-tools.mk new file +0 -0
new file mode 100644
index 0000000..791ed8d
@@ -0,0 +1,20 @@
+###########################################################################
#####
package/lirc-tools/lirc-tools.mk line 3
Quoted 4 lines
package/lirc-tools/lirc-tools.mk new file +3 -0
+#
+# lirc-tools
+#
+###########################################################################
#####
package/lirc-tools/lirc-tools.mk line 7
Quoted 4 lines
package/lirc-tools/lirc-tools.mk new file +4 -0
+
+LIRC_TOOLS_VERSION = 0.9.2
+LIRC_TOOLS_SOURCE = lirc-$(LIRC_TOOLS_VERSION).tar.bz2
+LIRC_TOOLS_SITE = 
http://downloads.sourceforge.net/project/lirc/LIRC/$(LIRC_TOOLS_VERSION)/
I forgot to mention that earlier, but please add license information here. See
the description of _LICENSE and _LICENSE_FILES in the manual at
http://nightly.buildroot.org/manual.html#_infrastructure_for_packages_with_s
pecific_build_systems.
package/lirc-tools/lirc-tools.mk line 9
Quoted 2 lines
package/lirc-tools/lirc-tools.mk new file +2 -0
+
+LIRC_TOOLS_CONF_OPTS = --without-x --enable-sandboxed 
--with-driver=userspace
package/lirc-tools/lirc-tools.mk line 12
Quoted 3 lines
package/lirc-tools/lirc-tools.mk new file +3 -0
+
+define LIRC_TOOLS_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/lirc-tools/S25lircd 
$(TARGET_DIR)/etc/init.d/
package/lirc-tools/lirc-tools.mk line 18
Quoted 6 lines
package/lirc-tools/lirc-tools.mk new file +6 -0
+endef
+
+$(eval $(autotools-package))
+#
+# lcdproc
+#
Please remove this part.
baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -