drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
Subsystems (2)
PATCH 1/2 drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
All timestamps returned by GuC for GuC PMU busyness are captured from GUC PM TIMESTAMP. Since this timestamp does not tick when GuC goes idle, kmd uses RING_TIMESTAMP to measure busyness of an engine with an active context. In further stress testing, the MMIO read of the RING_TIMESTAMP is seen to cause a rare hang. Resolve the issue by using gt specific timestamp from PM which is in sync with the GuC PM timestamp.
--- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 5 ++ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++++++++++----- drivers/gpu/drm/i915/i915_reg.h | 3 +- 3 files changed, 50 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.h +5 -0
@@ -215,6 +215,11 @@ struct intel_guc {* context usage for overflows. */ struct delayed_work work; + +/** +* @shift: Right shift value for the gpm timestamp +*/ +u32 shift; } timestamp;#ifdef CONFIG_DRM_I915_SELFTEST
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +43 -13
97 lines not on this page · raw message
drivers/gpu/drm/i915/i915_reg.h +2 -1
@@ -1848,7 +1848,8 @@#define BLT_HWS_PGA_GEN7 _MMIO(0x04280)#define VEBOX_HWS_PGA_GEN7 _MMIO(0x04380) -#define GUCPMTIMESTAMP _MMIO(0xC3E8) +#define MISC_STATUS0 _MMIO(0xA500) +#define MISC_STATUS1 _MMIO(0xA504)#define GEN7_TLB_RD_ADDR _MMIO(0x4700)
Signature · 1 line
2.33.1
PATCH 2/2 drm/i915/pmu: Fix KMD and GuC race on accessing busyness
GuC updates shared memory and KMD reads it. Since this is not synchronized, we run into a race where the value read is inconsistent. Sometimes the inconsistency is in reading the upper MSB bytes of the last_switch_in value. 2 types of cases are seen - upper 8 bits are zero and upper 24 bits are zero. Since these are non-zero values, it is not trivial to determine validity of these values. Instead we read the values multiple times until they are consistent. In test runs, 3 attempts results in consistent values. The upper bound is set to 6 attempts and may need to be tuned as per any new occurences.
Since the duration that gt is parked can vary, the patch also updates the gt timestamp on unpark before starting the worker.
v2:
- Initialize i
- Use READ_ONCE to access engine record
--- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 58 +++++++++++++++++-- 1 file changed, 54 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +54 -4
@@ -1114,6 +1114,19 @@ __extend_last_switch(struct intel_guc *guc, u64 *prev_start, u32 new_start)if (new_start ==lower_32_bits (*prev_start))return ; +/* +* When gt is unparked, we update the gt timestamp and start the ping +* worker that updates the gt_stamp every POLL_TIME_CLKS. As long as gt +* is unparked, all switched in contexts will have a start time that is +* within +/- POLL_TIME_CLKS of the most recent gt_stamp. +* +* If neither gt_stamp nor new_start has rolled over, then the +* gt_stamp_hi does not need to be adjusted, however if one of them has +* rolled over, we need to adjust gt_stamp_hi accordingly. +* +* The below conditions address the cases of new_start rollover and +* gt_stamp_last rollover respectively. +*/ if (new_start < gt_stamp_last && (new_start - gt_stamp_last) <=POLL_TIME_CLKS ) gt_stamp_hi++;
@@ -1125,17 +1138,45 @@ __extend_last_switch(struct intel_guc *guc, u64 *prev_start, u32 new_start) *prev_start = ((u64 )gt_stamp_hi <<32 ) | new_start; } -static void guc_update_engine_gt_clks (struct intel_engine_cs *engine) +/* +* GuC updates shared memory and KMD reads it. Since this is not synchronized, +* we run into a race where the value read is inconsistent. Sometimes the +* inconsistency is in reading the upper MSB bytes of the last_in value when +* this race occurs. 2 types of cases are seen - upper 8 bits are zero and upper +* 24 bits are zero. Since these are non-zero values, it is non-trivial to +* determine validity of these values. Instead we read the values multiple times +* until they are consistent. In test runs, 3 attempts results in consistent +* values. The upper bound is set to 6 attempts and may need to be tuned as per +* any new occurences. +*/ +static void __get_engine_usage_record (struct intel_engine_cs *engine, +u32 *last_in,u32 *id,u32 *total) {struct guc_engine_usage_record *rec =intel_guc_engine_usage (engine); +int i =0 ; + +do { + *last_in =READ_ONCE (rec->last_switch_in_stamp); + *id =READ_ONCE (rec->current_context_index); + *total =READ_ONCE (rec->total_runtime); + +if (READ_ONCE (rec->last_switch_in_stamp) == *last_in && +READ_ONCE (rec->current_context_index) == *id && +READ_ONCE (rec->total_runtime) == *total) +break ; + }while (++i <6 ); +} + +static void guc_update_engine_gt_clks (struct intel_engine_cs *engine) +{struct intel_engine_guc_stats *stats = &engine->stats.guc;struct intel_guc *guc = &engine->gt->uc.guc; -u32 last_switch = rec->last_switch_in_stamp; -u32 ctx_id = rec->current_context_index; -u32 total = rec->total_runtime; +u32 last_switch, ctx_id, total;lockdep_assert_held (&guc->timestamp.lock); +__get_engine_usage_record (engine, &last_switch, &ctx_id, &total); + stats->running = ctx_id != ~0U && last_switch;if (stats->running)__extend_last_switch (guc, &stats->start_gt_clk, last_switch);
@@ -1237,6 +1278,10 @@ static ktime_t guc_engine_busyness(struct intel_engine_cs *engine, ktime_t *now)if (!in_reset &&intel_gt_pm_get_if_awake (gt)) { stats_saved = *stats; gt_stamp_saved = guc->timestamp.gt_stamp; +/* +* Update gt_clks, then gt timestamp to simplify the 'gt_stamp - +* start_gt_clk' calculation below for active engines. +*/ guc_update_engine_gt_clks (engine);guc_update_pm_timestamp (guc, now);intel_gt_pm_put_async (gt);
@@ -1365,10 +1410,15 @@ void intel_guc_busyness_park(struct intel_gt *gt)void intel_guc_busyness_unpark (struct intel_gt *gt) {struct intel_guc *guc = >->uc.guc; +unsigned long flags; +ktime_t unused;if (!guc_submission_initialized (guc))return ; +spin_lock_irqsave (&guc->timestamp.lock, flags); +guc_update_pm_timestamp (guc, &unused); +spin_unlock_irqrestore (&guc->timestamp.lock, flags);mod_delayed_work (system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay); }
Signature · 1 line
2.33.1
Re: [Intel-gfx] [2/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness
Thanks for the offline run through of all the corner cases we are trying to handle through below codes.
...alan
Quoted 124 lines · Umesh Nerlige Ramappa
GuC updates shared memory and KMD reads it. Since this is not synchronized, we run into a race where the value read is inconsistent. Sometimes the inconsistency is in reading the upper MSB bytes of the
last_switch_invalue. 2 types of cases are seen - upper 8 bits are zero and upper 24 bits are zero. Since these are non-zero values, it is not trivial to determine validity of these values. Instead we read the values multiple times until they are consistent. In test runs, 3 attempts results in consistent values. The upper bound is set to 6 attempts and may need to be tuned as per any new occurences.Since the duration that gt is parked can vary, the patch also updates the gt timestamp on unpark before starting the worker.
v2:
- Initialize i
- UseREAD_ONCEto access engine recordFixes 77cdd054dd2c ("drm/i915/pmu: Connect engine busyness stats from GuC to pmu")Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 58 +++++++++++++++++-- 1 file changed, 54 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +54
-4@@ -1114,6 +1114,19 @@ __extend_last_switch(struct intel_guc *guc, u64 *prev_start, u32 new_start)if (new_start ==lower_32_bits (*prev_start))return ; +/* +* When gt is unparked, we update the gt timestamp and start the ping +* worker that updates the gt_stamp every POLL_TIME_CLKS. As long as gt +* is unparked, all switched in contexts will have a start time that is +* within +/- POLL_TIME_CLKS of the most recent gt_stamp. +* +* If neither gt_stamp nor new_start has rolled over, then the +* gt_stamp_hi does not need to be adjusted, however if one of them has +* rolled over, we need to adjust gt_stamp_hi accordingly. +* +* The below conditions address the cases of new_start rollover and +* gt_stamp_last rollover respectively. +*/ if (new_start < gt_stamp_last && (new_start - gt_stamp_last) <=POLL_TIME_CLKS ) gt_stamp_hi++;@@ -1125,17 +1138,45 @@ __extend_last_switch(struct intel_guc *guc, u64 *prev_start, u32 new_start) *prev_start = ((u64 )gt_stamp_hi <<32 ) | new_start; } -static void guc_update_engine_gt_clks (struct intel_engine_cs *engine) +/* +* GuC updates shared memory and KMD reads it. Since this is not synchronized, +* we run into a race where the value read is inconsistent. Sometimes the +* inconsistency is in reading the upper MSB bytes of the last_in value when +* this race occurs. 2 types of cases are seen - upper 8 bits are zero and upper +* 24 bits are zero. Since these are non-zero values, it is non-trivial to +* determine validity of these values. Instead we read the values multiple times +* until they are consistent. In test runs, 3 attempts results in consistent +* values. The upper bound is set to 6 attempts and may need to be tuned as per +* any new occurences. +*/ +static void __get_engine_usage_record (struct intel_engine_cs *engine, +u32 *last_in,u32 *id,u32 *total) {struct guc_engine_usage_record *rec =intel_guc_engine_usage (engine); +int i =0 ; + +do { + *last_in =READ_ONCE (rec->last_switch_in_stamp); + *id =READ_ONCE (rec->current_context_index); + *total =READ_ONCE (rec->total_runtime); + +if (READ_ONCE (rec->last_switch_in_stamp) == *last_in && +READ_ONCE (rec->current_context_index) == *id && +READ_ONCE (rec->total_runtime) == *total) +break ; + }while (++i <6 ); +} + +static void guc_update_engine_gt_clks (struct intel_engine_cs *engine) +{struct intel_engine_guc_stats *stats = &engine->stats.guc;struct intel_guc *guc = &engine->gt->uc.guc; -u32 last_switch = rec->last_switch_in_stamp; -u32 ctx_id = rec->current_context_index; -u32 total = rec->total_runtime; +u32 last_switch, ctx_id, total;lockdep_assert_held (&guc->timestamp.lock); +__get_engine_usage_record (engine, &last_switch, &ctx_id, &total); + stats->running = ctx_id != ~0U && last_switch;if (stats->running)__extend_last_switch (guc, &stats->start_gt_clk, last_switch);@@ -1237,6 +1278,10 @@ static ktime_t guc_engine_busyness(struct intel_engine_cs *engine, ktime_t *now)if (!in_reset &&intel_gt_pm_get_if_awake (gt)) { stats_saved = *stats; gt_stamp_saved = guc->timestamp.gt_stamp; +/* +* Update gt_clks, then gt timestamp to simplify the 'gt_stamp - +* start_gt_clk' calculation below for active engines. +*/ guc_update_engine_gt_clks (engine);guc_update_pm_timestamp (guc, now);intel_gt_pm_put_async (gt);@@ -1365,10 +1410,15 @@ void intel_guc_busyness_park(struct intel_gt *gt)void intel_guc_busyness_unpark (struct intel_gt *gt) {struct intel_guc *guc = >->uc.guc; +unsigned long flags; +ktime_t unused;if (!guc_submission_initialized (guc))return ; +spin_lock_irqsave (&guc->timestamp.lock, flags); +guc_update_pm_timestamp (guc, &unused); +spin_unlock_irqrestore (&guc->timestamp.lock, flags);mod_delayed_work (system_highpri_wq, &guc->timestamp.work, guc->timestamp.ping_delay); }
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
URL : https://patchwork.freedesktop.org/series/99301/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
URL : https://patchwork.freedesktop.org/series/99301/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11129 -> Patchwork_22093
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/index.html
Participating hosts (51 -> 43)
------------------------------
Missing (8): shard-tglu fi-hsw-4200u fi-bsw-cyan fi-ilk-650 fi-ctg-p8600 shard-rkl shard-dg1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_22093 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][1] -> [DMESG-FAIL][2] ([i915#2927] / [i915#3428])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [PASS][3] -> [FAIL][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][5] ([i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-skl-6600u/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][6] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-bsw-nick/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][7] ([i915#541]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
- fi-bsw-kefka: [DMESG-FAIL][9] ([i915#541]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/fi-bsw-kefka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/fi-bsw-kefka/igt@i915_selftest@live@gt_heartbeat.html
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][11] -> [DMESG-FAIL][12] ([i915#4494])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/bat-dg1-6/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/bat-dg1-6/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Build changes
-------------
* Linux: CI_DRM_11129 -> Patchwork_22093
CI-20190529: 20190529
CI_DRM_11129: 0b83d3cf9f9eab03ec804d56ac2686320a64f3ee @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6330: f73008bac9a8db0779264b170f630483e9165764 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22093: 4e9418c964cee10547ef67bdde75703f8de1fea0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4e9418c964ce drm/i915/pmu: Fix KMD and GuC race on accessing busyness 9fe230d0aaaa drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/index.html
Jani Nikula
maintainerQuoted 61 lines · Umesh Nerlige Ramappa
All timestamps returned by GuC for GuC PMU busyness are captured from GUC PM TIMESTAMP. Since this timestamp does not tick when GuC goes idle, kmd uses
RING_TIMESTAMPto measure busyness of an engine with an active context. In further stress testing, the MMIO read of theRING_TIMESTAMPis seen to cause a rare hang. Resolve the issue by using gt specific timestamp from PM which is in sync with the GuC PM timestamp.Fixes 77cdd054dd2c ("drm/i915/pmu: Connect engine busyness stats from GuC to pmu")Signed-off-by Umesh Nerlige Ramappa <[email protected]>Reviewed-by Alan Previn <[email protected]>--- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 5 ++ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++++++++++----- drivers/gpu/drm/i915/i915_reg.h | 3 +- 3 files changed, 50 insertions(+), 14 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc.h +5
-0@@ -215,6 +215,11 @@ struct intel_guc {* context usage for overflows. */ struct delayed_work work; + +/** +* @shift: Right shift value for the gpm timestamp +*/ +u32 shift; } timestamp;#ifdef CONFIG_DRM_I915_SELFTEST drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +16
-4@@ -1150,23 +1150,51 @@ static void guc_update_engine_gt_clks(struct intel_engine_cs *engine) } } -static void guc_update_pm_timestamp (struct intel_guc *guc, -struct intel_engine_cs *engine, -ktime_t *now) +static u32 gpm_timestamp_shift (struct intel_gt *gt) { -u32 gt_stamp_now, gt_stamp_hi; +intel_wakeref_t wakeref; +u32 reg, shift; + +with_intel_runtime_pm (gt->uncore->rpm, wakeref) + reg = intel_uncore_read(gt->uncore, RPM_CONFIG0); + + shift = (reg &GEN10_RPM_CONFIG0_CTC_SHIFT_PARAMETER_MASK ) >> +GEN10_RPM_CONFIG0_CTC_SHIFT_PARAMETER_SHIFT ; + +return 3 - shift; +} + +static u64 gpm_timestamp (struct intel_gt *gt) +{ +u32 lo, hi, old_hi, loop =0 ;
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_update_engine_gt_clks(struct intel_engine_cs *engine) · line 1179
Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +10
-0+ + hi =intel_uncore_read (gt->uncore,MISC_STATUS1 ); +do { + lo =intel_uncore_read (gt->uncore,MISC_STATUS0 ); + old_hi = hi; + hi =intel_uncore_read (gt->uncore,MISC_STATUS1 ); + }while (old_hi != hi && loop++ <2 ); + +return ((u64 )hi <<32 ) | lo; +}
See intel_uncore_read64_2x32().
Quoted 80 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +17
-9+ +static void guc_update_pm_timestamp (struct intel_guc *guc,ktime_t *now) +{ +struct intel_gt *gt =guc_to_gt (guc); +u32 gt_stamp_lo, gt_stamp_hi; +u64 gpm_ts;lockdep_assert_held (&guc->timestamp.lock); gt_stamp_hi =upper_32_bits (guc->timestamp.gt_stamp); - gt_stamp_now =intel_uncore_read (engine->uncore, -RING_TIMESTAMP (engine->mmio_base)); + gpm_ts =gpm_timestamp (gt) >> guc->timestamp.shift; + gt_stamp_lo =lower_32_bits (gpm_ts); *now =ktime_get (); -if (gt_stamp_now <lower_32_bits (guc->timestamp.gt_stamp)) +if (gt_stamp_lo <lower_32_bits (guc->timestamp.gt_stamp)) gt_stamp_hi++; - guc->timestamp.gt_stamp = ((u64 )gt_stamp_hi <<32 ) | gt_stamp_now; + guc->timestamp.gt_stamp = ((u64 )gt_stamp_hi <<32 ) | gt_stamp_lo; }/* @@ -1210,7 +1238,7 @@ static ktime_t guc_engine_busyness(struct intel_engine_cs *engine, ktime_t *now) stats_saved = *stats; gt_stamp_saved = guc->timestamp.gt_stamp;guc_update_engine_gt_clks (engine); -guc_update_pm_timestamp (guc, engine, now); +guc_update_pm_timestamp (guc, now);intel_gt_pm_put_async (gt);if (i915_reset_count (gpu_error) != reset_count) { *stats = stats_saved;@@ -1242,8 +1270,8 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)spin_lock_irqsave (&guc->timestamp.lock, flags); +guc_update_pm_timestamp (guc, &unused);for_each_engine (engine, gt, id) { -guc_update_pm_timestamp (guc, engine, &unused);guc_update_engine_gt_clks (engine); engine->stats.guc.prev_total =0 ; }@@ -1260,10 +1288,11 @@ static void __update_guc_busyness_stats(struct intel_guc *guc)ktime_t unused;spin_lock_irqsave (&guc->timestamp.lock, flags); -for_each_engine (engine, gt, id) { -guc_update_pm_timestamp (guc, engine, &unused); + +guc_update_pm_timestamp (guc, &unused); +for_each_engine (engine, gt, id)guc_update_engine_gt_clks (engine); - } +spin_unlock_irqrestore (&guc->timestamp.lock, flags); }@@ -1757,6 +1786,7 @@ int intel_guc_submission_init(struct intel_guc *guc)spin_lock_init (&guc->timestamp.lock);INIT_DELAYED_WORK (&guc->timestamp.work, guc_timestamp_ping); guc->timestamp.ping_delay = (POLL_TIME_CLKS / gt->clock_frequency +1 ) *HZ ; + guc->timestamp.shift =gpm_timestamp_shift (gt);return 0 ; }drivers/gpu/drm/i915/i915_reg.h +2
-1@@ -1848,7 +1848,8 @@#define BLT_HWS_PGA_GEN7 _MMIO(0x04280)#define VEBOX_HWS_PGA_GEN7 _MMIO(0x04380) -#define GUCPMTIMESTAMP _MMIO(0xC3E8) +#define MISC_STATUS0 _MMIO(0xA500) +#define MISC_STATUS1 _MMIO(0xA504)#define GEN7_TLB_RD_ADDR _MMIO(0x4700)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 66 lines · Jani Nikula
Quoted 65 lines · Umesh Nerlige Ramappa
All timestamps returned by GuC for GuC PMU busyness are captured from GUC PM TIMESTAMP. Since this timestamp does not tick when GuC goes idle, kmd uses
RING_TIMESTAMPto measure busyness of an engine with an active context. In further stress testing, the MMIO read of theRING_TIMESTAMPis seen to cause a rare hang. Resolve the issue by using gt specific timestamp from PM which is in sync with the GuC PM timestamp.Fixes 77cdd054dd2c ("drm/i915/pmu: Connect engine busyness stats from GuC to pmu")Signed-off-by Umesh Nerlige Ramappa <[email protected]>Reviewed-by Alan Previn <[email protected]>--- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 5 ++ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 ++++++++++++++----- drivers/gpu/drm/i915/i915_reg.h | 3 +- 3 files changed, 50 insertions(+), 14 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc.h +5
-0@@ -215,6 +215,11 @@ struct intel_guc {* context usage for overflows. */ struct delayed_work work; + +/** +* @shift: Right shift value for the gpm timestamp +*/ +u32 shift; } timestamp;#ifdef CONFIG_DRM_I915_SELFTEST drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +20
-4@@ -1150,23 +1150,51 @@ static void guc_update_engine_gt_clks(struct intel_engine_cs *engine) } } -static void guc_update_pm_timestamp (struct intel_guc *guc, -struct intel_engine_cs *engine, -ktime_t *now) +static u32 gpm_timestamp_shift (struct intel_gt *gt) { -u32 gt_stamp_now, gt_stamp_hi; +intel_wakeref_t wakeref; +u32 reg, shift; + +with_intel_runtime_pm (gt->uncore->rpm, wakeref) + reg = intel_uncore_read(gt->uncore, RPM_CONFIG0); + + shift = (reg &GEN10_RPM_CONFIG0_CTC_SHIFT_PARAMETER_MASK ) >> +GEN10_RPM_CONFIG0_CTC_SHIFT_PARAMETER_SHIFT ; + +return 3 - shift; +} + +static u64 gpm_timestamp (struct intel_gt *gt) +{ +u32 lo, hi, old_hi, loop =0 ; + + hi =intel_uncore_read (gt->uncore,MISC_STATUS1 ); + do { + lo = intel_uncore_read(gt->uncore, MISC_STATUS0);
Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_update_engine_gt_clks(struct intel_engine_cs *engine) · line 1179
Quoted 6 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6
-0+ old_hi = hi; + hi =intel_uncore_read (gt->uncore,MISC_STATUS1 ); + }while (old_hi != hi && loop++ <2 ); + +return ((u64 )hi <<32 ) | lo; +}See
intel_uncore_read64_2x32().
This was a good suggestion - since the patch was merged regardless I think a follow up cleanup is in order so we don't accumulate duplicated code.
Regards,
Tvrtko
Quoted 82 lines
Quoted 81 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +17
-9+ +static void guc_update_pm_timestamp (struct intel_guc *guc,ktime_t *now) +{ +struct intel_gt *gt =guc_to_gt (guc); +u32 gt_stamp_lo, gt_stamp_hi; +u64 gpm_ts;lockdep_assert_held (&guc->timestamp.lock); gt_stamp_hi =upper_32_bits (guc->timestamp.gt_stamp); - gt_stamp_now =intel_uncore_read (engine->uncore, -RING_TIMESTAMP (engine->mmio_base)); + gpm_ts =gpm_timestamp (gt) >> guc->timestamp.shift; + gt_stamp_lo =lower_32_bits (gpm_ts); *now =ktime_get (); -if (gt_stamp_now <lower_32_bits (guc->timestamp.gt_stamp)) +if (gt_stamp_lo <lower_32_bits (guc->timestamp.gt_stamp)) gt_stamp_hi++; - guc->timestamp.gt_stamp = ((u64 )gt_stamp_hi <<32 ) | gt_stamp_now; + guc->timestamp.gt_stamp = ((u64 )gt_stamp_hi <<32 ) | gt_stamp_lo; }/* @@ -1210,7 +1238,7 @@ static ktime_t guc_engine_busyness(struct intel_engine_cs *engine, ktime_t *now) stats_saved = *stats; gt_stamp_saved = guc->timestamp.gt_stamp;guc_update_engine_gt_clks (engine); -guc_update_pm_timestamp (guc, engine, now); +guc_update_pm_timestamp (guc, now);intel_gt_pm_put_async (gt);if (i915_reset_count (gpu_error) != reset_count) { *stats = stats_saved;@@ -1242,8 +1270,8 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)spin_lock_irqsave (&guc->timestamp.lock, flags); +guc_update_pm_timestamp (guc, &unused);for_each_engine (engine, gt, id) { -guc_update_pm_timestamp (guc, engine, &unused);guc_update_engine_gt_clks (engine); engine->stats.guc.prev_total =0 ; }@@ -1260,10 +1288,11 @@ static void __update_guc_busyness_stats(struct intel_guc *guc)ktime_t unused;spin_lock_irqsave (&guc->timestamp.lock, flags); -for_each_engine (engine, gt, id) { -guc_update_pm_timestamp (guc, engine, &unused); + +guc_update_pm_timestamp (guc, &unused); +for_each_engine (engine, gt, id)guc_update_engine_gt_clks (engine); - } +spin_unlock_irqrestore (&guc->timestamp.lock, flags); }@@ -1757,6 +1786,7 @@ int intel_guc_submission_init(struct intel_guc *guc)spin_lock_init (&guc->timestamp.lock);INIT_DELAYED_WORK (&guc->timestamp.work, guc_timestamp_ping); guc->timestamp.ping_delay = (POLL_TIME_CLKS / gt->clock_frequency +1 ) *HZ ; + guc->timestamp.shift =gpm_timestamp_shift (gt);return 0 ; }drivers/gpu/drm/i915/i915_reg.h +2
-1@@ -1848,7 +1848,8 @@#define BLT_HWS_PGA_GEN7 _MMIO(0x04280)#define VEBOX_HWS_PGA_GEN7 _MMIO(0x04380) -#define GUCPMTIMESTAMP _MMIO(0xC3E8) +#define MISC_STATUS0 _MMIO(0xA500) +#define MISC_STATUS1 _MMIO(0xA504)#define GEN7_TLB_RD_ADDR _MMIO(0x4700)
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference
URL : https://patchwork.freedesktop.org/series/99301/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11129_full -> Patchwork_22093_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22093_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22093_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22093_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl10/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_flip@flip-vs-fences-interruptible@a-vga1:
- shard-snb: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-snb6/igt@kms_flip@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-snb6/igt@kms_flip@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22093_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-iclb2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][8] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk9/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk1/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][11] ([fdo#109271]) +179 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl10/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk8/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-tglb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-kbl3/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2842]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-tglb2/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#4270])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@gem_reg_read@bad-register:
- shard-skl: [PASS][24] -> [DMESG-WARN][25] ([i915#1982])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl7/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3323])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3323])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl10/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3297])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-kbl3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#2527] / [i915#2856])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#1937])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@i915_pm_lpsp@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][35] ([i915#1886] / [i915#2291])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl7/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111614]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3777])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][38] ([i915#3763])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111615])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3777]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3886]) +12 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3689] / [i915#3886])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +15 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +9 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][51] ([i915#1319])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-apl8/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3319]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109279] / [i915#3359])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278] / [fdo#109279])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-128x128-random:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#2346] / [i915#533])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@kms_flip@2x-plain-flip-interruptible:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#109274] / [fdo#111825]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][62] -> [FAIL][63] ([i915#4911])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271]) +147 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109280] / [fdo#111825]) +6 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109280]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][67] -> [FAIL][68] ([i915#1188])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#1187])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#1187])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][74] ([i915#265])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl3/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][75] ([i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][76] ([fdo#108145] / [i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][77] ([i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][78] ([fdo#108145] / [i915#265]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][79] -> [FAIL][80] ([fdo#108145] / [i915#265])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl10/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl2/igt@[email protected]
* igt@kms_plane_cursor@pipe-d-viewport-size-128:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271]) +87 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3536])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#2920])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl6/igt@[email protected]
* igt@kms_setmode@basic:
- shard-glk: [PASS][85] -> [FAIL][86] ([i915#31])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk4/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk3/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#2437])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl10/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2437]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2437])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [PASS][91] -> [FAIL][92] ([i915#1542])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl7/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#109291])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html
* igt@sysfs_clients@sema-10:
- shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2994]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2994])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb3/igt@[email protected]
* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl7/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-1us:
- shard-tglb: [TIMEOUT][98] ([i915#3063]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-tglb1/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb6/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [FAIL][100] ([i915#232]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-tglb1/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-tglb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][102] ([i915#4525]) -> [PASS][103] +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-iclb3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-kbl3/igt@gem_exec_fair@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-apl: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-apl4/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][108] ([i915#2842]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk2/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][110] ([i915#2849]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-iclb5/igt@gem_exec_fair@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-skl: [INCOMPLETE][112] ([i915#4547]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl10/igt@gem_exec_suspend@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl9/igt@gem_exec_suspend@[email protected]
* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][114] ([i915#4171]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk6/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk9/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][116] ([i915#180]) -> [PASS][117] +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-apl3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-apl3/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][118] ([i915#118]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk4/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [FAIL][120] ([i915#2346]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-iclb7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][122] ([i915#79]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk9/igt@kms_flip@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][124] ([i915#79]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl9/igt@kms_flip@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127] +9 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-kbl4/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [FAIL][128] ([i915#4911]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-glk6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][130] ([fdo#108145] / [i915#265]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-skl4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][132] ([fdo#109441]) -> [PASS][133] +3 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][134] ([i915#180] / [i915#295]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-kbl6/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/shard-kbl1/igt@[email protected]
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][136] ([i915#3063] / [i915#3648]) -> [FAIL][137] ([i915#232])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11129/shard-tglb7/igt@[email protected]
[137]: https://intel-gf
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22093/index.html