Skip to contentSkip to conversation

xen: export device state to sysfs

PATCH Applied Joe Jin 2 participants 7 messages Aug 28, 2018 Xen hypervisor interface

lore
Share & tools
lore

Joe Jin

author
#0 lore raw

PATCH v2 1/1 xen: export device state to sysfs

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Documentation/ABI/stable/sysfs-bus-xen-backend +9 -0
index 3d5951c8bf5f..e8b60bd766f7 100644
@@ -73,3 +73,12 @@ KernelVersion:	3.0
 Contact:	Konrad Rzeszutek Wilk <[email protected]>
 Description:
                 Number of sectors written by the frontend.
+
+What:		/sys/bus/xen-backend/devices/*/state
+Date:		August 2018
+KernelVersion:	4.19
+Contact:	Joe Jin <[email protected]>
+Description:
+                The state of the device. One of: 'Unknown',
+                'Initialising', 'Initialised', 'Connected', 'Closing',
+                'Closed', 'Reconfiguring', 'Reconfigured'.
drivers/xen/xenbus/xenbus_probe.c +9 -0
index f2088838f690..5b471889d723 100644
@@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(modalias);
 
+static ssize_t state_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%s\n",
+			xenbus_strstate(to_xenbus_device(dev)->state));
+}
+static DEVICE_ATTR_RO(state);
+
 static struct attribute *xenbus_dev_attrs[] = {
 	&dev_attr_nodename.attr,
 	&dev_attr_devtype.attr,
 	&dev_attr_modalias.attr,
+	&dev_attr_state.attr,
 	NULL,
 };
 
Signature · 1 line
2.15.2 (Apple Git-101.1)
#1 lore raw
Quoted 13 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -0
index 3d5951c8bf5f..e8b60bd766f7 100644

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 1 line
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

-boris

Quoted 28 lines

+++ b/Documentation/ABI/stable/sysfs-bus-xen-backend

Documentation/ABI/stable/sysfs-bus-xen-backend +9 -0
@@ -73,3 +73,12 @@ KernelVersion:	3.0
 Contact:	Konrad Rzeszutek Wilk <[email protected]>
 Description:
                 Number of sectors written by the frontend.
+
+What:		/sys/bus/xen-backend/devices/*/state
+Date:		August 2018
+KernelVersion:	4.19
+Contact:	Joe Jin <[email protected]>
+Description:
+                The state of the device. One of: 'Unknown',
+                'Initialising', 'Initialised', 'Connected', 'Closing',
+                'Closed', 'Reconfiguring', 'Reconfigured'.
drivers/xen/xenbus/xenbus_probe.c +6 -0
index f2088838f690..5b471889d723 100644
@@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(modalias);
 
+static ssize_t state_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%s\n",
+			xenbus_strstate(to_xenbus_device(dev)->state));
+}

drivers/xen/xenbus/xenbus_probe.c static ssize_t modalias_show(struct device *dev, · line 420

Quoted 10 lines
drivers/xen/xenbus/xenbus_probe.c +3 -0
+static DEVICE_ATTR_RO(state);
+
 static struct attribute *xenbus_dev_attrs[] = {
 	&dev_attr_nodename.attr,
 	&dev_attr_devtype.attr,
 	&dev_attr_modalias.attr,
+	&dev_attr_state.attr,
 	NULL,
 };
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
In reply to Joe Jin
Quoted 13 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -0
index 3d5951c8bf5f..e8b60bd766f7 100644

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 1 line
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

-boris

Quoted 38 lines

+++ b/Documentation/ABI/stable/sysfs-bus-xen-backend

Documentation/ABI/stable/sysfs-bus-xen-backend +9 -0
@@ -73,3 +73,12 @@ KernelVersion:	3.0
 Contact:	Konrad Rzeszutek Wilk <[email protected]>
 Description:
                 Number of sectors written by the frontend.
+
+What:		/sys/bus/xen-backend/devices/*/state
+Date:		August 2018
+KernelVersion:	4.19
+Contact:	Joe Jin <[email protected]>
+Description:
+                The state of the device. One of: 'Unknown',
+                'Initialising', 'Initialised', 'Connected', 'Closing',
+                'Closed', 'Reconfiguring', 'Reconfigured'.
drivers/xen/xenbus/xenbus_probe.c +9 -0
index f2088838f690..5b471889d723 100644
@@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(modalias);
 
+static ssize_t state_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%s\n",
+			xenbus_strstate(to_xenbus_device(dev)->state));
+}
+static DEVICE_ATTR_RO(state);
+
 static struct attribute *xenbus_dev_attrs[] = {
 	&dev_attr_nodename.attr,
 	&dev_attr_devtype.attr,
 	&dev_attr_modalias.attr,
+	&dev_attr_state.attr,
 	NULL,
 };
 
author
#3 lore raw
Quoted 12 lines · Boris Ostrovsky
Quoted 11 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Quoted 6 lines

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 3 lines
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
index 3d5951c8bf5f..e8b60bd766f7 100644
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

Yes it will, current there is no any ABI document for xen-frontend.

Thanks,
Joe

Quoted 25 lines

-boris

Quoted 22 lines

+++ b/Documentation/ABI/stable/sysfs-bus-xen-backend

Documentation/ABI/stable/sysfs-bus-xen-backend +9 -0
@@ -73,3 +73,12 @@ KernelVersion:	3.0
 Contact:	Konrad Rzeszutek Wilk <[email protected]>
 Description:
                 Number of sectors written by the frontend.
+
+What:		/sys/bus/xen-backend/devices/*/state
+Date:		August 2018
+KernelVersion:	4.19
+Contact:	Joe Jin <[email protected]>
+Description:
+                The state of the device. One of: 'Unknown',
+                'Initialising', 'Initialised', 'Connected', 'Closing',
+                'Closed', 'Reconfiguring', 'Reconfigured'.
drivers/xen/xenbus/xenbus_probe.c +0 -0
index f2088838f690..5b471889d723 100644
@@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(modalias);
 
Quoted 17 lines
Quoted 6 lines
drivers/xen/xenbus/xenbus_probe.c +6 -0
+static ssize_t state_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%s\n",
+			xenbus_strstate(to_xenbus_device(dev)->state));
+}

drivers/xen/xenbus/xenbus_probe.c static ssize_t modalias_show(struct device *dev, · line 420

Quoted 10 lines
drivers/xen/xenbus/xenbus_probe.c +3 -0
+static DEVICE_ATTR_RO(state);
+
 static struct attribute *xenbus_dev_attrs[] = {
 	&dev_attr_nodename.attr,
 	&dev_attr_devtype.attr,
 	&dev_attr_modalias.attr,
+	&dev_attr_state.attr,
 	NULL,
 };
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#4 lore raw
In reply to Boris Ostrovsky
Quoted 12 lines · Boris Ostrovsky
Quoted 11 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Quoted 6 lines

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 3 lines
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
index 3d5951c8bf5f..e8b60bd766f7 100644
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

Yes it will, current there is no any ABI document for xen-frontend.

Thanks,
Joe

Quoted 42 lines

-boris

Quoted 38 lines

+++ b/Documentation/ABI/stable/sysfs-bus-xen-backend

Documentation/ABI/stable/sysfs-bus-xen-backend +9 -0
@@ -73,3 +73,12 @@ KernelVersion:	3.0
 Contact:	Konrad Rzeszutek Wilk <[email protected]>
 Description:
                 Number of sectors written by the frontend.
+
+What:		/sys/bus/xen-backend/devices/*/state
+Date:		August 2018
+KernelVersion:	4.19
+Contact:	Joe Jin <[email protected]>
+Description:
+                The state of the device. One of: 'Unknown',
+                'Initialising', 'Initialised', 'Connected', 'Closing',
+                'Closed', 'Reconfiguring', 'Reconfigured'.
drivers/xen/xenbus/xenbus_probe.c +9 -0
index f2088838f690..5b471889d723 100644
@@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(modalias);
 
+static ssize_t state_show(struct device *dev,
+			    struct device_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%s\n",
+			xenbus_strstate(to_xenbus_device(dev)->state));
+}
+static DEVICE_ATTR_RO(state);
+
 static struct attribute *xenbus_dev_attrs[] = {
 	&dev_attr_nodename.attr,
 	&dev_attr_devtype.attr,
 	&dev_attr_modalias.attr,
+	&dev_attr_state.attr,
 	NULL,
 };
 
#5 lore raw
Quoted 13 lines · Joe Jin
Quoted 12 lines · Boris Ostrovsky
Quoted 11 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Quoted 7 lines
Quoted 5 lines

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 3 lines
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
index 3d5951c8bf5f..e8b60bd766f7 100644
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

Yes it will, current there is no any ABI document for xen-frontend.

True.

Applied to for-linus-19b.

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
In reply to Joe Jin
Quoted 13 lines · Joe Jin
Quoted 12 lines · Boris Ostrovsky
Quoted 11 lines · Joe Jin

Export device state to sysfs to allow for easier get device state.

Cc Boris Ostrovsky <[email protected]>
Cc Juergen Gross <[email protected]>
Cc Konrad Rzeszutek Wilk <[email protected]>
---
 Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
 drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
 2 files changed, 18 insertions(+)
Quoted 7 lines
Quoted 5 lines

Documentation/ABI/stable/sysfs-bus-xen-backend

Quoted 3 lines
Documentation/ABI/stable/sysfs-bus-xen-backend +0 -1
index 3d5951c8bf5f..e8b60bd766f7 100644
--- a/Documentation/ABI/stable/sysfs-bus-xen-backend

Won't this show up in the frontend as well?

Yes it will, current there is no any ABI document for xen-frontend.

True.

Applied to for-linus-19b.

-boris