Skip to contentSkip to conversation

kbd: DEPEND on bison-native and don't build tests

PATCH In review Ola x Nilsson 3 participants 3 messages Nov 22, 2022 – Nov 23, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbd: DEPEND on bison-native and don't build tests

bison-native is required if any .y-file is changed.

Add --disable-tests to EXTRA_OECONF as the tests are not usable in ptest - they can only run in-situ - and fails when building with -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64.

---
 meta/recipes-core/kbd/kbd_2.5.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/kbd/kbd_2.5.1.bb +2 -1
index aa3ab6e121..75b3c2765a 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 inherit autotools gettext pkgconfig
 
-DEPENDS += "flex-native"
+DEPENDS += "bison-native flex-native"
 
 RREPLACES:${PN} = "console-tools"
 RPROVIDES:${PN} = "console-tools"
@@ -18,6 +18,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \
 
 SRC_URI[sha256sum] = "ccdf452387a6380973d2927363e9cbb939fa2068915a6f937ff9d24522024683"
 
+EXTRA_OECONF = "--disable-tests"
 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)} \
                   "
 
Signature · 1 line
2.30.2
#1 lore raw

please send this patch to oe-core mailing list as thats where the patch belongs to

Quoted 45 lines · Ola x Nilsson

bison-native is required if any .y-file is changed.

Add --disable-tests to EXTRA_OECONF as the tests are not usable in ptest - they can only run in-situ - and fails when building with -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64.

---
 meta/recipes-core/kbd/kbd_2.5.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/kbd/kbd_2.5.1.bb +2 -2
index aa3ab6e121..75b3c2765a 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 inherit autotools gettext pkgconfig
 
-DEPENDS += "flex-native"
+DEPENDS += "bison-native flex-native"
 
 RREPLACES:${PN} = "console-tools"
 RPROVIDES:${PN} = "console-tools"
@@ -18,6 +18,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \
 
 SRC_URI[sha256sum] = "ccdf452387a6380973d2927363e9cbb939fa2068915a6f937ff9d24522024683"
 
+EXTRA_OECONF = "--disable-tests"
 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)} \
                   "
 
--

2.30.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99688): https://lists.openembedded.org/g/openembedded-devel/message/99688
Mute This Topic: https://lists.openembedded.org/mt/95199342/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
In reply to Ola x Nilsson
Quoted 25 lines · Ola x Nilsson

bison-native is required if any .y-file is changed.

Add --disable-tests to EXTRA_OECONF as the tests are not usable in ptest - they can only run in-situ - and fails when building with -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64.

---
 meta/recipes-core/kbd/kbd_2.5.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/kbd/kbd_2.5.1.bb +1 -1
index aa3ab6e121..75b3c2765a 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 inherit autotools gettext pkgconfig
 
-DEPENDS += "flex-native"
+DEPENDS += "bison-native flex-native"
 
 RREPLACES:${PN} = "console-tools"
 RPROVIDES:${PN} = "console-tools"

meta/recipes-core/kbd/kbd_2.5.1.bb SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \ · line 23

Quoted 6 lines
meta/recipes-core/kbd/kbd_2.5.1.bb +1 -0
@@ -18,6 +18,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \
 
 SRC_URI[sha256sum] = "ccdf452387a6380973d2927363e9cbb939fa2068915a6f937ff9d24522024683"
 
+EXTRA_OECONF = "--disable-tests"
 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)} \
                   "

This needs to go to the other list. I'd also want to understand why we don't normally run into any problems despite the missing dependency? That needs to be explained in the commit message.

Cheers,

Richard