net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
Subsystems (16)
v2 cover net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
In several places the same code is used to populate rtnl_link_stats64 fields with data from pcpu_sw_netstats. Therefore factor out this code to a new function dev_fetch_sw_netstats().
v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch to EXPORT_SYMBOL_GPL
Heiner Kallweit (12):
net: core: add function dev_fetch_sw_netstats for fetching
pcpu_sw_netstats
IB/hfi1: use new function dev_fetch_sw_netstats
net: macsec: use new function dev_fetch_sw_netstats
net: usb: qmi_wwan: use new function dev_fetch_sw_netstats
net: usbnet: use new function dev_fetch_sw_netstats
qtnfmac: use new function dev_fetch_sw_netstats
net: bridge: use new function dev_fetch_sw_netstats
net: dsa: use new function dev_fetch_sw_netstats
iptunnel: use new function dev_fetch_sw_netstats
mac80211: use new function dev_fetch_sw_netstats
net: openvswitch: use new function dev_fetch_sw_netstats
xfrm: use new function dev_fetch_sw_netstats
drivers/infiniband/hw/hfi1/ipoib_main.c | 34 +------------------ drivers/net/macsec.c | 22 +----------- drivers/net/usb/qmi_wwan.c | 24 +------------ drivers/net/usb/usbnet.c | 24 +------------ drivers/net/wireless/quantenna/qtnfmac/core.c | 27 +-------------- include/linux/netdevice.h | 2 ++ net/bridge/br_device.c | 21 +----------- net/core/dev.c | 34 +++++++++++++++++++ net/dsa/slave.c | 21 +----------- net/ipv4/ip_tunnel_core.c | 23 +------------ net/mac80211/iface.c | 23 +------------ net/openvswitch/vport-internal_dev.c | 20 +---------- net/xfrm/xfrm_interface.c | 22 +----------- 13 files changed, 47 insertions(+), 250 deletions(-)
Signature · 1 line
2.28.0
PATCH v2 1/12 net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
In several places the same code is used to populate rtnl_link_stats64 fields with data from pcpu_sw_netstats. Therefore factor out this code to a new function dev_fetch_sw_netstats().
v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch to EXPORT_SYMBOL_GPL
--- include/linux/netdevice.h | 2 ++ net/core/dev.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+)
include/linux/netdevice.h +2 -0
@@ -4495,6 +4495,8 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev, struct rtnl_link_stats64 *storage);void netdev_stats_to_stats64 (struct rtnl_link_stats64 *stats64,const struct net_device_stats *netdev_stats); +void dev_fetch_sw_netstats (struct rtnl_link_stats64 *s, +const struct pcpu_sw_netstats __percpu *netstats);extern int netdev_max_backlog;extern int netdev_tstamp_prequeue;
net/core/dev.c +34 -0
@@ -10319,6 +10319,40 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev, }EXPORT_SYMBOL (dev_get_stats); +/** +* dev_fetch_sw_netstats - get per-cpu network device statistics +* @s: place to store stats +* @netstats: per-cpu network stats to read from +* +* Read per-cpu network statistics and populate the related fields in @s. +*/ +void dev_fetch_sw_netstats (struct rtnl_link_stats64 *s, +const struct pcpu_sw_netstats __percpu *netstats) +{ +int cpu; + +for_each_possible_cpu (cpu) { +const struct pcpu_sw_netstats *stats; +struct pcpu_sw_netstats tmp; +unsigned int start; + + stats =per_cpu_ptr (netstats, cpu); +do { + start =u64_stats_fetch_begin_irq (&stats->syncp); + tmp.rx_packets = stats->rx_packets; + tmp.rx_bytes = stats->rx_bytes; + tmp.tx_packets = stats->tx_packets; + tmp.tx_bytes = stats->tx_bytes; + }while (u64_stats_fetch_retry_irq (&stats->syncp, start)); + + s->rx_packets += tmp.rx_packets; + s->rx_bytes += tmp.rx_bytes; + s->tx_packets += tmp.tx_packets; + s->tx_bytes += tmp.tx_bytes; + } +} +EXPORT_SYMBOL_GPL (dev_fetch_sw_netstats); +struct netdev_queue *dev_ingress_queue_create (struct net_device *dev) {struct netdev_queue *queue =dev_ingress_queue (dev);
Signature · 1 line
2.28.0
PATCH v2 2/12 IB/hfi1: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- drivers/infiniband/hw/hfi1/ipoib_main.c | 34 +------------------------ 1 file changed, 1 insertion(+), 33 deletions(-)
drivers/infiniband/hw/hfi1/ipoib_main.c +1 -33
@@ -97,41 +97,9 @@ static void hfi1_ipoib_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *storage) {struct hfi1_ipoib_dev_priv *priv =hfi1_ipoib_priv (dev); -u64 rx_packets =0ull ; -u64 rx_bytes =0ull ; -u64 tx_packets =0ull ; -u64 tx_bytes =0ull ; -int i;netdev_stats_to_stats64 (storage, &dev->stats); - -for_each_possible_cpu (i) { -const struct pcpu_sw_netstats *stats; -unsigned int start; -u64 trx_packets; -u64 trx_bytes; -u64 ttx_packets; -u64 ttx_bytes; - - stats =per_cpu_ptr (priv->netstats, i); -do { - start =u64_stats_fetch_begin_irq (&stats->syncp); - trx_packets = stats->rx_packets; - trx_bytes = stats->rx_bytes; - ttx_packets = stats->tx_packets; - ttx_bytes = stats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats->syncp, start)); - - rx_packets += trx_packets; - rx_bytes += trx_bytes; - tx_packets += ttx_packets; - tx_bytes += ttx_bytes; - } - - storage->rx_packets += rx_packets; - storage->rx_bytes += rx_bytes; - storage->tx_packets += tx_packets; - storage->tx_bytes += tx_bytes; +dev_fetch_sw_netstats (storage, priv->netstats); }static const struct net_device_ops hfi1_ipoib_netdev_ops = {
Signature · 1 line
2.28.0
PATCH v2 3/12 net: macsec: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- drivers/net/macsec.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-)
drivers/net/macsec.c +1 -21
@@ -3647,30 +3647,10 @@ static int macsec_change_mtu(struct net_device *dev, int new_mtu)static void macsec_get_stats64 (struct net_device *dev,struct rtnl_link_stats64 *s) { -int cpu; -if (!dev->tstats)return ; -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats; -struct pcpu_sw_netstats tmp; -int start; - - stats =per_cpu_ptr (dev->tstats, cpu); -do { - start =u64_stats_fetch_begin_irq (&stats->syncp); - tmp.rx_packets = stats->rx_packets; - tmp.rx_bytes = stats->rx_bytes; - tmp.tx_packets = stats->tx_packets; - tmp.tx_bytes = stats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats->syncp, start)); - - s->rx_packets += tmp.rx_packets; - s->rx_bytes += tmp.rx_bytes; - s->tx_packets += tmp.tx_packets; - s->tx_bytes += tmp.tx_bytes; - } +dev_fetch_sw_netstats (s, dev->tstats); s->rx_dropped = dev->stats.rx_dropped; s->tx_dropped = dev->stats.tx_dropped;
Signature · 1 line
2.28.0
Re: [Bridge] [PATCH net-next v2 03/12] net: macsec: use new function dev_fetch_sw_netstats
Hello,
Quoting Heiner Kallweit (2020-10-12 10:04:11)
Quoted 3 lines
Simplify the code by using new function
dev_fetch_sw_netstats().Signed-off-by Heiner Kallweit <[email protected]>
Thanks!
Antoine
Quoted 44 lines
--- drivers/net/macsec.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-)drivers/net/macsec.c +1
-21@@ -3647,30 +3647,10 @@ static int macsec_change_mtu(struct net_device *dev, int new_mtu)static void macsec_get_stats64 (struct net_device *dev,struct rtnl_link_stats64 *s) { -int cpu; -if (!dev->tstats)return ; -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats; -struct pcpu_sw_netstats tmp; -int start; - - stats =per_cpu_ptr (dev->tstats, cpu); -do { - start =u64_stats_fetch_begin_irq (&stats->syncp); - tmp.rx_packets = stats->rx_packets; - tmp.rx_bytes = stats->rx_bytes; - tmp.tx_packets = stats->tx_packets; - tmp.tx_bytes = stats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats->syncp, start)); - - s->rx_packets += tmp.rx_packets; - s->rx_bytes += tmp.rx_bytes; - s->tx_packets += tmp.tx_packets; - s->tx_bytes += tmp.tx_bytes; - } +dev_fetch_sw_netstats (s, dev->tstats); s->rx_dropped = dev->stats.rx_dropped; s->tx_dropped = dev->stats.tx_dropped;Signature · 1 line
2.28.0
PATCH v2 4/12 net: usb: qmi_wwan: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- drivers/net/usb/qmi_wwan.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-)
drivers/net/usb/qmi_wwan.c +1 -23
@@ -126,31 +126,9 @@ static void qmimux_get_stats64(struct net_device *net, struct rtnl_link_stats64 *stats) {struct qmimux_priv *priv =netdev_priv (net); -unsigned int start; -int cpu;netdev_stats_to_stats64 (stats, &net->stats); - -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats64; -u64 rx_packets, rx_bytes; -u64 tx_packets, tx_bytes; - - stats64 =per_cpu_ptr (priv->stats64, cpu); - -do { - start =u64_stats_fetch_begin_irq (&stats64->syncp); - rx_packets = stats64->rx_packets; - rx_bytes = stats64->rx_bytes; - tx_packets = stats64->tx_packets; - tx_bytes = stats64->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats64->syncp, start)); - - stats->rx_packets += rx_packets; - stats->rx_bytes += rx_bytes; - stats->tx_packets += tx_packets; - stats->tx_bytes += tx_bytes; - } +dev_fetch_sw_netstats (stats, priv->stats64); }static const struct net_device_ops qmimux_netdev_ops = {
Signature · 1 line
2.28.0
PATCH v2 5/12 net: usbnet: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- drivers/net/usb/usbnet.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-)
drivers/net/usb/usbnet.c +1 -23
@@ -983,31 +983,9 @@ EXPORT_SYMBOL_GPL(usbnet_set_link_ksettings);void usbnet_get_stats64 (struct net_device *net,struct rtnl_link_stats64 *stats) {struct usbnet *dev =netdev_priv (net); -unsigned int start; -int cpu;netdev_stats_to_stats64 (stats, &net->stats); - -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats64; -u64 rx_packets, rx_bytes; -u64 tx_packets, tx_bytes; - - stats64 =per_cpu_ptr (dev->stats64, cpu); - -do { - start =u64_stats_fetch_begin_irq (&stats64->syncp); - rx_packets = stats64->rx_packets; - rx_bytes = stats64->rx_bytes; - tx_packets = stats64->tx_packets; - tx_bytes = stats64->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats64->syncp, start)); - - stats->rx_packets += rx_packets; - stats->rx_bytes += rx_bytes; - stats->tx_packets += tx_packets; - stats->tx_bytes += tx_bytes; - } +dev_fetch_sw_netstats (stats, dev->stats64); }EXPORT_SYMBOL_GPL (usbnet_get_stats64);
Signature · 1 line
2.28.0
PATCH v2 6/12 qtnfmac: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- drivers/net/wireless/quantenna/qtnfmac/core.c | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-)
drivers/net/wireless/quantenna/qtnfmac/core.c +1 -22
@@ -139,34 +139,13 @@ static void qtnf_netdev_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 *stats) {struct qtnf_vif *vif =qtnf_netdev_get_priv (ndev); -unsigned int start; -int cpu;netdev_stats_to_stats64 (stats, &ndev->stats);if (!vif->stats64)return ; -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats64; -u64 rx_packets, rx_bytes; -u64 tx_packets, tx_bytes; - - stats64 =per_cpu_ptr (vif->stats64, cpu); - -do { - start =u64_stats_fetch_begin_irq (&stats64->syncp); - rx_packets = stats64->rx_packets; - rx_bytes = stats64->rx_bytes; - tx_packets = stats64->tx_packets; - tx_bytes = stats64->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats64->syncp, start)); - - stats->rx_packets += rx_packets; - stats->rx_bytes += rx_bytes; - stats->tx_packets += tx_packets; - stats->tx_bytes += tx_bytes; - } +dev_fetch_sw_netstats (stats, vif->stats64); }/* Netdev handler for transmission timeout.
Signature · 1 line
2.28.0
PATCH v2 7/12 net: bridge: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/bridge/br_device.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-)
net/bridge/br_device.c +1 -20
@@ -206,27 +206,8 @@ static void br_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) {struct net_bridge *br =netdev_priv (dev); -struct pcpu_sw_netstats tmp, sum = {0 }; -unsigned int cpu; - -for_each_possible_cpu (cpu) { -unsigned int start; -const struct pcpu_sw_netstats *bstats - =per_cpu_ptr (br->stats, cpu); -do { - start =u64_stats_fetch_begin_irq (&bstats->syncp); -memcpy (&tmp, bstats,sizeof (tmp)); - }while (u64_stats_fetch_retry_irq (&bstats->syncp, start)); - sum.tx_bytes += tmp.tx_bytes; - sum.tx_packets += tmp.tx_packets; - sum.rx_bytes += tmp.rx_bytes; - sum.rx_packets += tmp.rx_packets; - } - stats->tx_bytes = sum.tx_bytes; - stats->tx_packets = sum.tx_packets; - stats->rx_bytes = sum.rx_bytes; - stats->rx_packets = sum.rx_packets; +dev_fetch_sw_netstats (stats, br->stats); }static int br_change_mtu (struct net_device *dev,int new_mtu)
Signature · 1 line
2.28.0
PATCH v2 8/12 net: dsa: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/dsa/slave.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-)
net/dsa/slave.c +1 -20
@@ -1221,28 +1221,9 @@ static void dsa_slave_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) {struct dsa_slave_priv *p =netdev_priv (dev); -struct pcpu_sw_netstats *s; -unsigned int start; -int i;netdev_stats_to_stats64 (stats, &dev->stats); -for_each_possible_cpu (i) { -u64 tx_packets, tx_bytes, rx_packets, rx_bytes; - - s =per_cpu_ptr (p->stats64, i); -do { - start =u64_stats_fetch_begin_irq (&s->syncp); - tx_packets = s->tx_packets; - tx_bytes = s->tx_bytes; - rx_packets = s->rx_packets; - rx_bytes = s->rx_bytes; - }while (u64_stats_fetch_retry_irq (&s->syncp, start)); - - stats->tx_packets += tx_packets; - stats->tx_bytes += tx_bytes; - stats->rx_packets += rx_packets; - stats->rx_bytes += rx_bytes; - } +dev_fetch_sw_netstats (stats, p->stats64); } static int dsa_slave_get_rxnfc(struct net_device *dev,
Signature · 1 line
2.28.0
PATCH v2 9/12 iptunnel: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/ipv4/ip_tunnel_core.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-)
net/ipv4/ip_tunnel_core.c +1 -22
@@ -433,29 +433,8 @@ EXPORT_SYMBOL(skb_tunnel_check_pmtu);void ip_tunnel_get_stats64 (struct net_device *dev,struct rtnl_link_stats64 *tot) { -int i; -netdev_stats_to_stats64 (tot, &dev->stats); - -for_each_possible_cpu (i) { -const struct pcpu_sw_netstats *tstats = -per_cpu_ptr (dev->tstats, i); -u64 rx_packets, rx_bytes, tx_packets, tx_bytes; -unsigned int start; - -do { - start =u64_stats_fetch_begin_irq (&tstats->syncp); - rx_packets = tstats->rx_packets; - tx_packets = tstats->tx_packets; - rx_bytes = tstats->rx_bytes; - tx_bytes = tstats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&tstats->syncp, start)); - - tot->rx_packets += rx_packets; - tot->tx_packets += tx_packets; - tot->rx_bytes += rx_bytes; - tot->tx_bytes += tx_bytes; - } +dev_fetch_sw_netstats (tot, dev->tstats); }EXPORT_SYMBOL_GPL (ip_tunnel_get_stats64);
Signature · 1 line
2.28.0
PATCH v2 10/12 mac80211: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/mac80211/iface.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-)
net/mac80211/iface.c +1 -22
@@ -709,28 +709,7 @@ static u16 ieee80211_netdev_select_queue(struct net_device *dev,static void ieee80211_get_stats64 (struct net_device *dev,struct rtnl_link_stats64 *stats) { -int i; - -for_each_possible_cpu (i) { -const struct pcpu_sw_netstats *tstats; -u64 rx_packets, rx_bytes, tx_packets, tx_bytes; -unsigned int start; - - tstats =per_cpu_ptr (dev->tstats, i); - -do { - start =u64_stats_fetch_begin_irq (&tstats->syncp); - rx_packets = tstats->rx_packets; - tx_packets = tstats->tx_packets; - rx_bytes = tstats->rx_bytes; - tx_bytes = tstats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&tstats->syncp, start)); - - stats->rx_packets += rx_packets; - stats->tx_packets += tx_packets; - stats->rx_bytes += rx_bytes; - stats->tx_bytes += tx_bytes; - } +dev_fetch_sw_netstats (stats, dev->tstats); }static const struct net_device_ops ieee80211_dataif_ops = {
Signature · 1 line
2.28.0
PATCH v2 11/12 net: openvswitch: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/openvswitch/vport-internal_dev.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-)
net/openvswitch/vport-internal_dev.c +1 -19
@@ -86,31 +86,13 @@ static void internal_dev_destructor(struct net_device *dev)static void internal_get_stats (struct net_device *dev,struct rtnl_link_stats64 *stats) { -int i; -memset (stats,0 ,sizeof (*stats)); stats->rx_errors = dev->stats.rx_errors; stats->tx_errors = dev->stats.tx_errors; stats->tx_dropped = dev->stats.tx_dropped; stats->rx_dropped = dev->stats.rx_dropped; -for_each_possible_cpu (i) { -const struct pcpu_sw_netstats *percpu_stats; -struct pcpu_sw_netstats local_stats; -unsigned int start; - - percpu_stats =per_cpu_ptr (dev->tstats, i); - -do { - start =u64_stats_fetch_begin_irq (&percpu_stats->syncp); - local_stats = *percpu_stats; - }while (u64_stats_fetch_retry_irq (&percpu_stats->syncp, start)); - - stats->rx_bytes += local_stats.rx_bytes; - stats->rx_packets += local_stats.rx_packets; - stats->tx_bytes += local_stats.tx_bytes; - stats->tx_packets += local_stats.tx_packets; - } +dev_fetch_sw_netstats (stats, dev->tstats); }static const struct net_device_ops internal_dev_netdev_ops = {
Signature · 1 line
2.28.0
PATCH v2 12/12 xfrm: use new function dev_fetch_sw_netstats
In reply to Heiner KallweitSimplify the code by using new function dev_fetch_sw_netstats().
--- net/xfrm/xfrm_interface.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-)
net/xfrm/xfrm_interface.c +1 -21
@@ -541,27 +541,7 @@ static int xfrmi_update(struct xfrm_if *xi, struct xfrm_if_parms *p)static void xfrmi_get_stats64 (struct net_device *dev,struct rtnl_link_stats64 *s) { -int cpu; - -for_each_possible_cpu (cpu) { -struct pcpu_sw_netstats *stats; -struct pcpu_sw_netstats tmp; -int start; - - stats =per_cpu_ptr (dev->tstats, cpu); -do { - start =u64_stats_fetch_begin_irq (&stats->syncp); - tmp.rx_packets = stats->rx_packets; - tmp.rx_bytes = stats->rx_bytes; - tmp.tx_packets = stats->tx_packets; - tmp.tx_bytes = stats->tx_bytes; - }while (u64_stats_fetch_retry_irq (&stats->syncp, start)); - - s->rx_packets += tmp.rx_packets; - s->rx_bytes += tmp.rx_bytes; - s->tx_packets += tmp.tx_packets; - s->tx_bytes += tmp.tx_bytes; - } +dev_fetch_sw_netstats (s, dev->tstats); s->rx_dropped = dev->stats.rx_dropped; s->tx_dropped = dev->stats.tx_dropped;
Signature · 1 line
2.28.0
Quoted 8 lines · On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
In several places the same code is used to populate
rtnl_link_stats64fields with data frompcpu_sw_netstats. Therefore factor out this code to a new functiondev_fetch_sw_netstats().v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch toEXPORT_SYMBOL_GPL
Applied, thank you!
Quoted 11 lines · Jakub Kicinski
Quoted 8 lines · On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
In several places the same code is used to populate
rtnl_link_stats64fields with data frompcpu_sw_netstats. Therefore factor out this code to a new functiondev_fetch_sw_netstats().v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch toEXPORT_SYMBOL_GPLApplied, thank you!
Jakub,
Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough.
44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats")
Thanks
Quoted 11 lines · Leon Romanovsky
Quoted 10 lines · Jakub Kicinski
Quoted 8 lines · On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
In several places the same code is used to populate
rtnl_link_stats64fields with data frompcpu_sw_netstats. Therefore factor out this code to a new functiondev_fetch_sw_netstats().v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch toEXPORT_SYMBOL_GPL
Quoted 9 lines
Quoted 1 line
Applied, thank you!
Jakub,
Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough.
I remember that once I did it the usual way (changelog below the ---) David requested the changelog to be part of the commit message. So obviously he sees some benefit in doing so.
Quoted 4 lines
44fa32f008ab("net: add functiondev_fetch_sw_netstatsfor fetchingpcpu_sw_netstats")Thanks
Quoted 16 lines · Heiner Kallweit
Quoted 15 lines · Leon Romanovsky
Quoted 11 lines · Jakub Kicinski
Quoted 8 lines · On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
In several places the same code is used to populate
rtnl_link_stats64fields with data frompcpu_sw_netstats. Therefore factor out this code to a new functiondev_fetch_sw_netstats().v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch toEXPORT_SYMBOL_GPLApplied, thank you!
Jakub,
Quoted 8 lines
Quoted 5 lines
Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough.
I remember that once I did it the usual way (changelog below the ---) David requested the changelog to be part of the commit message. So obviously he sees some benefit in doing so.
Do you have a link? What is the benefit and how can we use it?
Usually such request comes to ensure that commit message is updated with extra information (explanation) existed in changelog which is missing in the patch.
Thanks
Quoted 6 lines
Quoted 5 lines
44fa32f008ab("net: add functiondev_fetch_sw_netstatsfor fetchingpcpu_sw_netstats")Thanks
Quoted 22 lines · Leon Romanovsky
Quoted 21 lines · Heiner Kallweit
Quoted 20 lines · Leon Romanovsky
Quoted 11 lines · Jakub Kicinski
Quoted 8 lines · On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote:
In several places the same code is used to populate
rtnl_link_stats64fields with data frompcpu_sw_netstats. Therefore factor out this code to a new functiondev_fetch_sw_netstats().v2:
- constify argument netstats
- don't ignore netstats being NULL or an ERRPTR
- switch toEXPORT_SYMBOL_GPLApplied, thank you!
Jakub,
Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough.
Quoted 6 lines
Quoted 3 lines
I remember that once I did it the usual way (changelog below the ---) David requested the changelog to be part of the commit message. So obviously he sees some benefit in doing so.
Do you have a link? What is the benefit and how can we use it?
https://www.mail-archive.com/[email protected]/msg1873080.html
Quoted 12 lines
Usually such request comes to ensure that commit message is updated with extra information (explanation) existed in changelog which is missing in the patch.
Thanks
Quoted 6 lines
Quoted 5 lines
44fa32f008ab("net: add functiondev_fetch_sw_netstatsfor fetchingpcpu_sw_netstats")Thanks
Johannes Berg
maintainerQuoted 4 lines · Heiner Kallweit
Quoted 3 lines
Do you have a link? What is the benefit and how can we use it?
https://www.mail-archive.com/[email protected]/msg1873080.html
There was also a long discussion a year or so back, starting at
http://lore.kernel.org/r/[email protected]
johannes
Quoted 5 lines · Johannes Berg
Quoted 4 lines · Heiner Kallweit
Quoted 3 lines
Do you have a link? What is the benefit and how can we use it?
https://www.mail-archive.com/[email protected]/msg1873080.html
So why is it usable?
The combination of Link, b4 and git range-diff gives everything in much more reliable way.
Quoted 4 lines
There was also a long discussion a year or so back, starting at
I participated in that discussion too :)
Thanks
Quoted 3 lines
johannes