Skip to contentSkip to conversation

IB/mlx5: Add HW counter called rx_dct_connect

PATCH In review Leon Romanovsky 2 participants 3 messages Jul 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/mlx5: Add HW counter called rx_dct_connect

From: Shetu Ayalew <[email protected]>

The rx_dct_connect counter shows the number of received connection requests for the associated DCTs.

---
 drivers/infiniband/hw/mlx5/counters.c | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/hw/mlx5/counters.c +1 -0
index 93257fa5aae8..14af6ff91dfa 100644
@@ -40,6 +40,7 @@ static const struct mlx5_ib_counter retrans_q_cnts[] = {
 	INIT_Q_COUNTER(packet_seq_err),
 	INIT_Q_COUNTER(implied_nak_seq_err),
 	INIT_Q_COUNTER(local_ack_timeout_err),
+	INIT_Q_COUNTER(rx_dct_connect),
 };
 
 static const struct mlx5_ib_counter vport_basic_q_cnts[] = {
Signature · 1 line
2.41.0
#1 lore raw
Quoted 28 lines · Leon Romanovsky

External email: Use caution opening links or attachments

From: Shetu Ayalew <[email protected]>

The rx_dct_connect counter shows the number of received connection requests for the associated DCTs.

---
  drivers/infiniband/hw/mlx5/counters.c | 1 +
  1 file changed, 1 insertion(+)
drivers/infiniband/hw/mlx5/counters.c +1 -1
index 93257fa5aae8..14af6ff91dfa 100644
@@ -40,6 +40,7 @@ static const struct mlx5_ib_counter retrans_q_cnts[] = {
         INIT_Q_COUNTER(packet_seq_err),
         INIT_Q_COUNTER(implied_nak_seq_err),
         INIT_Q_COUNTER(local_ack_timeout_err),
+       INIT_Q_COUNTER(rx_dct_connect),
  };
 
  static const struct mlx5_ib_counter vport_basic_q_cnts[] = {
--
Quoted 2 lines

2.41.0

Just curious why it's in retrans_q_cnts[], instead of basic_q_cnts[]:

(quoted diff) +0 -0

b/drivers/infiniband/hw/mlx5/counters.c
index 93257fa5aae8..8300ce622835 100644

drivers/infiniband/hw/mlx5/counters.c +1 -0
@@ -27,6 +27,7 @@ static const struct mlx5_ib_counter basic_q_cnts[] = {
         INIT_Q_COUNTER(rx_write_requests),
         INIT_Q_COUNTER(rx_read_requests),
         INIT_Q_COUNTER(rx_atomic_requests),
+       INIT_Q_COUNTER(rx_dct_connect),
         INIT_Q_COUNTER(out_of_buffer),
  };
 
@@ -46,6 +47,7 @@ static const struct mlx5_ib_counter 

vport_basic_q_cnts[] = {
INIT_VPORT_Q_COUNTER(rx_write_requests), INIT_VPORT_Q_COUNTER(rx_read_requests), INIT_VPORT_Q_COUNTER(rx_atomic_requests),
+ INIT_VPORT_Q_COUNTER(rx_dct_connect),
INIT_VPORT_Q_COUNTER(out_of_buffer),
};

#2 lore raw
Quoted 27 lines · Mark Zhang
Quoted 26 lines · Leon Romanovsky

External email: Use caution opening links or attachments

From: Shetu Ayalew <[email protected]>

The rx_dct_connect counter shows the number of received connection requests for the associated DCTs.

---
  drivers/infiniband/hw/mlx5/counters.c | 1 +
  1 file changed, 1 insertion(+)
drivers/infiniband/hw/mlx5/counters.c +1 -0
index 93257fa5aae8..14af6ff91dfa 100644
@@ -40,6 +40,7 @@ static const struct mlx5_ib_counter retrans_q_cnts[] = {
         INIT_Q_COUNTER(packet_seq_err),
         INIT_Q_COUNTER(implied_nak_seq_err),
         INIT_Q_COUNTER(local_ack_timeout_err),
+       INIT_Q_COUNTER(rx_dct_connect),
  };
 
Quoted 6 lines
Quoted 4 lines
drivers/infiniband/hw/mlx5/counters.c +0 -1
  static const struct mlx5_ib_counter vport_basic_q_cnts[] = {
--

2.41.0

Just curious why it's in retrans_q_cnts[], instead of basic_q_cnts[]:

Ohh, you are right, it should be basic_q_cnts.

Thanks Mark.

Quoted 22 lines
drivers/infiniband/hw/mlx5/counters.c +2 -0
index 93257fa5aae8..8300ce622835 100644
@@ -27,6 +27,7 @@ static const struct mlx5_ib_counter basic_q_cnts[] = {
         INIT_Q_COUNTER(rx_write_requests),
         INIT_Q_COUNTER(rx_read_requests),
         INIT_Q_COUNTER(rx_atomic_requests),
+       INIT_Q_COUNTER(rx_dct_connect),
         INIT_Q_COUNTER(out_of_buffer),
  };
 
@@ -46,6 +47,7 @@ static const struct mlx5_ib_counter 
 vport_basic_q_cnts[] = {
         INIT_VPORT_Q_COUNTER(rx_write_requests),
         INIT_VPORT_Q_COUNTER(rx_read_requests),
         INIT_VPORT_Q_COUNTER(rx_atomic_requests),
+       INIT_VPORT_Q_COUNTER(rx_dct_connect),
         INIT_VPORT_Q_COUNTER(out_of_buffer),
  };