Skip to contentSkip to conversation

test-runner: fix double free issue on subtest queue

PATCH Applied James Prestwood 2 participants 2 messages Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-runner: fix double free issue on subtest queue

Coverity reported this as a leak, but the test queue is actually getting freed later and does not need to be freed locally in add_path

This basically reverts c0863e5bc62f645f0bde144e4e906b7277866bf7

---
 tools/test-runner.c | 2 --
 1 file changed, 2 deletions(-)
tools/test-runner.c +0 -2
index 1dfdb9af..d6334e83 100644
@@ -1092,8 +1092,6 @@ static bool add_path(const char *path, int level, struct l_queue *config_queue)
 		l_queue_insert(config_queue, entry, insert_test_entry, NULL);
 	}
 
-	l_queue_destroy(py_test_queue, l_free);
-
 	closedir(dir);
 	return true;
 }
Signature · 1 line
2.17.1
#1 lore raw

Hi James,

Quoted 8 lines · James Prestwood

Coverity reported this as a leak, but the test queue is actually getting freed later and does not need to be freed locally in add_path

This basically reverts c0863e5bc62f645f0bde144e4e906b7277866bf7

---
  tools/test-runner.c | 2 --
  1 file changed, 2 deletions(-)

Applied, thanks.

Regards,
-Denis