Skip to contentSkip to conversation

pthread_atfork.3: Remove a confusing reference to the current thread

PATCH In review Arjun Shankar 3 participants 6 messages Apr 12, 2022 – Apr 25, 2022 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pthread_atfork.3: Remove a confusing reference to the current thread

The reference to "this thread" in the DESCRIPTION of pthread_atfork(3) could be incorrectly interpreted to mean that only handlers registered by the thread calling fork(2) are executed. Therefore, remove the reference.

---
 man3/pthread_atfork.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/pthread_atfork.3 +1 -1
index b727cb48e..db5e210d4 100644
@@ -39,7 +39,7 @@ The
 .BR pthread_atfork ()
 function registers fork handlers that are to be executed when
 .BR fork (2)
-is called by this thread.
+is called.
 The handlers are executed in the context of the thread that calls
 .BR fork (2).
 .PP
Signature · 1 line
2.34.1
#1 lore raw

* Arjun Shankar:

Quoted 15 lines

The reference to "this thread" in the DESCRIPTION of pthread_atfork(3) could be incorrectly interpreted to mean that only handlers registered by the thread calling fork(2) are executed. Therefore, remove the reference.

---
 man3/pthread_atfork.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/pthread_atfork.3 +0 -0
index b727cb48e..db5e210d4 100644

man3/pthread_atfork.3 The · line 45

Quoted 8 lines
man3/pthread_atfork.3 +1 -1
@@ -39,7 +39,7 @@ The
 .BR pthread_atfork ()
 function registers fork handlers that are to be executed when
 .BR fork (2)
-is called by this thread.
+is called.
 The handlers are executed in the context of the thread that calls
 .BR fork (2).
 .PP

I suspect the intent was to indicate that the handlers are called on the thread calling fork, but that's probably clear enough from the context?

Thanks,
Florian

#2 lore raw
Quoted 2 lines

I suspect the intent was to indicate that the handlers are called on the thread calling fork, but that's probably clear enough from the context?

Yes, that could have been the intent. It is also mentioned separately in the second sentence, so that information will not be lost if this change gets applied.

#3 lore raw
In reply to Arjun Shankar

Hi Arjun,

Quoted 6 lines · Arjun Shankar

The reference to "this thread" in the DESCRIPTION of pthread_atfork(3) could be incorrectly interpreted to mean that only handlers registered by the thread calling fork(2) are executed. Therefore, remove the reference.

I already applied a different patch recently. See <http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.

If you think that can be improved, please send a patch on top of the main branch in that repo.

Thanks,

Alex

Quoted 9 lines
---
  man3/pthread_atfork.3 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
man3/pthread_atfork.3 +0 -0
index b727cb48e..db5e210d4 100644

man3/pthread_atfork.3 The · line 45

Quoted 8 lines
man3/pthread_atfork.3 +1 -1
@@ -39,7 +39,7 @@ The
  .BR pthread_atfork ()
  function registers fork handlers that are to be executed when
  .BR fork (2)
-is called by this thread.
+is called.
  The handlers are executed in the context of the thread that calls
  .BR fork (2).
  .PP

--
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

#4 lore raw

Hi Alex,

Quoted 2 lines

I already applied a different patch recently. See
<http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.

I wasn't aware of this repository and therefore missed the change. I'll keep it in mind.

Quoted 2 lines

If you think that can be improved, please send a patch on top of the main branch in that repo.

The commit you mentioned looks good to me. Apologies for the noise and thanks for looking into this.

Cheers,
Arjun

#5 lore raw

Hi Arjun,

Quoted 5 lines · Arjun Shankar

Hi Alex,

Quoted 2 lines

I already applied a different patch recently. See
<http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.

Quoted 7 lines

I wasn't aware of this repository and therefore missed the change. I'll keep it in mind. >

Quoted 2 lines

If you think that can be improved, please send a patch on top of the main branch in that repo.

The commit you mentioned looks good to me. Apologies for the noise and thanks for looking into this.

No problem. It's not noise, IMO :-)
It's always nice to have more wording options to consider.

Cheers,

Alex