Skip to contentSkip to conversation

"Initial commit" with entire git history - possible?

DISCUSSION Adrian Ambrożewicz 3 participants 6 messages Jun 19, 2020 – Jul 8, 2020

lore
Share & tools
lore
#0 lore raw

Hello,

We're developing solution which will soon end as new openbmc-hosted repository.

It would be nice to keep previous commit history intact when moving to upstream. Is it possible with our gerrit-based integration?

Regards,
Adrian

#1 lore raw
Quoted 5 lines · Adrian Ambrożewicz

Hello,

We're developing solution which will soon end as new openbmc-hosted repository.

It would be nice to keep previous commit history intact when moving to upstream. Is it possible with our gerrit-based integration?

Maintainers should have push access to move code over, although it'd be nice if code could be developed and reviewed in the open if possible.

Quoted 3 lines

Regards,
Adrian

#2 lore raw

Brad,

How (as a maintainer) I could 'move' code from our internal repository to github/openbmc hosted one? Is it specified somewhere?

Currently I've pushed whole code to gerrit as usual review to gather feedback, but after that I would still want to pursue path of pushing entire git history + review changes on top of that.

Regards,
Adrian

W dniu 6/20/2020 o 00:16, James Feist pisze:

Quoted 12 lines · Adrian Ambrożewicz
Quoted 5 lines

Hello,

We're developing solution which will soon end as new openbmc-hosted repository.

It would be nice to keep previous commit history intact when moving to upstream. Is it possible with our gerrit-based integration?

Maintainers should have push access to move code over, although it'd be nice if code could be developed and reviewed in the open if possible.

Quoted 3 lines

Regards,
Adrian

#3 lore raw
Quoted 4 lines · Adrian Ambrożewicz

Brad,

How (as a maintainer) I could 'move' code from our internal repository to github/openbmc hosted one? Is it specified somewhere?

git push <remote> HEAD:master

The gerrit remote is something like:
ssh://<user>@gerrit.openbmc-project.xyz:2918/openbmc/telemetry

and the github remote is:
ssh://[email protected]/openbmc/telemetry

You'll need to have configured both github and gerrit to accept whatever ssh keys you present.

Quoted 3 lines

Currently I've pushed whole code to gerrit as usual review to gather feedback, but after that I would still want to pursue path of pushing entire git history + review changes on top of that.

I'm glad to see you are willing to entertain feedback but I'd be suprised if Intel let you spend time on making any meaningful changes (e.g. ones that cause significant rework and time investment on your part) at this point. This is why code should be developed and reviewed in the open in the first place if you actually want others to use it.

#4 lore raw

W dniu 7/1/2020 o 14:15, Brad Bishop pisze:

Quoted 8 lines · Adrian Ambrożewicz
Quoted 4 lines

Brad,

How (as a maintainer) I could 'move' code from our internal repository to github/openbmc hosted one? Is it specified somewhere?

git push <remote> HEAD:master

Quoted 8 lines

The gerrit remote is something like:
ssh://<user>@gerrit.openbmc-project.xyz:2918/openbmc/telemetry

and the github remote is:
ssh://[email protected]/openbmc/telemetry

You'll need to have configured both github and gerrit to accept whatever ssh keys you present.

Thanks, will try this, it was much simpler than I anticipated - sorry!

Quoted 10 lines
Quoted 4 lines

Currently I've pushed whole code to gerrit as usual review to gather feedback, but after that I would still want to pursue path of pushing entire git history + review changes on top  of that.

I'm glad to see you are willing to entertain feedback but I'd be suprised if Intel let you spend time on making any meaningful changes (e.g. ones that cause significant rework and time investment on your part) at this point.  This is why code should be developed and reviewed in the open in the first place if you actually want others to use it.

Thanks for pointing that out. I'm aware of inconvenience with big-bang approach for code publication. I hope feedback like that will advocate for higher priority on legal issues next time. As for bigger changes I wouldn't be so pessimistic - we have allocated time for bugfixes and further development in following months.

Regards,
Adrian

#5 lore raw
Quoted 1 line · Adrian Ambrożewicz

Thanks, will try this, it was much simpler than I anticipated - sorry!

No problemo!

Quoted 1 line

As for bigger changes I wouldn't be so pessimistic - we have allocated time for bugfixes and further development in following months.

Awesome! I am happy to be proven wrong.

-brad