Skip to contentSkip to conversation

prism54/islpci_eth.c: dev_kfree_skb in irq context

PATCH In review Graham Gower 2 participants 2 messages Jan 2, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 prism54/islpci_eth.c: dev_kfree_skb in irq context

dev_kfree_skb shouldn't be used in an IRQ context.

--- linux/drivers/net/wireless/prism54/islpci_eth.c.orig 2006-01-03
01:23:27.000000000 +1030
+++ linux/drivers/net/wireless/prism54/islpci_eth.c 2006-01-03
00:38:46.000000000 +1030
@@ -178,7 +178,7 @@
#endif

newskb->dev = skb->dev;
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
skb = newskb;
}
}
@@ -242,7 +242,7 @@

drop_free:
/* free the skbuf structure before aborting */
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
skb = NULL;

priv->statistics.tx_dropped++;

#1 lore raw
Quoted 9 lines · Graham Gower

dev_kfree_skb shouldn't be used in an IRQ context.

--- linux/drivers/net/wireless/prism54/islpci_eth.c.orig 2006-01-03
01:23:27.000000000 +1030
+++ linux/drivers/net/wireless/prism54/islpci_eth.c 2006-01-03
00:38:46.000000000 +1030

Patch header is linewrapped (patch seems OK though).

You probably want to send this to Jeff Garzik CC'ing the netdev list. I didn't get any response from the prism54 developers when I submitted a fix for a similar problem in November.

Daniel