Follow up block fix
Jens Axboe
maintainerHi Linus,
Just a single followup fix to the corruption fix from yesterday. We have an exported interface that does direct dispatch, with DM being the sole user of it. Change that to do bypass insert always instead of attempting direct dispatch. This fixes a deadlock that can happen on DM. Additionally, it gets rid of any exported user of direct dispatch, and enables DM to drop any BUSY handling from using the interface.
Please pull!
git://git.kernel.dk/linux-block.git tags/for-linus-20181206
----------------------------------------------------------------
Jens Axboe (1):
block: fix direct dispatch issue failure for clones
block/blk-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
Jens Axboe
Quoted 10 lines · Jens Axboe
Just a single followup fix to the corruption fix from yesterday. We have an exported interface that does direct dispatch, with DM being the sole user of it. Change that to do bypass insert always instead of attempting direct dispatch. This fixes a deadlock that can happen on DM. Additionally, it gets rid of any exported user of direct dispatch, and enables DM to drop any BUSY handling from using the interface.
Please pull!>
git://git.kernel.dk/linux-block.gittags/for-linus-20181206
Hi Jens,
Which branch does that tag correspond to? Even after having run git fetch --tags I can't find that tag in your repository. Additionally, the patch on your for-linus branch is missing the "Cc: stable"and "Reported-by:"tags that you had promised to add. Did I look at the wrong branch?
Thanks,
Bart.
Jens Axboe
maintainerQuoted 11 lines · Bart Van Assche
Quoted 10 lines · Jens Axboe
Just a single followup fix to the corruption fix from yesterday. We have an exported interface that does direct dispatch, with DM being the sole user of it. Change that to do bypass insert always instead of attempting direct dispatch. This fixes a deadlock that can happen on DM. Additionally, it gets rid of any exported user of direct dispatch, and enables DM to drop any BUSY handling from using the interface.
Please pull!
Quoted 6 lines
Quoted 1 line
git://git.kernel.dk/linux-block.gittags/for-linus-20181206Hi Jens,
Which branch does that tag correspond to? Even after having run git fetch --tags I can't find that tag in your repository.
I pushed it before I sent the email, where are you looking?
http://git.kernel.dk/cgit/linux-block/tag/?h=for-linus-20181206
Quoted 3 lines
Additionally, the patch on your for-linus branch is missing the "Cc:
stable" and "Reported-by:" tags that you had promised to add. Did I look at the wrong branch?
Doh I did - Linus, I'm going to amend the commit with that info and push it out again, jfyi. Now done.
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Quoted 2 lines · Bart Van Assche
Which branch does that tag correspond to? Even after having run git fetch --tags I can't find that tag in your repository.
I pushed it before I sent the email, where are you looking?
http://git.kernel.dk/cgit/linux-block/tag/?h=for-linus-20181206
On my development system git has been configured to fetch from the following repository:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/
Should I fetch your branches from the git.kernel.dk repository instead?
Thanks,
Bart.
Jens Axboe
maintainerQuoted 5 lines · Bart Van Assche
Quoted 4 lines · Jens Axboe
Quoted 2 lines · Bart Van Assche
Which branch does that tag correspond to? Even after having run git fetch --tags I can't find that tag in your repository.
Quoted 8 lines
Quoted 3 lines
I pushed it before I sent the email, where are you looking?
http://git.kernel.dk/cgit/linux-block/tag/?h=for-linus-20181206
On my development system git has been configured to fetch from the following repository:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/Should I fetch your branches from the git.kernel.dk repository instead?
Ah I see, I always push to git.kernel.dk, and that syncs to git.kernel.org only every hour or so. So either one will work, but you might be a bit behind if you use git.kernel.org.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerQuoted 10 lines · Jens Axboe
Quoted 9 lines · Bart Van Assche
Quoted 7 lines · Jens Axboe
Quoted 2 lines · Bart Van Assche
Which branch does that tag correspond to? Even after having run git fetch --tags I can't find that tag in your repository.
I pushed it before I sent the email, where are you looking?
http://git.kernel.dk/cgit/linux-block/tag/?h=for-linus-20181206
Quoted 8 lines
Quoted 4 lines
On my development system git has been configured to fetch from the following repository:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/Should I fetch your branches from the git.kernel.dk repository instead?
Ah I see, I always push to git.kernel.dk, and that syncs to git.kernel.org only every hour or so. So either one will work, but you might be a bit behind if you use git.kernel.org.
Linus, I just know notice you are not on the CC for the discussion about the patch. Don't pull this one yet. It'll solve the issue, but it'll also mess up the BUSY feedback loop that DM relies on for good merging of sequential IO. Testing a new patch now, will push it to you when folks are happy and when my testing has completed.
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Linus, I just know notice you are not on the CC for the discussion about the patch. Don't pull this one yet. It'll solve the issue, but it'll also mess up the BUSY feedback loop that DM relies on for good merging of sequential IO. Testing a new patch now, will push it to you when folks are happy and when my testing has completed.
Ok, this pull request dropped from my queue.
Linus