Multicolor Framework
Subsystems (4)
v17 cover Multicolor Framework
Hello
Simple fix in the multicolor code where the extended registration call was not called in the devm_* function
Thanks Martin F. for finding this issue.
Hopefully this will be pulled in for the 5.5 merge window.
Dan
Dan Murphy (19):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add multicolor ID to the color ID list
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce a multicolor class definition
dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
leds: lp50xx: Add the LP50XX family of the RGB LED driver
dt: bindings: lp55xx: Be consistent in the document with LED acronym
dt: bindings: lp55xx: Update binding for Multicolor Framework
ARM: dts: n900: Add reg property to the LP5523 channel node
ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
leds: lp55xx: Convert LED class registration to devm_*
leds: lp55xx: Add multicolor framework support to lp55xx
leds: lp5523: Update the lp5523 code to add multicolor brightness
function
leds: lp5521: Add multicolor framework multicolor brightness support
leds: lp55xx: Fix checkpatch file permissions issues
leds: lp5523: Fix checkpatch issues in the code
dt: bindings: Update lp55xx binding to recommended LED naming
leds: lp55xx-common: Remove extern from lp55xx-common header
.../ABI/testing/sysfs-class-led-multicolor | 36 + .../bindings/leds/leds-class-multicolor.txt | 98 +++ .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++ .../devicetree/bindings/leds/leds-lp55xx.txt | 163 +++- Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 100 +++ arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 +- arch/arm/boot/dts/omap3-n900.dts | 29 +- arch/arm/boot/dts/ste-href.dtsi | 22 +- drivers/leds/Kconfig | 22 + drivers/leds/Makefile | 2 + drivers/leds/led-class-multicolor.c | 272 ++++++ drivers/leds/led-core.c | 1 + drivers/leds/leds-lp50xx.c | 799 ++++++++++++++++++ drivers/leds/leds-lp5521.c | 43 +- drivers/leds/leds-lp5523.c | 62 +- drivers/leds/leds-lp5562.c | 22 +- drivers/leds/leds-lp55xx-common.c | 235 ++++-- drivers/leds/leds-lp55xx-common.h | 36 +- drivers/leds/leds-lp8501.c | 23 +- include/dt-bindings/leds/common.h | 3 +- include/linux/led-class-multicolor.h | 139 +++ include/linux/platform_data/leds-lp55xx.h | 8 + 23 files changed, 2106 insertions(+), 172 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt create mode 100644 Documentation/leds/leds-class-multicolor.rst create mode 100644 drivers/leds/led-class-multicolor.c create mode 100644 drivers/leds/leds-lp50xx.c create mode 100644 include/linux/led-class-multicolor.h
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 1/19 dt: bindings: Add multicolor class dt bindings documention
Add DT bindings for the LEDs multicolor class framework.
--- .../bindings/leds/leds-class-multicolor.txt | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
Documentation/devicetree/bindings/leds/leds-class-multicolor.txt new file +98 -0
@@ -0,0 +1,98 @@ +* Multicolor LED properties + +Bindings for multi color LEDs show how to describe current outputs of +either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV +etc.) or standalone LEDs, to achieve logically grouped multi-color LED +modules. This is achieved by adding multi-led nodes layer to the +monochrome LED bindings. + +The nodes and properties defined in this document are unique to the multicolor +LED class. Common LED nodes and properties are inherited from the common.txt +within this documentation directory. + +Required LED child properties: + - color : For multicolor LED support this property should be defined as + LED_COLOR_ID_MULTI and further definition can be found in + include/linux/leds/common.h. + +led-controller@30 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "ti,lp5024"; + reg = <0x29>; + + multi-led@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_CHARGING; + + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_RED>; + }; + + led@4 { + reg = <4>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@5 { + reg = <5>; + color = <LED_COLOR_ID_BLUE>; + }; + }; + + multi-led@2 { + #address-cells = <1>; + #size-cells = <0>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_ACTIVITY; + reg = <2>; + ti,led-bank = <2 3 5>; + + led@6 { + reg = <0x6>; + color = <LED_COLOR_ID_RED>; + led-sources = <6 9 15>; + }; + + led@7 { + reg = <0x7>; + color = <LED_COLOR_ID_GREEN>; + led-sources = <7 10 16>; + }; + + led@8 { + reg = <0x8>; + color = <LED_COLOR_ID_BLUE>; + led-sources = <8 11 17>; + }; + }; + + multi-led@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_ACTIVITY; + + led@12 { + reg = <12>; + color = <LED_COLOR_ID_RED>; + }; + + led@13 { + reg = <13>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@14 { + reg = <14>; + color = <LED_COLOR_ID_BLUE>; + }; + }; + +};
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 2/19 dt-bindings: leds: Add multicolor ID to the color ID list
In reply to Dan MurphyAdd a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.
--- include/dt-bindings/leds/common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/dt-bindings/leds/common.h +2 -1
@@ -29,7 +29,8 @@#define LED_COLOR_ID_VIOLET 5#define LED_COLOR_ID_YELLOW 6#define LED_COLOR_ID_IR 7 -#define LED_COLOR_ID_MAX 8 +#define LED_COLOR_ID_MULTI 8 +#define LED_COLOR_ID_MAX 9/* Standard LED functions */ #define LED_FUNCTION_ACTIVITY "activity"
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 3/19 leds: Add multicolor ID to the color ID list
In reply to Dan MurphyAdd a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.
--- drivers/leds/led-core.c | 1 + 1 file changed, 1 insertion(+)
drivers/leds/led-core.c +1 -0
@@ -34,6 +34,7 @@ const char * const led_colors[LED_COLOR_ID_MAX] = { [LED_COLOR_ID_VIOLET] = "violet", [LED_COLOR_ID_YELLOW] = "yellow", [LED_COLOR_ID_IR] = "ir", + [LED_COLOR_ID_MULTI ] ="multicolor" , };EXPORT_SYMBOL_GPL (led_colors);
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 4/19 leds: multicolor: Introduce a multicolor class definition
In reply to Dan MurphyIntroduce a multicolor class that groups colored LEDs within a LED node.
The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via <color>_intensity files and the latter is controlled via brightness file.
--- .../ABI/testing/sysfs-class-led-multicolor | 36 +++ Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 100 +++++++ drivers/leds/Kconfig | 10 + drivers/leds/Makefile | 1 + drivers/leds/led-class-multicolor.c | 272 ++++++++++++++++++ include/linux/led-class-multicolor.h | 139 +++++++++ 7 files changed, 559 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor create mode 100644 Documentation/leds/leds-class-multicolor.rst create mode 100644 drivers/leds/led-class-multicolor.c create mode 100644 include/linux/led-class-multicolor.h
Documentation/ABI/testing/sysfs-class-led-multicolor new file +36 -0
@@ -0,0 +1,36 @@ +What: /sys/class/leds/<led>/brightness +Date: Sept 2019 +KernelVersion: 5.5 +Contact: Dan Murphy <[email protected]> +Description: read/write + Writing to this file will update all LEDs within the group to a + calculated percentage of what each color LED intensity is set + to. The percentage is calculated for each grouped LED via the + equation below: + + led_brightness = brightness * <color>_intensity/<color>_max_intensity + + For additional details please refer to + Documentation/leds/leds-class-multicolor.rst. + + The value of the color is from 0 to + /sys/class/leds/<led>/max_brightness. + +What: /sys/class/leds/<led>/colors/<color>_intensity +Date: Sept 2019 +KernelVersion: 5.5 +Contact: Dan Murphy <[email protected]> +Description: read/write + The <color>_intensity file is created based on the color + defined by the registrar of the class. + There is one file per color presented. + + The value of the color is from 0 to + /sys/class/leds/<led>/colors/<color>_max_intensity. + +What: /sys/class/leds/<led>/colors/<color>_max_intensity +Date: Sept 2019 +KernelVersion: 5.5 +Contact: Dan Murphy <[email protected]> +Description: read only + Maximum intensity level for the LED color.
Documentation/leds/index.rst +1 -0
@@ -9,6 +9,7 @@ LEDs leds-class leds-class-flash + leds-class-multicolor ledtrig-oneshot ledtrig-transient ledtrig-usbport
Documentation/leds/leds-class-multicolor.rst new file +100 -0
100 lines not on this page · raw message
drivers/leds/Kconfig +10 -0
@@ -30,6 +30,16 @@ config LEDS_CLASS_FLASH for the flash related features of a LED device. It can be built as a module. +config LEDS_CLASS_MULTI_COLOR + tristate "LED Mulit Color LED Class Support" + depends on LEDS_CLASS + help + This option enables the multicolor LED sysfs class in /sys/class/leds. + It wraps LED class and adds multicolor LED specific sysfs attributes + and kernel internal API to it. You'll need this to provide support + for multicolor LEDs that are grouped together. This class is not + intended for single color LEDs. It can be built as a module. + config LEDS_BRIGHTNESS_HW_CHANGED bool "LED Class brightness_hw_changed attribute support" depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
@@ -4,6 +4,7 @@ obj-$(CONFIG_NEW_LEDS) += led-core.o obj-$(CONFIG_LEDS_CLASS) += led-class.o obj-$(CONFIG_LEDS_CLASS_FLASH) += led-class-flash.o +obj-$(CONFIG_LEDS_CLASS_MULTI_COLOR) += led-class-multicolor.o obj-$(CONFIG_LEDS_TRIGGERS) += led-triggers.o # LED Platform Drivers
drivers/leds/led-class-multicolor.c new file +272 -0
272 lines not on this page · raw message
include/linux/led-class-multicolor.h new file +139 -0
139 lines not on this page · raw message
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 5/19 dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
In reply to Dan MurphyIntroduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part of a control bank group. These devices have the ability to adjust the mixing control for the RGB LEDs to obtain different colors independent of the overall brightness of the LED grouping.
Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf
--- .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++++++++++++++++ 1 file changed, 148 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
Documentation/devicetree/bindings/leds/leds-lp50xx.txt new file +148 -0
@@ -0,0 +1,148 @@ +* Texas Instruments - LP5009/12/18/24/30/36 RGB LED driver + +The LP50XX is multi-channel, I2C RGB LED Drivers that can group RGB LEDs into +a LED group or control them individually. + +The difference in these RGB LED drivers is the number of supported RGB modules. + +Required parent properties: + - compatible: + "ti,lp5009" + "ti,lp5012" + "ti,lp5018" + "ti,lp5024" + "ti,lp5030" + "ti,lp5036" + - reg : I2C slave address + lp5009/12 - 0x14, 0x15, 0x16, 0x17 + lp5018/24 - 0x28, 0x29, 0x2a, 0x2b + lp5030/36 - 0x30, 0x31, 0x32, 0x33 + - #address-cells : 1 + - #size-cells : 0 + +Optional parent properties: + - enable-gpios : gpio pin to enable/disable the device. + - vled-supply : LED supply + +Required child properties: + - #address-cells : 1 + - #size-cells : 0 + - reg : This is the LED module number. + - color : Must be LED_COLOR_ID_MULTI + - function : see Documentation/devicetree/bindings/leds/common.txt + +Required child properties only if LED modules will be banked: + - ti,led-bank : This property denotes the LED module numbers that will + be controlled as a single RGB cluster. Each LED module + number will be controlled by a single LED class instance. + There can only be one instance of the ti,led-bank + property for each device node. + +Required grandchildren properties: + - reg : A single entry denoting the LED output that controls + the monochrome LED. + - color : see Documentation/devicetree/bindings/leds/common.txt + - led-sources : see Documentation/devicetree/bindings/leds/common.txt + +The LED outputs associated with the LED modules are defined in Table 1 of the +corresponding data sheets. + +LP5009 - 3 Total RGB cluster LED outputs 0-2 +LP5012 - 4 Total RGB cluster LED outputs 0-3 +LP5018 - 6 Total RGB cluster LED outputs 0-5 +LP5024 - 8 Total RGB cluster LED outputs 0-7 +LP5030 - 10 Total RGB cluster LED outputs 0-9 +LP5036 - 12 Total RGB cluster LED outputs 0-11 + +Optional child properties: + - label : see Documentation/devicetree/bindings/leds/common.txt + - linux,default-trigger : + see Documentation/devicetree/bindings/leds/common.txt + +Examples: +led-controller@29 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "ti,lp5024"; + reg = <0x29>; + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + vled-supply = <&vmmcsd_fixed>; + + multi-led@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_STATUS; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_RED>; + }; + + led@4 { + reg = <4>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@5 { + reg = <5>; + color = <LED_COLOR_ID_BLUE>; + }; + }; + + multi-led@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_STANDBY; + ti,led-bank = <2 3 5>; + + led@6 { + reg = <0x6>; + color = <LED_COLOR_ID_RED>; + led-sources = <6 9 15>; + }; + + led@7 { + reg = <0x7>; + color = <LED_COLOR_ID_GREEN>; + led-sources = <7 10 16>; + }; + + led@8 { + reg = <0x8>; + color = <LED_COLOR_ID_BLUE>; + led-sources = <8 11 17>; + }; + }; + + multi-led@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_ACTIVITY; + + led@12 { + reg = <12>; + color = <LED_COLOR_ID_RED>; + }; + + led@13 { + reg = <13>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@14 { + reg = <14>; + color = <LED_COLOR_ID_BLUE>; + }; + }; +}; + +For more product information please see the link below: +http://www.ti.com/lit/ds/symlink/lp5012.pdf +http://www.ti.com/lit/ds/symlink/lp5024.pdf +http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 6/19 leds: lp50xx: Add the LP50XX family of the RGB LED driver
In reply to Dan MurphyIntroduce the LP5036/30/24/18/12/9 RGB LED driver. The difference in these parts are the number of LED outputs where the:
LP5036 can control 36 LEDs
LP5030 can control 30 LEDs
LP5024 can control 24 LEDs
LP5018 can control 18 LEDs
LP5012 can control 12 LEDs
LP5009 can control 9 LEDs
The device has the ability to group LED output into control banks so that multiple LED banks can be controlled with the same mixing and brightness. Inversely the LEDs can also be controlled independently.
--- drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-lp50xx.c | 799 +++++++++++++++++++++++++++++++++++++ 3 files changed, 811 insertions(+) create mode 100644 drivers/leds/leds-lp50xx.c
drivers/leds/Kconfig +11 -0
@@ -363,6 +363,17 @@ config LEDS_LP3952 To compile this driver as a module, choose M here: the module will be called leds-lp3952. +config LEDS_LP50XX + tristate "LED Support for TI LP5036/30/24/18/12/9 LED driver chip" + depends on LEDS_CLASS && REGMAP_I2C + depends on LEDS_CLASS_MULTI_COLOR + help + If you say yes here you get support for the Texas Instruments + LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 LED driver. + + To compile this driver as a module, choose M here: the + module will be called leds-lp50xx. + config LEDS_LP55XX_COMMON tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501" depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
drivers/leds/Makefile +1 -0
@@ -34,6 +34,7 @@ obj-$(CONFIG_LEDS_GPIO_REGISTER) += leds-gpio-register.o obj-$(CONFIG_LEDS_GPIO) += leds-gpio.o obj-$(CONFIG_LEDS_LP3944) += leds-lp3944.o obj-$(CONFIG_LEDS_LP3952) += leds-lp3952.o +obj-$(CONFIG_LEDS_LP50XX) += leds-lp50xx.o obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o obj-$(CONFIG_LEDS_LP5521) += leds-lp5521.o obj-$(CONFIG_LEDS_LP5523) += leds-lp5523.o
drivers/leds/leds-lp50xx.c new file +799 -0
799 lines not on this page · raw message
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 7/19 dt: bindings: lp55xx: Be consistent in the document with LED acronym
In reply to Dan MurphyUpdate the document to be consistent in case when using "LED". This acronym should be capital throughout the document.
--- Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +3 -3
@@ -1,4 +1,4 @@ -Binding for TI/National Semiconductor LP55xx Led Drivers +Binding for TI/National Semiconductor LP55xx LED Drivers Required properties: - compatible: one of
@@ -12,8 +12,8 @@ Required properties: - clock-mode: Input clock mode, (0: automode, 1: internal, 2: external) Each child has own specific current settings -- led-cur: Current setting at each led channel (mA x10, 0 if led is not connected) -- max-cur: Maximun current at each led channel. +- led-cur: Current setting at each LED channel (mA x10, 0 if LED is not connected) +- max-cur: Maximun current at each LED channel. Optional properties: - enable-gpio: GPIO attached to the chip's enable pin
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 07/19] dt: bindings: lp55xx: Be consistent in the document with LED acronym
Quoted 4 lines · Dan Murphy
Update the document to be consistent in case when using "LED". This acronym should be capital throughout the document.
Signed-off-by Dan Murphy <[email protected]>
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 8/19 dt: bindings: lp55xx: Update binding for Multicolor Framework
In reply to Dan MurphyUpdate the DT binding to include the properties to use the multicolor framework for the devices that use the LP55xx framework.
--- .../devicetree/bindings/leds/leds-lp55xx.txt | 149 +++++++++++++++--- 1 file changed, 124 insertions(+), 25 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +124 -25
@@ -1,6 +1,8 @@ Binding for TI/National Semiconductor LP55xx LED Drivers Required properties: +- #address-cells: 1 +- #size-cells: 0 - compatible: one of national,lp5521 national,lp5523
@@ -14,6 +16,18 @@ Required properties: Each child has own specific current settings - led-cur: Current setting at each LED channel (mA x10, 0 if LED is not connected) - max-cur: Maximun current at each LED channel. +- reg: Output channel for the LED. This is zero based channel identifier and + the data sheet is a one based channel identifier. + reg value to output to LED output number + D1 = reg value is 0 + D2 = reg value is 1 + D3 = reg value is 2 + D4 = reg value is 3 + D5 = reg value is 4 + D6 = reg value is 5 + D7 = reg value is 6 + D8 = reg value is 7 + D9 = reg value is 8 Optional properties: - enable-gpio: GPIO attached to the chip's enable pin
@@ -35,23 +49,28 @@ example 1) LP5521 on channel 0. lp5521@32 { + #address-cells = <1>; + #size-cells = <0>; compatible = "national,lp5521"; reg = <0x32>; label = "lp5521_pri"; clock-mode = /bits/ 8 <2>; - chan0 { + chan@0 { + reg = <0>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; linux,default-trigger = "heartbeat"; }; - chan1 { + chan@1 { + reg = <1>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; }; - chan2 { + chan@2 { + reg = <2>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; };
@@ -70,59 +89,70 @@ ASEL1 ASEL0 Address VEN VEN 35h lp5523@32 { + #address-cells = <1>; + #size-cells = <0>; compatible = "national,lp5523"; reg = <0x32>; clock-mode = /bits/ 8 <1>; - chan0 { + chan@0 { + reg = <0>; chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan1 { + chan@1 { + reg = <1>; chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan2 { + chan@2 { + reg = <2>; chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan3 { + chan@3 { + reg = <3>; chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan4 { + chan@4 { + reg = <4>; chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan5 { + chan@5 { + reg = <5>; chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan6 { + chan@6 { + reg = <6>; chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan7 { + chan@7 { + reg = <7>; chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan8 { + chan@8 { + reg = <8>; chan-name = "d9"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>;
@@ -133,29 +163,35 @@ example 3) LP5562 4 channels are defined. lp5562@30 { + #address-cells = <1>; + #size-cells = <0>; compatible = "ti,lp5562"; reg = <0x30>; clock-mode = /bits/8 <2>; - chan0 { + chan@0 { + reg = <0>; chan-name = "R"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan1 { + chan@1 { + reg = <1>; chan-name = "G"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan2 { + chan@2 { + reg = <2>; chan-name = "B"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan3 { + chan@3 { + reg = <3>; chan-name = "W"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>;
@@ -167,62 +203,125 @@ example 4) LP8501 Others are same as LP5523. lp8501@32 { + #address-cells = <1>; + #size-cells = <0>; compatible = "ti,lp8501"; reg = <0x32>; clock-mode = /bits/ 8 <2>; pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ - chan0 { + chan@0 { + reg = <0>; chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan1 { + chan@1 { + reg = <1>; chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan2 { + chan@2 { + reg = <2>; chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan3 { + chan@3 { + reg = <3>; chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan4 { + chan@4 { + reg = <4>; chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan5 { + chan@5 { + reg = <5>; chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan6 { + chan@6 { + reg = <6>; chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan7 { + chan@7 { + reg = <7>; chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan8 { + chan@8 { + reg = <8>; chan-name = "d9"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; }; + +Multicolor Framework Support +In addition to the nodes and properties defined above for device support the +properties below are needed for multicolor framework support as defined in +Documentation/devicetree/bindings/leds/leds-class-multicolor.txt + +Required child properties for multicolor framework + - color : Must be LED_COLOR_ID_MULTI + - function : see Documentation/devicetree/bindings/leds/common.txt + +Required grandchildren properties + - reg : This is the LED output of the device + - color : see Documentation/devicetree/bindings/leds/common.txt + +Multicolor LED example: +led-controller@32 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "national,lp5523"; + reg = <0x32>; + clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ + + multi-led@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_STANDBY; + linux,default-trigger = "heartbeat"; + + led@0 { + led-cur = /bits/ 8 <50>; + max-cur = /bits/ 8 <100>; + reg = <0x0>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@1 { + led-cur = /bits/ 8 <50>; + max-cur = /bits/ 8 <100>; + reg = <0x1>; + color = <LED_COLOR_ID_BLUE>; + }; + + led@6 { + led-cur = /bits/ 8 <50>; + max-cur = /bits/ 8 <100>; + reg = <0x6>; + color = <LED_COLOR_ID_RED>; + }; + }; +};
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 9/19 ARM: dts: n900: Add reg property to the LP5523 channel node
In reply to Dan MurphyAdd the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
--- arch/arm/boot/dts/omap3-n900.dts | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-)
arch/arm/boot/dts/omap3-n900.dts +20 -9
@@ -607,63 +607,74 @@ }; lp5523: lp5523@32 { + #address-cells = <1>; + #size-cells = <0>; compatible = "national,lp5523"; reg = <0x32>; clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */ enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ - chan0 { + chan@0 { chan-name = "lp5523:kb1"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <0>; }; - chan1 { + chan@1 { chan-name = "lp5523:kb2"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <1>; }; - chan2 { + chan@2 { chan-name = "lp5523:kb3"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <2>; }; - chan3 { + chan@3 { chan-name = "lp5523:kb4"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <3>; }; - chan4 { + chan@4 { chan-name = "lp5523:b"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <4>; }; - chan5 { + chan@5 { chan-name = "lp5523:g"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <5>; }; - chan6 { + chan@6 { chan-name = "lp5523:r"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <6>; }; - chan7 { + chan@7 { chan-name = "lp5523:kb5"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <7>; }; - chan8 { + chan@8 { chan-name = "lp5523:kb6"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <100>; + reg = <8>; }; };
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 09/19] ARM: dts: n900: Add reg property to the LP5523 channel node
Quoted 10 lines · Dan Murphy
Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
Signed-off-by Dan Murphy <[email protected]>Acked-by Tony Lindgren <[email protected]>CC Tony Lindgren <[email protected]>CC "Benoît Cousson" <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 10/19 ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
In reply to Dan MurphyAdd the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
--- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +10 -4
@@ -257,29 +257,35 @@ reg = <0x30>; clock-mode = /bits/ 8 <1>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; - chan0 { + chan@0 { chan-name = "R"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <0>; }; - chan1 { + chan@1 { chan-name = "G"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <1>; }; - chan2 { + chan@2 { chan-name = "B"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <2>; }; - chan3 { + chan@3 { chan-name = "W"; led-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>; + reg = <3>; }; };
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
Quoted 21 lines · Dan Murphy
Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
Signed-off-by Dan Murphy <[email protected]>CC Shawn Guo <[email protected]>CC Sascha Hauer <[email protected]>CC Pengutronix Kernel Team <[email protected]>CC Fabio Estevam <[email protected]>CC NXP Linux Team <[email protected]>--- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +0
-0
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi line 263
Quoted 8 lines
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +3
-1@@ -257,29 +257,35 @@ reg = <0x30>; clock-mode = /bits/ 8 <1>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; - chan0 { + chan@0 {
Again, why do not we rename it to led@0 as you update the bindings in the last patch in the series?
Shawn
Quoted 34 lines
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +7
-3chan-name = "R"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <0>; }; - chan1 { + chan@1 { chan-name = "G"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <1>; }; - chan2 { + chan@2 { chan-name = "B"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <2>; }; - chan3 { + chan@3 { chan-name = "W"; led-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>; + reg = <3>; }; };Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
Shawn
Quoted 28 lines · Shawn Guo
Quoted 27 lines · Dan Murphy
Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
Signed-off-by Dan Murphy <[email protected]>CC Shawn Guo <[email protected]>CC Sascha Hauer <[email protected]>CC Pengutronix Kernel Team <[email protected]>CC Fabio Estevam <[email protected]>CC NXP Linux Team <[email protected]>--- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +2
-0@@ -257,29 +257,35 @@ reg = <0x30>; clock-mode = /bits/ 8 <1>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>;
Quoted 4 lines
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi line 263
Quoted 2 lines
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +1
-1- chan0 { + chan@0 {Again, why do not we rename it to led@0 as you update the bindings in the last patch in the series?
I am trying to limit the amount of change in this patchset.
I know what you are asking is for a small change but that would be another patch to the series to the label. I want to keep functional changes like this isolated from clean up changes like you asked for bissectability.
From that point we can make additional changes. I would really like this to get into 5.6 as I thought I hit the merge window for 5.5 but it did not make it.
Dan
PATCH v17 11/19 ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
In reply to Dan MurphyAdd the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
--- arch/arm/boot/dts/ste-href.dtsi | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-)
arch/arm/boot/dts/ste-href.dtsi +16 -6
@@ -56,16 +56,21 @@ reg = <0x33>; label = "lp5521_pri"; clock-mode = /bits/ 8 <2>; - chan0 { + #address-cells = <1>; + #size-cells = <0>; + chan@0 { + reg = <0>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; linux,default-trigger = "heartbeat"; }; - chan1 { + chan@1 { + reg = <1>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; }; - chan2 { + chan@2 { + reg = <2>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; };
@@ -75,15 +80,20 @@ reg = <0x34>; label = "lp5521_sec"; clock-mode = /bits/ 8 <2>; - chan0 { + #address-cells = <1>; + #size-cells = <0>; + chan@0 { + reg = <0>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; }; - chan1 { + chan@1 { + reg = <1>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; }; - chan2 { + chan@2 { + reg = <2>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; };
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 11/19] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
Quoted 8 lines · Dan Murphy
Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.
Signed-off-by Dan Murphy <[email protected]>CC Linus Walleij <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 12/19 leds: lp55xx: Convert LED class registration to devm_*
In reply to Dan MurphyConvert the LED class registration calls to the LED devm_* registration calls.
--- drivers/leds/leds-lp5521.c | 9 +++------ drivers/leds/leds-lp5523.c | 9 +++------ drivers/leds/leds-lp5562.c | 9 +++------ drivers/leds/leds-lp55xx-common.c | 15 +-------------- drivers/leds/leds-lp55xx-common.h | 2 -- drivers/leds/leds-lp8501.c | 9 +++------ 6 files changed, 13 insertions(+), 40 deletions(-)
drivers/leds/leds-lp5521.c +3 -6
@@ -541,19 +541,17 @@ static int lp5521_probe(struct i2c_client *client, ret =lp55xx_register_leds (led, chip);if (ret) - goto err_register_leds; + goto err_out; ret =lp55xx_register_sysfs (chip);if (ret) {dev_err (&client->dev,"registering sysfs failed\n" ); - goto err_register_sysfs; + goto err_out; }return 0 ; -err_register_sysfs: -lp55xx_unregister_leds (led, chip); -err_register_leds: +err_out:lp55xx_deinit_device (chip); err_init:return ret;
@@ -566,7 +564,6 @@ static int lp5521_remove(struct i2c_client *client)lp5521_stop_all_engines (chip);lp55xx_unregister_sysfs (chip); -lp55xx_unregister_leds (led, chip);lp55xx_deinit_device (chip);return 0 ;
drivers/leds/leds-lp5523.c +3 -6
@@ -908,19 +908,17 @@ static int lp5523_probe(struct i2c_client *client, ret =lp55xx_register_leds (led, chip);if (ret) - goto err_register_leds; + goto err_out; ret =lp55xx_register_sysfs (chip);if (ret) {dev_err (&client->dev,"registering sysfs failed\n" ); - goto err_register_sysfs; + goto err_out; }return 0 ; -err_register_sysfs: -lp55xx_unregister_leds (led, chip); -err_register_leds: +err_out:lp55xx_deinit_device (chip); err_init:return ret;
@@ -933,7 +931,6 @@ static int lp5523_remove(struct i2c_client *client)lp5523_stop_all_engines (chip);lp55xx_unregister_sysfs (chip); -lp55xx_unregister_leds (led, chip);lp55xx_deinit_device (chip);return 0 ;
drivers/leds/leds-lp5562.c +3 -6
@@ -554,19 +554,17 @@ static int lp5562_probe(struct i2c_client *client, ret =lp55xx_register_leds (led, chip);if (ret) - goto err_register_leds; + goto err_out; ret =lp55xx_register_sysfs (chip);if (ret) {dev_err (&client->dev,"registering sysfs failed\n" ); - goto err_register_sysfs; + goto err_out; }return 0 ; -err_register_sysfs: -lp55xx_unregister_leds (led, chip); -err_register_leds: +err_out:lp55xx_deinit_device (chip); err_init:return ret;
@@ -580,7 +578,6 @@ static int lp5562_remove(struct i2c_client *client)lp5562_stop_engine (chip);lp55xx_unregister_sysfs (chip); -lp55xx_unregister_leds (led, chip);lp55xx_deinit_device (chip);return 0 ;
drivers/leds/leds-lp55xx-common.c +1 -14
@@ -181,7 +181,7 @@ static int lp55xx_init_led(struct lp55xx_led *led, led->cdev.name = name; } - ret =led_classdev_register (dev, &led->cdev); + ret =devm_led_classdev_register (dev, &led->cdev);if (ret) {dev_err (dev,"led register err: %d\n" , ret);return ret;
@@ -490,23 +490,10 @@ int lp55xx_register_leds(struct lp55xx_led *led, struct lp55xx_chip *chip)return 0 ; err_init_led: -lp55xx_unregister_leds (led, chip);return ret; }EXPORT_SYMBOL_GPL (lp55xx_register_leds); -void lp55xx_unregister_leds (struct lp55xx_led *led,struct lp55xx_chip *chip) -{ -int i; -struct lp55xx_led *each; - -for (i =0 ; i < chip->num_leds; i++) { - each = led + i; -led_classdev_unregister (&each->cdev); - } -} -EXPORT_SYMBOL_GPL (lp55xx_unregister_leds); -int lp55xx_register_sysfs (struct lp55xx_chip *chip) {struct device *dev = &chip->cl->dev;
drivers/leds/leds-lp55xx-common.h +0 -2
@@ -189,8 +189,6 @@ extern void lp55xx_deinit_device(struct lp55xx_chip *chip);/* common LED class device functions */ extern int lp55xx_register_leds (struct lp55xx_led *led,struct lp55xx_chip *chip); -extern void lp55xx_unregister_leds (struct lp55xx_led *led, -struct lp55xx_chip *chip);/* common device attributes functions */ extern int lp55xx_register_sysfs (struct lp55xx_chip *chip);
drivers/leds/leds-lp8501.c +3 -6
@@ -344,19 +344,17 @@ static int lp8501_probe(struct i2c_client *client, ret =lp55xx_register_leds (led, chip);if (ret) - goto err_register_leds; + goto err_out; ret =lp55xx_register_sysfs (chip);if (ret) {dev_err (&client->dev,"registering sysfs failed\n" ); - goto err_register_sysfs; + goto err_out; }return 0 ; -err_register_sysfs: -lp55xx_unregister_leds (led, chip); -err_register_leds: +err_out:lp55xx_deinit_device (chip); err_init:return ret;
@@ -369,7 +367,6 @@ static int lp8501_remove(struct i2c_client *client)lp8501_stop_engine (chip);lp55xx_unregister_sysfs (chip); -lp55xx_unregister_leds (led, chip);lp55xx_deinit_device (chip);return 0 ;
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 12/19] leds: lp55xx: Convert LED class registration to devm_*
Quoted 4 lines · Dan Murphy
Convert the LED class registration calls to the LED devm_* registration calls.
Signed-off-by Dan Murphy <[email protected]>
Nothing obviously wrong here. Was it tested?
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH v17 12/19] leds: lp55xx: Convert LED class registration to devm_*
Pavel
Quoted 11 lines · Pavel Machek
Quoted 4 lines · Dan Murphy
Convert the LED class registration calls to the LED devm_* registration calls.
Signed-off-by Dan Murphy <[email protected]>Nothing obviously wrong here. Was it tested?
Acked-by Pavel Machek <[email protected]>Best regards,
Pavel
Was there a specific test you are looking for me to perform besides basic testing?
Dan
PATCH v17 13/19 leds: lp55xx: Add multicolor framework support to lp55xx
In reply to Dan MurphyAdd multicolor framework support for the lp55xx family.
--- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp5521.c | 14 +- drivers/leds/leds-lp5523.c | 14 +- drivers/leds/leds-lp5562.c | 13 +- drivers/leds/leds-lp55xx-common.c | 200 +++++++++++++++++++--- drivers/leds/leds-lp55xx-common.h | 12 +- drivers/leds/leds-lp8501.c | 14 +- include/linux/platform_data/leds-lp55xx.h | 8 + 8 files changed, 228 insertions(+), 48 deletions(-)
drivers/leds/Kconfig +1 -0
@@ -377,6 +377,7 @@ config LEDS_LP50XX config LEDS_LP55XX_COMMON tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501" depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501 + depends on OF select FW_LOADER select FW_LOADER_USER_HELPER help
drivers/leds/leds-lp5521.c +8 -6
@@ -505,9 +505,16 @@ static int lp5521_probe(struct i2c_client *client,struct lp55xx_platform_data *pdata =dev_get_platdata (&client->dev);struct device_node *np = client->dev.of_node; + chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); +if (!chip) +return -ENOMEM ; + + chip->cfg = &lp5521_cfg; +if (!pdata) {if (np) { - pdata =lp55xx_of_populate_pdata (&client->dev, np); + pdata =lp55xx_of_populate_pdata (&client->dev, np, + chip);if (IS_ERR (pdata))return PTR_ERR (pdata); }else {
@@ -516,10 +523,6 @@ static int lp5521_probe(struct i2c_client *client, } } - chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); -if (!chip) -return -ENOMEM ; - led =devm_kcalloc (&client->dev, pdata->num_channels,sizeof (*led),GFP_KERNEL );if (!led)
@@ -527,7 +530,6 @@ static int lp5521_probe(struct i2c_client *client, chip->cl = client; chip->pdata = pdata; - chip->cfg = &lp5521_cfg;mutex_init (&chip->lock);
drivers/leds/leds-lp5523.c +8 -6
@@ -872,9 +872,16 @@ static int lp5523_probe(struct i2c_client *client,struct lp55xx_platform_data *pdata =dev_get_platdata (&client->dev);struct device_node *np = client->dev.of_node; + chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); +if (!chip) +return -ENOMEM ; + + chip->cfg = &lp5523_cfg; +if (!pdata) {if (np) { - pdata =lp55xx_of_populate_pdata (&client->dev, np); + pdata =lp55xx_of_populate_pdata (&client->dev, np, + chip);if (IS_ERR (pdata))return PTR_ERR (pdata); }else {
@@ -883,10 +890,6 @@ static int lp5523_probe(struct i2c_client *client, } } - chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); -if (!chip) -return -ENOMEM ; - led =devm_kcalloc (&client->dev, pdata->num_channels,sizeof (*led),GFP_KERNEL );if (!led)
@@ -894,7 +897,6 @@ static int lp5523_probe(struct i2c_client *client, chip->cl = client; chip->pdata = pdata; - chip->cfg = &lp5523_cfg;mutex_init (&chip->lock);
drivers/leds/leds-lp5562.c +8 -5
@@ -520,9 +520,16 @@ static int lp5562_probe(struct i2c_client *client,struct lp55xx_platform_data *pdata =dev_get_platdata (&client->dev);struct device_node *np = client->dev.of_node; + chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); +if (!chip) +return -ENOMEM ; + + chip->cfg = &lp5562_cfg; +if (!pdata) {if (np) { - pdata =lp55xx_of_populate_pdata (&client->dev, np); + pdata =lp55xx_of_populate_pdata (&client->dev, np, + chip);if (IS_ERR (pdata))return PTR_ERR (pdata); }else {
@@ -531,9 +538,6 @@ static int lp5562_probe(struct i2c_client *client, } } - chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); -if (!chip) -return -ENOMEM ; led =devm_kcalloc (&client->dev, pdata->num_channels,sizeof (*led),GFP_KERNEL );
@@ -542,7 +546,6 @@ static int lp5562_probe(struct i2c_client *client, chip->cl = client; chip->pdata = pdata; - chip->cfg = &lp5562_cfg;mutex_init (&chip->lock);
drivers/leds/leds-lp55xx-common.c +176 -24
257 lines not on this page · raw message
drivers/leds/leds-lp55xx-common.h +11 -1
@@ -12,6 +12,8 @@#ifndef _LEDS_LP55XX_COMMON_H#define _LEDS_LP55XX_COMMON_H +#include <linux/led-class-multicolor.h> +enum lp55xx_engine_index {LP55XX_ENGINE_INVALID , LP55XX_ENGINE_1,
@@ -109,6 +111,9 @@ struct lp55xx_device_config {/* access brightness register */ int (*brightness_fn)(struct lp55xx_led *led); +/* perform brightness value to multiple LEDs */ +int (*multicolor_brightness_fn)(struct lp55xx_led *led); +/* current setting function */ void (*set_led_current) (struct lp55xx_led *led,u8 led_current);
@@ -159,6 +164,8 @@ struct lp55xx_chip {* struct lp55xx_led * @chan_nr : Channel number * @cdev : LED class device +* @mc_cdev : Multi color class device +* @color_components: Multi color LED map information * @led_current : Current setting at each led channel * @max_current : Maximun current at each led channel * @brightness : Brightness value
@@ -167,6 +174,8 @@ struct lp55xx_chip {struct lp55xx_led {int chan_nr;struct led_classdev cdev; +struct led_classdev_mc mc_cdev; +struct led_mc_color_conversion color_components[LP55XX_MAX_GROUPED_CHAN ];u8 led_current;u8 max_current;u8 brightness;
@@ -196,6 +205,7 @@ extern void lp55xx_unregister_sysfs(struct lp55xx_chip *chip);/* common device tree population function */ extern struct lp55xx_platform_data -*lp55xx_of_populate_pdata (struct device *dev,struct device_node *np); +*lp55xx_of_populate_pdata (struct device *dev,struct device_node *np, +struct lp55xx_chip *chip);#endif /* _LEDS_LP55XX_COMMON_H */
drivers/leds/leds-lp8501.c +8 -6
@@ -308,9 +308,16 @@ static int lp8501_probe(struct i2c_client *client,struct lp55xx_platform_data *pdata =dev_get_platdata (&client->dev);struct device_node *np = client->dev.of_node; + chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); +if (!chip) +return -ENOMEM ; + + chip->cfg = &lp8501_cfg; +if (!pdata) {if (np) { - pdata =lp55xx_of_populate_pdata (&client->dev, np); + pdata =lp55xx_of_populate_pdata (&client->dev, np, + chip);if (IS_ERR (pdata))return PTR_ERR (pdata); }else {
@@ -319,10 +326,6 @@ static int lp8501_probe(struct i2c_client *client, } } - chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL ); -if (!chip) -return -ENOMEM ; - led =devm_kcalloc (&client->dev, pdata->num_channels,sizeof (*led),GFP_KERNEL );if (!led)
@@ -330,7 +333,6 @@ static int lp8501_probe(struct i2c_client *client, chip->cl = client; chip->pdata = pdata; - chip->cfg = &lp8501_cfg;mutex_init (&chip->lock);
include/linux/platform_data/leds-lp55xx.h +8 -0
@@ -12,17 +12,25 @@#ifndef _LEDS_LP55XX_H#define _LEDS_LP55XX_H +#include <linux/led-class-multicolor.h> +/* Clock configuration */ #define LP55XX_CLOCK_AUTO 0#define LP55XX_CLOCK_INT 1#define LP55XX_CLOCK_EXT 2 +#define LP55XX_MAX_GROUPED_CHAN 4 +struct lp55xx_led_config {const char *name;const char *default_trigger;u8 chan_nr;u8 led_current;/* mA x10, 0 if led is not connected */ u8 max_current; +int num_colors; +unsigned int max_channel; +unsigned long available_colors; +struct led_mc_color_conversion color_components[LP55XX_MAX_GROUPED_CHAN ]; }; struct lp55xx_predef_pattern {
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 14/19 leds: lp5523: Update the lp5523 code to add multicolor brightness function
In reply to Dan MurphyAdd the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels in a single function.
--- drivers/leds/leds-lp5523.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
drivers/leds/leds-lp5523.c +20 -0
@@ -791,6 +791,25 @@ static ssize_t store_master_fader_leds(struct device *dev,return ret; } +static int lp5523_multicolor_brightness (struct lp55xx_led *led) +{ +struct lp55xx_chip *chip = led->chip; +int ret; +int i; + +mutex_lock (&chip->lock); +for (i =0 ; i < led->mc_cdev.num_leds; i++) { + ret =lp55xx_write (chip, +LP5523_REG_LED_PWM_BASE + + led->color_components[i].output_num, + led->color_components[i].brightness); +if (ret) +break ; + } +mutex_unlock (&chip->lock); +return ret; +} +static int lp5523_led_brightness (struct lp55xx_led *led) {struct lp55xx_chip *chip = led->chip;
@@ -857,6 +876,7 @@ static struct lp55xx_device_config lp5523_cfg = { .max_channel = LP5523_MAX_LEDS, .post_init_device = lp5523_post_init_device, .brightness_fn = lp5523_led_brightness, + .multicolor_brightness_fn = lp5523_multicolor_brightness, .set_led_current = lp5523_set_led_current, .firmware_cb = lp5523_firmware_loaded, .run_engine = lp5523_run_engine,
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 15/19 leds: lp5521: Add multicolor framework multicolor brightness support
In reply to Dan MurphyAdd the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call.
--- drivers/leds/leds-lp5521.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
drivers/leds/leds-lp5521.c +20 -0
@@ -349,6 +349,25 @@ static int lp5521_run_selftest(struct lp55xx_chip *chip, char *buf)return 0 ; } +static int lp5521_multicolor_brightness (struct lp55xx_led *led) +{ +struct lp55xx_chip *chip = led->chip; +int ret; +int i; + +mutex_lock (&chip->lock); +for (i =0 ; i < led->mc_cdev.num_leds; i++) { + ret =lp55xx_write (chip, +LP5521_REG_LED_PWM_BASE + + led->color_components[i].output_num, + led->color_components[i].brightness); +if (ret) +break ; + } +mutex_unlock (&chip->lock); +return ret; +} +static int lp5521_led_brightness (struct lp55xx_led *led) {struct lp55xx_chip *chip = led->chip;
@@ -490,6 +509,7 @@ static struct lp55xx_device_config lp5521_cfg = { .max_channel = LP5521_MAX_LEDS, .post_init_device = lp5521_post_init_device, .brightness_fn = lp5521_led_brightness, + .multicolor_brightness_fn = lp5521_multicolor_brightness, .set_led_current = lp5521_set_led_current, .firmware_cb = lp5521_firmware_loaded, .run_engine = lp5521_run_engine,
Signature · 1 line
2.22.0.214.g8dca754b1e
PATCH v17 16/19 leds: lp55xx: Fix checkpatch file permissions issues
In reply to Dan MurphyFix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the DEVICE_ATTR_XX macros the call back function names needed to be updated within the code.
This means that the lp55xx_ needed to be dropped in the name to keep in harmony with the ABI documentation.
--- drivers/leds/leds-lp55xx-common.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-)
drivers/leds/leds-lp55xx-common.c +10 -12
@@ -78,7 +78,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip)return cfg->post_init_device (chip); } -static ssize_t lp55xx_show_current (struct device *dev, +static ssize_t led_current_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -87,7 +87,7 @@ static ssize_t lp55xx_show_current(struct device *dev,return scnprintf (buf,PAGE_SIZE ,"%d\n" , led->led_current); } -static ssize_t lp55xx_store_current (struct device *dev, +static ssize_t led_current_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) {
@@ -111,7 +111,7 @@ static ssize_t lp55xx_store_current(struct device *dev,return len; } -static ssize_t lp55xx_show_max_current (struct device *dev, +static ssize_t max_current_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -120,9 +120,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev,return scnprintf (buf,PAGE_SIZE ,"%d\n" , led->max_current); } -static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current, - lp55xx_store_current); -static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL); +static DEVICE_ATTR_RW (led_current); +static DEVICE_ATTR_RO (max_current);static struct attribute *lp55xx_led_attrs[] = { &dev_attr_led_current.attr,
@@ -292,7 +291,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip) GFP_KERNEL, chip, lp55xx_firmware_loaded); } -static ssize_t lp55xx_show_engine_select (struct device *dev, +static ssize_t select_engine_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -302,7 +301,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev,return sprintf (buf,"%d\n" , chip->engine_idx); } -static ssize_t lp55xx_store_engine_select (struct device *dev, +static ssize_t select_engine_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) {
@@ -344,7 +343,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start) chip->cfg->run_engine (chip, start); } -static ssize_t lp55xx_store_engine_run (struct device *dev, +static ssize_t run_engine_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) {
@@ -369,9 +368,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev,return len; } -static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR, - lp55xx_show_engine_select, lp55xx_store_engine_select); -static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run); +static DEVICE_ATTR_RW (select_engine); +static DEVICE_ATTR_WO (run_engine);static struct attribute *lp55xx_engine_attributes[] = { &dev_attr_select_engine.attr,
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 16/19] leds: lp55xx: Fix checkpatch file permissions issues
Quoted 8 lines · Dan Murphy
Fix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the
DEVICE_ATTR_XXmacros the call back function names needed to be updated within the code.This means that the
lp55xx_needed to be dropped in the name to keep in harmony with the ABI documentation.Signed-off-by Dan Murphy <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 17/19 leds: lp5523: Fix checkpatch issues in the code
In reply to Dan MurphyFix checkpatch errors and warnings for the LP5523.c device driver.
--- drivers/leds/leds-lp5523.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/leds/leds-lp5523.c +10 -9
@@ -23,13 +23,13 @@#define LP5523_PROGRAM_LENGTH 32/* bytes */ /* Memory is used like this: -0x00 engine 1 program -0x10 engine 2 program -0x20 engine 3 program -0x30 engine 1 muxing info -0x40 engine 2 muxing info -0x50 engine 3 muxing info -*/ +* 0x00 engine 1 program +* 0x10 engine 2 program +* 0x20 engine 3 program +* 0x30 engine 1 muxing info +* 0x40 engine 2 muxing info +* 0x50 engine 3 muxing info +*/ #define LP5523_MAX_LEDS 9/* Registers */
@@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, const u8 *data, size_t size) {u8 pattern[LP5523_PROGRAM_LENGTH ] = {0 }; -unsigned cmd; +unsigned int cmd;char c[3 ];int nrchars;int ret;
@@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)static void lp5523_mux_to_array (u16 led_mux,char *array) {int i, pos =0 ; +for (i =0 ; i <LP5523_MAX_LEDS ; i++) pos +=sprintf (array + pos,"%x" ,LED_ACTIVE (led_mux, i));
@@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)if (ret)return ret; - ret =lp55xx_write (chip,LP5523_REG_PROG_MEM , (u8)(mux >>8 )); + ret =lp55xx_write (chip,LP5523_REG_PROG_MEM , (u8)(mux >>8 ));if (ret)return ret;
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 17/19] leds: lp5523: Fix checkpatch issues in the code
Quoted 4 lines · Dan Murphy
Fix checkpatch errors and warnings for the
LP5523.cdevice driver.Signed-off-by Dan Murphy <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 18/19 dt: bindings: Update lp55xx binding to recommended LED naming
In reply to Dan MurphyUpdate the LP55xx DT binding examples to the recommended node naming convention. There are no changes to the DT properties.
--- .../devicetree/bindings/leds/leds-lp55xx.txt | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +29 -29
@@ -48,7 +48,7 @@ example 1) LP5521 'lp5521_pri:channel1' and 'lp5521_pri:channel2', with a heartbeat trigger on channel 0. -lp5521@32 { +led-controller@32 { #address-cells = <1>; #size-cells = <0>; compatible = "national,lp5521";
@@ -56,20 +56,20 @@ lp5521@32 { label = "lp5521_pri"; clock-mode = /bits/ 8 <2>; - chan@0 { + led@0 { reg = <0>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; linux,default-trigger = "heartbeat"; }; - chan@1 { + led@1 { reg = <1>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>; }; - chan@2 { + led@2 { reg = <2>; led-cur = /bits/ 8 <0x2f>; max-cur = /bits/ 8 <0x5f>;
@@ -88,70 +88,70 @@ ASEL1 ASEL0 Address VEN GND 34h VEN VEN 35h -lp5523@32 { +led-controller@32 { #address-cells = <1>; #size-cells = <0>; compatible = "national,lp5523"; reg = <0x32>; clock-mode = /bits/ 8 <1>; - chan@0 { + led@0 { reg = <0>; chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@1 { + led@1 { reg = <1>; chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@2 { + led@2 { reg = <2>; chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@3 { + led@3 { reg = <3>; chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@4 { + led@4 { reg = <4>; chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@5 { + led@5 { reg = <5>; chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@6 { + led@6 { reg = <6>; chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@7 { + led@7 { reg = <7>; chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@8 { + led@8 { reg = <8>; chan-name = "d9"; led-cur = /bits/ 8 <0x14>;
@@ -162,35 +162,35 @@ lp5523@32 { example 3) LP5562 4 channels are defined. -lp5562@30 { +led-controller@30 { #address-cells = <1>; #size-cells = <0>; compatible = "ti,lp5562"; reg = <0x30>; clock-mode = /bits/8 <2>; - chan@0 { + led@0 { reg = <0>; chan-name = "R"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan@1 { + led@1 { reg = <1>; chan-name = "G"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan@2 { + led@2 { reg = <2>; chan-name = "B"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; }; - chan@3 { + led@3 { reg = <3>; chan-name = "W"; led-cur = /bits/ 8 <0x20>;
@@ -202,7 +202,7 @@ example 4) LP8501 9 channels are defined. The 'pwr-sel' is LP8501 specific property. Others are same as LP5523. -lp8501@32 { +led-controller@32 { #address-cells = <1>; #size-cells = <0>; compatible = "ti,lp8501";
@@ -210,63 +210,63 @@ lp8501@32 { clock-mode = /bits/ 8 <2>; pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */ - chan@0 { + led@0 { reg = <0>; chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@1 { + led@1 { reg = <1>; chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@2 { + led@2 { reg = <2>; chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@3 { + led@3 { reg = <3>; chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@4 { + led@4 { reg = <4>; chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@5 { + led@5 { reg = <5>; chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@6 { + led@6 { reg = <6>; chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@7 { + led@7 { reg = <7>; chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; }; - chan@8 { + led@8 { reg = <8>; chan-name = "d9"; led-cur = /bits/ 8 <0x14>;
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 18/19] dt: bindings: Update lp55xx binding to recommended LED naming
Quoted 4 lines · Dan Murphy
Update the LP55xx DT binding examples to the recommended node naming convention. There are no changes to the DT properties.
Signed-off-by Dan Murphy <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH v17 19/19 leds: lp55xx-common: Remove extern from lp55xx-common header
In reply to Dan Murphyextern is implied and is not needed in the common header file. Remove the extern keyword and re-align the code.
--- drivers/leds/leds-lp55xx-common.h | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-)
drivers/leds/leds-lp55xx-common.h +12 -14
@@ -183,29 +183,27 @@ struct lp55xx_led { };/* register access */ -extern int lp55xx_write (struct lp55xx_chip *chip,u8 reg,u8 val); -extern int lp55xx_read (struct lp55xx_chip *chip,u8 reg,u8 *val); -extern int lp55xx_update_bits (struct lp55xx_chip *chip,u8 reg, -u8 mask,u8 val); +int lp55xx_write (struct lp55xx_chip *chip,u8 reg,u8 val); +int lp55xx_read (struct lp55xx_chip *chip,u8 reg,u8 *val); +int lp55xx_update_bits (struct lp55xx_chip *chip,u8 reg,u8 mask,u8 val);/* external clock detection */ -extern bool lp55xx_is_extclk_used (struct lp55xx_chip *chip); +bool lp55xx_is_extclk_used (struct lp55xx_chip *chip);/* common device init/deinit functions */ -extern int lp55xx_init_device (struct lp55xx_chip *chip); -extern void lp55xx_deinit_device (struct lp55xx_chip *chip); +int lp55xx_init_device (struct lp55xx_chip *chip); +void lp55xx_deinit_device (struct lp55xx_chip *chip);/* common LED class device functions */ -extern int lp55xx_register_leds (struct lp55xx_led *led, -struct lp55xx_chip *chip); +int lp55xx_register_leds (struct lp55xx_led *led,struct lp55xx_chip *chip);/* common device attributes functions */ -extern int lp55xx_register_sysfs (struct lp55xx_chip *chip); -extern void lp55xx_unregister_sysfs (struct lp55xx_chip *chip); +int lp55xx_register_sysfs (struct lp55xx_chip *chip); +void lp55xx_unregister_sysfs (struct lp55xx_chip *chip);/* common device tree population function */ -extern struct lp55xx_platform_data -*lp55xx_of_populate_pdata (struct device *dev,struct device_node *np, -struct lp55xx_chip *chip); +struct lp55xx_platform_data *lp55xx_of_populate_pdata (struct device *dev, +struct device_node *np, +struct lp55xx_chip *chip);#endif /* _LEDS_LP55XX_COMMON_H */
Signature · 1 line
2.22.0.214.g8dca754b1e
Re: [PATCH v17 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header
Quoted 4 lines · Dan Murphy
extern is implied and is not needed in the common header file. Remove the extern keyword and re-align the code.
Signed-off-by Dan Murphy <[email protected]>
Lets not do this.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH v17 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header
Pavel
Thanks for the review on all the patches. Sorry for the late reply I was on holiday
Quoted 6 lines · Pavel Machek
Quoted 4 lines · Dan Murphy
extern is implied and is not needed in the common header file. Remove the extern keyword and re-align the code.
Signed-off-by Dan Murphy <[email protected]>Lets not do this.
OK this is the last patch in the series so I am OK to drop it.
Dan
Quoted 8 lines · Dan Murphy
Hello
Simple fix in the multicolor code where the extended registration call was not called in the devm_* function
Thanks Martin F. for finding this issue.
Hopefully this will be pulled in for the 5.5 merge window.
For patches 2, 3, 4
I have applied patch 1 to my tree too but, being just documentation, it's not testable.
I don't have a lp50xx but have written my own multicolor driver on top of this patchset (for a custom LED controller implemented in a MCU).
Martin
Pavel
Quoted 24 lines · Dan Murphy
Hello
Simple fix in the multicolor code where the extended registration call was not called in the devm_* function
Thanks Martin F. for finding this issue.
Hopefully this will be pulled in for the 5.5 merge window.
Dan
Dan Murphy (19):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add multicolor ID to the color ID list
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce a multicolor class definition
dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
leds: lp50xx: Add the LP50XX family of the RGB LED driver
dt: bindings: lp55xx: Be consistent in the document with LED acronym
dt: bindings: lp55xx: Update binding for Multicolor Framework
ARM: dts: n900: Add reg property to the LP5523 channel node
ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
leds: lp55xx: Convert LED class registration to devm_*
Quoted 8 lines
leds: lp55xx: Add multicolor framework support to lp55xx
leds: lp5523: Update the lp5523 code to add multicolor brightness
function
leds: lp5521: Add multicolor framework multicolor brightness support
leds: lp55xx: Fix checkpatch file permissions issues
leds: lp5523: Fix checkpatch issues in the code
dt: bindings: Update lp55xx binding to recommended LED naming
leds: lp55xx-common: Remove extern from lp55xx-common header
Are these going to be pulled in for 5.6?
I need to post the changes requested by Shawn on the DT but would like to do it against the leds-next tree.
Dan
Hello
Bump for application to leds-next
Dan
Quoted 65 lines · Dan Murphy
Hello
Simple fix in the multicolor code where the extended registration call was not called in the devm_* function
Thanks Martin F. for finding this issue.
Hopefully this will be pulled in for the 5.5 merge window.
Dan
Dan Murphy (19):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add multicolor ID to the color ID list
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce a multicolor class definition
dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
leds: lp50xx: Add the LP50XX family of the RGB LED driver
dt: bindings: lp55xx: Be consistent in the document with LED acronym
dt: bindings: lp55xx: Update binding for Multicolor Framework
ARM: dts: n900: Add reg property to the LP5523 channel node
ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
leds: lp55xx: Convert LED class registration to devm_*
leds: lp55xx: Add multicolor framework support to lp55xx
leds: lp5523: Update the lp5523 code to add multicolor brightness
function
leds: lp5521: Add multicolor framework multicolor brightness support
leds: lp55xx: Fix checkpatch file permissions issues
leds: lp5523: Fix checkpatch issues in the code
dt: bindings: Update lp55xx binding to recommended LED naming
leds: lp55xx-common: Remove extern from lp55xx-common header.../ABI/testing/sysfs-class-led-multicolor | 36 + .../bindings/leds/leds-class-multicolor.txt | 98 +++ .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++ .../devicetree/bindings/leds/leds-lp55xx.txt | 163 +++- Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 100 +++ arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 +- arch/arm/boot/dts/omap3-n900.dts | 29 +- arch/arm/boot/dts/ste-href.dtsi | 22 +- drivers/leds/Kconfig | 22 + drivers/leds/Makefile | 2 + drivers/leds/led-class-multicolor.c | 272 ++++++ drivers/leds/led-core.c | 1 + drivers/leds/leds-lp50xx.c | 799 ++++++++++++++++++ drivers/leds/leds-lp5521.c | 43 +- drivers/leds/leds-lp5523.c | 62 +- drivers/leds/leds-lp5562.c | 22 +- drivers/leds/leds-lp55xx-common.c | 235 ++++-- drivers/leds/leds-lp55xx-common.h | 36 +- drivers/leds/leds-lp8501.c | 23 +- include/dt-bindings/leds/common.h | 3 +- include/linux/led-class-multicolor.h | 139 +++ include/linux/platform_data/leds-lp55xx.h | 8 + 23 files changed, 2106 insertions(+), 172 deletions(-)create mode 100644
Documentation/ABI/testing/sysfs-class-led-multicolorcreate mode 100644Documentation/devicetree/bindings/leds/leds-class-multicolor.txtcreate mode 100644Documentation/devicetree/bindings/leds/leds-lp50xx.txtcreate mode 100644Documentation/leds/leds-class-multicolor.rstcreate mode 100644drivers/leds/led-class-multicolor.c
create mode 100644drivers/leds/leds-lp50xx.c
create mode 100644include/linux/led-class-multicolor.h
Hello
Do you have a time frame in applying this patch set?
Dan
Quoted 9 lines · Dan Murphy
Hello
Bump for application to leds-next
Dan
Quoted 2 lines · Dan Murphy
Hello
Quoted 3 lines · Dan Murphy
Hello
Do you have a time frame in applying this patch set?
I am afraid we're not waiting just for applying but for Pavel's opinion on the most crucial parts of this patch set...
Quoted 10 lines · Dan Murphy
Quoted 9 lines
Hello
Bump for application to leds-next
Dan
Quoted 2 lines · Dan Murphy
Hello
Signature · 2 lines
Best regards, Jacek Anaszewski
Jacek
Quoted 6 lines · Jacek Anaszewski
Quoted 3 lines · Dan Murphy
Hello
Do you have a time frame in applying this patch set?
I am afraid we're not waiting just for applying but for Pavel's opinion on the most crucial parts of this patch set...
OK. The patchset is aging rapidly as it is almost 2 months old.
Dan